[ 
https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510016#comment-13510016
 ] 

Jay Kreps commented on KAFKA-648:
---------------------------------

A bunch of the config values are non standard. For example KafkaConfig.brokerId 
is given by the property "brokerid" which should be "broker.id". What I take 
Swapnil to be saying is that all properties should be in the form
  a.config.name
and the scala variable should always be the same thing, but in camel case,
  aConfigName
Would be great to do this in 0.8 with the other compatibility changes.
                
> Use uniform convention for naming properties keys for clientId, groupId, 
> consumerId, correlationId
> --------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-648
>                 URL: https://issues.apache.org/jira/browse/KAFKA-648
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Swapnil Ghike
>
> Currently, the convention that we seem to use to get a property value in 
> *Config is as follows:
> val configVal = property.getType("config.val", ...) // dot is used to 
> separate two words in the key and the first letter of second word is 
> capitalized in configVal.
> We should use similar convention for groupId, consumerId, clientId, 
> correlationId.
> This change will probably be backward non-compatible.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to