[
https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543554#comment-13543554
]
Jun Rao commented on KAFKA-648:
-------------------------------
Thanks for the patch. Some comments:
1. ConsumerConfig: We have both enable.shallow.iterator and auto.commit.enable.
Need to standardize.
2. We need to make a pass of the names in SyncProducerConfigShared and
AsyncProducerConfig too.
3. Could you change the affected property names in other directories (config/,
system_tests/, examples/, perf/, contrib/) too?
> Use uniform convention for naming properties keys
> --------------------------------------------------
>
> Key: KAFKA-648
> URL: https://issues.apache.org/jira/browse/KAFKA-648
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Swapnil Ghike
> Assignee: Sriram Subramanian
> Priority: Blocker
> Fix For: 0.8, 0.8.1
>
> Attachments: configchanges-1.patch
>
>
> Currently, the convention that we seem to use to get a property value in
> *Config is as follows:
> val configVal = property.getType("config.val", ...) // dot is used to
> separate two words in the key and the first letter of second word is
> capitalized in configVal.
> We should use similar convention for groupId, consumerId, clientId,
> correlationId.
> This change will probably be backward non-compatible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
