[DISCUSS] KIP-1203: Allow to configure custom `ReplicaPlacer` implementation

2025-08-05 Thread
Hello everyone, I would like to start a discussion on KIP-1203: Allow to configure custom `ReplicaPlacer` implementation This proposal introduces a new internal configuration, replica.placer.class.name, which allows users to specify a custom impl

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-08-05 Thread
ers? > > JR48. If we want to preserve the current behavior, we should remove the > following validation, right? >if (validStrings.length == 0) { >throw new IllegalArgumentException("Valid strings list cannot > be empty for in validator"); &g

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-08-01 Thread
= 0) { > throw new IllegalArgumentException("Valid strings list cannot > be empty for in validator"); >} >return new ValidList(List.of(validStrings), true, false); >} > > Jun > > On Tue, Jul 29, 2025 at 8:53 AM 黃竣陽 wrote: >

Re: [DISCUSS] KIP-1100: Consider renaming org.apache.kafka.server:type=AssignmentsManager

2025-07-31 Thread
iunn-Yang > > Pardon me, why to deprecate them? Changing the value does not break the > compatibility, right? > > Best, > Chia-Ping > > 黃竣陽 於 2025年7月30日 週三 下午10:22寫道: > >> Hello all, >> >> Since REMOTE_LOG_READER_TASK_QUEUE_SIZE_METRIC and >>

Re: [DISCUSS] KIP-1100: Consider renaming org.apache.kafka.server:type=AssignmentsManager

2025-07-30 Thread
and will be removed in Kafka 5.0. I've updated the KIP to reflect these changes. Please let me know if you have any feedback. Best Regards, Jiunn-Yang > Chia-Ping Tsai 於 2025年7月18日 凌晨2:58 寫道: > > hi Jiunn-Yang > > I think this KIP is ready for a VOTE thread. > > th

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-07-29 Thread
changes. (1) Disallow null. This is ok since > one can't really set a null value through a config file. (2) Disallow > duplicates. This is ok since it's rare and confusing. (3) Disallow empty. > Ideally, we want to claim that for those cases, they all lead to some other > errors

Re: [VOTE] KIP-1100: Rename org.apache.kafka.server:type=AssignmentsManager and org.apache.kafka.storage.internals.log.RemoteStorageThreadPool metrics

2025-07-29 Thread
t;>>> >>>>> +1 (binding) >>>>> >>>>>> On Jul 22, 2025, at 4:54 PM, Omnia Ibrahim >>>>> wrote: >>>>>> >>>>>> Thanks Jiunn-Yang for the K

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-07-23 Thread
r plugin.path, we > reject empty lists. > > JR39. We can remove the fields isEmptyAllowed and isNullAllowed since they > are not public facing. > > Jun > > > On Tue, Jul 22, 2025 at 4:26 AM 黃竣陽 wrote: > >> Hello Jun, Chia, >> >> Thanks for t

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-07-22 Thread
Hello Jun, Chia, Thanks for the reply, JR36: I’ve updated the following configurations: - sasl.oauthbearer.expected.audience - ssl.cipher.suites - ssl.enabled.protocols These now allow both empty and non-empty lists. Since the default values of sasl.oauthbearer.expected.audience and ssl.ciph

Re: [VOTE] KIP-1193: Deprecate MX4j support

2025-07-20 Thread
+1 (non-binding) Best Regards, Jiunn-Yang > PoAn Yang 於 2025年7月21日 上午8:08 寫道: > > +1 (binding) > > Thanks, > PoAn > >> On Jul 19, 2025, at 6:28 AM, Kirk True wrote: >> >> +1 (non-binding) >> >> Thanks Fede! >> >> On Fri, Jul 18, 2025, at 1:38 PM, Marouan REJEB wrote: >>> Thanks Federico,

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-07-18 Thread
ded if group.protocol is > classic. I guess that it's ok for it to be empty. > > JR36. ssl.enabled.protocols: This is interesting. If this is null, it > implies that all available protocols are enabled. However, since null is > not the default value, a user can't set it to null through a

[VOTE] KIP-1100: Rename org.apache.kafka.server:type=AssignmentsManager and org.apache.kafka.storage.internals.log.RemoteStorageThreadPool metrics

2025-07-18 Thread
Hello everyone, I would like to start a vote on KIP-1100 Rename org.apache.kafka.server:type=AssignmentsManager and org.apache.kafka.storage.internals.log.RemoteStorageThreadPool metrics KIP Link: https://cwiki.apache.org/confluence/x/6oqMEw Discussion thread: https://lists.apache.org/thread/8

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-07-17 Thread
be null? In general, null only makes >> sense if it's the default value. >> MirrorSourceConfig: topics, topics.exclude, config.properties.exclude >> >> JR31. WorkerConfig: plugin.path It seems that we should allow it to be >> empty, but not null? >> &g

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-07-16 Thread
transforms > predicates > > SourceConnectorConfig > topic.creation.groups > > WorkerConfig > plugin.path > > DistributedConfig > inter.worker.verification.algorithms > > RestServerConfig > rest.extension.classes > admin.listeners > listeners > > Thanks, > &

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-07-15 Thread
>> ConsumerConfig: 5 >> ProducerConfig: 4 >> SaslConfigs: 1 >> SslConfigs: 2 >> BrokerSecurityConfigs: 5 >> MirrorClientConfig: 1 >> org.apache.kafka.connect.mirror : 16 >> org.apache.kafka.connect.runtime : 21 >> GroupCoordinatorConfig: 3 >&

Re: [ANNOUNCE] New Kafka PMC member: Lucas Brutschy

2025-07-14 Thread
Congratulations Lucas! Best, Jiunn-Yang > PoAn Yang 於 2025年7月15日 上午9:53 寫道: > > Congratulations Lucas! > >> On Jul 15, 2025, at 9:44 AM, TengYao Chi wrote: >> >> Glad to hear that! >> Congratulations Lucas! >> >> Cheers, >> TengYao >> >> Kirk True 於 2025年7月15日 週二,上午8:53寫道: >> >>> Congratu

Re: [ANNOUNCE] New Kafka Committer: PoAn Yang

2025-07-12 Thread
Congratulations PoAn Regards, Jiunn-Yang > ziming deng 於 2025年7月13日 上午9:28 寫道: > > Congrats PoAn! > > >> On Jul 13, 2025, at 8:40 AM, Jhen-Yung Hsu wrote: >> >> Congratulations PoAn! Happy to contribute with you. >> >> On 2025/07/12 18:31:18 Chia-Ping Tsai wrote: >>> Dear all, >>> >>> The

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-07-11 Thread
tuitive convention is: if the >> config is not set, it defaults to all available cipher suites. If it's >> explicitly set, it can't be empty. >> >> Jun >> >> >> >> On Wed, Jul 9, 2025 at 8:27 AM 黃竣陽 wrote: >> >>> Hi Jun, C

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-07-09 Thread
allowed. >>> >>> >>> If we agree to support "empty list", the approach of "none" could be >>> eliminated, right? >>> >>> I don't understand the point of "5.0". Could you please share more details? >>>

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-07-08 Thread
>> JR11. There is an existing config interceptor.classes that allows an empty >> list and it makes intuitive sense. So, it seems that it's ok to support >> empty lists in general. Given that, it's probably simpler to just allow >> log.cleanup.policy to be empty and p

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-07-04 Thread
ehavior for each config with an empty list or duplicate entry? > > Thanks, > > Jun > > > > On Mon, Jun 30, 2025 at 6:02 AM 黃竣陽 wrote: > >> Hello all, >> >> I am manually bumping this thread. Any feedback would be appreciated. >> >> Bes

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-06-30 Thread
Hello all, I am manually bumping this thread. Any feedback would be appreciated. Best regards, Jiunn-Yang > 黃竣陽 於 2025年5月28日 晚上11:21 寫道: > > Hello Jun, > > I have updated the KIP and introduced a new validator, NonEmptyListValidator, > which ensures that the > provide

Re: [ANNOUNCE] New Kafka Committer: Omnia Ibrahim

2025-06-25 Thread
Congrats Omnia! Regards, Jiunn-Yang > TengYao Chi 於 2025年6月25日 晚上11:50 寫道: > > Congrats Omnia! > > Cheers > TengYao > > Chia-Ping Tsai 於 2025年6月25日 週三 下午11:47寫道: > >> Thanks to Omnia for all your contributions! >> >> Apoorv Mittal 於 2025年6月25日 週三 下午11:43寫道: >> >>> Congrats Omnia! Great t

Re: [ANNOUNCE] New Kafka PMC Member: José Armando García Sancio

2025-06-16 Thread
Congratulations José! Regards, Jiunn-Yang > Gaurav Narula 於 2025年6月16日 晚上9:57 寫道: > > Congrats José! > > Regards, > Gaurav > >> On 16 Jun 2025, at 14:50, Apoorv Mittal wrote: >> >> Congratulations Jose! >> >> Regards, >> Apoorv Mittal >> >> >> On Mon, Jun 16, 2025 at 2:46 PM TengYao Chi

Re: [VOTE] KIP-1153: Refactor Kafka Streams CloseOptions to Fluent API Style

2025-06-13 Thread
Hi all, Thanks for the votes. The vote has passed with 4 binding votes. (Matthias, Bill, Sophie, Chia-Ping) Best Regards, Jiunn-Yang > Chia-Ping Tsai 於 2025年6月13日 晚上9:22 寫道: > > +1 (binding) > > On 2025/05/20 12:38:06 黃竣陽 wrote: >> Hello all, >> >> I

Re: [VOTE] KIP-1175: Fix the typo `PARTITIONER_ADPATIVE_PARTITIONING_ENABLE` in ProducerConfig

2025-06-05 Thread
+1 (non-binding) Best, Jiunn-Yang > Andrew Schofield 於 2025年6月6日 凌晨12:13 寫道: > > +1 (binding) > > Thanks, > Andrew > > From: TengYao Chi > Sent: 05 June 2025 17:05 > To: dev@kafka.apache.org > Subject: Re: [VOTE] KIP-1175: Fix the typo > `PARTITIONER

Re: [DISCUSS] KIP-1100: Consider renaming org.apache.kafka.server:type=AssignmentsManager

2025-05-30 Thread
Hi all, I’d like to manually bump this thread. If there’s no further feedback, I’ll start the vote tomorrow. Best Regards, Jiunn-Yang > 黃竣陽 於 2025年5月11日 下午4:29 寫道: > > Hi chia, > > File a Jira to trace it https://issues.apache.org/jira/browse/KAFKA-19262 > > Best

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-05-28 Thread
t;>>>> Thanks for the KIP. >>>>>> >>>>>> Comments: >>>>>> 1. "it is acceptable because an empty cleanup.policy is considered >>>> invalid >>>>>> in Kafka. Therefore, this trade-off is justified." >&

Re: [VOTE] KIP-1179: Introduce remote.log.manager.follower.thread.pool.size config

2025-05-21 Thread
Thanks for the KIP! +1 (non-binding) Jiunn-Yang > Luke Chen 於 2025年5月22日 上午8:11 寫道: > > +1 binding from me. > > Thanks. > Luke > > On Thu, May 22, 2025 at 12:54 AM Kamal Chandraprakash < > kamal.chandraprak...@gmail.com> wrote: > >> +1 (binding). Thanks for the KIP! >> >> On Wed, May 21, 20

[VOTE] KIP-1153: Refactor Kafka Streams CloseOptions to Fluent API Style

2025-05-20 Thread
Hello all, I would like to call a vote on KIP-1153: Refactor Kafka Streams CloseOptions to Fluent API Style KIP: Discussion thread: Best Regards, Jiunn-Yang

Re: [VOTE] KIP-1135: Deprecated "org.apache.kafka.disallowed.login.modules"

2025-05-20 Thread
Thank for this KIP. +1 (non-binding) Best Regards, Jiunn-Yang > Luke Chen 於 2025年5月20日 上午10:25 寫道: > > +1 (binding) from me. > > Thanks for the KIP. > Luke > > On Mon, May 19, 2025 at 11:12 PM Chia-Ping Tsai wrote: > >> +1 (binding) >> >> 龚宣璋 於 2025年5月14日 週三 下午7:29寫道: >> >>> Hi Chia-Pin

Re: [DISCUSS] KIP-1153: Kafka Streams `CloseOptions` should not have a public constructor

2025-05-19 Thread
Hi all, I’d like to manually bump this thread. If there’s no further feedback, I’ll start the vote tomorrow. Best Regards, Jiunn-Yang > 黃竣陽 於 2025年5月8日 晚上8:35 寫道: > > Hi all, > > Thanks for all the feedback. I’ve updated the KIP and introduced a > CloseOptionsInternal cla

Re: [VOTE] 3.9.1 RC2

2025-05-17 Thread
+1 (non-binding) Best Regards, Jiunn-Yang > 黃竣陽 於 2025年5月16日 晚上8:21 寫道: > > Hello, > > I've completed the following tests on my local machine: > > - Built from source using JDK 21 & JDK 17 > - Executed all unit and integration tests > - Ran the KR

Re: [DISCUSS] KIP-1140: Avoid to return null value in Map from public api of consumer

2025-05-17 Thread
27;ve opened KAFKA-19284 to add documentation regarding the >>> null value in all offset-related results. >>> >>> Best, >>> Chia-Ping >>> >>> >>> >>> >>> Jun Rao 於 2025年5月15日 週四 上午1:47寫道: >>> >>>&

Re: [VOTE] 3.9.1 RC2

2025-05-16 Thread
Hello, I've completed the following tests on my local machine: - Built from source using JDK 21 & JDK 17 - Executed all unit and integration tests - Ran the KRaft quickstart successfully - test console producer and consumer Best Regards Jiunn-Yang > Mickael Maison 於 2025年5月16日 下午5:28 寫道: >

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-05-13 Thread
#x27;re looking at the configuration's validation I thought I'd bring > it up. > > Thanks, > Mickael > > > On Mon, May 12, 2025 at 5:18 PM 黃竣陽 wrote: >> >> Hi Luke, Chia, >> >> Thanks for your information. >> >>>> FYI, ther

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-05-12 Thread
to configure Kafka to retain all log >> segments without any automatic cleanup." >> This is the motivation we mentioned in the KIP, but to me, backward >> compatibility is much more important than "a clear and direct way to config >> kafka". >> Do

Re: [DISCUSS] KIP-1100: Consider renaming org.apache.kafka.server:type=AssignmentsManager

2025-05-11 Thread
Hi chia, File a Jira to trace it https://issues.apache.org/jira/browse/KAFKA-19262 Best Regards, Jiunn-Yang > 黃竣陽 於 2025年5月11日 下午1:41 寫道: > > Hi Ismael, chia, > > Thanks for all the feedback. I’ve updated the KIP. > >> 2. Given that we regressed in two different ins

Re: [DISCUSS] KIP-1100: Consider renaming org.apache.kafka.server:type=AssignmentsManager

2025-05-10 Thread
is focused on the user facing aspects), but important. > Perhaps we can add a test that iterates through all metrics and verifies > the naming pattern. > > Ismael > > On Sun, Oct 27, 2024 at 9:23 AM 黃竣陽 wrote: > >> Hello everyone, >> >> I would like to st

[VOTE] KIP-1161: cleanup.policy shouldn't be empty

2025-05-09 Thread
Hello all I would like to call a vote on KIP-1161: cleanup.policy shouldn't be empty KIP: Discussion thread: Best Regards, Jiunn-Yang

Re: [DISCUSS] KIP-1140: Avoid to return null value in Map from public api of consumer

2025-05-09 Thread
oEnd(Collections.singleton(partitionAndOffset.getKey())); >>} >>} >> >> In both cases, knowing that the offset doesn't exist is actually important >> to the application. Instead of ignoring the missing offset,

Re: [DISCUSS] KIP-1153: Kafka Streams `CloseOptions` should not have a public constructor

2025-05-08 Thread
king good now, my only feedback >>> would be to update the KIP title as well to reflect these latest changes. >>> Feel free to pick one yourself but if you want a suggestion, maybe >>> something like "Redo Kafka Streams CloseOptions in fluent style" or >>

Re: [DISCUSS] KIP-1100: Consider renaming org.apache.kafka.server:type=AssignmentsManager

2025-05-07 Thread
Hi all, This KIP now encompasses the work outlined in the following Jira tickets: - KAFKA-17876 - KAFKA-19150 Both tickets aim to deprecate and update incorrectly named metrics to align with the standard kafka. naming convention. Best Regards, Jiunn-Yang > 黃竣陽 於 2025年5月5日 晚上7:26

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-05-06 Thread
2025年5月6日 週二 上午12:28寫道: > >> Hi, Jiunn-Yang, >> >> Thanks for the reply. There are still references to the deprecated method. >> >> "stop relying on the deprecated methods" >> "Finally, the deprecated method will be removed in Kafka 5.0

Re: [VOTE] KIP-1130: Add metrics indicating the connection count exceeds

2025-05-06 Thread
+1 (non-binding) Best Regards, Jiunn-Yang > Kuan Po Tseng 於 2025年5月6日 凌晨12:31 寫道: > > +1(non-binding), thanks for the KIP! > > Best, > Kuan-Po Tseng > > On 2025/05/05 07:02:04 TengYao Chi wrote: >> Hello everyone, >> >> I would like to call a vote for KIP-1130 >>

Re: [DISCUSS] KIP-1153: Kafka Streams `CloseOptions` should not have a public constructor

2025-05-05 Thread
>> TengYao Chi 於 2025年4月26日 週六 下午12:17寫道: >> >>> Hi Jiunn-Yang >>> >>> You could copy the code example from KIP-1092, but adjust it to fit the >>> Streams style (e.g. javadoc, definition). >>> It would be easier since these examples have bee

Re: [DISCUSS] KIP-1100: Consider renaming org.apache.kafka.server:type=AssignmentsManager

2025-05-05 Thread
ion. Could you please take a look? > > Best, > Chia-Ping > > On 2024/10/27 17:24:11 黃竣陽 wrote: >> Hi Chia-Ping >> >> Thanks for your comments, >> >>> *Q0:* Should we add "deprecation" to the MBean description instead of >>> l

Re: [VOTE] KIP-1157: Enforce KafkaPrincipalSerde Implementation for KafkaPrincipalBuilder

2025-05-05 Thread
+1 (non-binding) Jiunn-Yang > PoAn Yang 於 2025年5月5日 下午5:11 寫道: > > +1 (non-binding) > > PoAn > >> On May 5, 2025, at 4:44 PM, Chia-Ping Tsai wrote: >> >> +1 (binding) >> >> On 2025/05/05 08:03:12 Johnny Wang wrote: >>> Hi all, >>> I would like to call a vote for KIP-1157. >>> https://cwiki

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-05-03 Thread
t to deprecate ValidList#in for now. Could you update the KIP >> completely? There are still references to deprecation. >> >> Thanks, >> >> Jun >> >> On Fri, May 2, 2025 at 4:59 AM 黃竣陽 wrote: >> >>> Hi Jun, >>> >>> I do

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-05-02 Thread
t; Just a minor comment. It would be useful to document that during upgrade, > if cleanup.policy is empty, the broker will fail to start. > > Jun > > On Thu, May 1, 2025 at 8:40 AM 黃竣陽 wrote: > >> Hello Jun, >> >> Since ValidList is a public API, we need to ma

Re: [DISCUSS] KIP-1140: Avoid to return null value in Map from public api of consumer

2025-05-02 Thread
-Ping >>>> >>>> Jun Rao 於 2025年4月30日 週三 上午6:30寫道: >>>> >>>>> Hi, Jiunn-Yang, >>>>> >>>>> Thanks for the KIP. >>>>> >>>>> It would be useful to think through the consistency with >>

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-05-01 Thread
iunn-Yang, > > Thanks for the reply. > > Do we really need isEmptyAllowed? It's awkward since the method name is > inNonEmpty. Also, it's not clear when it's set to true. > > Thanks, > > Jun > > On Fri, Apr 25, 2025 at 6:26 AM 黃竣陽 wrote: >

[VOTE] KIP-1140: Avoid to return null value in Map from public api of consumer

2025-04-25 Thread
Hello all I would like to call a vote on KIP-1140: Avoid to return null value in Map from public api of consumer KIP: Discussion thread: Best Regards, Jiunn-Yang

Re: [DISCUSS] KIP-1153: Kafka Streams `CloseOptions` should not have a public constructor

2025-04-25 Thread
ar names.) >> >> Btw: Instead of using a `boolean` it could also be beneficial to use an >> enum a la KIP-1092 with valued DEFAULT, LEAVE_GROUP, REMAIN_IN_GROUP? >> >> >> Thoughts? >> >> >> -Matthias >> >> >> >&g

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-04-25 Thread
. > > Thanks, > > Jun > > On Thu, Apr 24, 2025 at 5:32 AM 黃竣陽 wrote: > >> Hi Jun, chia, >> >> Thanks for your feedback. >> >> I add a new section for this change: >> >> - Validation for group.coordinator.rebalance.protocols

Re: [DISCUSS] KIP-1153: Kafka Streams `CloseOptions` should not have a public constructor

2025-04-25 Thread
the design of the > CloseOptions class we just added for the consumer client, which we designed > specifically to match the style we wanted the Streams CloseOptions to have. > The parameters are a bit different but the API format should be the same > > Cheers, > Sophie > > On F

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-04-24 Thread
ms. Otherwise, >>> we >>> risk running out of local disk space when remote storage is enabled. >>> >>> Thanks, >>> >>> Jun >>> >>> On Tue, Apr 22, 2025 at 9:45 AM Jun Rao wrote: >>> >>>> Hi, Jiunn-Ya

Re: [VOTE] 3.9.1 RC1

2025-04-24 Thread
Hello TengYao, I've completed the following tests on my local machine: - Built from source using JDK 21 & JDK 17 (Zulu) - Executed all unit and integration tests - Ran the quickstart successfully - test console consumer and producer Best Regards Jiunn-Yang > Luke Chen 於 2025年4月24日 下午2:32 寫道:

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-04-23 Thread
out of local disk space when remote storage is enabled. > > Thanks, > > Jun > > On Tue, Apr 22, 2025 at 9:45 AM Jun Rao wrote: > >> Hi, Jiunn-Yang, >> >> Thanks for the reply. >> >> Q2. What about existing empty values for >> group.coordin

Re: [VOTE] KIP-877: Mechanism for plugins and connectors to register metrics

2025-04-23 Thread
gt;> >> Hi, Jiunn-Yang, >> >> Thanks for the improvement. >> >> KAFKA-18390 changes a public interface. Do we have a KIP for that? >> >> Jun >> >> On Tue, Apr 22, 2025 at 3:39 AM 黃竣陽 wrote: >> >>> Hello, >>>

Re: [DISCUSS] KIP-1140: Avoid to return null value in Map from public api of consumer

2025-04-23 Thread
.null.entries" might be a little too vague. Is > "allow.null.offsets.entries" better? > > Thanks, > Kirk > > On Tue, Apr 22, 2025, at 6:03 AM, 黃竣陽 wrote: >> Hello everyone, >> >> I’ve submitted an updated version of this KIP based on recent di

Re: [DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-04-22 Thread
pty > list. > 3. inWithEmptyCheck: It's not clear what the empty check does. How about > sth like inNonEmpty ? > > Thanks, > > Jun > > On Tue, Apr 15, 2025 at 8:25 AM 黃竣陽 wrote: > >> Hello everyone, >> >> I would like to start a discus

Re: [DISCUSS] KIP-1140: Avoid to return null value in Map from public api of consumer

2025-04-22 Thread
Hello everyone, I’ve submitted an updated version of this KIP based on recent discussions. I'm happy to hear any further concerns or suggestions you might have. <https://cwiki.apache.org/confluence/x/mIuMEw> Best Regards, Jiunn-Yang > 黃竣陽 於 2025年4月22日 下午6:35 寫道: > > H

Re: [VOTE] KIP-877: Mechanism for plugins and connectors to register metrics

2025-04-22 Thread
Hello, I haven’t seen any feedback, so I’ll go ahead and implement the improvement regarding PluginMetrics#metricName. Best Regards, Jiunn-Yang > 黃竣陽 於 2025年4月14日 晚上11:43 寫道: > > Hi, > > There is an improvement in KIP-877. > > There will be an update to the Plu

Re: [DISCUSS] KIP-1140: Avoid to return null value in Map from public api of consumer

2025-04-22 Thread
i Colin, >>>>> >>>>> If so, is 5.0 the earliest this 'allow.nulls.in.consumer' configuration >>> can be changed and marked as deprecated? And if that holds, is 6.0 the >>> earliest it can be removed? >>>>> >>>>&

[DISCUSS] KIP-1161: cleanup.policy shouldn't be empty

2025-04-15 Thread
Hello everyone, I would like to start a discussion on KIP-1161: cleanup.policy shouldn't be empty This proposal aims to improve the cleanup.policy configuration. Currently, this setting should not be left empty. Therefore, there are two proposed i

Re: [VOTE] KIP-877: Mechanism for plugins and connectors to register metrics

2025-04-14 Thread
Hi, There is an improvement in KIP-877. There will be an update to the PluginMetrics#metricName method: the type of the tags parameter will be changed from Map to LinkedHashMap. This change is necessary because the order of metric tags is important 1. If the tag order is inconsistent, identic

[DISCUSS] KIP-1153: Kafka Streams `CloseOptions` should not have a public constructor

2025-04-11 Thread
Hello everyone, I would like to start a discussion on KIP-1153: Kafka Streams `CloseOptions` should not have a public constructor This proposal aims to improve KafkaStreams.CloseOptions by adopting a builder pattern to ensure API consistency. Best

Re: [VOTE] KIP-1143: Deprecated Optional and return String from public Endpoint#listenerName

2025-04-11 Thread
Thanks for this KIP. +1 (non-binding) Jiunn-Yang > Kirk True 於 2025年4月4日 凌晨1:20 寫道: > > +1 (non-binding) > > Thanks! > > On Thu, Apr 3, 2025, at 9:58 AM, Andrew Schofield wrote: >> +1 (binding) >> >> Thanks, >> Andrew >> >>> From: Chia-Ping Tsai >>>

Re: [VOTE] KIP-1148: Remove log.cleaner.enable configuration

2025-04-10 Thread
Thanks for the KIP. +1 (non-binding), > Andrew Schofield 於 2025年4月10日 下午4:30 寫道: > > Thanks for the KIP. > > +1 (binding) > > Andrew > > From: Kuan Po Tseng > Date: Thursday, 10 April 2025 at 09:05 > To: dev@kafka.apache.org > Subject: Re: [VOTE] KIP-1148: Remove log.cleaner.enable config

Re: [ANNOUNCE] New committer: Apoorv Mittal

2025-04-10 Thread
Congratulation Apoorv! Best Regards, Jiunn-Yang > Chia-Ping Tsai 於 2025年4月10日 晚上11:59 寫道: > > Welcome Apoorv as a committer! You deserve it! > > Matthias J. Sax 於 2025年4月10日 週四 下午11:56寫道: > >> The Project Management Committee (PMC) for Apache Kafka is pleased to >> announce Apoorv Mittal as

Re: [ANNOUNCE] New committer: TengYao Chi

2025-04-10 Thread
Congratulation TengYao! Best Regards, Jiunn-Yang > Chia-Ping Tsai 於 2025年4月10日 晚上11:57 寫道: > > You are the best! TengYao > > Matthias J. Sax 於 2025年4月10日 週四 下午11:55寫道: > >> The Project Management Committee (PMC) for Apache Kafka is pleased to >> announce TengYao Chi as a new Kafka committer.

Re: [DISCUSS] KIP-1157: Enforce KafkaPrincipalSerde Implementation for KafkaPrincipalBuilder

2025-04-08 Thread
Hi Johnny, Thanks for this KIP. ken_0: Doesn't this change break backward compatibility? If a user has only implemented the `KafkaPrincipalBuilder` interface, upgrading to this version would result in a compilation error. Changes that break compatibility like this typically need to be reserve

Re: [VOTE] KIP-1133: AK Documentation and Website in Markdown

2025-04-05 Thread
Thanks for this KIP, +1 (non-binding) Best Regards, Jiunn-Yang > Kirk True 於 2025年4月4日 凌晨1:21 寫道: > > +1 (non-binding) > > On Thu, Apr 3, 2025, at 6:43 AM, TaiJu Wu wrote: >> Thanks for this KIP, >> >> +1(non-binding) >> >> Best, >> TaiJuWu >> >> On Thu, Apr 3, 2025 at 9:42 PM Kuan Po Tsen

Re: [DISCUSS] KIP-1140: Avoid to return null value in Map from public api of consumer

2025-03-31 Thread
clearly spelled > out in the JavaDoc. Then, once the KIP is accepted, those comments could be > updated with the intended future changes. > > Thanks, > Kirk > > On Sat, Mar 22, 2025, at 7:54 PM, 黃竣陽 wrote: >> Hello Ismael, >> >> Thanks for your comments. &

Re: [DISCUSS] KIP-1140: Avoid to return null value in Map from public api of consumer

2025-03-22 Thread
to make > the change in a compatible way. > > Thanks, > Ismael > > On Fri, Mar 14, 2025 at 4:31 AM 黃竣陽 wrote: > >> Hello everyone, >> >> I would like to start a discussion on KIP-1140: Avoid to return null value >> in Map from public api of consumer >>

Re: [ANNOUNCE] Apache Kafka 4.0.0

2025-03-18 Thread
Thanks for running the release and hard work Jiunn-Yang > Lucas Brutschy 於 2025年3月19日 凌晨12:00 寫道: > > Thanks for the well done release, David! > > On Tue, Mar 18, 2025 at 4:56 PM TengYao Chi wrote: >> >> Thanks for runing this EPIC release and all hard work!!! >> >> Best, >> TengYao >> >>

Re: [RESULTS] [VOTE] Release Kafka version 4.0.0

2025-03-18 Thread
Thanks for running the release. Jiunn-Yang > Josep Prat 於 2025年3月18日 下午6:41 寫道: > > Great job David! > > On Tue, Mar 18, 2025 at 9:37 AM Chia-Ping Tsai wrote: > >> Oh, what a day... what a lovely day! >> >> On 2025/03/18 08:02:29 David Jacot wrote: >>> This vote passes with 10 +1 votes (4 b

Re: [VOTE] 4.0.0 RC4

2025-03-15 Thread
Hello David, I've completed the following tests on my local machine: - Built from source using JDK 21 & JDK 17 (Zulu, Amazon, Eclipse) in docker container - Executed all unit and integration tests - Ran the quickstart successfully - test console consumer and producer - Tested dynamic voter with

[DISCUSS] KIP-1140: Avoid to return null value in Map from public api of consumer

2025-03-14 Thread
Hello everyone, I would like to start a discussion on KIP-1140: Avoid to return null value in Map from public api of consumer This proposal aims to improve the Kafka consumer API by ensuring that the Map it returns contains only non-null values,

Re: [VOTE] 4.0.0 RC3

2025-03-12 Thread
Hello David, FYI, https://github.com/apache/kafka-site/pull/669 this PR resolve “1.7 Compatibility” section is empty. Best, Jiunn-Yang > David Jacot 於 2025年3月12日 晚上10:15 寫道: > > Hi all, > > FYI - I just updated the documentation. The "1.7 Compatibility" > section is empty. Looking into it. >

Re: [VOTE] 4.0.0 RC0

2025-02-25 Thread
Hello David, I've completed the following tests on my local machine: - Built from source using JDK 21 & JDK 17 (Zulu, Amazon, Eclipse) - Executed all unit and integration tests - Ran the quickstart successfully - Tested dynamic voter with 4.0 and 3.9 controllers - Tested 4.0 controller with a 3.9

Discussion on KIP-896 and the client upgrade path

2025-01-07 Thread
Hello forks, Kafka 4.0 is a major release that introduces significant changes. We have deprecated outdated APIs and established a new baseline version of 2.1 as defined in KIP-896. While there has been extensive discussion in related PRs regarding broker-client compatibility, the client upgrad

Re: [ANNOUNCE] Apache Kafka 3.7.2

2024-12-13 Thread
Thanks for running the release. Jiunn-Yang > Luke Chen 於 2024年12月14日 下午3:41 寫道: > > Thanks for running the release, Matthias! > > Luke > > On Sat, Dec 14, 2024 at 3:21 PM David Jacot wrote: > >> Thanks for running the release! >> >> Le sam. 14 déc. 2024 à 00:33, Bill Bejeck a écrit : >>

Re: [VOTE] 3.7.2 RC1

2024-12-06 Thread
Hi Matthias, Thanks for running the release. I did the following steps, - Ran all the unit test and integration test. - Built from source - Ran the KRaft quickstart +1 (non-binding) Thanks, Jiunn-Yang > Andrew Schofield 於 2024年12月6日 下午5:03 寫道: > > Hi Matthias, > Thanks for running the releas

Re: [ANNOUNCE] New committer: Andrew Schofield

2024-12-02 Thread
Congratulations Andrew!! Regards, Jiunn-Yang > Yash Mayya 於 2024年12月2日 晚上11:09 寫道: > > Congrats Andrew! > > On Mon, 2 Dec, 2024, 20:26 PoAn Yang, wrote: > >> Congratulations Andrew! >> >> PoAn >> >>> On Dec 2, 2024, at 10:36 PM, Rajini Sivaram >> wrote: >>> >>> Congratulations, Andrew! W

Re: [VOTE] KIP-1080: Fix the typo: `maxlifeTimeMs` in CreateDelegationTokenOptions

2024-11-10 Thread
> +1 (binding). Thanks for the KIP! > > On Mon, Nov 11, 2024 at 9:41 AM Luke Chen wrote: > >> +1 (binding) from me. >> >> Thanks for the KIP. >> >> Luke >> >> On Mon, Nov 11, 2024 at 10:51 AM TengYao Chi wrote: >> >>> Hi >&

Re: [VOTE] KIP-1080: Fix the typo: `maxlifeTimeMs` in CreateDelegationTokenOptions

2024-11-10 Thread
Hello everyone, I hope this message finds you well. As the vote has been pending for three weeks, I would like to push it manually. Thank you for your attention. Best regards, Jiunn-Yang > 黃竣陽 於 2024年9月28日 上午10:04 寫道: > > Hello everyone, > I hope this message finds you well. >

[VOTE] KIP-1100: Consider renaming org.apache.kafka.server:type=AssignmentsManager

2024-11-10 Thread
Hi all, I'd like to call for a vote on KIP-1100 The discussion can be found here: Best regards,

Re: [ANNOUNCE] Apache Kafka 3.8.1

2024-10-29 Thread
Hello Josep Thanks for hard working on running this release! Best regards, Jiunn-Yang > TengYao Chi 於 2024年10月30日 凌晨12:35 寫道: > > Hi Josep > Thanks for running this release > > Cheers, > TengYao > > Apoorv Mittal 於 2024年10月30日 週三 上午12:18寫道: > >> Thanks Josep for all the hard work for the r

Re: [VOTE] 3.8.1 RC1

2024-10-27 Thread
Hi Josep, +1(non-binding) I did the following - Built from different JDK (8, 11, 17, 21) in Docker image - Ran all the unit test and integration test in container Best regards, Jiunn-Yang > TengYao Chi 於 2024年10月26日 凌晨12:22 寫道: > > Hi Josep, > > Thanks for handling the release of the 3.8.1 R

Re: [DISCUSS] KIP-1100: Consider renaming org.apache.kafka.server:type=AssignmentsManager

2024-10-27 Thread
add "deprecation" to the MBean description instead of > logging it? > > *Q1:* To allow users to migrate to the new metrics now, should we add the > metric kafka.server:type=AssignmentsManager at the same time? > > Best, > Chia-Ping > > > > 黃竣陽 於 202

[DISCUSS] KIP-1100: Consider renaming org.apache.kafka.server:type=AssignmentsManager

2024-10-27 Thread
Hello everyone, I would like to start a discussion about KIP-1100 In this KIP, we plan to update the `AssignmentsManager` metric name from `org.apache.kafka.server

Re: [VOTE] KIP-1080: Fix the typo: `maxlifeTimeMs` in CreateDelegationTokenOptions

2024-10-21 Thread
Hello everyone, I hope you're all doing well. Since the vote has been pending for over three weeks, I’d like to proceed with pushing it manually. Thank you for your attention. Best regards, Jiunn-Yang > 黃竣陽 於 2024年9月28日 上午10:04 寫道: > > Hello everyone, > I hope this messa

Re: [VOTE] KIP-1080: Fix the typo: `maxlifeTimeMs` in CreateDelegationTokenOptions

2024-09-27 Thread
ooks good to me now. > > +1 (binding) > > Lianet > > > On Thu, Sep 5, 2024, 8:29 p.m. 黃竣陽 wrote: > >> It make sense to me, I will change to >> `CreateDelegationTokenRequestData.setMaxLifetimeMs` >> >>> Chia-Ping Tsai 於 2024年9月5日 晚上11:22

Re: [DISCUSS] KIP-1022 Formatting and Updating Features

2024-09-24 Thread
> Thanks again, > Justine > > On Sat, Sep 14, 2024 at 6:21 PM 黃竣陽 wrote: > >> Hi everyone, >> >> I make some update to KIP-1022 < >> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1022%3A+Formatting+and+Updating+Features >>>

RE: Re: [DISCUSS] KIP-1022 Formatting and Updating Features

2024-09-14 Thread
Hi everyone, I make some update to KIP-1022 < https://cwiki.apache.org/confluence/display/KAFKA/KIP-1022%3A+Formatting+and+Updating+Features > As part of KIP-584, brokers expose supported version ranges for features, which may include 0. Version 0 can indicate either an incomplete feature or a dis

Re: [VOTE] KIP-1085: Fix leaking *_DOC variables in StreamsConfig

2024-09-11 Thread
ep 6, 2024 at 4:20 AM Luke Chen wrote: >> >> +1 from me. Thanks. >> >> On Fri, Sep 6, 2024 at 1:04 AM Matthias J. Sax wrote: >> >>> +1 (binding) >>> >>> On 9/5/24 06:34, Chia-Ping Tsai wrote: >>>> +1 (binding) >>>&

Re: [VOTE] KIP-1080: Fix the typo: `maxlifeTimeMs` in CreateDelegationTokenOptions

2024-09-05 Thread
me_ms), that >> generates a CreateDelegationTokenRequestData.maxLifetimeMs() and >> CreateDelegationTokenRequestData.setMaxLifetimeMs(...) >> >> Thanks! >> >> Lianet >> >> On Thu, Sep 5, 2024 at 9:36 AM Chia-Ping Tsai wrote: >> >>

[VOTE] KIP-1085: Fix leaking *_DOC variables in StreamsConfig

2024-09-05 Thread
Hello everyone, I would like to call for a vote on KIP-1085: The discussion can be found here: Best regards, Jiunn-Yang

  1   2   >