Hello chia, Changing only the group name field in MetricsName should not affect users, since the original metrics are still preserved. Therefore, this change should not introduce any compatibility issues.
Best Regards, Jiunn-Yang > Chia-Ping Tsai <chia7...@gmail.com> 於 2025年7月31日 凌晨12:33 寫道： > > hi Jiunn-Yang > > Pardon me, why to deprecate them? Changing the value does not break the > compatibility, right? > > Best, > Chia-Ping > > 黃竣陽 <s7133...@gmail.com> 於 2025年7月30日 週三 下午10:22寫道： > >> Hello all, >> >> Since REMOTE_LOG_READER_TASK_QUEUE_SIZE_METRIC and >> REMOTE_LOG_READER_AVG_IDLE_PERCENT_METRIC >> are part of the public API, I have introduced corresponding deprecated >> fields as a temporary bridge. >> These fields are marked as deprecated because they serve as a transitional >> workaround and will be removed in Kafka 5.0. >> >> I've updated the KIP to reflect these changes. Please let me know if you >> have any feedback. >> >> Best Regards, >> Jiunn-Yang >> >>> Chia-Ping Tsai <chia7...@gmail.com> 於 2025年7月18日 凌晨2:58 寫道： >>> >>> hi Jiunn-Yang >>> >>> I think this KIP is ready for a VOTE thread. >>> >>> thanks, >>> Chia-Ping >>> >>> 黃竣陽 <s7133...@gmail.com> 於 2025年5月30日 週五 上午11:17寫道： >>> >>>> Hi all, >>>> >>>> I’d like to manually bump this thread. If there’s no further feedback, >>>> I’ll start the vote tomorrow. >>>> >>>> Best Regards, >>>> Jiunn-Yang >>>> >>>>> 黃竣陽 <s7133...@gmail.com> 於 2025年5月11日 下午4:29 寫道： >>>>> >>>>> Hi chia, >>>>> >>>>> File a Jira to trace it >>>> https://issues.apache.org/jira/browse/KAFKA-19262 >>>>> >>>>> Best Regards, >>>>> Jiunn-Yang >>>>> >>>>>> 黃竣陽 <s7133...@gmail.com> 於 2025年5月11日 下午1:41 寫道： >>>>>> >>>>>> Hi Ismael, chia, >>>>>> >>>>>> Thanks for all the feedback. I’ve updated the KIP. >>>>>> >>>>>>> 2. Given that we regressed in two different instances (that we found >> so >>>>>>> far), this indicates a test gap combined with a brittle coding >>>> pattern. We >>>>>>> should consider how to fix this going forward. It's not specific to >>>> the KIP >>>>>>> itself (which is focused on the user facing aspects), but important. >>>>>>> Perhaps we can add a test that iterates through all metrics and >>>> verifies >>>>>>> the naming pattern. >>>>>> >>>>>> I agree, We should add an integration test for KafkaYammerMetrics >>>>>> to ensure all metric names conform to the expected naming convention. >>>>>> >>>>>> Best Regards, >>>>>> Jiunn-Yang >>>>>> >>>>>>> Ismael Juma <m...@ismaeljuma.com> 於 2025年5月11日 凌晨1:44 寫道： >>>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> Thanks for the KIP. A couple of comments: >>>>>>> 1. Nit: KIPs should not "consider" things, they propose specific and >>>> well >>>>>>> defined changes. Given that, please update the title to match the >>>> proposal. >>>>>>> 2. Given that we regressed in two different instances (that we found >> so >>>>>>> far), this indicates a test gap combined with a brittle coding >>>> pattern. We >>>>>>> should consider how to fix this going forward. It's not specific to >>>> the KIP >>>>>>> itself (which is focused on the user facing aspects), but important. >>>>>>> Perhaps we can add a test that iterates through all metrics and >>>> verifies >>>>>>> the naming pattern. >>>>>>> >>>>>>> Ismael >>>>>>> >>>>>>> On Sun, Oct 27, 2024 at 9:23 AM 黃竣陽 <s7133...@gmail.com> wrote: >>>>>>> >>>>>>>> Hello everyone, >>>>>>>> >>>>>>>> I would like to start a discussion about KIP-1100 >>>>>>>> < >>>>>>>> >>>> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1100%3A+Consider+renaming+org.apache.kafka.server%3Atype%3DAssignmentsManager >>>>>>>>> >>>>>>>> In this KIP, we plan to update the `AssignmentsManager` metric name >>>> from >>>>>>>> `org.apache.kafka.server:type=AssignmentsManager` to >>>>>>>> `kafka.server:type=AssignmentsManager`. >>>>>>>> >>>>>>>> >>>>>>>> Any feedback and suggestions for the KIP are welcome in this email >>>> thread. >>>>>>>> >>>>>>>> Thank you! >>>>>>>> Best regards, >>>>>>>> Jiunn-Yang >>>>>> >>>>> >>>> >>>> >> >>
