Hi Ismael, chia, Thanks for all the feedback. I’ve updated the KIP.
> 2. Given that we regressed in two different instances (that we found so > far), this indicates a test gap combined with a brittle coding pattern. We > should consider how to fix this going forward. It's not specific to the KIP > itself (which is focused on the user facing aspects), but important. > Perhaps we can add a test that iterates through all metrics and verifies > the naming pattern. I agree, We should add an integration test for KafkaYammerMetrics to ensure all metric names conform to the expected naming convention. Best Regards, Jiunn-Yang > Ismael Juma <m...@ismaeljuma.com> 於 2025年5月11日 凌晨1:44 寫道： > > Hi, > > Thanks for the KIP. A couple of comments: > 1. Nit: KIPs should not "consider" things, they propose specific and well > defined changes. Given that, please update the title to match the proposal. > 2. Given that we regressed in two different instances (that we found so > far), this indicates a test gap combined with a brittle coding pattern. We > should consider how to fix this going forward. It's not specific to the KIP > itself (which is focused on the user facing aspects), but important. > Perhaps we can add a test that iterates through all metrics and verifies > the naming pattern. > > Ismael > > On Sun, Oct 27, 2024 at 9:23 AM 黃竣陽 <s7133...@gmail.com> wrote: > >> Hello everyone, >> >> I would like to start a discussion about KIP-1100 >> < >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1100%3A+Consider+renaming+org.apache.kafka.server%3Atype%3DAssignmentsManager >>> >> In this KIP, we plan to update the `AssignmentsManager` metric name from >> `org.apache.kafka.server:type=AssignmentsManager` to >> `kafka.server:type=AssignmentsManager`. >> >> >> Any feedback and suggestions for the KIP are welcome in this email thread. >> >> Thank you! >> Best regards, >> Jiunn-Yang
