Re: Review Request 20468: Add log cleaner metrics. (Cherry-picked from trunk)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20468/#review40840 --- Also, I think we need to make the following var volatile. CleanerSt

Re: Review Request 20468: Add log cleaner metrics. (Cherry-picked from trunk)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20468/#review40838 --- Ship it! core/src/main/scala/kafka/log/LogCleanerManager.scala

[jira] [Commented] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974624#comment-13974624 ] Jay Kreps commented on KAFKA-1359: -- Yeah I'm not opposed to switching. > Add topic/broke

[jira] [Resolved] (KAFKA-1398) Topic config changes can be lost and cause fatal exceptions on broker restarts

[ https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-1398. --- Resolution: Fixed Committed to 0.8.1 as well > Topic config changes can be lost and cause fatal exce

Jenkins build is back to normal : Kafka-trunk #168

See

[jira] [Commented] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974561#comment-13974561 ] Guozhang Wang commented on KAFKA-1359: -- I did a small benchmark on my mac laptop and

[jira] [Resolved] (KAFKA-1355) Reduce/optimize update metadata requests sent during leader election

[ https://issues.apache.org/jira/browse/KAFKA-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-1355. --- Resolution: Fixed Thanks for the review. Committed to 0.8.1 as well. > Reduce/optimize update metada

[jira] [Commented] (KAFKA-493) High CPU usage on inactive server

[ https://issues.apache.org/jira/browse/KAFKA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974471#comment-13974471 ] Joel Koshy commented on KAFKA-493: -- For (1) I think the issue was discussed (not yet fixed

[jira] [Reopened] (KAFKA-1398) Topic config changes can be lost and cause fatal exceptions on broker restarts

[ https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy reopened KAFKA-1398: --- Reopening to keep track of the follow-up. Also, I need to commit to 0.8.1. > Topic config changes can be

[jira] [Resolved] (KAFKA-1362) Publish sources and javadoc jars

[ https://issues.apache.org/jira/browse/KAFKA-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-1362. --- Resolution: Fixed > Publish sources and javadoc jars > > >

[jira] [Commented] (KAFKA-1362) Publish sources and javadoc jars

[ https://issues.apache.org/jira/browse/KAFKA-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974454#comment-13974454 ] Joel Koshy commented on KAFKA-1362: --- Committed to both 0.8.1 and trunk Filed KAFKA-1406

[jira] [Updated] (KAFKA-1406) Fix scaladoc/javadoc warnings

[ https://issues.apache.org/jira/browse/KAFKA-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1406: -- Fix Version/s: 0.8.2 > Fix scaladoc/javadoc warnings > - > >

[jira] [Created] (KAFKA-1406) Fix scaladoc/javadoc warnings

Joel Koshy created KAFKA-1406: - Summary: Fix scaladoc/javadoc warnings Key: KAFKA-1406 URL: https://issues.apache.org/jira/browse/KAFKA-1406 Project: Kafka Issue Type: Bug Components: p

[jira] [Updated] (KAFKA-1406) Fix scaladoc/javadoc warnings

[ https://issues.apache.org/jira/browse/KAFKA-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1406: -- Labels: build (was: ) > Fix scaladoc/javadoc warnings > - > >

[jira] [Commented] (KAFKA-1399) Drop Scala 2.8.x support

[ https://issues.apache.org/jira/browse/KAFKA-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1397#comment-1397 ] Jun Rao commented on KAFKA-1399: We are re-rewriting the clients in java. Once that's done

Re: Review Request 20471: KAFKA-1398: Follow-up comments on dynamic config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20471/#review40810 --- Ship it! Ship It! - Jun Rao On April 18, 2014, 8:03 p.m., Jay Kr

Re: Review Request 20471: KAFKA-1398: Follow-up comments on dynamic config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20471/#review40809 --- Ship it! Ship It! - Joel Koshy On April 18, 2014, 8:03 p.m., Jay

[jira] [Commented] (KAFKA-1398) Topic config changes can be lost and cause fatal exceptions on broker restarts

[ https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974420#comment-13974420 ] Jay Kreps commented on KAFKA-1398: -- Updated reviewboard https://reviews.apache.org/r/2047

[jira] [Updated] (KAFKA-1398) Topic config changes can be lost and cause fatal exceptions on broker restarts

[ https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1398: - Attachment: KAFKA-1398_2014-04-18_13:03:03.patch > Topic config changes can be lost and cause fatal excep

Re: Review Request 20471: KAFKA-1398: Follow-up comments on dynamic config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20471/ --- (Updated April 18, 2014, 8:03 p.m.) Review request for kafka. Summary (update

Re: Review Request 20471: Patch for KAFKA-1398

> On April 18, 2014, 3:22 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 123-124 > > > > > > This is not needed. In ZK, new sequential nodes always get a higher id > > whethe

[jira] [Commented] (KAFKA-1398) Topic config changes can be lost and cause fatal exceptions on broker restarts

[ https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974418#comment-13974418 ] Jay Kreps commented on KAFKA-1398: -- Created reviewboard https://reviews.apache.org/r/2049

[jira] [Updated] (KAFKA-1398) Topic config changes can be lost and cause fatal exceptions on broker restarts

[ https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1398: - Attachment: KAFKA-1398.patch > Topic config changes can be lost and cause fatal exceptions on broker rest

Review Request 20498: KAFKA-1398: Follow-up comments on dynamic config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20498/ --- Review request for kafka. Bugs: KAFKA-1398 https://issues.apache.org/jira/b

Re: Review Request 20471: Patch for KAFKA-1398

> On April 18, 2014, 6:12 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 87-88 > > > > > > Actually that's not the right example - it would work fine since you > > only wan

[jira] [Commented] (KAFKA-1356) Topic metadata requests takes too long to process

[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974346#comment-13974346 ] Joel Koshy commented on KAFKA-1356: --- Thanks for the review. Committed the follow-up patc

[jira] [Commented] (KAFKA-1356) Topic metadata requests takes too long to process

[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974333#comment-13974333 ] Jun Rao commented on KAFKA-1356: Joel, +1 on https://issues.apache.org/jira/secure/atta

[jira] [Updated] (KAFKA-1380) 0.8.1.1 release candidate

[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1380: -- Due Date: 21/Apr/14 (was: 16/Apr/14) Quick update - we have to push this out to Monday. Most of the pa

Re: Review Request 20471: Patch for KAFKA-1398

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20471/#review40792 --- core/src/main/scala/kafka/server/TopicConfigManager.scala

Re: Review Request 20376: Publish source jars and javadoc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20376/#review40791 --- Ship it! Ship It! - Jun Rao On April 15, 2014, 7:39 p.m., Joel K

Re: Review Request 20471: Patch for KAFKA-1398

> On April 18, 2014, 6:01 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 87-88 > > > > > > Say you override the retention to x hours, realize you made a mistake > > and the

Re: Review Request 20440: Patch for KAFKA-1337

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20440/#review40790 --- Ship it! Ship It! - Jun Rao On April 17, 2014, 12:41 a.m., Jay K

[jira] [Commented] (KAFKA-1398) Topic config changes can be lost and cause fatal exceptions on broker restarts

[ https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974311#comment-13974311 ] Jay Kreps commented on KAFKA-1398: -- Created reviewboard https://reviews.apache.org/r/2049

[jira] [Updated] (KAFKA-1398) Topic config changes can be lost and cause fatal exceptions on broker restarts

[ https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1398: - Attachment: KAFKA-1398.patch > Topic config changes can be lost and cause fatal exceptions on broker rest

Re: Review Request 20471: Patch for KAFKA-1398

> On April 18, 2014, 3:22 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 123-124 > > > > > > This is not needed. In ZK, new sequential nodes always get a higher id > > whethe

Could I get a review

https://reviews.apache.org/r/20440/ Should be a simple one. -Jay

Re: Review Request 20376: Publish source jars and javadoc

> On April 18, 2014, 4:54 p.m., Jun Rao wrote: > > README.md, lines 10-11 > > > > > > Do we need the trailing ###? Will make that change. > On April 18, 2014, 4:54 p.m., Jun Rao wrote: > > build.gradle, lines 78-79

Review Request 20492: KAFKA-1398: Follow-up comments on dynamic config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20492/ --- Review request for kafka. Bugs: KAFKA-1398 https://issues.apache.org/jira/b

Re: Review Request 20471: Patch for KAFKA-1398

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20471/#review40786 --- core/src/main/scala/kafka/server/TopicConfigManager.scala

Re: Review Request 20471: Patch for KAFKA-1398

> On April 18, 2014, 3:22 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 87-88 > > > > > > The child list returned by ZK doesn't guarantee any ordering. We will > > need to so

Re: Review Request 20471: Patch for KAFKA-1398

> On April 18, 2014, 5:25 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 121-134 > > > > > > You mean that the purge is only triggered by a broker bounce or a new > > conf

[jira] [Commented] (KAFKA-1403) Adding timestamp to kafka index structure

[ https://issues.apache.org/jira/browse/KAFKA-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974302#comment-13974302 ] Jun Rao commented on KAFKA-1403: Would it be good enough to just add the timestamp in the

Re: Review Request 20471: Patch for KAFKA-1398

> On April 18, 2014, 3:22 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 97-98 > > > > > > In the corner case, it seems that it's still possible by the time that > > we try to

Build failed in Jenkins: Kafka-trunk #167

See Changes: [jay.kreps] KAFKA-1398 dynamic config changes are broken. -- [...truncated 738 lines...] kafka.admin.AddPartitionsTest > testManualAssignmentOfReplicas PASSED kafka.admin.AddPartitionsTe

Re: Review Request 20471: Patch for KAFKA-1398

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20471/#review40780 --- core/src/main/scala/kafka/server/TopicConfigManager.scala

[jira] [Commented] (KAFKA-1405) Global JSON.globalNumberParser screws up other libraries

[ https://issues.apache.org/jira/browse/KAFKA-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974266#comment-13974266 ] Jun Rao commented on KAFKA-1405: Vadim, Thanks for reporting this. Yes, overriding JSON.g

Re: Review Request 20376: Publish source jars and javadoc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20376/#review40777 --- Looks good. Just some minor comments below. README.md

[jira] [Resolved] (KAFKA-1398) Topic config changes can be lost and cause fatal exceptions on broker restarts

[ https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-1398. -- Resolution: Fixed > Topic config changes can be lost and cause fatal exceptions on broker restarts > --

Re: Review Request 20471: Patch for KAFKA-1398

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20471/#review40772 --- Could you add some comments at the beginning of TopicConfigManager t

[jira] [Commented] (KAFKA-1365) Second Manual preferred replica leader election command always fails

[ https://issues.apache.org/jira/browse/KAFKA-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974159#comment-13974159 ] BalajiSeshadri commented on KAFKA-1365: --- We will test the controller issue one in de