----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20471/#review40809 -----------------------------------------------------------
Ship it! Ship It! - Joel Koshy On April 18, 2014, 8:03 p.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20471/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 8:03 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1398 > https://issues.apache.org/jira/browse/KAFKA-1398 > > > Repository: kafka > > > Description > ------- > > KAFKA-1398 Dynamic config follow-on-comments. > > > Diffs > ----- > > core/src/main/scala/kafka/server/TopicConfigManager.scala > 4a4274eef790ff1fd2dfbbd85d44722688bfadee > core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala > 5a1d5cc36033d0427c6c680d198c02207e10326c > > Diff: https://reviews.apache.org/r/20471/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >