> On April 18, 2014, 3:22 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 97-98 > > <https://reviews.apache.org/r/20471/diff/1/?file=561891#file561891line97> > > > > In the corner case, it seems that it's still possible by the time that > > we try to read this ZK path, it's deleted by another broker. We probably > > need to handle the ZKNodeNotExistException.
Ok, this is handled in readDataMaybeNull. So this is fine. - Jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20471/#review40772 ----------------------------------------------------------- On April 18, 2014, 12:36 a.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20471/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 12:36 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1398 > https://issues.apache.org/jira/browse/KAFKA-1398 > > > Repository: kafka > > > Description > ------- > > KAFKA-1398 dynamic config changes are broken. > > > Diffs > ----- > > core/src/main/scala/kafka/server/TopicConfigManager.scala > d41fd33d91406dfa2ce8c1e1b04a078e983ccadd > core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/20471/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
