> On April 18, 2014, 6:01 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 87-88 > > <https://reviews.apache.org/r/20471/diff/1/?file=561891#file561891line87> > > > > Say you override the retention to x hours, realize you made a mistake > > and then override to y hours. If the order can be mixed then it would be an > > issue no?
I don't think so--the notification just says read the config for topic X. So two updates will just mean two entries saying the config has changed. The only config value that is stored is the final value. - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20471/#review40786 ----------------------------------------------------------- On April 18, 2014, 12:36 a.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20471/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 12:36 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1398 > https://issues.apache.org/jira/browse/KAFKA-1398 > > > Repository: kafka > > > Description > ------- > > KAFKA-1398 dynamic config changes are broken. > > > Diffs > ----- > > core/src/main/scala/kafka/server/TopicConfigManager.scala > d41fd33d91406dfa2ce8c1e1b04a078e983ccadd > core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/20471/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
