> On April 18, 2014, 6:12 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/TopicConfigManager.scala, lines 87-88 > > <https://reviews.apache.org/r/20471/diff/1/?file=561891#file561891line87> > > > > Actually that's not the right example - it would work fine since you > > only want the later change. > > > > How about this: > > Say you first override retention to x hours. > > (change 1) > > > > Then you override compaction policy (change 2) > > > > If you bring up a broker that has been down for some time (and has that > > topic) then it could fail to apply change 1 if it sees change 2 first.
Ok nm - the topic's config would have been written in zookeeper already. I'll cherry-pick this and the follow-up patch into 0.8.1 - Joel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20471/#review40792 ----------------------------------------------------------- On April 18, 2014, 12:36 a.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20471/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 12:36 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1398 > https://issues.apache.org/jira/browse/KAFKA-1398 > > > Repository: kafka > > > Description > ------- > > KAFKA-1398 dynamic config changes are broken. > > > Diffs > ----- > > core/src/main/scala/kafka/server/TopicConfigManager.scala > d41fd33d91406dfa2ce8c1e1b04a078e983ccadd > core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/20471/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
