[jira] [Commented] (KAFKA-1356) Topic metadata requests takes too long to process

[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960865#comment-13960865 ] Timothy Chen commented on KAFKA-1356: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1356) Topic metadata requests takes too long to process

[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1356: Attachment: KAFKA-1356_2014-04-04_17:45:37.patch > Topic metadata requests takes too long to proces

Re: Review Request 19957: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19957/ --- (Updated April 5, 2014, 12:45 a.m.) Review request for kafka. Bugs: KAFKA-135

Re: Review Request 19957: Patch for KAFKA-1356

> On April 5, 2014, 12:11 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/api/TopicMetadata.scala, line 35 > > > > > > could you confirm why we need to fill the array vs create an empty one > > of size numPart

Re: Review Request 19957: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19957/#review39618 --- core/src/main/scala/kafka/api/TopicMetadata.scala

Re: Review Request 20038: Patch for KAFKA-1355

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20038/#review39616 --- Ship it! Ship It! - Timothy Chen On April 4, 2014, 8:51 p.m., Jo

Re: Review Request 20038: Patch for KAFKA-1355

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20038/#review39614 --- Ship it! Ship It! - Neha Narkhede On April 4, 2014, 8:51 p.m., J

Re: Review Request 19831: Patch for KAFKA-1337

> On April 4, 2014, 8:36 p.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java, > > line 51 > > > > > > We also fetch metadata when there are topic changes or leader

Re: Review Request 19957: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19957/#review39605 --- Ship it! Ship It! - Guozhang Wang On April 4, 2014, 9:40 p.m., T

[jira] [Commented] (KAFKA-1356) Topic metadata requests takes too long to process

[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960456#comment-13960456 ] Timothy Chen commented on KAFKA-1356: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1356) Topic metadata requests takes too long to process

[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1356: Attachment: KAFKA-1356_2014-04-04_14:40:18.patch > Topic metadata requests takes too long to proces

Re: Review Request 19957: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19957/ --- (Updated April 4, 2014, 9:40 p.m.) Review request for kafka. Bugs: KAFKA-1356

Re: Review Request 19957: Patch for KAFKA-1356

> On April 4, 2014, 3:59 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, lines 619-620 > > > > > > If this is expensive, perhaps we can only do that if we require all > > topics? If that mak

Re: Review Request 20050: Fix KAFKA-1359

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20050/#review39598 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

[jira] [Commented] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960452#comment-13960452 ] Guozhang Wang commented on KAFKA-1359: -- Created reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1359: - Attachment: KAFKA-1359.patch > Add topic/broker metrics once new topic/broker is discovered > ---

Review Request 20050: Fix KAFKA-1359

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20050/ --- Review request for kafka. Bugs: KAFKA-1359 https://issues.apache.org/jira/b

[jira] [Resolved] (KAFKA-1327) Add log cleaner metrics

[ https://issues.apache.org/jira/browse/KAFKA-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-1327. -- Resolution: Fixed > Add log cleaner metrics > --- > > Key: KAFKA-13

[jira] [Resolved] (KAFKA-1337) Rationalize new producer configs

[ https://issues.apache.org/jira/browse/KAFKA-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-1337. -- Resolution: Fixed > Rationalize new producer configs > > >

[jira] [Commented] (KAFKA-1337) Rationalize new producer configs

[ https://issues.apache.org/jira/browse/KAFKA-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960414#comment-13960414 ] Jay Kreps commented on KAFKA-1337: -- Cool, Neha I addressed your comments except for one w

Re: Review Request 19831: Patch for KAFKA-1337

> On April 4, 2014, 8:36 p.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java, > > line 51 > > > > > > We also fetch metadata when there are topic changes or leader

[jira] [Commented] (KAFKA-1355) Reduce/optimize update metadata requests sent during leader election

[ https://issues.apache.org/jira/browse/KAFKA-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960410#comment-13960410 ] Joel Koshy commented on KAFKA-1355: --- Updated reviewboard https://reviews.apache.org/r/20

[jira] [Updated] (KAFKA-1355) Reduce/optimize update metadata requests sent during leader election

[ https://issues.apache.org/jira/browse/KAFKA-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1355: -- Attachment: KAFKA-1355_2014-04-04_13:51:22.patch > Reduce/optimize update metadata requests sent during

Re: Review Request 20038: Patch for KAFKA-1355

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20038/ --- (Updated April 4, 2014, 8:51 p.m.) Review request for kafka. Bugs: KAFKA-1355

[jira] [Updated] (KAFKA-1355) Reduce/optimize update metadata requests sent during leader election

[ https://issues.apache.org/jira/browse/KAFKA-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1355: -- Attachment: KAFKA-1355_2014-04-04_13:48:34.patch > Reduce/optimize update metadata requests sent during

[jira] [Commented] (KAFKA-1355) Reduce/optimize update metadata requests sent during leader election

[ https://issues.apache.org/jira/browse/KAFKA-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960408#comment-13960408 ] Joel Koshy commented on KAFKA-1355: --- Updated reviewboard https://reviews.apache.org/r/20

Re: Review Request 20038: Patch for KAFKA-1355

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20038/ --- (Updated April 4, 2014, 8:48 p.m.) Review request for kafka. Bugs: KAFKA-1355

[jira] [Commented] (KAFKA-1337) Rationalize new producer configs

[ https://issues.apache.org/jira/browse/KAFKA-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960401#comment-13960401 ] Neha Narkhede commented on KAFKA-1337: -- This looks really good. I have posted minor c

Re: Review Request 19831: Patch for KAFKA-1337

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19831/#review39328 --- Ship it! Minor comments below that you can fix on checkin clients

Re: Review Request 20034: Fix KAFKA-1353

> On April 4, 2014, 8:22 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/network/SocketServer.scala, line 260 > > > > > > can we just record it here instead of where it's registered. It's a bit > > confusing

Re: Review Request 20034: Fix KAFKA-1353

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20034/#review39590 --- core/src/main/scala/kafka/network/SocketServer.scala

[jira] [Updated] (KAFKA-1353) report capacity used by request thread pool and network thread pool

[ https://issues.apache.org/jira/browse/KAFKA-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1353: - Assignee: Guozhang Wang > report capacity used by request thread pool and network thread pool > -

Re: Review Request 20038: Patch for KAFKA-1355

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20038/#review39587 --- core/src/main/scala/kafka/controller/ControllerChannelManager.scala

Re: Review Request 20038: Patch for KAFKA-1355

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20038/#review39571 --- core/src/main/scala/kafka/controller/ControllerChannelManager.scala

[jira] [Commented] (KAFKA-1355) Reduce/optimize update metadata requests sent during leader election

[ https://issues.apache.org/jira/browse/KAFKA-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960237#comment-13960237 ] Joel Koshy commented on KAFKA-1355: --- https://reviews.apache.org/r/20038 > Reduce/optimi

Review Request 20038: Patch for KAFKA-1355

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20038/ --- Review request for kafka. Bugs: KAFKA-1355 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1352) Reduce logging on the server

[ https://issues.apache.org/jira/browse/KAFKA-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960226#comment-13960226 ] Ivan Lyutov commented on KAFKA-1352: Updated reviewboard https://reviews.apache.org/r/

[jira] [Updated] (KAFKA-1352) Reduce logging on the server

[ https://issues.apache.org/jira/browse/KAFKA-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1352: --- Attachment: KAFKA-1352_2014-04-04_21:20:31.patch > Reduce logging on the server > ---

Re: Review Request 20030: Patch for KAFKA-1352

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20030/ --- (Updated April 4, 2014, 6:20 p.m.) Review request for kafka. Bugs: KAFKA-1352

[jira] [Updated] (KAFKA-1353) report capacity used by request thread pool and network thread pool

[ https://issues.apache.org/jira/browse/KAFKA-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1353: - Attachment: KAFKA-1353.patch > report capacity used by request thread pool and network thread poo

[jira] [Commented] (KAFKA-1353) report capacity used by request thread pool and network thread pool

[ https://issues.apache.org/jira/browse/KAFKA-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960182#comment-13960182 ] Guozhang Wang commented on KAFKA-1353: -- Created reviewboard https://reviews.apache.or

[jira] [Assigned] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang reassigned KAFKA-1359: Assignee: Guozhang Wang > Add topic/broker metrics once new topic/broker is discovered > --

Review Request 20034: Fix KAFKA-1353

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20034/ --- Review request for kafka. Bugs: KAFKA-1353 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1352) Reduce logging on the server

[ https://issues.apache.org/jira/browse/KAFKA-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960177#comment-13960177 ] Neha Narkhede commented on KAFKA-1352: -- [~edgefox] Thanks for the patch! I think it w

Re: Review Request 19831: Patch for KAFKA-1337

> On April 1, 2014, 4:50 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java, > > lines 32-33 > > > > > > Is the java variable name part of the public API too? Yes, as

Re: Review Request 20030: Patch for KAFKA-1352

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20030/#review39555 --- Thanks for the patch. Some comments below. core/src/main/scala/kaf

[jira] [Commented] (KAFKA-1354) Failed to load class "org.slf4j.impl.StaticLoggerBinder"

[ https://issues.apache.org/jira/browse/KAFKA-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960135#comment-13960135 ] Jun Rao commented on KAFKA-1354: The issue is related to slf4j. slf4j only provides the ap

Re: Review Request 19957: Patch for KAFKA-1356

> On April 4, 2014, 3:59 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, lines 619-620 > > > > > > If this is expensive, perhaps we can only do that if we require all > > topics? If that mak

Re: Review Request 19626: Patch for KAFKA-1323

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19626/#review39553 --- Ship it! Ship It! - Jun Rao On April 2, 2014, 7:18 p.m., Timothy

Re: Review Request 19953: Patch for KAFKA-1303

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19953/#review39550 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

[jira] [Commented] (KAFKA-1352) Reduce logging on the server

[ https://issues.apache.org/jira/browse/KAFKA-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960102#comment-13960102 ] Ivan Lyutov commented on KAFKA-1352: Created reviewboard https://reviews.apache.org/r/

[jira] [Assigned] (KAFKA-1352) Reduce logging on the server

[ https://issues.apache.org/jira/browse/KAFKA-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov reassigned KAFKA-1352: -- Assignee: Ivan Lyutov > Reduce logging on the server > > >

[jira] [Updated] (KAFKA-1352) Reduce logging on the server

[ https://issues.apache.org/jira/browse/KAFKA-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1352: --- Attachment: KAFKA-1352.patch > Reduce logging on the server > > >

Review Request 20030: Patch for KAFKA-1352

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20030/ --- Review request for kafka. Bugs: KAFKA-1352 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960097#comment-13960097 ] Neha Narkhede commented on KAFKA-1323: -- The same tests (mentioned above) fail for me

Re: Review Request 19957: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19957/#review39546 --- core/src/main/scala/kafka/api/TopicMetadata.scala

Re: Review Request 19957: Patch for KAFKA-1356

> On April 4, 2014, 3:59 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, lines 619-620 > > > > > > If this is expensive, perhaps we can only do that if we require all > > topics? If that mak

Re: Review Request 19957: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19957/#review39542 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 19947: Patch for KAFKA-1327

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19947/#review39543 --- Ship it! Ship It! - Neha Narkhede On April 2, 2014, 5:21 p.m., J

Re: Review Request 19947: Patch for KAFKA-1327

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19947/#review39540 --- Ship it! Ship It! - Guozhang Wang On April 2, 2014, 5:21 p.m., J

[jira] [Updated] (KAFKA-1358) Broker throws exception when reconnecting to zookeeper

[ https://issues.apache.org/jira/browse/KAFKA-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1358: --- Resolution: Fixed Status: Resolved (was: Patch Available) Committed to 0.8.1 branch. > Broker throw

[jira] [Resolved] (KAFKA-803) Offset returned to producer is not consistent

[ https://issues.apache.org/jira/browse/KAFKA-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-803. --- Resolution: Fixed Fixed in KAFKA-1260. > Offset returned to producer is not consistent >

Re: Review Request 19947: Patch for KAFKA-1327

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19947/#review39537 --- Ship it! Ship It! - Jun Rao On April 2, 2014, 5:21 p.m., Jay Kre