----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20050/#review39598 -----------------------------------------------------------
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java <https://reviews.apache.org/r/20050/#comment72038> Ideal we should be using Utils.notNull for all these. But we can't since some unit/integration tests bypass the metric registration phase and causing NPE. I tried to create a MockMetrics and MockSensor but that does not work perfectly either. If people have better suggestion I would love to make a change. - Guozhang Wang On April 4, 2014, 9:33 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20050/ > ----------------------------------------------------------- > > (Updated April 4, 2014, 9:33 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1359 > https://issues.apache.org/jira/browse/KAFKA-1359 > > > Repository: kafka > > > Description > ------- > > KAFKA-1359.v1 > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java > 855ae84f14aa91653b3fa855c2af40560323f42a > clients/src/main/java/org/apache/kafka/common/network/Selector.java > 558f8b47638b354f9c1a30be5d45dc7b61131bea > > Diff: https://reviews.apache.org/r/20050/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
