> On April 4, 2014, 3:59 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, lines 619-620 > > <https://reviews.apache.org/r/19957/diff/2/?file=547050#file547050line619> > > > > If this is expensive, perhaps we can only do that if we require all > > topics? If that makes the code too complicated, we don't have to do this > > optimization. > > Neha Narkhede wrote: > Since this is invoked just once, it's not worth optimizing. Is it?
We don't have to if it's too complicated. However, most requests will have a small # of topics in the request. In those cases, there is no need to make a copy of all cached topics. - Jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19957/#review39542 ----------------------------------------------------------- On April 3, 2014, 1:39 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19957/ > ----------------------------------------------------------- > > (Updated April 3, 2014, 1:39 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1356 > https://issues.apache.org/jira/browse/KAFKA-1356 > > > Repository: kafka > > > Description > ------- > > KAFKA-1356 Improve topic metadata handling in kafka api > > > Diffs > ----- > > core/src/main/scala/kafka/api/TopicMetadata.scala > 0513a59ed94e556894b3515dc38666ee9a66ae3d > core/src/main/scala/kafka/controller/KafkaController.scala > fcabd0da201ccd478f5884bcca9b75a8c8ea8373 > core/src/main/scala/kafka/server/KafkaApis.scala > c068ef69207c351eec413a595f1747c59f8b3983 > > Diff: https://reviews.apache.org/r/19957/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >
