> On April 4, 2014, 8:22 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/network/SocketServer.scala, line 260 > > <https://reviews.apache.org/r/20034/diff/1/?file=549059#file549059line260> > > > > can we just record it here instead of where it's registered. It's a bit > > confusing to read the code now
Since we need to traverse over all threads and compute their metrics, we cannot really record it just in on thread. - Guozhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20034/#review39590 ----------------------------------------------------------- On April 4, 2014, 5:44 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20034/ > ----------------------------------------------------------- > > (Updated April 4, 2014, 5:44 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1353 > https://issues.apache.org/jira/browse/KAFKA-1353 > > > Repository: kafka > > > Description > ------- > > KAFKA-1353.v1 > > > Diffs > ----- > > core/src/main/scala/kafka/network/RequestChannel.scala > a6ec970d72fc8adc56bc6e200d1ff5bbf0d2b748 > core/src/main/scala/kafka/network/SocketServer.scala > dcfca3f4156957b0006ba9bfdeca848c115825a8 > core/src/main/scala/kafka/server/KafkaRequestHandler.scala > 871212bf9110ca95ca7d2109be070f69d0f90247 > > Diff: https://reviews.apache.org/r/20034/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
