----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20038/#review39587 -----------------------------------------------------------
core/src/main/scala/kafka/controller/ControllerChannelManager.scala <https://reviews.apache.org/r/20038/#comment72017> Can this be renamed to something like updateMetadataRequestMap? core/src/main/scala/kafka/controller/ControllerChannelManager.scala <https://reviews.apache.org/r/20038/#comment72016> There can be overlap in these 2 lists of partitions when large number of topics are being deleted. So instead of potentially updating the overlapping partitions twice, can we separate them first and then invoke updateMapFor with the right value for beingDeleted? - Neha Narkhede On April 4, 2014, 6:22 p.m., Joel Koshy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20038/ > ----------------------------------------------------------- > > (Updated April 4, 2014, 6:22 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1355 > https://issues.apache.org/jira/browse/KAFKA-1355 > > > Repository: kafka > > > Description > ------- > > Avoid sending all topic metadata on state changes. > > > Diffs > ----- > > core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala > 03117377e1cb2ad63e4c7740d97ca9a4f20abeeb > core/src/main/scala/kafka/controller/ControllerChannelManager.scala > f17d97603798e803d035f313f0165f11f6d0f2c0 > core/src/main/scala/kafka/controller/KafkaController.scala > fcabd0da201ccd478f5884bcca9b75a8c8ea8373 > core/src/main/scala/kafka/controller/TopicDeletionManager.scala > 09f54acc733d49a9be9a9c6633271c190dea1bf0 > core/src/main/scala/kafka/server/KafkaApis.scala > c068ef69207c351eec413a595f1747c59f8b3983 > > Diff: https://reviews.apache.org/r/20038/diff/ > > > Testing > ------- > > > Thanks, > > Joel Koshy > >
