[GitHub] rdblue commented on a change in pull request #7: Allow custom hadoop properties to be loaded in the Spark data source

rdblue commented on a change in pull request #7: Allow custom hadoop properties to be loaded in the Spark data source URL: https://github.com/apache/incubator-iceberg/pull/7#discussion_r240717374 ## File path: spark/src/main/java/com/netflix/iceberg/spark/source/IcebergSource.java

[GitHub] rdblue commented on a change in pull request #7: Allow custom hadoop properties to be loaded in the Spark data source

rdblue commented on a change in pull request #7: Allow custom hadoop properties to be loaded in the Spark data source URL: https://github.com/apache/incubator-iceberg/pull/7#discussion_r240717846 ## File path: spark/src/main/java/com/netflix/iceberg/spark/source/IcebergSource.java

[GitHub] mccheah commented on a change in pull request #7: Allow custom hadoop properties to be loaded in the Spark data source

mccheah commented on a change in pull request #7: Allow custom hadoop properties to be loaded in the Spark data source URL: https://github.com/apache/incubator-iceberg/pull/7#discussion_r240760798 ## File path: spark/src/main/java/com/netflix/iceberg/spark/source/IcebergSource.java

[GitHub] mccheah commented on issue #45: Lazily submit tasks in ParallelIterable and add cancellation.

mccheah commented on issue #45: Lazily submit tasks in ParallelIterable and add cancellation. URL: https://github.com/apache/incubator-iceberg/pull/45#issuecomment-446334195 Still looking over this, but separately I wonder if we've looked into Java's built in parallel iterators, or [split

[GitHub] rdblue commented on a change in pull request #7: Allow custom hadoop properties to be loaded in the Spark data source

rdblue commented on a change in pull request #7: Allow custom hadoop properties to be loaded in the Spark data source URL: https://github.com/apache/incubator-iceberg/pull/7#discussion_r240763430 ## File path: spark/src/main/java/com/netflix/iceberg/spark/source/IcebergSource.java

[GitHub] rdblue commented on issue #45: Lazily submit tasks in ParallelIterable and add cancellation.

rdblue commented on issue #45: Lazily submit tasks in ParallelIterable and add cancellation. URL: https://github.com/apache/incubator-iceberg/pull/45#issuecomment-446338379 I'm not that impressed with the Spliterator API, and it wouldn't really help here where we want to control when backg

[GitHub] mccheah commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation.

mccheah commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation. URL: https://github.com/apache/incubator-iceberg/pull/45#discussion_r240776853 ## File path: core/src/main/java/com/netflix/iceberg/util/ParallelIterable.java ##

[GitHub] mccheah commented on a change in pull request #7: Allow custom hadoop properties to be loaded in the Spark data source

mccheah commented on a change in pull request #7: Allow custom hadoop properties to be loaded in the Spark data source URL: https://github.com/apache/incubator-iceberg/pull/7#discussion_r240778558 ## File path: spark/src/main/java/com/netflix/iceberg/spark/source/IcebergSource.java

[GitHub] rdblue commented on issue #6: Support customizing the location where data is written in Spark

rdblue commented on issue #6: Support customizing the location where data is written in Spark URL: https://github.com/apache/incubator-iceberg/pull/6#issuecomment-446352792 Merged. Thanks @mccheah! This is an automated messag

[GitHub] rdblue closed pull request #6: Support customizing the location where data is written in Spark

rdblue closed pull request #6: Support customizing the location where data is written in Spark URL: https://github.com/apache/incubator-iceberg/pull/6 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance

[GitHub] mccheah commented on issue #20: Encryption in Data Files

mccheah commented on issue #20: Encryption in Data Files URL: https://github.com/apache/incubator-iceberg/issues/20#issuecomment-446404505 @rdblue @omalley I moved the architecture to https://docs.google.com/document/d/1LptmFB7az2rLnou27QK_KKHgjcA5vKza0dWj4h8fkno/edit?usp=sharing. Please

[GitHub] rdsr commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation.

rdsr commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation. URL: https://github.com/apache/incubator-iceberg/pull/45#discussion_r240885973 ## File path: core/src/main/java/com/netflix/iceberg/util/ParallelIterable.java ## @

[GitHub] rdsr commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation.

rdsr commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation. URL: https://github.com/apache/incubator-iceberg/pull/45#discussion_r240886083 ## File path: core/src/main/java/com/netflix/iceberg/util/ThreadPools.java ## @@ -27

[GitHub] rdsr commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation.

rdsr commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation. URL: https://github.com/apache/incubator-iceberg/pull/45#discussion_r240886393 ## File path: core/src/main/java/com/netflix/iceberg/util/ThreadPools.java ## @@ -27

[GitHub] rdsr commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation.

rdsr commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation. URL: https://github.com/apache/incubator-iceberg/pull/45#discussion_r240886083 ## File path: core/src/main/java/com/netflix/iceberg/util/ThreadPools.java ## @@ -27

[GitHub] rdsr commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation.

rdsr commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation. URL: https://github.com/apache/incubator-iceberg/pull/45#discussion_r240886393 ## File path: core/src/main/java/com/netflix/iceberg/util/ThreadPools.java ## @@ -27

[GitHub] rdsr commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation.

rdsr commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation. URL: https://github.com/apache/incubator-iceberg/pull/45#discussion_r240885973 ## File path: core/src/main/java/com/netflix/iceberg/util/ParallelIterable.java ## @

[GitHub] rdsr commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation.

rdsr commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation. URL: https://github.com/apache/incubator-iceberg/pull/45#discussion_r240901429 ## File path: core/src/main/java/com/netflix/iceberg/util/ParallelIterable.java ## @

[GitHub] mccheah commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation.

mccheah commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation. URL: https://github.com/apache/incubator-iceberg/pull/45#discussion_r241103604 ## File path: core/src/main/java/com/netflix/iceberg/util/ParallelIterable.java ##

[GitHub] rdsr commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation.

rdsr commented on a change in pull request #45: Lazily submit tasks in ParallelIterable and add cancellation. URL: https://github.com/apache/incubator-iceberg/pull/45#discussion_r241119180 ## File path: core/src/main/java/com/netflix/iceberg/util/ParallelIterable.java ## @

[GitHub] rdblue commented on issue #20: Encryption in Data Files

rdblue commented on issue #20: Encryption in Data Files URL: https://github.com/apache/incubator-iceberg/issues/20#issuecomment-446690252 @mccheah, can you also start a thread on the dev list to point out this spec? I think other people will probably be interested that aren't necessarily

[GitHub] rdblue opened a new pull request #48: Fix commit retry with manfiest lists.

rdblue opened a new pull request #48: Fix commit retry with manfiest lists. URL: https://github.com/apache/incubator-iceberg/pull/48 A manifest list is created for every commit attempt. Before this update, the same file was used, which caused retries to fail trying to create the same l

[GitHub] rdblue closed pull request #46: Do not scan manifests with no deletes when expiring snapshots.

rdblue closed pull request #46: Do not scan manifests with no deletes when expiring snapshots. URL: https://github.com/apache/incubator-iceberg/pull/46 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenanc

[GitHub] vinooganesh commented on issue #23: DataFile External Identifier Field

vinooganesh commented on issue #23: DataFile External Identifier Field URL: https://github.com/apache/incubator-iceberg/issues/23#issuecomment-446758457 Hey @rdblue - quickly jumping in here. I think the mentality is that a file path as the sole identifier of a file may not suffice for ev

[GitHub] rdblue commented on issue #23: DataFile External Identifier Field

rdblue commented on issue #23: DataFile External Identifier Field URL: https://github.com/apache/incubator-iceberg/issues/23#issuecomment-446766094 @vinooganesh, I don't really understand the use case. How would you use the identifier? -

[GitHub] rdblue opened a new pull request #49: Fix type handling in Spark and Pig.

rdblue opened a new pull request #49: Fix type handling in Spark and Pig. URL: https://github.com/apache/incubator-iceberg/pull/49 This copies Pig type handling from Spark and fixes a minor bug in Spark with integer logical types that have been promoted to longs. --

[GitHub] groodt commented on issue #46: Do not scan manifests with no deletes when expiring snapshots.

groodt commented on issue #46: Do not scan manifests with no deletes when expiring snapshots. URL: https://github.com/apache/incubator-iceberg/pull/46#issuecomment-446770708 I'm sorry. I really don't wish to be annoying, but I'm getting spammed by something called GitBox f

[GitHub] rdblue commented on issue #46: Do not scan manifests with no deletes when expiring snapshots.

rdblue commented on issue #46: Do not scan manifests with no deletes when expiring snapshots. URL: https://github.com/apache/incubator-iceberg/pull/46#issuecomment-446775717 @groodt, I think we've requested for gitbox notifications to stop going to the dev list, but I'll che

[GitHub] rdblue commented on issue #46: Do not scan manifests with no deletes when expiring snapshots.

rdblue commented on issue #46: Do not scan manifests with no deletes when expiring snapshots. URL: https://github.com/apache/incubator-iceberg/pull/46#issuecomment-446781096 Looks like we had not requested it yet, we had asked a question about it. I've submitted the request: https://issues

[GitHub] rdblue opened a new pull request #50: Use manifest lists by default and fix tests.

rdblue opened a new pull request #50: Use manifest lists by default and fix tests. URL: https://github.com/apache/incubator-iceberg/pull/50 This also fixes tests that were picking up manifest list files because they validated manifests in the metadata directory by looking for all Avro file

[GitHub] danielcweeks commented on issue #49: Fix type handling in Spark and Pig.

danielcweeks commented on issue #49: Fix type handling in Spark and Pig. URL: https://github.com/apache/incubator-iceberg/pull/49#issuecomment-447036149 +1 This is an automated message from the Apache Git Service. To respond t

[GitHub] rdblue closed pull request #49: Fix type handling in Spark and Pig.

rdblue closed pull request #49: Fix type handling in Spark and Pig. URL: https://github.com/apache/incubator-iceberg/pull/49 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pul

[GitHub] vinooganesh commented on issue #23: DataFile External Identifier Field

vinooganesh commented on issue #23: DataFile External Identifier Field URL: https://github.com/apache/incubator-iceberg/issues/23#issuecomment-447057968 So I see 2 uses for this: (1) Identifier shared across files - let's say that I have a bunch of files that make up a RDD that come fro

[GitHub] rdblue opened a new pull request #51: Use manifest lists by default.

rdblue opened a new pull request #51: Use manifest lists by default. URL: https://github.com/apache/incubator-iceberg/pull/51 This also fixes tests that were broken by defaulting to manifest lists because they assumed that the only avro files in the metadata directory were manifests.

[GitHub] rdblue commented on issue #50: Use manifest lists by default and fix tests.

rdblue commented on issue #50: Use manifest lists by default and fix tests. URL: https://github.com/apache/incubator-iceberg/pull/50#issuecomment-447117765 Accidentally duplicated this one in #51. Closing. This is an automated

[GitHub] rdblue commented on issue #51: Use manifest lists by default.

rdblue commented on issue #51: Use manifest lists by default. URL: https://github.com/apache/incubator-iceberg/pull/51#issuecomment-447117967 Test failures are because #48 is missing. This is an automated message from the Apac

[GitHub] rdblue closed pull request #50: Use manifest lists by default and fix tests.

rdblue closed pull request #50: Use manifest lists by default and fix tests. URL: https://github.com/apache/incubator-iceberg/pull/50 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fo

[GitHub] danielcweeks commented on issue #48: Fix commit retry with manfiest lists.

danielcweeks commented on issue #48: Fix commit retry with manfiest lists. URL: https://github.com/apache/incubator-iceberg/pull/48#issuecomment-447118392 +1 This is an automated message from the Apache Git Service. To respond

[GitHub] rdblue closed pull request #48: Fix commit retry with manfiest lists.

rdblue closed pull request #48: Fix commit retry with manfiest lists. URL: https://github.com/apache/incubator-iceberg/pull/48 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign p

[GitHub] rdblue commented on issue #28: Apply baseline checkstyle for iceberg-api only

rdblue commented on issue #28: Apply baseline checkstyle for iceberg-api only URL: https://github.com/apache/incubator-iceberg/pull/28#issuecomment-447124528 I think we should get this in, but I'd like to try to do it when we move from com.netflix packages to org.apache. That is going to to

[GitHub] mccheah opened a new pull request #52: Use the FileIO submodule in Spark writers and readers.

mccheah opened a new pull request #52: Use the FileIO submodule in Spark writers and readers. URL: https://github.com/apache/incubator-iceberg/pull/52 Tricky because the table operations needs to be exposed. Added a mixed interface of Table + TableOperations accordingly. Therefore now the

[GitHub] mccheah commented on a change in pull request #52: Use the FileIO submodule in Spark writers and readers.

mccheah commented on a change in pull request #52: Use the FileIO submodule in Spark writers and readers. URL: https://github.com/apache/incubator-iceberg/pull/52#discussion_r241580782 ## File path: spark/src/main/java/com/netflix/iceberg/spark/source/IcebergSource.java ##

[GitHub] rdblue commented on a change in pull request #52: Use the FileIO submodule in Spark writers and readers.

rdblue commented on a change in pull request #52: Use the FileIO submodule in Spark writers and readers. URL: https://github.com/apache/incubator-iceberg/pull/52#discussion_r241587801 ## File path: spark/src/main/java/com/netflix/iceberg/spark/source/IcebergSource.java ##

[GitHub] mccheah commented on a change in pull request #52: Use the FileIO submodule in Spark writers and readers.

mccheah commented on a change in pull request #52: Use the FileIO submodule in Spark writers and readers. URL: https://github.com/apache/incubator-iceberg/pull/52#discussion_r241604276 ## File path: spark/src/main/java/com/netflix/iceberg/spark/source/IcebergSource.java ##

[GitHub] mccheah commented on a change in pull request #52: Use the FileIO submodule in Spark writers and readers.

mccheah commented on a change in pull request #52: Use the FileIO submodule in Spark writers and readers. URL: https://github.com/apache/incubator-iceberg/pull/52#discussion_r241606297 ## File path: api/src/main/java/com/netflix/iceberg/Table.java ## @@ -171,4 +172,10 @@ d

[GitHub] [iceberg-docs] samredai opened a new pull request #1: First version of hugo doc site

samredai opened a new pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1 This is the hugo docs-site shared on the dev mailing list and in [apache/iceberg/issues/3616](https://github.com/apache/iceberg/issues/3616). It includes a github workflow that builds and pushes the s

[GitHub] [iceberg-docs] samredai commented on pull request #1: First version of hugo doc site

samredai commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-986105830 @rdblue @jackye1995 @kbendick @ajantha-bhat @RussellSpitzer @ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [iceberg-docs] samredai edited a comment on pull request #1: First version of hugo doc site

samredai edited a comment on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-986105830 @rdblue @jackye1995 @kbendick @ajantha-bhat @RussellSpitzer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [iceberg-docs] jackye1995 commented on pull request #1: First version of hugo doc site

jackye1995 commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-986153886 There are over 3600 files, what are the important files to look into? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [iceberg-docs] rdblue commented on pull request #1: First version of hugo doc site

rdblue commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-986315139 Yeah, could you break this into smaller commits that we can look at? Why is this almost 3,700 files? -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [iceberg-docs] samredai commented on pull request #1: First version of hugo doc site

samredai commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-986319585 Ah, my bad that's from two things: - Didn't realize I included all of the javadocs, (which accounts for 3,310 files) - I included the theme repo in this actual repo but

[GitHub] [iceberg-docs] rdblue commented on pull request #1: First version of hugo doc site

rdblue commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-986321968 Makes sense! Let's remove whatever we can and then follow up with Javadocs in a separate commit for each version once we have the basics. That should let us review it much more ea

[GitHub] [iceberg-docs] samredai commented on pull request #1: First version of hugo doc site

samredai commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-986415495 Updated to not include the javadocs and also to include the theme as a submodule. An overview of the important directories/files. - `content/docs` directory includes all o

[GitHub] [iceberg-docs] jackye1995 commented on a change in pull request #1: First version of hugo doc site

jackye1995 commented on a change in pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#discussion_r762692930 ## File path: .github/workflows/deploy.yml ## @@ -0,0 +1,52 @@ +name: github pages + +on: [push, pull_request] + +jobs: + deploy: +runs-on: ubuntu-

[GitHub] [iceberg-docs] rdblue commented on a change in pull request #1: First version of hugo doc site

rdblue commented on a change in pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#discussion_r763192839 ## File path: README.md ## @@ -1,3 +1,19 @@ -## Iceberg Docs +# Apache Iceberg Documentation Site -This repository contains the markdown documentation hos

[GitHub] [iceberg-docs] rdblue commented on a change in pull request #1: First version of hugo doc site

rdblue commented on a change in pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#discussion_r763195072 ## File path: asciinema/schema_evolution.py ## @@ -0,0 +1,53 @@ +from generate_asciinema_cast import Cast + +sequence = [ +( +"ALTER TABLE taxis

[GitHub] [iceberg-docs] rdblue commented on a change in pull request #1: First version of hugo doc site

rdblue commented on a change in pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#discussion_r763195862 ## File path: config.toml ## @@ -0,0 +1,24 @@ +baseURL = "" # This is populated by the github deploy workflow and is equal to "/" +languageCode = "en-us"

[GitHub] [iceberg-docs] rdblue commented on a change in pull request #1: First version of hugo doc site

rdblue commented on a change in pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#discussion_r763196285 ## File path: content/about/about.md ## @@ -0,0 +1,9 @@ +--- +Title: What is Iceberg? +Draft: false +--- + +Iceberg adds tables to compute engines including

[GitHub] [iceberg-docs] samredai commented on a change in pull request #1: First version of hugo doc site

samredai commented on a change in pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#discussion_r763652648 ## File path: .github/workflows/deploy.yml ## @@ -0,0 +1,52 @@ +name: github pages + +on: [push, pull_request] + +jobs: + deploy: +runs-on: ubuntu-20

[GitHub] [iceberg-docs] samredai commented on a change in pull request #1: First version of hugo doc site

samredai commented on a change in pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#discussion_r763652888 ## File path: README.md ## @@ -1,3 +1,19 @@ -## Iceberg Docs +# Apache Iceberg Documentation Site -This repository contains the markdown documentation h

[GitHub] [iceberg-docs] samredai commented on a change in pull request #1: First version of hugo doc site

samredai commented on a change in pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#discussion_r763656608 ## File path: config.toml ## @@ -0,0 +1,24 @@ +baseURL = "" # This is populated by the github deploy workflow and is equal to "/" +languageCode = "en-us

[GitHub] [iceberg-docs] samredai commented on a change in pull request #1: First version of hugo doc site

samredai commented on a change in pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#discussion_r763658510 ## File path: config.toml ## @@ -0,0 +1,24 @@ +baseURL = "" # This is populated by the github deploy workflow and is equal to "/" +languageCode = "en-us

[GitHub] [iceberg-docs] samredai commented on a change in pull request #1: First version of hugo doc site

samredai commented on a change in pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#discussion_r763658651 ## File path: content/about/about.md ## @@ -0,0 +1,9 @@ +--- +Title: What is Iceberg? +Draft: false +--- + +Iceberg adds tables to compute engines includi

[GitHub] [iceberg-docs] samredai commented on pull request #1: First version of hugo doc site

samredai commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-987600519 > It looks like the Apache 2.0 license header is missing for some README and script files, please check and add, thanks! > > For Python script, it seems like indentation i

[GitHub] [iceberg-docs] kbendick commented on pull request #1: First version of hugo doc site

kbendick commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-987616428 > Thinking about this now, we could probably get rid of the main branch here and set next as the default branch for the repo, or alternatively we can have some "if main then nex

[GitHub] [iceberg-docs] jackye1995 commented on pull request #1: First version of hugo doc site

jackye1995 commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-988424006 How are we going to move forward with this PR? If we move to the `next` branch, is this PR for the `main` branch still needed? -- This is an automated message from the Apach

[GitHub] [iceberg-docs] samredai commented on pull request #1: First version of hugo doc site

samredai commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-989259177 > How are we going to move forward with this PR? If we move to the `next` branch, is this PR for the `main` branch still needed? If a `next` branch is created I can re-ope

[GitHub] [iceberg-docs] rdblue commented on a change in pull request #1: First version of hugo doc site

rdblue commented on a change in pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#discussion_r765314353 ## File path: config.toml ## @@ -0,0 +1,24 @@ +baseURL = "" # This is populated by the github deploy workflow and is equal to "/" +languageCode = "en-us"

[GitHub] [iceberg-docs] rdblue commented on a change in pull request #1: First version of hugo doc site

rdblue commented on a change in pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#discussion_r765318054 ## File path: config.toml ## @@ -0,0 +1,24 @@ +baseURL = "" # This is populated by the github deploy workflow and is equal to "/" +languageCode = "en-us"

[GitHub] [iceberg-docs] rdblue commented on a change in pull request #1: First version of hugo doc site

rdblue commented on a change in pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#discussion_r765318518 ## File path: content/docs/_index.md ## @@ -0,0 +1,54 @@ +--- +title: Introduction +type: docs +--- + + + + +**Apache Ice

[GitHub] [iceberg-docs] rdblue commented on pull request #1: First version of hugo doc site

rdblue commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-989309666 It looks like this isn't quite ready to merge. Most of the text links on pages are broken and the nav menu is really huge. Nav links go to paths like `/spark-ddl/` but I think we

[GitHub] [iceberg-docs] rdblue commented on pull request #1: First version of hugo doc site

rdblue commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-989311369 For the conversation about a `next` branch: * I don't see much value in having docs for the upcoming release. Maybe it's just me, but I'd not prioritize this very highly. * I

[GitHub] [iceberg-docs] jackye1995 commented on pull request #1: First version of hugo doc site

jackye1995 commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-989319785 > I'd focus on getting just 0.12.1 done. We can add more versions later Yeah I was just gonna ask about that, I thought we are going to first create those doc branches f

[GitHub] [iceberg-docs] rdblue commented on pull request #1: First version of hugo doc site

rdblue commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-989323751 Yeah, that sounds reasonable to me. I still question whether we even want to have `next`. In any case, there's still a lot of work to do here to make sure we have everything the w

[GitHub] [iceberg-docs] jackye1995 commented on pull request #1: First version of hugo doc site

jackye1995 commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-989324679 yes, `next` is really good-to-have stuff, I saw it in a few other Apache websites that's why I brought it up, but if it's too much effort for community to maintain then we can

[GitHub] [iceberg-docs] samredai opened a new pull request #2: Landing-Page Site and Versioned Docs Site

samredai opened a new pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2 This addresses 3 main issues raised in #1. - Broken Links - All links have been fixed and verified with https://github.com/filiph/linkcheck - Split the landing page and the docs site wit

[GitHub] [iceberg-docs] samredai commented on pull request #1: First version of hugo doc site

samredai commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-992183368 Closing this and continuing in #2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [iceberg-docs] samredai closed pull request #1: First version of hugo doc site

samredai closed pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [iceberg-docs] rdblue commented on pull request #2: Landing-Page Site and Versioned Docs Site

rdblue commented on pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2#issuecomment-994162460 Here are a few notes from clicking around: * Is the final path going to be `iceberg.apache.org/iceberg-docs`? Why not make the landing page at the root level? * In the previe

[GitHub] [iceberg-docs] rdblue edited a comment on pull request #2: Landing-Page Site and Versioned Docs Site

rdblue edited a comment on pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2#issuecomment-994162460 Here are a few notes from clicking around: * Is the final path going to be `iceberg.apache.org/iceberg-docs`? Why not make the landing page at the root level? * In the

[GitHub] [iceberg-docs] rdblue edited a comment on pull request #2: Landing-Page Site and Versioned Docs Site

rdblue edited a comment on pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2#issuecomment-994162460 Here are a few notes from clicking around: * Is the final path going to be `iceberg.apache.org/iceberg-docs`? Why not make the landing page at the root level? * In the

[GitHub] [iceberg-docs] rdblue edited a comment on pull request #2: Landing-Page Site and Versioned Docs Site

rdblue edited a comment on pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2#issuecomment-994162460 Here are a few notes from clicking around: * Is the final path going to be `iceberg.apache.org/iceberg-docs`? Why not make the landing page at the root level? * In the

[GitHub] [iceberg-docs] rdblue edited a comment on pull request #2: Landing-Page Site and Versioned Docs Site

rdblue edited a comment on pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2#issuecomment-994162460 Here are a few notes from clicking around: * Is the final path going to be `iceberg.apache.org/iceberg-docs`? Why not make the landing page at the root level? * In the

[GitHub] [iceberg-docs] rdblue edited a comment on pull request #2: Landing-Page Site and Versioned Docs Site

rdblue edited a comment on pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2#issuecomment-994162460 Here are a few notes from clicking around: * Is the final path going to be `iceberg.apache.org/iceberg-docs`? Why not make the landing page at the root level? * In the

[GitHub] [iceberg-docs] jackye1995 commented on pull request #2: Landing-Page Site and Versioned Docs Site

jackye1995 commented on pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2#issuecomment-994422440 Also tried the website, thanks for continuing the work! It seems like some links are still broken as Ryan points out. I have some additional nitpicking: 1. Github

[GitHub] [iceberg-docs] samredai commented on pull request #2: Landing-Page Site and Versioned Docs Site

samredai commented on pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2#issuecomment-997086542 Thanks for all the feedback! Here's an updated demo site to show all the fixes: https://iceberg.redai.dev/ @rdblue Is the final path going to be iceberg.apache.org/ice

[GitHub] [iceberg-docs] samredai edited a comment on pull request #2: Landing-Page Site and Versioned Docs Site

samredai edited a comment on pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2#issuecomment-997086542 Thanks for all the feedback! Here's an updated demo site to show all the fixes: https://iceberg.redai.dev/ @rdblue Is the final path going to be iceberg.apache.

[GitHub] [iceberg-docs] rdblue commented on pull request #2: Landing-Page Site and Versioned Docs Site

rdblue commented on pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2#issuecomment-997489501 Thanks, @samredai! The site looks much better. Before, we talked about having some pages that are not versioned and have just one copy throughout. Things like the Releases p

[GitHub] [iceberg-docs] samredai commented on pull request #2: Landing-Page Site and Versioned Docs Site

samredai commented on pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2#issuecomment-998133549 Done! Here's what I came up with: - Moved all of the common pages to `docs/commons`. This includes the Community, Releases, and Format sections but let me know if there's any

[GitHub] [iceberg-docs] jackye1995 commented on pull request #2: Landing-Page Site and Versioned Docs Site

jackye1995 commented on pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2#issuecomment-998987824 @rdblue yes I totally agree we can move forward and make incremental progress on this, that also makes the review much easier with more specific changes to look at. -- This

[GitHub] [iceberg-docs] kbendick commented on a change in pull request #2: Landing-Page Site and Versioned Docs Site

kbendick commented on a change in pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2#discussion_r773448184 ## File path: .github/workflows/deploy.yml ## @@ -0,0 +1,98 @@ +name: github pages + +on: [push, pull_request] + +jobs: + deploy-landing-page: +if: g

[GitHub] [iceberg-docs] rdblue commented on pull request #2: Landing-Page Site and Versioned Docs Site

rdblue commented on pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2#issuecomment-999187098 @samredai, if I understand the workflow correctly, it sounds like you're making extra copies of the common pages, one in each set of docs? I think that still has a problem b

[GitHub] [iceberg-docs] samredai commented on pull request #2: Landing-Page Site and Versioned Docs Site

samredai commented on pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2#issuecomment-999728798 @rdblue Yes you're understanding is correct. That's a good point, updating the common pages would still require redeploying the previous sites (even though the same document is

[GitHub] [iceberg-docs] samredai opened a new pull request #3: Add .asf.yaml file with notification settings

samredai opened a new pull request #3: URL: https://github.com/apache/iceberg-docs/pull/3 This adds an .asf.yaml file with notification settings to send commit notifications to comm...@iceberg.apache.org and issue/pr notifications to iss...@iceberg.apache.org. -- This is an automated me

[GitHub] [iceberg-docs] rdblue commented on a change in pull request #3: Add .asf.yaml file with notification settings

rdblue commented on a change in pull request #3: URL: https://github.com/apache/iceberg-docs/pull/3#discussion_r777680979 ## File path: .asf.yaml ## @@ -0,0 +1,34 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [iceberg-docs] rdblue commented on a change in pull request #3: Add .asf.yaml file with notification settings

rdblue commented on a change in pull request #3: URL: https://github.com/apache/iceberg-docs/pull/3#discussion_r777681084 ## File path: .asf.yaml ## @@ -0,0 +1,34 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [iceberg-docs] samredai commented on a change in pull request #3: Add .asf.yaml file with notification settings

samredai commented on a change in pull request #3: URL: https://github.com/apache/iceberg-docs/pull/3#discussion_r17386 ## File path: .asf.yaml ## @@ -0,0 +1,34 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. S

[GitHub] [iceberg-docs] samredai commented on a change in pull request #3: Add .asf.yaml file with notification settings

samredai commented on a change in pull request #3: URL: https://github.com/apache/iceberg-docs/pull/3#discussion_r17576 ## File path: .asf.yaml ## @@ -0,0 +1,34 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. S

[GitHub] [iceberg-docs] rdblue commented on pull request #3: Add .asf.yaml file with notification settings

rdblue commented on pull request #3: URL: https://github.com/apache/iceberg-docs/pull/3#issuecomment-1004398533 I merged this using the CLI since I didn't see that I could squash and merge in the dropdown. We'll have to figure out how to remove merge commits as an option. Thanks, @s

[GitHub] [iceberg-docs] samredai closed pull request #3: Add .asf.yaml file with notification settings

samredai closed pull request #3: URL: https://github.com/apache/iceberg-docs/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

  1   2   3   4   5   >