samredai commented on pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2#issuecomment-997086542
Thanks for all the feedback! Here's an updated demo site to show all the fixes: https://iceberg.redai.dev/ @rdblue Is the final path going to be iceberg.apache.org/iceberg-docs? Why not make the landing page at the root level? - No there won't be any "/iceberg-docs". This is mainly because I'm using the stock personal gh-pages without a custom domain so it appends the repo name. I had a domain lying around that just plugged into this demo (once it's merged we'll be able to do "dev" deployments of the site to something like "/unstable"). So now the demo urls will match how the site will look, besides the domain of course. (see https://iceberg.redai.dev/) In the preview, the "Learn More" link is broken. It points to https://samredai.github.io/docs instead of https://samredai.github.io/iceberg-docs/docs/, which is where the docs link takes you. - This is slightly related to the previous item and is also fixed. Since we also have a new front page, what about having the Docs link send you to a Getting Started page? - I like it! I changed Learn More to link to the spark getting-started page (we can update this as we add more getting started material) Clicking on "Tables" in the docs left nav is an empty page. Maybe we can make that a set of links to learn more about general table topics? - Removed the empty link, and that's a great idea. When we add the new set of getting started material I'll re-link this section titles. Same with Integrations, API, and Format. The text is a link, but there's no page there. - Fixed by removing the link Under releases, should we include "latest"? - I was overthinking this a bit and removed latest because it's a clone of the 0.12.1 site. Thinking about it now it actually makes sense to keep them as two different sites so I updated this. Also included a link to the "Release Notes" page as an item instead of linking the section title which wasn't obvious. The About page is odd and just links to other pages - Fixed when changing the left nav to collapsible sections at the bottom Looks like the ASF and About nav pages are there because we've removed the subpages from the nav. Is it possible to make those collapsible? - Fixed, these are now collapsible It's hard to find the pages under About. Those pages are important, like Blogs, Talks, Community, Releases, etc. - These are now included in the left nav What does search do? When I search for something like write.format.default, there isn't much context, only a list of pages that look unrelated. The pages also show up in the nav and push everything down. - Wow...thanks for pointing this out! I looked into this and it turns out this theme is using [flexsearch](https://github.com/nextapps-de/flexsearch) which is a pretty advanced full-text search library with some scoring algorithm that's doing way too much to predict relevance (and clearly missing the mark). Hugo already provides a way to generate a search index using the templates functionality (see `search-data.json`). I replaced all of the flexsearch code with a simple lookup of the search box's value to the content and a few lines of javascript to show a preview of where the match is and to link to the page. It looks to be working well and it lets us remove the flexsearch dependency. Clicking the Iceberg logo in the upper left in /docs brings you back to the docs splash page, not the Iceberg splash site. - Fixed! The splash site uses "Mailing lists" instead of "Community". Could you link to the community page instead? - Fixed! Github and Slack buttons should open in a new page instead of loading in the current page. - Fixed! On the splash page, I think we should add links to the features that are highlighted. We should also consider what to put here. The 3 listed don't seem compelling enough. - Great idea, I'll add this as I work on a more compelling feature set to display @jackye1995 for the issue that there is no link for those top level tabs like "Integration", I think we can just disable the link? Because the 2 that has link (Spark and Flink) are all linking to the getting started page, I think we can make them just a new sub-tab called Getting started and disable all top level tab links. - Done! Collapsing the lower sections freed up a lot of space to add this in it's on line. Once I am in the doc page, I cannot go back to the landing page anymore, can we at least have a way to go back? - Fixed this by changing the Iceberg logo to return to the splash page like @rdblue suggested the time travel script is setting a table property to perform time-travel, can we use the latest time travel syntax AS OF? - Will do! What's the Spark and Iceberg versions that support this? Wondering if we need to note that. also agree that feature list is not full, we can think about the list of features together - Sounds good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
