samredai opened a new pull request #2:
URL: https://github.com/apache/iceberg-docs/pull/2
This addresses 3 main issues raised in #1.
- Broken Links
- All links have been fixed and verified with
https://github.com/filiph/linkcheck
- Split the landing page and the docs site with only the docs site versioned
- The deployment workflow has two jobs, `deploy-landing-page` and
`deploy-docs`
- Commits to `main` deploys **only** the single landing page
- Commits to any non-`main` branch deploys **only** a docs site version
(explained in the README)
- Too many items in the navbar
- The navbar has been shortened by hidding some pages and making them
available in consolidated single pages with a list of links. See the `About`
and `ASF` sections.
- This is completely flexible and so any pages can be exposed in any of
the following 3 places
1. Landing Page
2. Left Navbar
3. Within a Page View
- (Let me know if any item in one of these places feels like it should
be in another place)
I have all of this running in my fork at
https://samredai.github.io/iceberg-docs
To check for broken links I ran these commands:
```
docker run --rm tennox/linkcheck https://samredai.github.io/iceberg-docs >
landing-page-linkcheck.txt
```
```
docker run --rm tennox/linkcheck
https://samredai.github.io/iceberg-docs/docs/0.12.1 >
0.12.1-docsite-linkcheck.txt
```
```
docker run --rm tennox/linkcheck
https://samredai.github.io/iceberg-docs/docs/0.12.0 >
0.12.0-docsite-linkcheck.txt
```
There are a number of broken links that show up but they're all links to the
javadocs (cat command into `grep -v 'javadoc'` filters out all of the broken
links detected). Once we add the javadocs I can address those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
