jackye1995 commented on a change in pull request #1:
URL: https://github.com/apache/iceberg-docs/pull/1#discussion_r762692930
##########
File path: .github/workflows/deploy.yml
##########
@@ -0,0 +1,52 @@
+name: github pages
+
+on: [push, pull_request]
+
+jobs:
+ deploy:
+ runs-on: ubuntu-20.04
+ steps:
+ - uses: actions/checkout@v2
+
+ - name: Set output
+ id: vars
+ run: echo ::set-output name=branch_name::${GITHUB_REF#refs/*/}
+
+ - name: Set baseURL in config.toml
+ uses: ciiiii/toml-editor@1.0.0
+ with:
+ file: "config.toml"
+ key: "baseURL"
+ value: "https://samredai.github.io/iceberg-docs-prototype/${{
steps.vars.outputs.branch_name }}"
Review comment:
needs to be updated?
##########
File path: README.md
##########
@@ -1,3 +1,19 @@
-## Iceberg Docs
+# Apache Iceberg Documentation Site
-This repository contains the markdown documentation hosted at
https://iceberg.apache.org.
+This repository contains the documentation for [Apache
Iceberg](https://github.com/apache/iceberg).
+It's built with [Hugo](https://gohugo.io/) and hosted on GitHub pages.
Review comment:
hosted at https://iceberg.apache.org ?
##########
File path: config.toml
##########
@@ -0,0 +1,24 @@
+baseURL = "" # This is populated by the github deploy workflow and is equal
to "<domainName>/<version|latest>"
+languageCode = "en-us"
+title = "Apache Iceberg"
+theme= "hugo-book"
+
+[params]
+ BookLogo = "img/iceberg-logo-icon.png"
+ description = "The open table format for analytic datasets."
+ versions.iceberg = "" # This is populated by the github deploy workflow and
is equal to the branch name
+ versions.nessie = "0.15.1"
+ latestVersions.iceberg = "0.12.1" # This is used for the version badge on
the "latest" site version
+
+[[params.social]]
+ title = "devlist"
Review comment:
indentation seems off here?
##########
File path: asciinema/schema_evolution.py
##########
@@ -0,0 +1,53 @@
+from generate_asciinema_cast import Cast
+
+sequence = [
+ (
+ "ALTER TABLE taxis ADD COLUMN fare_per_distance_unit float AFTER
trip_distance;",
+ "Time taken: 0.671 seconds",
+ ),
+ (
+ "DESCRIBE TABLE nyc.taxis;",
+ """VendorID string
+tpep_pickup_datetime string
Review comment:
indentation seems off here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
