Re: [ANNOUNCE] New PMC Member : John Pullokkaran

2015-11-24 Thread Navis Ryu
Congratulations! 2015년 11월 25일 수요일, Hari Sivarama Subramaniyan님이 작성한 메시지: > Congrats, John! > -- > *From:* Eugene Koifman > > *Sent:* Tuesday, November 24, 2015 3:14 PM > *To:* u...@hive.apache.org > ; > dev@hive.apache.org > *Subject:* Re: [ANNOUNCE] New PMC Member

Re: [ANNOUNCE] New Hive Committer - Siddharth Seth

2015-10-22 Thread Navis Ryu
Congratulations! 2015-10-22 16:49 GMT+09:00 Chinna Rao Lalam : > Congratulations! > > On Thu, Oct 22, 2015 at 12:18 PM, Santlal J Gupta < > santlal.gu...@bitwiseglobal.com> wrote: > >> Congratulations !! >> >> -Original Message- >> From: Chetna C [mailto:chetna@gmail.com] >> Sent: Thur

Re: [ANNOUNCE] New Hive Committer- Aihua Xu

2015-10-22 Thread Navis Ryu
Congratulations! 2015-10-22 16:48 GMT+09:00 Chinna Rao Lalam : > Congrats Aihua! > > On Thu, Oct 22, 2015 at 10:45 AM, Vaibhav Gumashta < > vgumas...@hortonworks.com> wrote: > >> Congrats Aihua! >> >> ‹Vaibhav >> >> On 10/21/15, 4:42 PM, "Pengcheng Xiong" wrote: >> >> >Congrats Aihua! >> > >> >On

Re: Review Request 38292: HIVE-11768 java.io.DeleteOnExitHook leaks memory on long running Hive Server2 Instances

2015-10-14 Thread Navis Ryu
op/hive/ql/session/SessionState.java 92ac209 service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java 1d1e995 service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 175348b Diff: https://reviews.apache.org/r/38292/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 38292: HIVE-11768 java.io.DeleteOnExitHook leaks memory on long running Hive Server2 Instances

2015-10-13 Thread Navis Ryu
ive/ql/session/SessionState.java 41b4bb1 service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java 1d1e995 service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 175348b Diff: https://reviews.apache.org/r/38292/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 38292: HIVE-11768 java.io.DeleteOnExitHook leaks memory on long running Hive Server2 Instances

2015-10-13 Thread Navis Ryu
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38292/#review102537 ------- On 10 13, 2015, 1:19 오전, Navis Ryu wrote: > >

Re: Review Request 37347: HIVE-11518 Provide interface to adjust required resource for tez tasks

2015-10-12 Thread Navis Ryu
pache/hadoop/hive/ql/exec/tez/SimpleCalculator.java PRE-CREATION Diff: https://reviews.apache.org/r/37347/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 39253: SemanticAnalysis of "a=1" can result in a new Configuration() object

2015-10-12 Thread Navis Ryu
253/diff/ Testing --- Thanks, Navis Ryu

Review Request 39253: SemanticAnalysis of "a=1" can result in a new Configuration() object

2015-10-12 Thread Navis Ryu
g/apache/hadoop/hive/ql/udf/ptf/TableFunctionResolver.java 71034d7 Diff: https://reviews.apache.org/r/39253/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 38292: HIVE-11768 java.io.DeleteOnExitHook leaks memory on long running Hive Server2 Instances

2015-10-12 Thread Navis Ryu
iff: https://reviews.apache.org/r/38292/diff/ Testing --- Thanks, Navis Ryu

Re: [ANNOUNCE] New Hive PMC Chair - Ashutosh Chauhan

2015-09-16 Thread Navis Ryu
Congratulations! 2015-09-17 9:35 GMT+09:00 Xu, Cheng A : > Congratulations, Ashutosh! > > -Original Message- > From: Mohammad Islam [mailto:misla...@yahoo.com.INVALID] > Sent: Thursday, September 17, 2015 8:23 AM > To: u...@hive.apache.org; Hive > Subject: Re: [ANNOUNCE] New Hive PMC Chair

Review Request 38292: HIVE-11768 java.io.DeleteOnExitHook leaks memory on long running Hive Server2 Instances

2015-09-10 Thread Navis Ryu
Testing --- Thanks, Navis Ryu

Re: Review Request 38290: HIVE-11774 Show macro definition for desc function

2015-09-10 Thread Navis Ryu
Diff: https://reviews.apache.org/r/38290/diff/ Testing --- Thanks, Navis Ryu

Review Request 38290: Show macro definition for desc function

2015-09-10 Thread Navis Ryu
/hadoop/hive/ql/udf/generic/TestGenericUDFMacro.java 8bbaa6b ql/src/test/queries/clientpositive/macro.q 47b05ff ql/src/test/results/clientpositive/macro.q.out 76ea250 Diff: https://reviews.apache.org/r/38290/diff/ Testing --- Thanks, Navis Ryu

Review Request 38206: HIVE-11662 Dynamic partitioning cannot be applied to external table which contains part-spec like directory name

2015-09-08 Thread Navis Ryu
/clientpositive/dynamic_partition_insert_external.q.out PRE-CREATION Diff: https://reviews.apache.org/r/38206/diff/ Testing --- Thanks, Navis Ryu

Review Request 37986: Implement "show create database"

2015-08-31 Thread Navis Ryu
reate_database.q.out PRE-CREATION Diff: https://reviews.apache.org/r/37986/diff/ Testing --- Thanks, Navis Ryu

Review Request 37347: HIVE-11518 Provide interface to adjust required resource for tez tasks

2015-08-11 Thread Navis Ryu
https://reviews.apache.org/r/37347/diff/ Testing --- Thanks, Navis Ryu

Review Request 37333: HIVE-11515 Still some possible race condition in DynamicPartitionPruner

2015-08-10 Thread Navis Ryu
() is called. Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicPartitionPruner.java 7abd94d Diff: https://reviews.apache.org/r/37333/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 37287: HIVE-11506 Casting varchar/char type to string cannot be vectorized

2015-08-10 Thread Navis Ryu
join1.q.out 744bfb3 ql/src/test/results/clientpositive/vector_varchar_mapjoin1.q.out 2994bff ql/src/test/results/clientpositive/vectorized_casts.q.out 1113453 Diff: https://reviews.apache.org/r/37287/diff/ Testing --- Thanks, Navis Ryu

Review Request 37287: HIVE-11506 Casting varchar/char type to string cannot be vectorized

2015-08-10 Thread Navis Ryu
d07b1 ql/src/test/results/clientpositive/vectorized_casts.q.out 1113453 Diff: https://reviews.apache.org/r/37287/diff/ Testing --- Thanks, Navis Ryu

Review Request 31335: Correlating expression cannot contain unqualified column references

2015-02-23 Thread Navis Ryu
expr.q PRE-CREATION ql/src/test/results/clientnegative/subquery_unqual_corr_expr.q.out f69a538 ql/src/test/results/clientpositive/subquery_unqual_corr_expr.q.out PRE-CREATION Diff: https://reviews.apache.org/r/31335/diff/ Testing --- Thanks, Navis Ryu

Review Request 31079: Extend PTFs to provide referenced columns for CP

2015-02-16 Thread Navis Ryu
/results/clientpositive/spark/ptf_matchpath.q.out 22c8af3 ql/src/test/results/clientpositive/tez/ptf_matchpath.q.out fc2b034 Diff: https://reviews.apache.org/r/31079/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 29196: Add some explain to PTF operator

2015-02-12 Thread Navis Ryu
/vectorized_ptf.q.out 6bd98b7 ql/src/test/results/clientpositive/windowing_streaming.q.out d45646a Diff: https://reviews.apache.org/r/29196/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2015-02-11 Thread Navis Ryu
- On Feb. 9, 2015, 6:56 p.m., Jason Dere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26854/ > ------- >

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2015-02-11 Thread Navis Ryu
d e-mail. To reply, visit: > https://reviews.apache.org/r/26854/ > --- > > (Updated Feb. 9, 2015, 6:56 p.m.) > > > Review request for hive, Navis Ryu and Thejas Nair. > > > Bugs: HIVE-2573 > https://issues.apache

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2015-02-09 Thread Navis Ryu
To reply, visit: > https://reviews.apache.org/r/26854/ > --- > > (Updated Feb. 9, 2015, 6:56 p.m.) > > > Review request for hive, Navis Ryu and Thejas Nair. > > > Bugs: HIVE-2573 > https://issues.apache.org/jira/browse/HIVE-2573 > &g

Review Request 30783: JDBC should provide metadata for columns whether a column is a partition column or not

2015-02-08 Thread Navis Ryu
getBoolean("IS_PARTITION_COLUMN"); {code} It's not JDBC standard column but seemed to be useful. Diffs - service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java 92ea7b0 Diff: https://reviews.apache.org/r/30783/diff/ Testing --- Thanks, Navis Ryu

Review Request 30782: Window clause ROW BETWEEN for PRECEDING does not work

2015-02-08 Thread Navis Ryu
/clientpositive/windowing_windowspec.q.out 00af6b8 Diff: https://reviews.apache.org/r/30782/diff/ Testing --- Thanks, Navis Ryu

Review Request 30780: Use session classloader instead of application loader

2015-02-08 Thread Navis Ryu
orMR.java d3ad515 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect.java 89496ea Diff: https://reviews.apache.org/r/30780/diff/ Testing --- Thanks, Navis Ryu

Review Request 30779: hive.limit.query.max.table.partition makes queries fail on non-partitioned tables

2015-02-08 Thread Navis Ryu
/apache/hadoop/hive/ql/parse/ParseContext.java 6c1ab07 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 2466d78 Diff: https://reviews.apache.org/r/30779/diff/ Testing --- Thanks, Navis Ryu

Review Request 30778: NPE for invalid union all

2015-02-08 Thread Navis Ryu
ion3.q ce65747 ql/src/test/queries/clientpositive/union35.q PRE-CREATION ql/src/test/results/clientnegative/union3.q.out de1c62b ql/src/test/results/clientpositive/union35.q.out PRE-CREATION Diff: https://reviews.apache.org/r/30778/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2015-02-08 Thread Navis Ryu
e: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26854/ > --- > > (Updated Nov. 13, 2014, 10:15 p.m.) > > > Review requ

Re: Review Request 30602: HIVE-6099

2015-02-04 Thread Navis Ryu
gt; not-not-isDistinct.. how about replace it with isDistinct - Navis Ryu On Feb. 4, 2015, 9:16 p.m., Ashutosh Chauhan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 30602: HIVE-6099

2015-02-03 Thread Navis Ryu
.distPartAgg=false -> GroupByDesc.groupKeyIsNotReduceKey=false -> GroupByOperator.groupKeyIsNotReduceKey/keysCurrentGroup/firstRowInGroup/startGroup/endGroup is not needed - Navis Ryu On Feb. 4, 2015, 2:02 a.m., Ashutosh Chauhan

Re: Review Request 30549: SELECT max(bar) FROM foo is broken after ANALYZE ... FOR COLUMNS

2015-02-03 Thread Navis Ryu
st/results/clientpositive/tez/metadata_only_queries.q.out 8c0bccb Diff: https://reviews.apache.org/r/30549/diff/ Testing --- Thanks, Navis Ryu

Review Request 30549: SELECT max(bar) FROM foo is broken after ANALYZE ... FOR COLUMNS

2015-02-02 Thread Navis Ryu
apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java d1118f1 ql/src/test/results/clientpositive/metadata_only_queries.q.out 90c76ed ql/src/test/results/clientpositive/metadata_only_queries_with_filters.q.out 5be958f Diff: https://reviews.apache.org/r/30549/diff/ Testing --- Thanks,

Re: Review Request 30151: Remove Extract Operator & its friends from codebase.

2015-02-01 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30151/#review70534 --- Ship it! Ship It! - Navis Ryu On Jan. 30, 2015, 7:46 p.m

Review Request 30345: Problem with subquery using windowing functions

2015-01-27 Thread Navis Ryu
sting --- Thanks, Navis Ryu

Re: Review Request 30151: Remove Extract Operator & its friends from codebase.

2015-01-26 Thread Navis Ryu
/clientpositive/bucketsortoptimize_insert_4.q.out <https://reviews.apache.org/r/30151/#comment114490> Any idea why the plan is changed so much? - Navis Ryu On Jan. 24, 2015, 6:08 p.m., Ashutosh Chauhan wrote: > > --- > This is a

Re: Review Request 29196: Add some explain to PTF operator

2015-01-26 Thread Navis Ryu
/results/clientpositive/tez/vectorized_ptf.q.out a814849 ql/src/test/results/clientpositive/vectorized_ptf.q.out 1e3c43c ql/src/test/results/clientpositive/windowing_streaming.q.out ac9e180 Diff: https://reviews.apache.org/r/29196/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 29800: Apply ColumnPrunning for noop PTFs

2015-01-22 Thread Navis Ryu
/clientpositive/vectorized_ptf.q.out 7fdd1d8 Diff: https://reviews.apache.org/r/29800/diff/ Testing --- Thanks, Navis Ryu

Review Request 30018: ReduceSinkOperator of PTFOperator can have redundant key columns

2015-01-18 Thread Navis Ryu
ws.apache.org/r/30018/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 29878: Bug with max() together with rank() and grouping sets

2015-01-18 Thread Navis Ryu
an/GroupByDesc.java 7a0b0da Diff: https://reviews.apache.org/r/29878/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 29878: Bug with max() together with rank() and grouping sets

2015-01-18 Thread Navis Ryu
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/29878/#review68438 ------- On Jan. 14, 2015, 9:13 a.m., Navis Ryu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apac

Review Request 29878: Bug with max() together with rank() and grouping sets

2015-01-14 Thread Navis Ryu
sets6.q.out d2ff112 ql/src/test/results/clientpositive/groupby_rollup1.q.out 0108ce0 ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out 301b90c Diff: https://reviews.apache.org/r/29878/diff/ Testing --- Thanks, Navis Ryu

Review Request 29800: Apply ColumnPrunning for noop PTFs

2015-01-11 Thread Navis Ryu
functions. Diffs - ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java afd1738 ql/src/java/org/apache/hadoop/hive/ql/ppd/PredicatePushDown.java ee7328e Diff: https://reviews.apache.org/r/29800/diff/ Testing --- Thanks, Navis Ryu

Review Request 29753: Support split sampling for parallel order by

2015-01-08 Thread Navis Ryu
/test/queries/clientpositive/parallel_orderby.q 73c3940 ql/src/test/results/clientpositive/parallel_orderby.q.out 2f4ac8f Diff: https://reviews.apache.org/r/29753/diff/ Testing --- Thanks, Navis Ryu

Review Request 29498: Upgrade JavaEWAH version to allow for unsorted bitset creation

2014-12-30 Thread Navis Ryu
iff: https://reviews.apache.org/r/29498/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 23351: Support direct fetch for lateral views, sub queries, etc.

2014-12-28 Thread Navis Ryu
y generated e-mail. To reply, visit: https://reviews.apache.org/r/23351/#review59662 ------- On July 9, 2014, 6:55 a.m., Navis Ryu wrote: > > --- > This is an automatical

Review Request 29390: CBO changes constant to column type

2014-12-23 Thread Navis Ryu
/serde2/objectinspector/ObjectInspectorUtils.java e844979 serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableVoidObjectInspector.java 02b672a Diff: https://reviews.apache.org/r/29390/diff/ Testing --- Thanks, Navis Ryu

Review Request 29300: Merging HIVE-5871 into LazySimpleSerDe

2014-12-21 Thread Navis Ryu
/TestLazyArrayMapStruct.java 48f3b02 Diff: https://reviews.apache.org/r/29300/diff/ Testing --- Thanks, Navis Ryu

Review Request 29196: Add some explain to PTF operator

2014-12-17 Thread Navis Ryu
--- Thanks, Navis Ryu

Review Request 29195: incompatFileSet in AbstractFileMergeOperator should be marked to skip task id check

2014-12-17 Thread Navis Ryu
7a9c772 ql/src/test/results/clientpositive/tez/orc_merge_incompat1.q.out ea2dd5d Diff: https://reviews.apache.org/r/29195/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 29037: Avoid creating serde for partitions if possible in FetchTask

2014-12-17 Thread Navis Ryu
ector/primitive/PrimitiveObjectInspectorConverter.java 49884b8 Diff: https://reviews.apache.org/r/29037/diff/ Testing --- Thanks, Navis Ryu

Review Request 29037: Avoid creating serde for partitions if possible in FetchTask

2014-12-15 Thread Navis Ryu
/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java 49884b8 Diff: https://reviews.apache.org/r/29037/diff/ Testing --- Thanks, Navis Ryu

Review Request 28990: ANALYZE TABLE statement fails on postgres metastore

2014-12-12 Thread Navis Ryu
ff: https://reviews.apache.org/r/28990/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 25628: alias of compound aggregation functions fails in having clause

2014-12-11 Thread Navis Ryu
ory.java bd610d9 ql/src/test/queries/clientpositive/having3.q PRE-CREATION ql/src/test/results/clientpositive/having3.q.out PRE-CREATION Diff: https://reviews.apache.org/r/25628/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 26966: Path type entities should use qualified path rather than string

2014-12-11 Thread Navis Ryu
ps://reviews.apache.org/r/26966/#review64424 ----------- On Dec. 12, 2014, 7:31 a.m., Navis Ryu wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 26966: Path type entities should use qualified path rather than string

2014-12-11 Thread Navis Ryu
/clientpositive/alter5.q.out 583be83 ql/src/test/results/clientpositive/exim_17_part_managed.q.out 9036a28 Diff: https://reviews.apache.org/r/26966/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 26966: Path type entities should use qualified path rather than string

2014-12-11 Thread Navis Ryu
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26966/#review64432 ------- On Dec. 12, 2014, 7:31 a.m., Navis Ryu wrote: > > --

Re: Review Request 26966: Path type entities should use qualified path rather than string

2014-12-11 Thread Navis Ryu
/clientpositive/alter5.q.out 583be83 ql/src/test/results/clientpositive/exim_17_part_managed.q.out 9036a28 Diff: https://reviews.apache.org/r/26966/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 26966: Path type entities should use qualified path rather than string

2014-12-11 Thread Navis Ryu
using syntax that this is a local file path, > > should we use that information instead of trying to automatically > > determine/guess that ? > > Navis Ryu wrote: > I've missed this comment. Imho, we should throw exception when user > specified non-local path wi

Review Request 28988: hive.default.fileformat should accept all formats described by StorageFormatDescriptor

2014-12-11 Thread Navis Ryu
9aa917c common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2e2bf5a ql/pom.xml 515d235 ql/src/java/org/apache/hadoop/hive/ql/io/StorageFormatFactory.java e0bf153 Diff: https://reviews.apache.org/r/28988/diff/ Testing --- Thanks, Navis Ryu

Review Request 28982: Data loading from text files or text file processing doesn't handle nulls correctly

2014-12-11 Thread Navis Ryu
/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java 588cc8c serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUnion.java 22fc638 serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryObject.java b3625b3 Diff: https://reviews.apache.org/r/28982/diff/ Testing --- Thanks, Navis Ryu

Review Request 28936: Set completer in CliDriver is not working

2014-12-10 Thread Navis Ryu
.java aec5018 common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2e2bf5a common/src/java/org/apache/hadoop/hive/conf/Validator.java bb0f836 Diff: https://reviews.apache.org/r/28936/diff/ Testing --- Thanks, Navis Ryu

Review Request 28884: Provide compile + run method for HiveServer2

2014-12-09 Thread Navis Ryu
Diff: https://reviews.apache.org/r/28884/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15855: Check DATABASES/TABLE privilege for metastore authorizer

2014-12-08 Thread Navis Ryu
But this is just for showing/listing legitimated databases/tables for the user. Isn't it? - Navis --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15855/#review43888 -

Review Request 28839: Support custom virtual columns from serde implementation

2014-12-08 Thread Navis Ryu
nary/LazyBinarySerDe.java 62cba01 serde/src/java/org/apache/hadoop/hive/serde2/thrift/ThriftDeserializer.java b78ec69 Diff: https://reviews.apache.org/r/28839/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 26966: Path type entities should use qualified path rather than string

2014-12-08 Thread Navis Ryu
non-local path with local keyword. Should we? - Navis --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26966/#review57607 ----------- On Oct. 21, 2014, 6:55 a.m., Navis Ryu wrote: > > --

Review Request 28837: SessionState.getUserFromAuthenticator() should be used instead of SessionState.getName()

2014-12-08 Thread Navis Ryu
5864e Diff: https://reviews.apache.org/r/28837/diff/ Testing --- Thanks, Navis Ryu

Review Request 28274: Refactoring of PassThroughOutputFormat

2014-11-19 Thread Navis Ryu
Diff: https://reviews.apache.org/r/28274/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-30 Thread Navis Ryu
--------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26854/ > --- > > (Updated Oct. 30, 2014, 11:41 p.m.) > > > Review request for hive, Navis R

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-30 Thread Navis Ryu
r UDFs apart from the > > static initialization. So if one CLI user creates a permanent UDF, another > > user on CLI, or HS2, will not be able to use that new UDF if the 2nd CLI or > > HS2 was initialized before this UDF was created. > > Navis Ryu wrote: > Perma

Re: Review Request 27367: support ISO-2012 timestamp literals

2014-10-30 Thread Navis Ryu
CREATION ql/src/test/results/clientpositive/partition_timestamp2.q.out PRE-CREATION ql/src/test/results/clientpositive/timestamp_literal.q.out PRE-CREATION Diff: https://reviews.apache.org/r/27367/diff/ Testing --- Thanks, Navis Ryu

Review Request 27367: support ISO-2012 timestamp literals

2014-10-29 Thread Navis Ryu
src/test/results/clientnegative/illegal_partition_type4.q.out e388086 ql/src/test/results/clientnegative/timestamp_literal.q.out PRE-CREATION ql/src/test/results/clientpositive/timestamp_literal.q.out PRE-CREATION Diff: https://reviews.apache.org/r/27367/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 22903: Extend join transitivity PPD to non-column expressions

2014-10-28 Thread Navis Ryu
https://reviews.apache.org/r/22903/diff/ Testing --- Thanks, Navis Ryu

Review Request 27225: HCatPartition needs getPartCols method

2014-10-27 Thread Navis Ryu
/hcatalog/api/TestHCatClient.java f9f7b04 Diff: https://reviews.apache.org/r/27225/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 26854: HIVE-2573 Create per-session function registry

2014-10-23 Thread Navis Ryu
accesses internal of it. If it does not act like that, we should fix metastore. - Navis --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/#review57952 ------- On O

Review Request 26966: Path type entities should use qualified path rather than string

2014-10-20 Thread Navis Ryu
/test/results/clientpositive/exim_17_part_managed.q.out 9036a28 Diff: https://reviews.apache.org/r/26966/diff/ Testing --- Thanks, Navis Ryu

Review Request 26918: "Failed to locate the winutils binary" when loading JDBC driver on Windows

2014-10-20 Thread Navis Ryu
n/src/main/java/org/apache/hadoop/hive/shims/Environments.java PRE-CREATION Diff: https://reviews.apache.org/r/26918/diff/ Testing --- Thanks, Navis Ryu

Review Request 26917: Make OrcNewInputFormat return row number as a key

2014-10-20 Thread Navis Ryu
/src/java/org/apache/hadoop/hive/ql/io/orc/OrcNewInputFormat.java b6ad0dc Diff: https://reviews.apache.org/r/26917/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 25628: alias of compound aggregation functions fails in having clause

2014-10-20 Thread Navis Ryu
op/hive/ql/parse/TypeCheckProcFactory.java e065983 ql/src/test/queries/clientpositive/having3.q PRE-CREATION ql/src/test/results/clientpositive/having3.q.out PRE-CREATION Diff: https://reviews.apache.org/r/25628/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 25238: make timestamp accessible in the hbase KeyValue

2014-10-14 Thread Navis Ryu
op/hive/serde2/io/TimestampWritable.java 0ab27ff Diff: https://reviews.apache.org/r/25238/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 25238: make timestamp accessible in the hbase KeyValue

2014-10-14 Thread Navis Ryu
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25238/#review56517 ------- On Sept. 2, 2014, 6:15 a.m., Navis Ryu wrote: > >

Re: Review Request 25059: Ambiguous column reference error on query

2014-10-13 Thread Navis Ryu
ut 237c21f ql/src/test/results/clientpositive/ambiguous_col.q.out e8760f1 ql/src/test/results/clientpositive/complex_alias.q.out PRE-CREATION Diff: https://reviews.apache.org/r/25059/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 26435: Self join may fail if one side has VCs and other doesn't

2014-10-13 Thread Navis Ryu
Diff: https://reviews.apache.org/r/26435/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 26435: Self join may fail if one side has VCs and other doesn't

2014-10-13 Thread Navis Ryu
/exec/MapOperator.java, line 202 > > <https://reviews.apache.org/r/26435/diff/1/?file=715105#file715105line202> > > > > nit: hash codes could be combined similar to how Java does it ( * prime > > + next) hashCode and equals seemed not neede

Review Request 26435: Self join may fail if one side has VCs and other doesn't

2014-10-07 Thread Navis Ryu
004ca Diff: https://reviews.apache.org/r/26435/diff/ Testing --- Thanks, Navis Ryu

Review Request 26406: Implement support for BETWEEN in SELECT list

2014-10-07 Thread Navis Ryu
Thanks, Navis Ryu

Re: Review Request 26218: Add configuration for custom services in hiveserver2

2014-10-06 Thread Navis Ryu
/ServiceStateChangeListener.java 16ad9a9 service/src/java/org/apache/hive/service/server/HiveServer2.java c667533 Diff: https://reviews.apache.org/r/26218/diff/ Testing --- Thanks, Navis Ryu

Review Request 26257: Index related events should be delivered to metastore event listener

2014-10-01 Thread Navis Ryu
/clientpositive/show_indexes_syntax.q.out bc96359 ql/src/test/results/clientpositive/union_view.q.out bbbf5e7 Diff: https://reviews.apache.org/r/26257/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 26218: Add configuration for custom services in hiveserver2

2014-10-01 Thread Navis Ryu
To reply, visit: https://reviews.apache.org/r/26218/#review55057 ------- On Oct. 1, 2014, 7:24 a.m., Navis Ryu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26218/ > -

Review Request 26218: Add configuration for custom services in hiveserver2

2014-10-01 Thread Navis Ryu
://reviews.apache.org/r/26218/diff/ Testing --- Thanks, Navis Ryu

Review Request 25688: hive jdbc can not used by jmeter, because of unsupported auto commit feature

2014-09-16 Thread Navis Ryu
/HiveConnection.java cbcfec7 Diff: https://reviews.apache.org/r/25688/diff/ Testing --- Thanks, Navis Ryu

Review Request 25678: Using type variable in UDF

2014-09-15 Thread Navis Ryu
de2/objectinspector/ThriftUnionObjectInspector.java 17add28 serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 8dffe63 Diff: https://reviews.apache.org/r/25678/diff/ Testing --- Thanks, Navis Ryu

Review Request 25628: alias of compound aggregation functions fails in having clause

2014-09-14 Thread Navis Ryu
sitive/having3.q PRE-CREATION ql/src/test/results/clientpositive/having3.q.out PRE-CREATION Diff: https://reviews.apache.org/r/25628/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 25625: Support non-constant expressions for MAP type indices.

2014-09-14 Thread Navis Ryu
constant.q.out PRE-CREATION ql/src/test/results/compiler/errors/invalid_list_index.q.out a4179cd ql/src/test/results/compiler/errors/invalid_list_index2.q.out aaa9455 ql/src/test/results/compiler/errors/invalid_map_index.q.out 4eb7afa ql/src/test/results/compiler/errors/invalid_map_index2.q.out edc9bda Diff: https://reviews.apache.org/r/25625/diff/ Testing --- Thanks, Navis Ryu

Review Request 25625: Support non-constant expressions for MAP type indices.

2014-09-14 Thread Navis Ryu
9cd ql/src/test/results/compiler/errors/invalid_list_index2.q.out aaa9455 ql/src/test/results/compiler/errors/invalid_map_index.q.out 4eb7afa ql/src/test/results/compiler/errors/invalid_map_index2.q.out edc9bda Diff: https://reviews.apache.org/r/25625/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 23352: Support non-constant expressions for MAP type indices.

2014-09-11 Thread Navis Ryu
-------- On July 9, 2014, 6:57 a.m., Navis Ryu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23352/ > -

Re: Review Request 25059: Ambiguous column reference error on query

2014-09-11 Thread Navis Ryu
.q.out e8760f1 ql/src/test/results/clientpositive/complex_alias.q.out PRE-CREATION Diff: https://reviews.apache.org/r/25059/diff/ Testing --- Thanks, Navis Ryu

  1   2   3   4   5   >