> On Dec. 9, 2014, 8:31 p.m., Mohit Sabharwal wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 556 > > <https://reviews.apache.org/r/26966/diff/1/?file=727019#file727019line556> > > > > nit: while we're here, this code will be cleaner if we replace the many > > continues with bunch of else if {} blocks or, better, a switch {}
Introduces Entity.isPathType(), which seemed cleaner enough. - Navis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26966/#review64424 ----------------------------------------------------------- On Dec. 12, 2014, 7:31 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26966/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2014, 7:31 a.m.) > > > Review request for hive. > > > Bugs: HIVE-8357 > https://issues.apache.org/jira/browse/HIVE-8357 > > > Repository: hive-git > > > Description > ------- > > Path type entities should use qualified path rather than string > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/FileUtils.java 3c34d7a > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestCreateUdfEntities.java > c60f856 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 395a5f5 > ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java 76b1f01 > ql/src/java/org/apache/hadoop/hive/ql/hooks/ReadEntity.java 8b6a923 > ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java fc8afc0 > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java > f33abb4 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > d2c4dc0 > ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java > f96209c > ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java > 01b97c8 > ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java > eda7984 > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java > 1ae5b71 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 6f44f9c > ql/src/test/results/clientnegative/udf_local_resource.q.out 2f2227b > ql/src/test/results/clientnegative/udf_nonexistent_resource.q.out e184787 > ql/src/test/results/clientpositive/add_part_multiple.q.out 975baa5 > ql/src/test/results/clientpositive/alter2.q.out cce6e0a > ql/src/test/results/clientpositive/alter5.q.out 583be83 > ql/src/test/results/clientpositive/exim_17_part_managed.q.out 9036a28 > > Diff: https://reviews.apache.org/r/26966/diff/ > > > Testing > ------- > > > Thanks, > > Navis Ryu > >
