-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39253/
-----------------------------------------------------------
(Updated 10 13, 2015, 1:39 오전)
Review request for hive.
Bugs: HIVE-11679
https://issues.apache.org/jira/browse/HIVE-11679
Repository: hive-git
Description
-------
{code}
public static ExprNodeGenericFuncDesc newInstance(GenericUDF genericUDF,
String funcText,
List<ExprNodeDesc> children) throws UDFArgumentException {
...
if (genericUDF instanceof GenericUDFBaseCompare && children.size() == 2) {
TypeInfo oiTypeInfo0 = children.get(0).getTypeInfo();
TypeInfo oiTypeInfo1 = children.get(1).getTypeInfo();
SessionState ss = SessionState.get();
Configuration conf = (ss != null) ? ss.getConf() : new Configuration();
{code}
This is both a SessionState.get() which is a threadlocal lookup or worse, a
new Configuration() which means XML parsing of multiple files for each
equality expression in the query.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/JoinTypeCheckCtx.java
dccd1d9
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java fbe93f9
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 61ee2bd
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 2d7d9d4
ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java e0cd398
ql/src/java/org/apache/hadoop/hive/ql/parse/QBSubQuery.java f95ee8d
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 4af07ad
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckCtx.java 8ad28be
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java ab5d006
ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeColumnListDesc.java
be78e73
ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDesc.java 328bd86
ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java
b5d2ddf
ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/MatchPath.java cc2b77b
ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/TableFunctionResolver.java
71034d7
ql/src/test/results/clientnegative/compare_double_bigint.q.out 68a295a
ql/src/test/results/clientnegative/compare_string_bigint.q.out 9a604fa
Diff: https://reviews.apache.org/r/39253/diff/
Testing
-------
Thanks,
Navis Ryu
