> On Oct. 21, 2014, 5:04 p.m., Thejas Nair wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java, line
> > 236
> > <https://reviews.apache.org/r/26966/diff/1/?file=727028#file727028line236>
> >
> > if the user has specified using syntax that this is a local file path,
> > should we use that information instead of trying to automatically
> > determine/guess that ?
>
> Navis Ryu wrote:
> I've missed this comment. Imho, we should throw exception when user
> specified non-local path with local keyword. Should we?
>
> Thejas Nair wrote:
> Yes, that would be a good solution.
Ah, sorry. It's already in LoadSemanticAnalyzer.applyConstraints().
```java
if (isLocal && !fromURI.getScheme().equals("file")) {
throw new SemanticException(ErrorMsg.ILLEGAL_PATH.getMsg(ast,
"Source file system should be \"file\" if \"local\" is specified"));
}
```
- Navis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26966/#review57607
-----------------------------------------------------------
On Oct. 21, 2014, 6:55 a.m., Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26966/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2014, 6:55 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-8357
> https://issues.apache.org/jira/browse/HIVE-8357
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Path type entities should use qualified path rather than string
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/FileUtils.java 95e8d7c
>
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestCreateUdfEntities.java
> c60f856
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java e254505
> ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java 76b1f01
> ql/src/java/org/apache/hadoop/hive/ql/hooks/ReadEntity.java 8b6a923
> ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java c5be822
> ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java
> 37cbf7f
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
> c060d74
> ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java
> f96209c
> ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java
> 22e5b47
> ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java
> 4891518
> ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java
> 8bd24d3
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1b7a41d
> ql/src/test/results/clientnegative/udf_local_resource.q.out 2f2227b
> ql/src/test/results/clientnegative/udf_nonexistent_resource.q.out e184787
> ql/src/test/results/clientpositive/add_part_multiple.q.out 975baa5
> ql/src/test/results/clientpositive/alter2.q.out 3356ab9
> ql/src/test/results/clientpositive/alter5.q.out a83b68d
> ql/src/test/results/clientpositive/exim_17_part_managed.q.out 9036a28
>
> Diff: https://reviews.apache.org/r/26966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Navis Ryu
>
>
