> On Oct. 14, 2014, 1:50 p.m., Swarnim Kulkarni wrote: > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseRow.java, line > > 147 > > <https://reviews.apache.org/r/25238/diff/1/?file=673709#file673709line147> > > > > I think timestamp and long make sense. I am a little confused on why we > > have string as a valid type for timestamp. I understand the flexibility it > > provides but I don't see a place where we do a validation that the string > > actually corresponds to a valid timestamp.
Ok - Navis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25238/#review56517 ----------------------------------------------------------- On Sept. 2, 2014, 6:15 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25238/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2014, 6:15 a.m.) > > > Review request for hive. > > > Bugs: HIVE-2828 > https://issues.apache.org/jira/browse/HIVE-2828 > > > Repository: hive-git > > > Description > ------- > > Originated from HIVE-2781 and not accepted, but I think this could be helpful > to someone. > > By using special column notation ':timestamp' in HBASE_COLUMNS_MAPPING, user > might access timestamp value in hbase KeyValue. > {code} > CREATE TABLE hbase_table (key int, value string, time timestamp) > STORED BY 'org.apache.hadoop.hive.hbase.HBaseStorageHandler' > WITH SERDEPROPERTIES ("hbase.columns.mapping" = ":key,cf:string,:timestamp") > {code} > > > Diffs > ----- > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/ColumnMappings.java > 8735fbc > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseRowSerializer.java > fe6081e > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java 6c1ce5c > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDeParameters.java > 8ea4408 > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java > feb3cd1 > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseInputFormatUtil.java > 5aa1d796 > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java > 4ac0803 > hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseRow.java > 3e8b8fd > > hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestLazyHBaseObject.java > 9a31f0f > hbase-handler/src/test/queries/positive/hbase_timestamp.q PRE-CREATION > hbase-handler/src/test/results/positive/hbase_timestamp.q.out PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java > 683618f > serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java > 0ab27ff > > Diff: https://reviews.apache.org/r/25238/diff/ > > > Testing > ------- > > > Thanks, > > Navis Ryu > >
