Mohit Sabharwal created HIVE-18559:
--
Summary: Allow hive.metastore.limit.partition.request to be user
configurable
Key: HIVE-18559
URL: https://issues.apache.org/jira/browse/HIVE-18559
Project: Hive
/listener/TestTransactionalDbNotificationListener.java
PRE-CREATION
Diff: https://reviews.apache.org/r/61244/diff/1/
Testing
---
Thanks,
Mohit Sabharwal
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60950/#review181012
---
Ship it!
Ship It!
- Mohit Sabharwal
On July 20, 2017, 12:39
LocalModifiedConfig is non null before calling
notifyMetaListenersOnShutDown
- Mohit Sabharwal
On July 19, 2017, 7:40 a.m., PRASHANT GOLASH wrote:
>
> ---
> This is an automatically generated e-mail
217>
For clarity, move this to finally() inside cleanupRawStore(), so that all
thread local cleanup is captured in one place as
HMSHandler.threadLocalModifiedMetaConfKeys.remove().
- Mohit Sabharwal
On July 18, 2017, 10:
Mohit Sabharwal created HIVE-17022:
--
Summary: Add mode in lock debug statements
Key: HIVE-17022
URL: https://issues.apache.org/jira/browse/HIVE-17022
Project: Hive
Issue Type: Improvement
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57626/#review170943
---
Ship it!
Ship It!
- Mohit Sabharwal
On April 3, 2017, 10:34
> On March 30, 2017, 1:54 p.m., Mohit Sabharwal wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java
> > Lines 51-52 (patched)
> > <https://reviews.apache.org/r/57626/diff/6/?file=1677663#file1677663line51>
> >
> >
> On March 30, 2017, 1:54 p.m., Mohit Sabharwal wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java
> > Lines 51-52 (patched)
> > <https://reviews.apache.org/r/57626/diff/6/?file=1677663#file1677663line51>
> >
> >
time a new items is added.
As I said, you can simply add a new method called
getunmodifiableParameters() which returns
Collections.unmodifiableMap(parameters) without the need for this copy.
- Mohit Sabharwal
On March 28, 2017, 3:17 p.m., Sergio Pena wrote:
>
> -
> On March 17, 2017, 10:34 p.m., Mohit Sabharwal wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListenerNotifier.java
> > Lines 138 (patched)
> > <https://reviews.apache.org/r/57626/diff/2/?file=1666420#file1666420line138>
> >
> >
ch makes it brittle.
- Mohit Sabharwal
On March 20, 2017, 10:33 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
st-wise the branch (listeners != null) is expensive, so let's not do
it twice.
- Mohit Sabharwal
On March 17, 2017, 8:14 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically genera
+1
On Tue, Feb 28, 2017 at 11:12 AM, Thejas Nair wrote:
> Note that upgrading the minimum required version to JDK8 also gives Hive
> the option of using more recent versions of several libraries including
> hikaricp (as default connection pool option) [1] and jetty [2]
>
> [1] https://issues.a
.org/r/56687/#comment238763>
what about this ?
- Mohit Sabharwal
On Feb. 23, 2017, 9:01 p.m., Misha Dmitriev wrote:
>
> ---
> This is an automatically generated
Mohit Sabharwal created HIVE-16016:
--
Summary: Use same PersistenceManager for metadata and notification
Key: HIVE-16016
URL: https://issues.apache.org/jira/browse/HIVE-16016
Project: Hive
che.org/r/54393/#comment229110>
throw RuntimeException
- Mohit Sabharwal
On Dec. 6, 2016, 8:13 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
Mohit Sabharwal created HIVE-15305:
--
Summary: Add tests for METASTORE_EVENT_LISTENERS
Key: HIVE-15305
URL: https://issues.apache.org/jira/browse/HIVE-15305
Project: Hive
Issue Type: Bug
a3b16d049c9c06f08e5ef8809ad386274479d66d
Diff: https://reviews.apache.org/r/53838/diff/
Testing
---
Verified using TestDbNotificationListener
Thanks,
Mohit Sabharwal
a3b16d049c9c06f08e5ef8809ad386274479d66d
Diff: https://reviews.apache.org/r/53838/diff/
Testing
---
Verified using TestDbNotificationListener
Thanks,
Mohit Sabharwal
/
Testing
---
Verified using TestDbNotificationListener
Thanks,
Mohit Sabharwal
Mohit Sabharwal created HIVE-15232:
--
Summary: Add notification events for functions and indexes
Key: HIVE-15232
URL: https://issues.apache.org/jira/browse/HIVE-15232
Project: Hive
Issue
TestDbNotificationListener
Thanks,
Mohit Sabharwal
TestDbNotificationListener
Thanks,
Mohit Sabharwal
will cause some backward compatibility
> > issue, if the HiveMetaStore is currently the only consumer of the
> > AlterHandler, it should be fine.
>
> Mohit Sabharwal wrote:
> That's a good point. I have created new versions of these methods. But
> adding new meth
TestDbNotificationListener
Thanks,
Mohit Sabharwal
I wonder if the API changes will cause some backward compatibility
> > issue, if the HiveMetaStore is currently the only consumer of the
> > AlterHandler, it should be fine.
That's a good point. I have created new versions of these methods. But adding
new methods ma
Mohit Sabharwal created HIVE-15145:
--
Summary: Alter partition and fs renameDir should happen in same
transaction
Key: HIVE-15145
URL: https://issues.apache.org/jira/browse/HIVE-15145
Project: Hive
40b337a9e40ea04a37f108146853d2d1f42dcd29
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
60e462fd06a3f84d5b87cd335afb49768cb27562
Diff: https://reviews.apache.org/r/52800/diff/
Testing
---
Enhanced TestDbNotificationListener
Thanks,
Mohit Sabharwal
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52283/#review152739
---
Ship it!
Ship It!
- Mohit Sabharwal
On Oct. 14, 2016, 6:32
in/java/org/apache/hive/spark/client/SparkClientImpl.java
(line 495)
<https://reviews.apache.org/r/52283/#comment221548>
static ?
- Mohit Sabharwal
On Oct. 12, 2016, 8:34 p.m., Vihang Karajgaonkar wrote:
>
> ---
> Thi
l.java
(line 447)
<https://reviews.apache.org/r/52283/#comment220185>
// -> // A...
spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java
(lines 450 - 454)
<https://reviews.apache.org/r/52283/#comment220190>
This pattern of choosing the correct password i
(lines 109 - 112)
<https://reviews.apache.org/r/52283/#comment219977>
This is super unread-able... please make this into one line
ql/src/test/org/apache/hadoop/hive/ql/exec/TestHiveCredentialProviders.java
(lines 333 - 335)
<https://reviews.apache.org/r/52283/#comment21
ache/hadoop/hive/common/metrics/LegacyMetrics.java (line
191)
<https://reviews.apache.org/r/52084/#comment218599>
same for this file.
- Mohit Sabharwal
On Sept. 21, 2016, 3:20 p.m., Barna Zsombor Klara wrote:
>
> ---
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50405/#review144977
---
Ship it!
Ship It!
- Mohit Sabharwal
On July 26, 2016, 3:13
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50160/#review142786
---
Ship it!
Ship It!
- Mohit Sabharwal
On July 18, 2016, 8:41
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50073/#review142448
---
Ship it!
Ship It!
- Mohit Sabharwal
On July 15, 2016, 6:52
t() == null ? null :
SessionState.get().getReloadableAuxJars(); ?
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java
(line 215)
<https://reviews.apache.org/r/50073/#comment207983>
To be safe:
SessionState.get() == null ? null :
SessionState.get().getRel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49919/#review142322
---
Ship it!
Ship It!
- Mohit Sabharwal
On July 14, 2016, 11:12
oop it should be
> > Math.min(Math.max(max[j], row.sizes[j] + 1), maxColumnWidth); Did you
> > mean the same?
Ah, right, that should me min not max.
- Mohit
---
This is an automatically generate
g/r/49919/#comment207855>
Missing Apache header
beeline/src/test/org/apache/hive/beeline/TestBufferedRows.java (line 16)
<https://reviews.apache.org/r/49919/#comment207856>
nit: extra line
- Mohit Sabharwal
On July 12, 2016, 5:51 p.m., Vihang
f45b90d2f6bc9d853b895a837938a15f7d45a1e1
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
44d73d482263bc7f3c210503ba9440a6cd793a72
Diff: https://reviews.apache.org/r/49739/diff/
Testing
---
Added unit test
Thanks,
Mohit Sabharwal
Mohit Sabharwal created HIVE-14187:
--
Summary: JDOPersistenceManager objects remain cached if
MetaStoreClient#close is not called
Key: HIVE-14187
URL: https://issues.apache.org/jira/browse/HIVE-14187
lt;https://reviews.apache.org/r/48233/#comment203289>
Add the @Deprecated annotation for this config.
For the sake of completeness, we can say "Please use
ConfVars.METASTORE_LIMIT_PARTITION_REQUEST in the metastore instead."
-
ct count query - which will be issued for every getPartitions request.
- Mohit Sabharwal
On June 13, 2016, 6:28 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
Mohit Sabharwal created HIVE-13894:
--
Summary: Fix more json related JDK8 test failures Part 2
Key: HIVE-13894
URL: https://issues.apache.org/jira/browse/HIVE-13894
Project: Hive
Issue Type
Mohit Sabharwal created HIVE-13884:
--
Summary: Disallow queries fetching more than a configured number
of partitions in PartitionPruner
Key: HIVE-13884
URL: https://issues.apache.org/jira/browse/HIVE-13884
f such tests
should be relatively small.
On Tue, Apr 19, 2016 at 10:43 AM, Mohit Sabharwal
wrote:
> Created HIVE-13547 to track switching 2x tests to JDK8.
>
> On Wed, Apr 13, 2016 at 10:02 AM, Sergio Pena
> wrote:
>
>> I agree with such change as JDK7 is not longer supported.
Mohit Sabharwal created HIVE-13860:
--
Summary: Fix more json related JDK8 test failures
Key: HIVE-13860
URL: https://issues.apache.org/jira/browse/HIVE-13860
Project: Hive
Issue Type: Sub
/src/main/java/org/apache/hadoop/hive/schshim/FairSchedulerShim.java
(line 137)
<https://reviews.apache.org/r/47040/#comment197079>
config for consistency
shims/scheduler/src/test/java/org/apache/hadoop/hive/schshim/TestFairScheduler.java
(line 1)
<https://reviews.apache.org/r/47040/#comm
ava1.8.out
789e6c2b82ffa473f2c8fd29ee9568f83243c2bf
ql/src/test/results/clientpositive/vector_cast_constant.q.out
39ed1c85839c5b567bca603d335bf947b0a03b7f
Diff: https://reviews.apache.org/r/47204/diff/
Testing
---
Thanks,
Mohit Sabharwal
shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/QueueAllocator.java
(line 1)
<https://reviews.apache.org/r/47040/#comment196857>
Missing Apache License Header
shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/QueueAllocator.java
(line 10)
<https://review
tant.q.out
39ed1c85839c5b567bca603d335bf947b0a03b7f
Diff: https://reviews.apache.org/r/47204/diff/
Testing
---
Thanks,
Mohit Sabharwal
Mohit Sabharwal created HIVE-13657:
--
Summary: Spark driver stderr logs should appear in hive client logs
Key: HIVE-13657
URL: https://issues.apache.org/jira/browse/HIVE-13657
Project: Hive
Mohit Sabharwal created HIVE-13587:
--
Summary: Set Hive pom to use Hadoop 2.6.1
Key: HIVE-13587
URL: https://issues.apache.org/jira/browse/HIVE-13587
Project: Hive
Issue Type: Sub-task
Mohit Sabharwal created HIVE-13585:
--
Summary: Add counter metric for direct sql failures
Key: HIVE-13585
URL: https://issues.apache.org/jira/browse/HIVE-13585
Project: Hive
Issue Type: Bug
Mohit Sabharwal created HIVE-13549:
--
Summary: Remove jdk version specific out files from Hive2
Key: HIVE-13549
URL: https://issues.apache.org/jira/browse/HIVE-13549
Project: Hive
Issue Type
unds good. I'd ideally like to make JDK8 the minimum
> requirement
> > soon as well.
> >
> > On Mon, Apr 11, 2016 at 4:59 PM, Szehon Ho wrote:
> >
> > > Sounds like a good plan, +1
> > >
> > > On Mon, Apr 11, 2016 at 4:31 PM, Mohit S
Mohit Sabharwal created HIVE-13547:
--
Summary: Switch Hive2 tests to JDK8
Key: HIVE-13547
URL: https://issues.apache.org/jira/browse/HIVE-13547
Project: Hive
Issue Type: Bug
Thanks, Ashutosh. Makes sense to keep the source and target as 1.7 since
we're not using any JDK8 specific features yet. So, option (3) essentially
just means using JDK8 exclusively to build & test Hive2.
On Sat, Apr 9, 2016 at 12:23 PM, Ashutosh Chauhan
wrote:
> Hi Mohit,
>
JDK8 also lines us up better for Java 9, which is on the
horizon (Oracle will end public updates for Java 8 in Sep 2017)
Around 100 of the latest crop of failures are due to one cause
(HIVE-13409).
I can take a pass at triaging the rest if there is consensus around what
to do overall.
Thanks,
Mohit Sabharwal created HIVE-13409:
--
Summary: Fix JDK8 test failures related to COLUMN_STATS_ACCURATE
Key: HIVE-13409
URL: https://issues.apache.org/jira/browse/HIVE-13409
Project: Hive
ql, metadata and set operations.
Added tests to TestQueryDisplay
Thanks,
Mohit Sabharwal
nager.java
96c01de40fa581f1583fc3f9a93a2c71355ebc04
Diff: https://reviews.apache.org/r/43785/diff/
Testing
---
Thanks,
Mohit Sabharwal
Mohit Sabharwal created HIVE-13099:
--
Summary: Non-SQLOperations lead to Web UI NPE
Key: HIVE-13099
URL: https://issues.apache.org/jira/browse/HIVE-13099
Project: Hive
Issue Type: Bug
org/r/43553/diff/
Testing
---
Thanks,
Mohit Sabharwal
Mohit Sabharwal created HIVE-13057:
--
Summary: Remove duplicate copies of TableDesc property values in
PartitionDesc
Key: HIVE-13057
URL: https://issues.apache.org/jira/browse/HIVE-13057
Project
Mohit Sabharwal created HIVE-13047:
--
Summary: Disabling Web UI leads to NullPointerException
Key: HIVE-13047
URL: https://issues.apache.org/jira/browse/HIVE-13047
Project: Hive
Issue Type
Mohit Sabharwal created HIVE-13045:
--
Summary: move guava dependency back to 14 after HIVE-12952
Key: HIVE-13045
URL: https://issues.apache.org/jira/browse/HIVE-13045
Project: Hive
Issue
Mohit Sabharwal created HIVE-12966:
--
Summary: Change some ZooKeeperHiveLockManager logs to debug
Key: HIVE-12966
URL: https://issues.apache.org/jira/browse/HIVE-12966
Project: Hive
Issue
Mohit Sabharwal created HIVE-12949:
--
Summary: Fix description of hive.server2.logging.operation.level
Key: HIVE-12949
URL: https://issues.apache.org/jira/browse/HIVE-12949
Project: Hive
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42777/#review116611
---
Ship it!
Ship It!
- Mohit Sabharwal
On Jan. 27, 2016, 7:38
peration/OperationManager.java
(line 341)
<https://reviews.apache.org/r/42777/#comment177506>
check for getSQLOperationInfo() returning null here.
- Mohit Sabharwal
On Jan. 26, 2016, 10:26 p.m., Szehon Ho wrote:
>
> ---
Mohit Sabharwal created HIVE-12705:
--
Summary: Java8 Jenkins jobs failing with "Error executing
HIVE-TRUNK-JAVA8-*"
Key: HIVE-12705
URL: https://issues.apache.org/jira/browse/HIVE-12705
Pro
Mohit Sabharwal created HIVE-12670:
--
Summary: Fix tests failing due to invalid ConnectionDriverName
Key: HIVE-12670
URL: https://issues.apache.org/jira/browse/HIVE-12670
Project: Hive
Issue
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41062/#review109581
---
Ship it!
LGTM
- Mohit Sabharwal
On Dec. 9, 2015, 4:35 p.m
)
<https://reviews.apache.org/r/41062/#comment168907>
should this be conditional on the cluster itself being kerberized ?
i.e.
if (UserGroupInformation.isSecurityEnabled()) {
}
- Mohit Sabharwal
On Dec. 8, 2015, 12:05 a.m., Jimmy Xiang
ogging since it's every 5 minutes, no ? Make it
DEBUG ? same for below..
- Mohit Sabharwal
On Dec. 4, 2015, 1:51 a.m., Szehon Ho wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
/CLIServiceTest.java
d90002bd16e46b5ce970d4c6c544a9c7605328d1
Diff: https://reviews.apache.org/r/40898/diff/
Testing
---
TestEmbeddedThriftBinaryCLIService#testGlobalCompileLockTimeout
Thanks,
Mohit Sabharwal
Lenni Kuff wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 1280
> > <https://reviews.apache.org/r/40898/diff/2/?file=1152869#file1152869line1280>
> >
> > Can we include the query text here?
Done.
- Mohit
--
d90002bd16e46b5ce970d4c6c544a9c7605328d1
Diff: https://reviews.apache.org/r/40898/diff/
Testing
---
TestEmbeddedThriftBinaryCLIService#testGlobalCompileLockTimeout
Thanks,
Mohit Sabharwal
/40898/diff/
Testing
---
TestEmbeddedThriftBinaryCLIService#testGlobalCompileLockTimeout
Thanks,
Mohit Sabharwal
/java/org/apache/hive/http/HttpServer.java (line 274)
<https://reviews.apache.org/r/40833/#comment168177>
(!b.useSSL) ?
- Mohit Sabharwal
On Dec. 2, 2015, 8:09 p.m., Jimmy Xiang wrote:
>
> ---
> This is an automatica
s.apache.org/r/40833/#comment168071>
Any reason why it shouldn't just default to what's specified in
HiveConf.HIVE_SERVER2_WEBUI_MAX_THREADS (which is 50) ?
- Mohit Sabharwal
On Dec. 1, 2015, 6:50 p.m., Jimmy Xiang wrote:
>
> ---
Mohit Sabharwal created HIVE-12561:
--
Summary: Add sentry jars to HS2 & HMS classpath
Key: HIVE-12561
URL: https://issues.apache.org/jira/browse/HIVE-12561
Project: Hive
Issue
Mohit Sabharwal created HIVE-12512:
--
Summary: Include driver logs in execution-level Operation logs
Key: HIVE-12512
URL: https://issues.apache.org/jira/browse/HIVE-12512
Project: Hive
Issue
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40549/#review107416
---
Ship it!
Ship It!
- Mohit Sabharwal
On Nov. 20, 2015, 8:39 p.m
> On Nov. 20, 2015, 7:30 p.m., Mohit Sabharwal wrote:
> > service/src/java/org/apache/hive/service/cli/operation/Operation.java, line
> > 56
> > <https://reviews.apache.org/r/40549/diff/1/?file=1134612#file1134612line56>
> >
> > what does MDC stand
these public ... only accessed in this class.
service/src/java/org/apache/hive/service/cli/operation/Operation.java (line 87)
<https://reviews.apache.org/r/40549/#comment166497>
is this conditional needed ?
- Mohit Sabharwal
On Nov. 20, 2015, 4:56 p.
> On Nov. 20, 2015, 4:53 a.m., Mohit Sabharwal wrote:
> > LGTM. This patch only includes SQLOperations. Are we planning to add
> > metadata operations as well ? (so we can capture jdbc clients and Hue usage
> > as well...)
>
> Jimmy Xiang wrote:
> Than
operation/OperationManager.java
(line 65)
<https://reviews.apache.org/r/40500/#comment166342>
any reason we only want sqloperations ?
- Mohit Sabharwal
On Nov. 19, 2015, 8:53 p.m., Jimmy Xiang wrote:
>
> ---
> This is an automa
Mohit Sabharwal created HIVE-11677:
--
Summary: Access to opHandleSet in HiveSession should be
synchronized
Key: HIVE-11677
URL: https://issues.apache.org/jira/browse/HIVE-11677
Project: Hive
Mohit Sabharwal created HIVE-11534:
--
Summary: Improve validateTableCols error message
Key: HIVE-11534
URL: https://issues.apache.org/jira/browse/HIVE-11534
Project: Hive
Issue Type
Mohit Sabharwal created HIVE-11133:
--
Summary: Support hive.explain.user for Spark
Key: HIVE-11133
URL: https://issues.apache.org/jira/browse/HIVE-11133
Project: Hive
Issue Type: Sub-task
estNegativeSparkCliDriver -Phadoop-2 -Dqfile=$line
-Dtest.output.overwrite=true; done
Thanks,
Mohit Sabharwal
,
Mohit Sabharwal
Mohit Sabharwal created HIVE-11099:
--
Summary: Add support for running negative q-tests [Spark Branch]
Key: HIVE-11099
URL: https://issues.apache.org/jira/browse/HIVE-11099
Project: Hive
/GenericUDFMonthsBetween.java
<https://reviews.apache.org/r/32489/#comment127019>
nit: cleaner to just say (31 * 24 * 60 * 60)
- Mohit Sabharwal
On March 31, 2015, 8:08 p.m., Alexander Pivovarov wrote:
>
> ---
> This is an automatica
u want to return null for dataStr.length() >
10 ?
As it stands now, long date+time string will get converted using:
Object writableValue = converters[i].convert(obj);
Timestamp ts = ((TimestampWritable) writableValue).getTimestamp();
return ts;
Is th
STRING_GROUP ?
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java
<https://reviews.apache.org/r/32489/#comment126505>
19...a comment on where this comes from would be great
- Mohit Sabharwal
On March 27, 2015, 12:58 a.m., Alexand
1 - 100 of 368 matches
Mail list logo
