----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40833/#review108613 -----------------------------------------------------------
LGTM. Thanks for adding the Builder! Couple of nits. common/src/java/org/apache/hive/http/HttpServer.java (line 268) <https://reviews.apache.org/r/40833/#comment168072> Nit: b.keyStorePath to determine ssl is not enabled looks bit unclean. Maybe add a useSsl boolean to the builder ? common/src/java/org/apache/hive/http/HttpServer.java (line 290) <https://reviews.apache.org/r/40833/#comment168073> Add back the comment /* Set servlet context attribute that can be used in jsp */ It wasn't clear to me this is related to jsp common/src/java/org/apache/hive/http/HttpServer.java (line 299) <https://reviews.apache.org/r/40833/#comment168071> Any reason why it shouldn't just default to what's specified in HiveConf.HIVE_SERVER2_WEBUI_MAX_THREADS (which is 50) ? - Mohit Sabharwal On Dec. 1, 2015, 6:50 p.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40833/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2015, 6:50 p.m.) > > > Review request for hive, Lefty Leverenz, Szehon Ho, and Xuefu Zhang. > > > Bugs: HIVE-12471 > https://issues.apache.org/jira/browse/HIVE-12471 > > > Repository: hive-git > > > Description > ------- > > This patch changed the HttpServer construction to use builder which is > flexible. It addes 3 configurations for web UI SSL support. By default, it is > disabled. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 9e805bd > common/src/java/org/apache/hive/http/HttpServer.java 1ff8d7c > service/src/java/org/apache/hive/service/server/HiveServer2.java 204eb5a > > Diff: https://reviews.apache.org/r/40833/diff/ > > > Testing > ------- > > Tested web UI with and without SSL, both work as expected. > > > Thanks, > > Jimmy Xiang > >
