> On July 14, 2016, 9:57 p.m., Vihang Karajgaonkar wrote: > > beeline/src/java/org/apache/hive/beeline/BufferedRows.java, line 76 > > <https://reviews.apache.org/r/49919/diff/2/?file=1442484#file1442484line76> > > > > Thanks for reviewing. I thought of adding it in the above loop like you > > mentioned, but then went against that for readability reasons since > > max.length should not be too big (it is numbers of columns in a row). I > > will add it now in the loop. > > > > btw, If we have to add it in the loop it should be > > Math.min(Math.max(max[j], row.sizes[j] + 1), maxColumnWidth); Did you > > mean the same?
Ah, right, that should me min not max. - Mohit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49919/#review142292 ----------------------------------------------------------- On July 12, 2016, 5:51 p.m., Vihang Karajgaonkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49919/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 5:51 p.m.) > > > Review request for hive, Mohit Sabharwal, Sergio Pena, Sahil Takiar, and > Thejas Nair. > > > Repository: hive-git > > > Description > ------- > > HIVE-14135 : beeline output not formatted correctly for large column widths > > > Diffs > ----- > > beeline/pom.xml a720d0835314221ec3bd9e8d354d148498ff794c > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java > 5aaa38527734d46de037352ff51e54e0ae1cede0 > beeline/src/java/org/apache/hive/beeline/BufferedRows.java > 962c5319bb7e6e448979e1cef80a086cadd2ecc6 > beeline/src/test/org/apache/hive/beeline/TestBufferedRows.java PRE-CREATION > > Diff: https://reviews.apache.org/r/49919/diff/ > > > Testing > ------- > > > Thanks, > > Vihang Karajgaonkar > >
