----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45525/ -----------------------------------------------------------
Review request for hive. Bugs: HIVE-12484 https://issues.apache.org/jira/browse/HIVE-12484 Repository: hive-git Description ------- HIVE-12484 : Show meta operations on HS2 web UI Expands display availablity to meta operations as well as "set" ("command") operations. Moves OperationDisplay to Operation level. Added getDisplayQuery() method for all meta operations to specify the query string to display in the UI. Diffs ----- itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestQueryDisplay.java 418f71eb87cdd519677b2f5a59c67099f704ec80 ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java d582bc063fc150002a01d63451ae6632fca29ac1 service/src/jamon/org/apache/hive/tmpl/QueryProfileTmpl.jamon 8d51a73f7ac6c5eb5fe44c5525ed840b641c5c6b service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java 8868ec18e0f50f6a434eb0498e4a923b0a151b97 service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java 35b6c5209025a0e9b5c3732493afd9d30d4f4a1f service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java 8db2e62604345a2d3b9193c497080f3f2977f2ac service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java d6f6280f1c398fa0239cb52070ff8c40168215bf service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java a09b39a4e0855152925085e46b2e0a703b32de7f service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java 740b85158a6008ecece592d72cd743d8f5a433f4 service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java 2a0fec27715daba4307f661a6f65c3cd4d43c975 service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java f5a9771449a7cc1fb5ac5c0b6f2fd6ab032a2162 service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java 285b4f94ec828a357da4c2e7dc96c64bd459ff80 service/src/java/org/apache/hive/service/cli/operation/Operation.java d9a273b1b95adf7a6a68fa013042da2408904d64 service/src/java/org/apache/hive/service/cli/operation/OperationDisplay.java PRE-CREATION service/src/java/org/apache/hive/service/cli/operation/OperationDisplayCache.java PRE-CREATION service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 56a9c18bc118b8d67f87e5500ec7d4442a90a869 service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 04d816a72afcadbff26f5eb5d68003a7344e31c9 service/src/java/org/apache/hive/service/cli/operation/SQLOperationDisplay.java d2ca1e7b79e9722ad0ce990e96bf3fc9297ca7fd service/src/java/org/apache/hive/service/cli/operation/SQLOperationDisplayCache.java 4a33d37a88a7216d832a5b9ab4b7534091129be7 service/src/java/org/apache/hive/service/servlet/QueryProfileServlet.java 8fa447a386c5a7a000b04453618f502e1681364e service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp 8b46550b603a51ba6143c36746029475d7e11a40 Diff: https://reviews.apache.org/r/45525/diff/ Testing ------- Tested with different sql, metadata and set operations. Added tests to TestQueryDisplay Thanks, Mohit Sabharwal