----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61244/ -----------------------------------------------------------
Review request for hive. Bugs: HIVE-15305 https://issues.apache.org/jira/browse/HIVE-15305 Repository: hive-git Description ------- HIVE-15232 reused TestDbNotificationListener to test METASTORE_TRANSACTIONAL_EVENT_LISTENERS and removed unit testing of METASTORE_EVENT_LISTENERS config. We should test both. Diffs ----- hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java 351546c3bc9edb69a435f04795b5ea6c3421f5b0 itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 35989f5b09d016ebde1c9953893f145cae414e42 itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java c36b632fd17791f00c9b69247a520a1bed22a337 itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestNonTransactionalDbNotificationListener.java PRE-CREATION itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestTransactionalDbNotificationListener.java PRE-CREATION Diff: https://reviews.apache.org/r/61244/diff/1/ Testing ------- Thanks, Mohit Sabharwal