Re: Review Request 72553: HIVE-23555 Cancel compaction jobs when hive.compactor.worker.timeout is reached

2020-05-29 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72553/#review220913 --- Ship it! Ship It! - Laszlo Pinter On May 28, 2020, 8:58 a.m.

Re: Review Request 71812: HIVE-22534: ACID: Improve Compactor thread logging

2020-04-02 Thread Laszlo Pinter via Review Board
> On March 27, 2020, 2:23 p.m., Karen Coppage wrote: > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java > > Lines 374-375 (original), 360-361 (patched) > > > > > > Not regression, but it looks lik

Review Request 72291: HIVE-23107: Remove MIN_HISTORY_LEVEL table

2020-03-31 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72291/ --- Review request for hive and Peter Vary. Repository: hive-git Description

Re: Review Request 71812: HIVE-22534: ACID: Improve Compactor thread logging

2020-03-26 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71812/ --- (Updated March 26, 2020, 2:43 p.m.) Review request for hive and Karen Coppage.

Review Request 72193: HIVE-22977: Merge delta files instead of running a query in major/minor compaction

2020-03-04 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72193/ --- Review request for hive, Karen Coppage and Peter Vary. Repository: hive-git D

Re: Review Request 72043: HIVE-21487: COMPLETED_COMPACTIONS and COMPACTION_QUEUE table missing appropriate indexes

2020-02-25 Thread Laszlo Pinter via Review Board
> On Jan. 31, 2020, 9:52 a.m., Peter Vary wrote: > > Have you tested the sqls on every db? > > If they run correctly on all supported DB, then +1 from my side > > > > Thanks, > > Peter Run tests on derby, mssql, mysql, oracle and postgres. All passed. - Laszlo --

Re: Review Request 72145: HIVE-21543: Use FilterHooks for show compactions

2020-02-17 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72145/ --- (Updated Feb. 17, 2020, 3:30 p.m.) Review request for hive, Karen Coppage and P

Re: Review Request 72109: HIVE-20948: Eliminate file rename in compactor

2020-02-17 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72109/ --- (Updated Feb. 17, 2020, 12:53 p.m.) Review request for hive, Karen Coppage, Mar

Review Request 72145: HIVE-21543: Use FilterHooks for show compactions

2020-02-17 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72145/ --- Review request for hive, Karen Coppage and Peter Vary. Repository: hive-git D

Re: Review Request 72105: HIVE-22610: Minor compaction for MM (insert-only) tables

2020-02-12 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72105/#review219570 --- Ship it! Ship It! - Laszlo Pinter On Feb. 12, 2020, 3:23 p.m

Re: Review Request 72105: HIVE-22610: Minor compaction for MM (insert-only) tables

2020-02-12 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72105/#review219569 --- Ship it! Ship It! - Laszlo Pinter On Feb. 12, 2020, 3:23 p.m

Review Request 72109: HIVE-20948: Eliminate file rename in compactor

2020-02-11 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72109/ --- Review request for hive, Karen Coppage, Marta Kuczora, and Peter Vary. Reposito

Re: Review Request 72028: HIVE-22729: Provide a failure reason for failed compactions

2020-01-30 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72028/ --- (Updated Jan. 30, 2020, 10:23 a.m.) Review request for hive, Denys Kuzmenko, Ka

Review Request 72059: HIVE-22793: Update default settings in HMS Benchmarking tool

2020-01-30 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72059/ --- Review request for hive, Denys Kuzmenko, Karen Coppage, and Peter Vary. Reposit

Re: Review Request 72028: HIVE-22729: Provide a failure reason for failed compactions

2020-01-29 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72028/ --- (Updated Jan. 29, 2020, 9:20 a.m.) Review request for hive, Denys Kuzmenko, Kar

Review Request 72043: HIVE-21487: COMPLETED_COMPACTIONS and COMPACTION_QUEUE table missing appropriate indexes

2020-01-24 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72043/ --- Review request for hive, Denys Kuzmenko, Karen Coppage, and Peter Vary. Reposit

Review Request 72028: HIVE-22729: Provide a failure reason for failed compactions

2020-01-20 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72028/ --- Review request for hive, Denys Kuzmenko, Karen Coppage, and Peter Vary. Reposit

Re: Review Request 71988: HIVE-22703: Compaction configuration check when starting HMS/HS2

2020-01-15 Thread Laszlo Pinter via Review Board
> On Jan. 13, 2020, 2:37 p.m., Denys Kuzmenko wrote: > > service/src/java/org/apache/hive/service/server/HiveServer2.java > > Lines 437 (patched) > > > > > > do we have constant for "hs2" literal? For "hs2" no, just

Re: Review Request 71888: HIVE-22568: Process compaction candidates in parallel by the Initiator

2020-01-13 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71888/#review219239 --- Ship it! +1 (non-binding) - Laszlo Pinter On Dec. 6, 2019, 1

Review Request 71988: HIVE-22703: Compaction configuration check when starting HMS/HS2

2020-01-13 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71988/ --- Review request for hive, Denys Kuzmenko, Karen Coppage, and Peter Vary. Reposit

Re: Review Request 71949: HIVE-20934: ACID: Query based compactor for minor compaction

2020-01-08 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71949/ --- (Updated Jan. 8, 2020, 10:40 a.m.) Review request for hive, Denys Kuzmenko, Kar

Re: Review Request 71949: HIVE-20934: ACID: Query based compactor for minor compaction

2020-01-08 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71949/#review219172 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/SplitGrouper.java

Review Request 71963: HIVE-22700: Compactions may leak memory when unauthorized

2020-01-07 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71963/ --- Review request for hive, Denys Kuzmenko, Karen Coppage, and Peter Vary. Reposit

Re: Review Request 71949: HIVE-20934: ACID: Query based compactor for minor compaction

2020-01-07 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71949/ --- (Updated Jan. 7, 2020, 2:24 p.m.) Review request for hive, Denys Kuzmenko, Kare

Re: Review Request 71949: HIVE-20934: ACID: Query based compactor for minor compaction

2020-01-07 Thread Laszlo Pinter via Review Board
> On Jan. 7, 2020, 10:21 a.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/SplitGrouper.java > > Lines 282 (patched) > > > > > > I do not see this in the original code. What is this for? I m

Review Request 71949: HIVE-20934: ACID: Query based compactor for minor compaction

2020-01-04 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71949/ --- Review request for hive, Denys Kuzmenko, Karen Coppage, and Peter Vary. Reposit

Review Request 71948: HIVE-22535: ACID: Check for already running compactions in Worker

2020-01-03 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71948/ --- Review request for hive. Repository: hive-git Description --- HIVE-22535

Re: Review Request 71918: HIVE-22651: Fix TestCrudCompactorOnTez#testCompactionWithSchemaEvolutionNoBucketsMultipleReducers()

2019-12-30 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71918/#review219108 --- Ship it! Ship It! - Laszlo Pinter On Dec. 16, 2019, 1:53 p.m

Review Request 71844: HIVE-22554: ACID: Wait timeout for blocking compaction should be configurable

2019-11-28 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71844/ --- Review request for hive and Peter Vary. Repository: hive-git Description

Review Request 71812: HIVE-22534: ACID: Improve Compactor thread logging

2019-11-25 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71812/ --- Review request for hive, Denys Kuzmenko and Peter Vary. Repository: hive-git

Re: Review Request 71792: COMPLETED_TXN_COMPONENTS table is never cleaned up unless Compactor runs

2019-11-22 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71792/#review218754 --- Ship it! Lgtm +1 - Laszlo Pinter On Nov. 21, 2019, 5:35 p.m.

Review Request 71775: HIVE-22280: Q tests for partitioned temporary tables

2019-11-20 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71775/ --- Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. Repository:

Review Request 71745: HIVE-22473: Avoid reading table as ACID when table name is starting with delta, but table is not transactional

2019-11-10 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71745/ --- Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. Repository:

Review Request 71744: HIVE-22279: Enable temporary table partitioning

2019-11-10 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71744/ --- Review request for hive. Repository: hive-git Description --- HIVE-22279

Re: Review Request 71671: HIVE-22401: Refactor CompactorMR

2019-10-31 Thread Laszlo Pinter via Review Board
> On Oct. 28, 2019, 5:44 p.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMajorQueryCompactor.java > > Lines 85-87 (patched) > > > > > > Maybe this should be checked outside? This is s

Review Request 71671: HIVE-22401: Refactor CompactorMR

2019-10-24 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71671/ --- Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. Repository:

Review Request 71586: HIVE-22230: Add support for filtering partitions on temporary tables.

2019-10-06 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71586/ --- Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. Repository:

Review Request 71574: HIVE-22212: Implement append partition related methods on temporary tables

2019-10-02 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71574/ --- Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. Repository:

Re: Review Request 71550: HIVE-22137: Implement alter/rename partition related methods on temporary tables

2019-10-02 Thread Laszlo Pinter via Review Board
> On Sept. 26, 2019, 5:24 p.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/PartitionTree.java > > Lines 208-210 (patched) > > > > > > What happens when one of the alter partition fails only?

Review Request 71550: HIVE-22137: Implement alter/rename partition related methods on temporary tables

2019-09-26 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71550/ --- Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. Repository:

Re: Review Request 71506: HIVE-22084: Implement exchange partitions related methods on temporary tables.

2019-09-23 Thread Laszlo Pinter via Review Board
> On Sept. 23, 2019, 11:34 a.m., Peter Vary wrote: > > Thanks Laszlo! > > Few quick questions below. > > We might want to test the cross exchange methods as well (exchange > > partition between temp and non-temp tables) > > > > Otherwise LGTM Thanks Peter for the review, highly appreciate it!

Review Request 71506: HIVE-22084: Implement exchange partitions related methods on temporary tables.

2019-09-18 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71506/ --- Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. Repository:

Re: Review Request 71243: HIVE-21875: Implement drop partition related methods on temporary tables.

2019-09-16 Thread Laszlo Pinter via Review Board
> On Sept. 16, 2019, 11:24 a.m., Gergely Hankó wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > > Lines 948-952 (patched) > > > > > > This can be simplified to: > > `ret

Re: Review Request 71243: HIVE-21875: Implement drop partition related methods on temporary tables.

2019-09-16 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71243/ --- (Updated Sept. 16, 2019, 12:39 p.m.) Review request for hive, Marta Kuczora, Pe

Review Request 71243: HIVE-21875: Implement drop partition related methods on temporary tables.

2019-08-07 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71243/ --- Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. Repository:

Re: Review Request 71011: HIVE:21957: Create temporary table like should omit transactional properties.

2019-07-25 Thread Laszlo Pinter via Review Board
> On July 18, 2019, noon, Marta Kuczora wrote: > > Thanks a lot for the patch! > > Just one question: could you add a test about the fixed use-case? I will add test in a separate patch. - Laszlo --- This is an automatically generated e-

Review Request 71011: HIVE:21957: Create temporary table like should omit transactional properties.

2019-07-04 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71011/ --- Review request for hive, Marta Kuczora and Thejas Nair. Repository: hive-git

Re: Review Request 70963: HIVE-21874: Implement add partitions related methods on temporary table

2019-07-01 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70963/ --- (Updated July 1, 2019, 9:20 a.m.) Review request for hive, Marta Kuczora, Peter

Re: Review Request 70963: HIVE-21874: Implement add partitions related methods on temporary table

2019-07-01 Thread Laszlo Pinter via Review Board
> On June 28, 2019, 2:42 p.m., Marta Kuczora wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > > Line 1046 (original), 1049-1050 (patched) > > > > > > Why do you need to mak

Review Request 70963: HIVE-21874: Implement add partitions related methods on temporary table

2019-06-27 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70963/ --- Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. Repository:

Re: Review Request 70934: HIVE-18735: Create table like loses transactional attribute.

2019-06-25 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70934/ --- (Updated June 25, 2019, 12:47 p.m.) Review request for hive, Eugene Koifman, Ma

Review Request 70934: HIVE-18735: Create table like loses transactional attribute.

2019-06-24 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70934/ --- Review request for hive, Eugene Koifman, Marta Kuczora, Peter Vary, and Adam Szi

Re: Review Request 70867: HIVE-21814: Implement list partitions related methods on temporary tables

2019-06-20 Thread Laszlo Pinter via Review Board
> On June 19, 2019, 9:39 a.m., Marta Kuczora wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > > Lines 1250-1255 (patched) > > > > > > This code piece is used in multiple me

Re: Review Request 70867: HIVE-21814: Implement list partitions related methods on temporary tables

2019-06-20 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70867/ --- (Updated June 20, 2019, 9:53 a.m.) Review request for hive, Marta Kuczora, Pete

Review Request 70867: HIVE-21814: Implement list partitions related methods on temporary tables

2019-06-17 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70867/ --- Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. Repository:

Review Request 70850: HIVE-21812: Implement get partition related methods on temporary tables

2019-06-13 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70850/ --- Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. Repository:

Re: Review Request 69341: HIVE-20891: Call alter_partition in batch when dynamically loading partitions

2018-12-05 Thread Laszlo Pinter via Review Board
> On Dec. 4, 2018, 10:08 p.m., Bharathkrishna Guruvayoor Murali wrote: > > Hi, the patch looks good, I just had a quick question. Does this mean that > > all the alters happen in one transaction? Will it prevent concurrent > > operations for the whole time a large number of partitions are alter

Re: Review Request 69341: HIVE-20891: Call alter_partition in batch when dynamically loading partitions

2018-11-30 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69341/ --- (Updated Nov. 30, 2018, 11:31 a.m.) Review request for hive. Repository: hive

Review Request 69341: HIVE-20891: Call alter_partition in batch when dynamically loading partitions

2018-11-15 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69341/ --- Review request for hive. Repository: hive-git Description --- HIVE-20891

Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

2018-10-26 Thread Laszlo Pinter via Review Board
> On Oct. 25, 2018, 4:44 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java > > Lines 1176 (patched) > > > > > > Nit:

Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

2018-10-26 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69167/ --- (Updated Oct. 26, 2018, 10:34 a.m.) Review request for hive and Peter Vary. R

Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

2018-10-26 Thread Laszlo Pinter via Review Board
> On Oct. 25, 2018, 4:48 p.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java > > Lines 1163 (patched) > > > > > > Stri

Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

2018-10-26 Thread Laszlo Pinter via Review Board
> On Oct. 25, 2018, 10:46 p.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java > > Lines 1172 (patched) > > > > > > Cou

Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

2018-10-25 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69167/ --- Review request for hive and Peter Vary. Repository: hive-git Description

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-19 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68975/ --- (Updated Oct. 19, 2018, 8:30 a.m.) Review request for hive and Peter Vary. Re

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-18 Thread Laszlo Pinter via Review Board
> On Oct. 18, 2018, 9:13 a.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > > Lines 1921 (patched) > > > > > > nit: one extra space done. > On Oct. 18, 2018, 9:13 a.m., Peter V

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-18 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68975/ --- (Updated Oct. 18, 2018, 7:01 a.m.) Review request for hive and Peter Vary. Re

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-17 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68975/ --- (Updated Oct. 17, 2018, 1:44 p.m.) Review request for hive and Peter Vary. Re

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-13 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68975/ --- (Updated Oct. 13, 2018, 9:55 a.m.) Review request for hive and Peter Vary. Re

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-13 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68975/ --- (Updated Oct. 13, 2018, 7:56 a.m.) Review request for hive and Peter Vary. Re

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-13 Thread Laszlo Pinter via Review Board
> On Oct. 11, 2018, 8:54 a.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > > Lines 1896 (patched) > > > > > > What does this method do? > > Moving files and updating partitio

Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-10 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68975/ --- Review request for hive and Peter Vary. Repository: hive-git Description

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-24 Thread Laszlo Pinter via Review Board
> On Sept. 20, 2018, 10:56 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Lines 316 (patched) > > > > > > 1) Does setO

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-24 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68767/ --- (Updated Sept. 24, 2018, 12:16 p.m.) Review request for hive, Alexander Kolbaso

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-21 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68767/ --- (Updated Sept. 21, 2018, 3:21 p.m.) Review request for hive, Alexander Kolbasov

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-21 Thread Laszlo Pinter via Review Board
> On Sept. 20, 2018, 10:56 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Lines 316 (patched) > > > > > > 1) Does setO

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-21 Thread Laszlo Pinter via Review Board
> On Sept. 20, 2018, 10:56 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Line 316 (original), 315 (patched) > > > > > >

Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-19 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68767/ --- Review request for hive, Alexander Kolbasov, Peter Vary, and Vihang Karajgaonkar

Review Request 68765: HIVE-20595: Add findbugs-exclude.xml to metastore-server

2018-09-19 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68765/ --- Review request for hive, Alexander Kolbasov, Peter Vary, and Vihang Karajgaonkar

Re: Review Request 68710: HIVE-20544: TOpenSessionReq logs password and username

2018-09-14 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68710/#review208621 --- Ship it! LGTM +! (non-binding) - Laszlo Pinter On Sept. 13,

Re: Review Request 68630: HIVE-20420: Provide a fallback authorizer when no other authorizer is in use

2018-09-12 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68630/#review208550 --- Ship it! Thanks for uploading a new patch. LGTM +1 - Laszlo Pi

Review Request 68656: HIVE-20505: upgrade org.openjdk.jmh:jmh-core to 1.21

2018-09-06 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68656/ --- Review request for hive. Repository: hive-git Description --- HIVE-20505

Re: Review Request 68630: HIVE-20420: Provide a fallback authorizer when no other authorizer is in use

2018-09-06 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68630/#review208398 --- ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plug