> On Sept. 20, 2018, 10:56 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Lines 316 (patched) > > <https://reviews.apache.org/r/68767/diff/1/?file=2090314#file2090314line318> > > > > 1) Does setObject() work OK on all the jdbc drivers that are supported? > > In the oast I have seen cases where it was necessary to dispatch to the > > correct method like setString, setInt > > 2) can the params over be null? Do we need to call setNull instead of > > setObject()? Again we need to consider all the drivers. > > Laszlo Pinter wrote: > 1) The jdbc driver will do the type checking. A slight disadvantage is > the minor overhead, but this is negligible as compared to the better > maitainable code you end up with. > 2) You're correct, I have to make sure that the params[i] is not null or > use setNull instead.
So I did a bit more of a debugging, and my previous comment about the params[i] can be null is not correct. The params can contain partitionIds, storageDescriptorIds, columnDescriptorIds, serdeIds, depeding from where the executeNoResult() is called. These fields are mandatory and cannot be null. If any of these items are null, means that the metastore db is not consistent and it was corrupted. - Laszlo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68767/#review208821 ----------------------------------------------------------- On Sept. 19, 2018, 9:46 a.m., Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68767/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2018, 9:46 a.m.) > > > Review request for hive, Alexander Kolbasov, Peter Vary, and Vihang > Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > HIVE-20551: Create PreparedStatement query dynamically when IN clause is used > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 571c789eddfd2b1a27c65c48bdc6dccfafaaf676 > > > Diff: https://reviews.apache.org/r/68767/diff/1/ > > > Testing > ------- > > > Thanks, > > Laszlo Pinter > >
