> On June 28, 2019, 2:42 p.m., Marta Kuczora wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > > Line 1046 (original), 1049-1050 (patched) > > <https://reviews.apache.org/r/70963/diff/1/?file=2152472#file2152472line1049> > > > > Why do you need to make the DB and Table name lower case?
Partition properties like table and db name must be stored in lower case. This is the same in HiveMestarore as well. Other properties are case sensitive. > On June 28, 2019, 2:42 p.m., Marta Kuczora wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > > Lines 1100 (patched) > > <https://reviews.apache.org/r/70963/diff/1/?file=2152472#file2152472line1100> > > > > Why is it needed to get the newly added partition from the "parts" list > > as the addPartition method returns the newly added Partition? Good catch, corrected it. - Laszlo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70963/#review216227 ----------------------------------------------------------- On June 27, 2019, 9:07 a.m., Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70963/ > ----------------------------------------------------------- > > (Updated June 27, 2019, 9:07 a.m.) > > > Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. > > > Repository: hive-git > > > Description > ------- > > HIVE-21874: Implement add partitions related methods on temporary table > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > 957ebb12725e9deac7e7644709521a998df4dbb4 > > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientAddPartitionsFromSpecTempTable.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientAddPartitionsTempTable.java > PRE-CREATION > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java > a15f5ea0453c7459217d229fa373cc1fec2f4d7a > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitionsFromPartSpec.java > 25643495b53e1ede473c48a90b208b43070ee6aa > > > Diff: https://reviews.apache.org/r/70963/diff/1/ > > > Testing > ------- > > Unit testing is done via > TestSessionHiveMetastoreClientAddPartitionsTempTable, > TestSessionHiveMetastoreClientAddPartitionsFromSpecTempTable. > > > Thanks, > > Laszlo Pinter > >
