> On Sept. 16, 2019, 11:24 a.m., Gergely Hankó wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > > Lines 948-952 (patched) > > <https://reviews.apache.org/r/71243/diff/1/?file=2160058#file2160058line949> > > > > This can be simplified to: > > `return tableParameters != null && > > "true".equals(tableParameters.get(EXTERNAL_PARAM));` > > > > It is more compact and also spares a query on the map.
Did the change. Thanks for the review. - Laszlo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71243/#review217753 ----------------------------------------------------------- On Sept. 16, 2019, 12:39 p.m., Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71243/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2019, 12:39 p.m.) > > > Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. > > > Repository: hive-git > > > Description > ------- > > HIVE-21875: Implement drop partition related methods on temporary tables. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > a2c84b4620fb1eb90069e294204f604565ffed9b > > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientDropPartitionsTempTable.java > PRE-CREATION > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestDropPartitions.java > 91c9edac95e9f9688dd2b806aeeb0823af02574f > > > Diff: https://reviews.apache.org/r/71243/diff/2/ > > > Testing > ------- > > Unit testing is done via > TestSessionHiveMetastoreClientDropPartitionsTempTable.java > > > Thanks, > > Laszlo Pinter > >
