> On Sept. 23, 2019, 11:34 a.m., Peter Vary wrote: > > Thanks Laszlo! > > Few quick questions below. > > We might want to test the cross exchange methods as well (exchange > > partition between temp and non-temp tables) > > > > Otherwise LGTM
Thanks Peter for the review, highly appreciate it! I addressed all the review findings and added a couple more test to cover the mentioned scenario as well. - Laszlo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71506/#review217910 ----------------------------------------------------------- On Sept. 18, 2019, 2:10 p.m., Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71506/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2019, 2:10 p.m.) > > > Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. > > > Repository: hive-git > > > Description > ------- > > HIVE-22084: Implement exchange partitions related methods on temporary tables. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > 506bf5dfa8404f3645b8c5db7ea19c0b4add33a7 > > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientExchangePartitionsTempTable.java > PRE-CREATION > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestExchangePartitions.java > 1a2b7e4f9f7562e84006e86061b482d1b535197c > > > Diff: https://reviews.apache.org/r/71506/diff/4/ > > > Testing > ------- > > > Thanks, > > Laszlo Pinter > >
