On 12/11, Ferruh Yigit wrote:
>On 12/11/2018 5:25 PM, Didier Pallard wrote:
>> This reverts
>> commit 09a62d75691f ("net/i40e: fix offload not supported mask")
>>
>> Contrary to what is said in above patch commit log,
>> I40E_TX_OFFLOAD_NOTSUP_MASK is the mask of Tx offload bits that are part
>> o
Hi, Ferruh,
On 10/02, Ferruh Yigit wrote:
>On 9/28/2018 10:47 PM, Xiaolong Ye wrote:
>> It's used to get number of available registered vDPA devices.
>>
>> Signed-off-by: Xiaolong Ye
>> Acked-by: Xiao Wang
>> Reviewed-by: Maxime Coquelin
>> ---
>> lib/librte_vhost/rte_vdpa.h| 3 ++
Hi, Ferruh,
On 10/02, Ferruh Yigit wrote:
>On 9/28/2018 10:47 PM, Xiaolong Ye wrote:
>> The vdpa sample application creates vhost-user sockets by using the
>> vDPA backend. vDPA stands for vhost Data Path Acceleration which utilizes
>> virtio ring compatible devices to serve virtio driver directly
On 10/03, Maxime Coquelin wrote:
>
>
>On 10/03/2018 09:34 PM, Xiaolong Ye wrote:
>> rte_strscpy is safer to use.
>>
>> Signed-off-by: Xiaolong Ye
>> ---
>> examples/vdpa/main.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>
>Reviewed-by: Maxime Coquelin
>
>I'll squash it
Acked-by: Ye Xiaolong
Thanks,
Xiaolong
On 09/25, Xiao Wang wrote:
>The address translation from user virtual address to guest physical
>address should not be named as qva_to_gpa.
>
>Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
>
>Signed-off-by: Xiao
On 10/11, Ferruh Yigit wrote:
>On 10/10/2018 10:14 AM, Xiaolong Ye wrote:
>> As APIs in rte_vdpa.h are public, we need to add doxygen comments
>> to all APIs and structures.
>>
>> Signed-off-by: Xiaolong Ye
>
><...>
>
>> @@ -29,6 +32,9 @@ struct rte_vdpa_dev_addr {
>> };
>> };
>>
>> +/**
On 10/23, Beilei Xing wrote:
>Tx offload mask is updated in following commit:
>commit 1037ed842c37 ("mbuf: fix Tx offload mask").
>Currently, the new added offload flags will be
>not supported in PMD and application will fail
Shouldn't it be "the new added offlaod flags are not supported in PMD an
On 10/25, Zhirun Yan wrote:
>Tx offload mask is updated in following commit:
>commit 1037ed842c37 ("mbuf: fix Tx offload mask")
>Currently, the new added offload flags will be
s/will be/are
Thanks,
Xiaolong
>not supported in PMD and application will fail to
>call PMD transmit prepare function.
>
ine IXGBE_TX_OFFLOAD_MASK (\
>+ PKT_TX_OUTER_IPV6 | \
>+ PKT_TX_OUTER_IPV4 | \
>+ PKT_TX_IPV6 |\
>+ PKT_TX_IPV4 |\
> PKT_TX_VLAN_PKT |\
>
Hi, Ferruh
On 11/02, Ferruh Yigit wrote:
>On 10/27/2018 11:40 AM, Xiaolong Ye wrote:
>> Hi,
>>
>> This patch series is to correct the wrong setting of
>> XXX_TX_OFFLOAD_MASK in multiple PMDs.
>>
>> Just as the name XXX_TX_OFFLOAD_NOTSUP_MASK indicates, it should be the
>> mask of unsupported fea
Hi, Rosen.
Thanks a lot for your comments.
On 09/06, Rami Rosen wrote:
>Hi all,
>First, thanks for the vdpa example patches.
>Second, I am getting a compilation error under Ubuntu 18.04, with gcc
>version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)
>...
> CC main.o
>/work/src/dpdk/examples/vdpa/main.c: In fu
Maxime Coquelin ; Bie,
>> Tiwei ; Wang, Zhihong
>> Cc: Wang, Xiao W ; Ye, Xiaolong
>>
>> Subject: [dpdk-dev] [PATCH v1 2/2] examples/vdpa: add a new sample for vdpa
>>
>> From: Xiao Wang
>>
>> This patch adds a sample which creates vhost-user socke
Hi, Xiao
On 09/10, Xiao Wang wrote:
>Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
Could you help describe what problem is without this fix in commit log?
Thanks,
Xiaolong
>
>Signed-off-by: Xiao Wang
>---
> drivers/net/ifc/ifcvf_vdpa.c | 8
> 1 file changed, 4 insertions(+),
On 09/13, Wang, Xiao W wrote:
>Hi Xiaolong,
>
>> -Original Message-----
>> From: Ye, Xiaolong
>> Sent: Thursday, September 13, 2018 8:55 PM
>> To: Wang, Xiao W
>> Cc: Bie, Tiwei ; dev@dpdk.org
>> Subject: Re: [PATCH] net/ifc: do not notify before HW r
Reviewed-and-Tested-by: Ye Xiaolong
Thanks,
Xiaolong
On 09/10, Xiao Wang wrote:
>IFCVF can help to log dirty page in live migration stage,
>each queue's index can be read and configured to support
>VHOST_USER_GET_VRING_BASE and VHOST_USER_SET_VRING_BASE.
>
>Sign
Looks good to me.
Reviewed-by: Ye Xiaolong
Thanks,
Xiaolong
On 09/14, Xiao Wang wrote:
>If the device is not clearly reset by the previous driver and holds
>some invalid ring addr, and the relay thread kicks it before HW is
>properly re-configured, a bad DMA request may happen.
>
&
On 09/19, Wang, Xiao W wrote:
>Hi,
>
>> -Original Message-----
>> From: Ye, Xiaolong
>> Sent: Friday, September 14, 2018 2:07 AM
>> To: dev@dpdk.org; Maxime Coquelin ; Bie,
>> Tiwei ; Wang, Zhihong
>> Cc: Wang, Xiao W ; Rami Rosen
>> ; Wang, Hai
On 09/19, Wang, Xiao W wrote:
>Hi Xiaolong,
>
[snip]
>> +.. note::
>> +We need to bind VFIO-pci to VFs before running vdpa sample.
>
>Replace "VFIO-pci" with "vfio-pci".
Got it.
>
>> +
>> +* modprobe vfio-pci
>> +* ./usertools/dpdk-devbind.py -b vfio-pci 06:00.2 06:00.3
>> +
>> +Then
On 09/21, Wang, Xiao W wrote:
>Hi Xiaolong,
>
>> -Original Message-----
>> From: Ye, Xiaolong
>> Sent: Friday, September 21, 2018 6:28 AM
>> To: dev@dpdk.org; Maxime Coquelin ; Bie,
>> Tiwei ; Wang, Zhihong
>> Cc: Wang, Xiao W ; Rami Rosen
>&
On 09/24, Wang, Xiao W wrote:
>Hi Xiaolong,
>
>Thanks for the update, 2 small comments below.
>
[snip]
>> +./vdpa --log-level=9 -c 0x6 -n 4 --socket-mem 1024,1024 \
>> +-w :06:00.3,vdpa=1 -w :06:00.4,vdpa=1 \
>> +-- --interactive
>
>To demonstrate app
On 09/27, Maxime Coquelin wrote:
[snip]
>> +devcnt = 0;
>This isn't needed as it is static.
>
>> +interactive = 0;
>Ditto
>
>> +memset(iface, 0, sizeof(iface));
>Ditto
>
>> +memset(vports, 0, sizeof(vports));
>And this one too when it will be made static.
>
>
>Appart these small com
On 09/28, Maxime Coquelin wrote:
>> +ret = rte_eal_init(argc, argv);
>> +if (ret < 0)
>> +rte_exit(EXIT_FAILURE, "eal init failed\n");
>> +argc -= ret;
>> +argv += ret;
>> +
>> +data_init();
>
>You need to check return from data_init().
>If this is fine for you, I ca
On 09/28, Maxime Coquelin wrote:
>
>
>On 09/28/2018 04:33 PM, Ye Xiaolong wrote:
>> On 09/28, Maxime Coquelin wrote:
>> > > +ret = rte_eal_init(argc, argv);
>> > > +if (ret < 0)
>> > > +rte_exit(EXIT_FAIL
On 09/28, Maxime Coquelin wrote:
>
>
>On 09/28/2018 05:17 PM, Ye Xiaolong wrote:
>> On 09/28, Maxime Coquelin wrote:
>> >
>> >
>> > On 09/28/2018 04:33 PM, Ye Xiaolong wrote:
>> > > On 09/28, Maxime Coquelin wrote:
>> > > &g
On 01/11, Tiwei Bie wrote:
>> vhost_user: remove statement for non-existed function
>
>s/vhost_user/vhost/
>
>On Fri, Jan 11, 2019 at 04:05:41PM +0800, Xiaolong Ye wrote:
>> vhost_user_host_notifier_ctrl is not existed anymore, its statement in
>> header file should be removed accordingly.
>>
>> F
Hi,
On 01/11, sunwenjie wrote:
>When rte_vhost_driver_unregister delete the connection fd,
>fdset_try_del will always try and donot release the
>vhostuser.mutex if the fd is busy, but the fdset_event_dispatch
>will set the fd to busy and call vhost_user_msg_handler to get
>vh
On 01/15, Burakov, Anatoly wrote:
>On 15-Jan-19 3:46 PM, Xiaolong Ye wrote:
>> The comment for igbuio_pci_irqhandler is out of date as the code evolves,
>> remove it to avoid misleading.
>>
>> Signed-off-by: Xiaolong Ye
>> ---
>> kernel/linux/igb_uio/igb_uio.c | 5 -
>> 1 file changed, 5 d
On 01/15, Stephen Hemminger wrote:
>On Wed, 16 Jan 2019 08:34:52 +0800
>Xiaolong Ye wrote:
>
>> The comment for igbuio_pci_irqhandler is out of date as the code evolves,
>> remove it to avoid misleading.
>>
>> Signed-off-by: Xiaolong Ye
>> ---
>> kernel/linux/igb_uio/igb_uio.c | 4
>> 1 fi
Hi, Stephen
On 01/15, Stephen Hemminger wrote:
>On Wed, 16 Jan 2019 08:34:52 +0800
>Xiaolong Ye wrote:
>
>> The comment for igbuio_pci_irqhandler is out of date as the code evolves,
>> remove it to avoid misleading.
>>
>> Signed-off-by: Xiaolong Ye
>> ---
>> kernel/linux/igb_uio/igb_uio.c | 4
On 01/16, Stephen Hemminger wrote:
>On Wed, 16 Jan 2019 15:48:36 +0800
>Ye Xiaolong wrote:
>
>> Hi, Stephen
>>
>> On 01/15, Stephen Hemminger wrote:
>> >On Wed, 16 Jan 2019 08:34:52 +0800
>> >Xiaolong Ye wrote:
>> >
>> >>
On 01/17, Andy Pei wrote:
>fix a typo and delete code of unused function
>
>Cc: andy@intel.com
>Cc: rosen...@intel.com
>Cc: tianfei.zh...@intel.com
>
>Signed-off-by: Andy Pei
>---
> drivers/raw/ifpga_rawdev/base/opae_hw_api.c | 24 +---
> 1 file changed, 1 insertion(+), 23 d
Hi,
On 01/17, Shahaf Shuler wrote:
>Hi,
>
>Going back to this merged commit,
>
>Saturday, September 29, 2018 12:48 AM, Xiaolong Ye:
>> Subject: [dpdk-dev] [PATCH v8 2/2] examples/vdpa: introduce a new sample
>> for vDPA
>>
>> The vdpa sample application creates vhost-user sockets by using the v
Hi, Stephen
On 01/17, Ye Xiaolong wrote:
>On 01/16, Stephen Hemminger wrote:
>>On Wed, 16 Jan 2019 15:48:36 +0800
>>Ye Xiaolong wrote:
>>
>>> Hi, Stephen
>>>
>>> On 01/15, Stephen Hemminger wrote:
>>> >On Wed, 16 Jan 2019 08:34:52 +
Hi, Ferruh
On 01/29, Ferruh Yigit wrote:
[snip]
>
>Hi Xiaolong,
>
>Your analysis looks correct, thanks for history provided, it seems renaming
>"state" to "status" was not correct [1].
>
>The intention of the 'pci_check_and_mask_intx()' is mask the interrupt if it is
>from this device, so your sug
Hi,
On 03/01, Stephen Hemminger wrote:
>On Fri, 1 Mar 2019 16:09:47 +0800
>Xiaolong Ye wrote:
>
>> When create rte_mempool, flags can be parsed from command line.
>> Now, it is possible for testpmd to create a af_xdp friendly
>> mempool (which enable zero copy).
>>
>> Signed-off-by: Qi Zhang
>
Hi,
On 03/01, Stephen Hemminger wrote:
>On Fri, 1 Mar 2019 16:09:42 +0800
>Xiaolong Ye wrote:
>
>> +
>> +static int
>> +rte_pmd_af_xdp_probe(struct rte_vdev_device *dev)
>> +{
>> +struct rte_kvargs *kvlist;
>> +char *if_name = NULL;
>> +int queue_idx = ETH_AF_XDP_DFLT_QUEUE_IDX;
>> +
Hi,
On 03/01, Stephen Hemminger wrote:
>On Fri, 1 Mar 2019 16:09:42 +0800
>Xiaolong Ye wrote:
>
>> +if (umem->buffer)
>> +free(umem->buffer);
>
>Minor nit: you don't need to check for NULL free() already handles this.
Thanks for the suggestion, will change accordingly.
Hi, Luca
Thanks for your review.
On 03/01, Luca Boccassi wrote:
>On Fri, 2019-03-01 at 16:09 +0800, Xiaolong Ye wrote:
>> Add a new PMD driver for AF_XDP which is a proposed faster version of
>> AF_PACKET interface in Linux. More info about AF_XDP, please refer to
>> [1]
>> [2].
>>
>> This is th
Hi David,
Thanks for you comments.
On 03/05, David Marchand wrote:
>On Fri, Mar 1, 2019 at 9:13 AM Xiaolong Ye wrote:
>
>> This give the option that applicaiton can configure each
>> memory chunk's size precisely. (by MEMPOOL_F_NO_SPREAD).
>>
>> Signed-off-by: Qi Zhang
>> Signed-off-by: Xiaolon
Hi, David
Thanks for your review.
On 03/05, David Marchand wrote:
>On Fri, Mar 1, 2019 at 9:13 AM Xiaolong Ye wrote:
>
>> diff --git a/doc/guides/rel_notes/release_18_11.rst
>> b/doc/guides/rel_notes/release_18_11.rst
>> index 65bab557d..e0918441a 100644
>> --- a/doc/guides/rel_notes/release_18_
On 03/11, Ferruh Yigit wrote:
>On 3/1/2019 8:09 AM, Xiaolong Ye wrote:
>> When create rte_mempool, flags can be parsed from command line.
>> Now, it is possible for testpmd to create a af_xdp friendly
>> mempool (which enable zero copy).
>>
>> Signed-off-by: Qi Zhang
>> Signed-off-by: Xiaolong Ye
Hi, Ferruh
Thanks for your review.
On 03/11, Ferruh Yigit wrote:
>On 3/1/2019 8:09 AM, Xiaolong Ye wrote:
>> Add a new PMD driver for AF_XDP which is a proposed faster version of
>> AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1]
>> [2].
>>
>> This is the vanilla versio
On 03/13, Ferruh Yigit wrote:
>
>>> <...>
>>>
+Prerequisites
+-
+
+This is a Linux-specific PMD, thus the following prerequisites apply:
+
+* A Linux Kernel with XDP sockets configuration enabled;
>>>
>>> Can you please give more details of what exact vani
On 03/02, Ye Xiaolong wrote:
>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += -lrte_pmd_af_packet
>>> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_XDP) += -lrte_pmd_af_xdp
>>> -lelf -lbpf
>>
>>Are symbols from libelf being used by the PMD?
>
>Hmm, it is
On 03/12, Ye Xiaolong wrote:
>>I can see in makefile, libelf is also linked, is it a dependency?
>
>libelf is a leftover of RFC, will delete it in next version.
Correction, libbpf depends on libelf, so I still need to keep it.
Thanks,
Xiaolong
Hi, Mattias
Thanks for the review.
On 03/19, Mattias Rönnblom wrote:
>On 2019-03-19 08:12, Xiaolong Ye wrote:
>> Try to check if external mempool (from rx_queue_setup) is fit for
>> af_xdp, if it is, it will be registered to af_xdp socket directly and
>> there will be no packet data copy on Rx an
Hi, Mattias
Thanks for your comments.
On 03/19, Mattias Rönnblom wrote:
>On 2019-03-19 08:12, Xiaolong Ye wrote:
>> Add a new PMD driver for AF_XDP which is a proposed faster version of
>> AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1]
>> [2].
>>
>> This is the vanilla
On 03/19, Stephen Hemminger wrote:
>> \ No newline at end of file
>
>
>This is bad. Configure your editor to always put newline at end of file.
>In .emacs
>
> (setq require-final-newline t)
>
I wasn't aware of it before, thanks for the info, will configure it for my
emacs.
Thanks,
Xiaolong
On 03/19, Bruce Richardson wrote:
>> This is bad. Configure your editor to always put newline at end of file.
>> In .emacs
>>
>>(setq require-final-newline t)
>>
>Or use Vim which needs no extra configuration to do this. :-)
I used to be a Vimer, just switch to emacs recently. :-)
>
Hi,
On 03/19, Jerin Jacob Kollanukkaran wrote:
>On Tue, 2019-03-19 at 15:12 +0800, Xiaolong Ye wrote:
>> When create rte_mempool, flags can be parsed from command line.
>> Now, it is possible for testpmd to create a af_xdp friendly
>> mempool (which enable zero copy).
>>
>> Signed-off-by: Qi Zha
Hi, Stephen
On 03/19, Stephen Hemminger wrote:
>Lots of little review comments. This is what I saw in 30 minutes.
>Expect more.
Thanks for taking time to review my patch. They are all valuable inputs.
>
>
>On Tue, 19 Mar 2019 15:12:51 +0800
>Xiaolong Ye wrote:
>
>> +nb_pkts = nb_pkts < ETH_
Thanks for your comments.
On 03/20, David Marchand wrote:
>On Tue, Mar 19, 2019 at 8:17 AM Xiaolong Ye wrote:
>
>> diff --git a/doc/guides/nics/features/af_xdp.ini
>> b/doc/guides/nics/features/af_xdp.ini
>> new file mode 100644
>> index 0..7b8fcce00
>> --- /dev/null
>> +++ b/doc/guides/n
On 03/20, David Marchand wrote:
>On Wed, Mar 20, 2019 at 12:37 AM Jerin Jacob Kollanukkaran <
>jer...@marvell.com> wrote:
>
>> On Tue, 2019-03-19 at 15:12 +0800, Xiaolong Ye wrote:
>> > When create rte_mempool, flags can be parsed from command line.
>> > Now, it is possible for testpmd to create a
On 03/21, Stephen Hemminger wrote:
>On Thu, 21 Mar 2019 17:18:41 +0800
>Xiaolong Ye wrote:
>
>> +
>> +RTE_PMD_REGISTER_VDEV(eth_af_xdp, pmd_af_xdp_drv);
>
>The convention in other network drivers is to use net_XXX in the vdev name.
>In AF_XDP that would be:
>
>RTE_PMD_REGISTER_VDEV(net_af_xdp, pmd
On 03/21, Stephen Hemminger wrote:
>On Thu, 21 Mar 2019 17:18:41 +0800
>Xiaolong Ye wrote:
>
>> +
>> +strlcpy(ifr.ifr_name, if_name, IFNAMSIZ);
>> +if (ioctl(sock, SIOCGIFINDEX, &ifr))
>> +goto error;
>> +
>> +if (ioctl(sock, SIOCGIFHWADDR, &ifr))
>> +goto error
On 03/21, Stephen Hemminger wrote:
>On Thu, 21 Mar 2019 17:18:41 +0800
>Xiaolong Ye wrote:
>
>> +if (strnlen(value, IFNAMSIZ) > IFNAMSIZ - 1) {
>> +RTE_LOG(ERR, AF_XDP, "Invalid name %s, should be less than "
>> +"%u bytes.\n", value, IFNAMSIZ)
>
>Please don't b
On 03/21, Stephen Hemminger wrote:
>On Thu, 21 Mar 2019 17:18:41 +0800
>Xiaolong Ye wrote:
>
>> +
>> +if (ret < 0)
>> +return -EINVAL;
>> +
>> +return 0;
>
>You could propogate kernel errno into DPDK?
> return (ret < 0) ? -errno : 0;
>
Sorry, could you share the advantag
On 03/21, Stephen Hemminger wrote:
>On Thu, 21 Mar 2019 17:18:41 +0800
>Xiaolong Ye wrote:
>
>> static void kick_tx(struct pkt_tx_queue *txq)
>> +{
>> +struct xsk_umem_info *umem = txq->pair->umem;
>> +
>> +while (send(xsk_socket__fd(txq->pair->xsk), NULL,
>> + 0, MSG_DONT
On 03/21, Stephen Hemminger wrote:
>On Thu, 21 Mar 2019 17:18:41 +0800
>Xiaolong Ye wrote:
>
>> +for (i = 0; i < rcvd; i++) {
>> +const struct xdp_desc *desc;
>> +uint64_t addr;
>> +uint32_t len;
>> +void *pkt;
>> +
>> +desc = xsk_rin
On 03/21, Stephen Hemminger wrote:
>On Thu, 21 Mar 2019 17:18:41 +0800
>Xiaolong Ye wrote:
>
>> +
>> +static inline int
>> +reserve_fill_queue(struct xsk_umem_info *umem, int reserve_size)
>> +{
>> +struct xsk_ring_prod *fq = &umem->fq;
>> +uint32_t idx;
>> +void *addr = NULL;
>> +
On 03/21, Stephen Hemminger wrote:
>On Thu, 21 Mar 2019 17:18:41 +0800
>Xiaolong Ye wrote:
>
>> +if (ret != 0) {
>> +RTE_LOG(ERR, AF_XDP, "getsockopt() failed for
>> XDP_STATISTICS.\n");
>> +return -1;
>
>You need to use the new dynamic log type
On 03/22, Stephen Hemminger wrote:
>On Fri, 22 Mar 2019 10:01:57 +0800
>Ye Xiaolong wrote:
>
>> On 03/21, Stephen Hemminger wrote:
>> >On Thu, 21 Mar 2019 17:18:41 +0800
>> >Xiaolong Ye wrote:
>> >
>> >> +
>> >> + if
On 03/22, Stephen Hemminger wrote:
>On Fri, 22 Mar 2019 10:15:23 +0800
>Ye Xiaolong wrote:
>
>> On 03/21, Stephen Hemminger wrote:
>> >On Thu, 21 Mar 2019 17:18:41 +0800
>> >Xiaolong Ye wrote:
>> >
>> >> + if (ret != 0) {
&g
On 03/22, Maxime Coquelin wrote:
>
>
>On 3/22/19 2:01 PM, Xiaolong Ye wrote:
>> Now, af_xdp registered memory buffer is managed by rte_mempool. mbuf be
>s/mbuf be allocated/mbuf allocated/
>> allocated from rte_mempool can be convert to xdp_desc's address and vice
>s/convert/converted/
>> versa.
W
On 03/22, Maxime Coquelin wrote:
>
>
>On 3/22/19 2:01 PM, Xiaolong Ye wrote:
>> This allows applications to create mbuf mempool with specific flags
>> such as MEMPOOL_F_NO_SPREAD if they want fixed size memory objects.
>>
>> Signed-off-by: Qi Zhang
>> Signed-off-by: Xiaolong Ye
>> ---
>> lib/l
On 03/22, Maxime Coquelin wrote:
>
>
>On 3/22/19 2:01 PM, Xiaolong Ye wrote:
>> Add a new PMD driver for AF_XDP which is a proposed faster version of
>> AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1]
>> [2].
>>
>> This is the vanilla version PMD which just uses a raw buf
On 03/24, Ye Xiaolong wrote:
>>> - ret = xsk_umem__create(&umem->umem, bufs,
>>> + ret = xsk_umem__create(&umem->umem, base_addr,
>>>ETH_AF_XDP_NUM_BUFFERS * ETH_AF_XDP_FRAME_SIZE,
>>&g
On 03/24, Luca Boccassi wrote:
>On Sun, 2019-03-17 at 11:34 +0800, Ye Xiaolong wrote:
>> On 03/02, Ye Xiaolong wrote:
>> > > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) +=
>> > > > -lrte_pmd_af_packet
>> > > > +_LDLIBS-$(CONFIG_R
On 03/25, Luca Boccassi wrote:
>On Mon, 2019-03-25 at 10:45 +0800, Ye Xiaolong wrote:
>> On 03/24, Luca Boccassi wrote:
>> > On Sun, 2019-03-17 at 11:34 +0800, Ye Xiaolong wrote:
>> > > On 03/02, Ye Xiaolong wrote:
>> > > > &
On 03/25, Stephen Hemminger wrote:
>On Mon, 25 Mar 2019 14:03:56 +0800
>Xiaolong Ye wrote:
>
>> +
>> +ret = xsk_ring_prod__reserve(fq, reserve_size, &idx);
>> +if (unlikely(!ret)) {
>> +AF_XDP_LOG(ERR, "Failed to reserve enough fq descs.\n");
>
>You defined AF_XDP_LOG to add a
On 03/25, Luca Boccassi wrote:
>On Mon, 2019-03-25 at 10:45 +0800, Ye Xiaolong wrote:
>> On 03/24, Luca Boccassi wrote:
>> > On Sun, 2019-03-17 at 11:34 +0800, Ye Xiaolong wrote:
>> > > On 03/02, Ye Xiaolong wrote:
>> > > > &
On 03/25, Andrew Rybchenko wrote:
>On 3/25/19 9:03 AM, Xiaolong Ye wrote:
>> Allow create a mempool with page size aligned base address.
>>
>> Signed-off-by: Qi Zhang
>> Signed-off-by: Xiaolong Ye
>> ---
>> lib/librte_mempool/rte_mempool.c | 3 +++
>> lib/librte_mempool/rte_mempool.h | 1 +
>>
On 03/26, Luca Boccassi wrote:
>On Tue, 2019-03-26 at 10:18 +0800, Ye Xiaolong wrote:
>> On 03/25, Luca Boccassi wrote:
>> > On Mon, 2019-03-25 at 10:45 +0800, Ye Xiaolong wrote:
>> > > On 03/24, Luca Boccassi wrote:
>> > > > On Sun, 2019-03-17 at 11:
On 03/26, Stephen Hemminger wrote:
>On Tue, 26 Mar 2019 20:20:25 +0800
>Xiaolong Ye wrote:
>
>> +This Linux-specific PMD driver creates the AF_XDP socket and binds it to a
>> +specific netdev queue, it allows a DPDK application to send and receive raw
>> +packets through the socket which would byp
On 03/28, Ferruh Yigit wrote:
>On 3/27/2019 9:00 AM, Xiaolong Ye wrote:
>> Try to check if external mempool (from rx_queue_setup) is fit for
>> af_xdp, if it is, it will be registered to af_xdp socket directly and
>> there will be no packet data copy on Rx and Tx.
>>
>> Signed-off-by: Xiaolong Ye
Hi, Ferruh
Thanks for the comments.
On 03/28, Ferruh Yigit wrote:
>On 3/27/2019 9:00 AM, Xiaolong Ye wrote:
>> Add a new PMD driver for AF_XDP which is a proposed faster version of
>> AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1]
>> [2].
>>
>> This is the vanilla vers
Hi, Olivier
Thanks for the comments.
On 03/29, Olivier Matz wrote:
>Hi Xiaolong,
>
>On Tue, Mar 26, 2019 at 08:20:28PM +0800, Xiaolong Ye wrote:
>> Now, af_xdp registered memory buffer is managed by rte_mempool. mbuf
>> allocated from rte_mempool can be converted to xdp_desc's address and
>> vice
On 04/02, Stephen Hemminger wrote:
>On Tue, 2 Apr 2019 18:45:54 +0800
>Xiaolong Ye wrote:
>
>> +
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
On 04/02, Stephen Hemminger wrote:
>On Tue, 2 Apr 2019 23:46:53 +0800
>Xiaolong Ye wrote:
>
>> +/* pull from complete qeueu to leave more space */
>
>Overall looks good, one last spelling error
Sorry for the typo, will fix in in next version.
Thanks,
Xiaolong
Hi, Luca
On 04/02, Luca Boccassi wrote:
>On Tue, 2019-04-02 at 23:46 +0800, Xiaolong Ye wrote:
>> diff --git a/drivers/net/af_xdp/Makefile
>> b/drivers/net/af_xdp/Makefile
>> new file mode 100644
>> index 0..8343e3016
>> --- /dev/null
>> +++ b/drivers/net/af_xdp/Makefile
>> @@ -0,0 +1,32 @
On 04/03, Ferruh Yigit wrote:
[snip]
>
>It seems, 'tools/include/asm/barrier.h' is required for 'smp_wmb()' &
>'smp_rmb()' in 'xsk.h'.
>We have equivalents of these in DPDK [1], and perhaps it can be possible to use
>them and not include this header at all.
>
>in 'rte_eth_af_xdp.c', before includin
On 04/03, Luca Boccassi wrote:
[snip]
>>
>> Got it.
>>
>> In above steps, 'libbpf' also build from kernel source tree, will it
>> be problem
>> in you builds to not have it build from source?
>>
>> If not, taking into account that xsk.h also will be fixed, only
>> 'tools/include/asm/barrier.h' r
On 04/03, Luca Boccassi wrote:
>On Wed, 2019-04-03 at 22:43 +0800, Ye Xiaolong wrote:
>> On 04/03, Luca Boccassi wrote:
>> [snip]
>> > > Got it.
>> > >
>> > > In above steps, 'libbpf' also build from kernel source tree, will
>>
On 04/03, Bruce Richardson wrote:
>On Wed, Apr 03, 2019 at 11:14:58PM +0800, Ye Xiaolong wrote:
>> On 04/03, Luca Boccassi wrote:
>> >On Wed, 2019-04-03 at 22:43 +0800, Ye Xiaolong wrote:
>> >> On 04/03, Luca Boccassi wrote:
>> >> [snip]
>> &g
On 04/03, Ferruh Yigit wrote:
>On 4/3/2019 3:22 PM, Ye Xiaolong wrote:
>> On 04/03, Ferruh Yigit wrote:
>> [snip]
>>>
>>> It seems, 'tools/include/asm/barrier.h' is required for 'smp_wmb()' &
>>> 'smp_rmb()' in 'xsk
Hi, Ferruh
On 04/03, Ferruh Yigit wrote:
>On 4/3/2019 5:59 PM, Xiaolong Ye wrote:
>> Add a new PMD driver for AF_XDP which is a proposed faster version of
>> AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1]
>> [2].
>>
>> This is the vanilla version PMD which just uses a r
bout AF_XDP, please refer
>> > to [1]
>> > [2].
>> >
>> > This is the vanilla version PMD which just uses a raw buffer
>> > registered as
>> > the umem.
>> >
>> > [1]
>> > https://fosdem.org/2018/schedule/event/af_x
More info about AF_XDP, please refer
>> > to [1]
>> > [2].
>> >
>> > This is the vanilla version PMD which just uses a raw buffer
>> > registered as
>> > the umem.
>> >
>> > [1]
>> > https://fosdem.org/2018/sch
Hi, Tiwei,
On 04/04, Tiwei Bie wrote:
[snip]
>> @@ -515,7 +515,7 @@ rte_vhost_get_ifname(int vid, char *buf, size_t len)
>> {
>> struct virtio_net *dev = get_device(vid);
>>
>> -if (dev == NULL)
>> +if (dev == NULL || !buf)
>
>It would be better to do the check in this way: (!dev |
On 04/04, Luca Boccassi wrote:
>>
>> After apply the fix in af_xdp pmd's meson.build, now I was able to
>> build
>> library for af_xdp pmd.
>>
>> $ ls drivers/ |grep xdp
>> a715181@@rte_pmd_af_xdp@sha
>> a715181@@rte_pmd_af_xdp@sta
>> a715181@@tmp_rte_pmd_af_xdp@sta
>> librte_pmd_af_xdp.a
>> libr
Hi, Ferruh
On 04/05, Ferruh Yigit wrote:
>On 4/4/2019 9:51 AM, Xiaolong Ye wrote:
>> Add a new PMD driver for AF_XDP which is a proposed faster version of
>> AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1]
>> [2].
>>
>> This is the vanilla version PMD which just uses a r
On 04/05, Ferruh Yigit wrote:
>On 4/5/2019 4:05 PM, Ye Xiaolong wrote:
>> Hi, Ferruh
>>
>> On 04/05, Ferruh Yigit wrote:
>>> On 4/4/2019 9:51 AM, Xiaolong Ye wrote:
>>>> Add a new PMD driver for AF_XDP which is a proposed faster version of
>>>>
On 12/12, Bruce Richardson wrote:
>The ipn3ke driver and the ifpga driver had circular dependencies on each
>other, meaning that neither could be built with meson. Fix this by:
>
>* setting the build order of net and raw to match that in makefiles
>* removing the dependency from the net driver on t
On 12/13, Wu, Jingjing wrote:
>
>
>> -Original Message-
>> From: Min, JiaqiX
>> Sent: Friday, December 13, 2019 9:23 AM
>> To: dev@dpdk.org
>> Cc: Wu, Jingjing ; Yang, Qiming
>> ; Min, JiaqiX
>> ; sta...@dpdk.org
>> Subject: [PATCH v2] net/iavf: fix Rx total stats
>>
>> Rx total stats is
On 12/06, Guinan Sun wrote:
>Repeat switching flow control on or off during receiving traffic,
>testpmd reports "failed to switch Tx queue occurs" after quit.
>The patch fixes the issue.
>
>Fixes: f53577f06925 ("i40e: support flow control")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Guinan Sun
>---
>
On 12/16, Ye Xiaolong wrote:
>On 12/06, Guinan Sun wrote:
>>Repeat switching flow control on or off during receiving traffic,
>>testpmd reports "failed to switch Tx queue occurs" after quit.
>>The patch fixes the issue.
>>
>>Fixes: f53577f06925 ("i4
On 12/11, Chenxu Di wrote:
>FreeBSD OS doesn't support igb_uio interrupt, so it will fail when
>unregister the interrupt callback in port close. We can fix the issue by
>passing -ENOENT when check the return value of unregister interrupt
>callback function.
>
>Fixes: ac89d46096d5 ("net/i40e: releas
On 12/18, Zhang, Qi Z wrote:
>
>
>> -Original Message-
>> From: dev On Behalf Of taox@intel.com
>> Sent: Tuesday, December 3, 2019 11:28 PM
>> To: Wu, Jingjing ; Lu, Wenzhuo
>>
>> Cc: dev@dpdk.org; Zhu, TaoX
>> Subject: [dpdk-dev] [PATCH] net/iavf: add TSO offload use basic path
>>
On 12/17, Lunyuan Cui wrote:
>The link status for ixgbevf is not correct when PF link up.
>IXGBE_ESDP register is only used when media type is fiber.
>
>Fixes: 1ca05831b9be ("net/ixgbe: fix link status")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Lunyuan Cui
>---
> drivers/net/ixgbe/ixgbe_ethdev.c | 8
On 12/16, Lunyuan Cui wrote:
>In FreeBSD environment, nic_uio drivers do not support interrupts,
>rte_intr_callback_register() will fail to register interrupts.
>We can not make link status to change from down to up by interrupt
>callback. So we need to wait for the controller to acquire link
>when
1 - 100 of 715 matches
Mail list logo
