On 03/20, David Marchand wrote: >On Wed, Mar 20, 2019 at 12:37 AM Jerin Jacob Kollanukkaran < >jer...@marvell.com> wrote: > >> On Tue, 2019-03-19 at 15:12 +0800, Xiaolong Ye wrote: >> > When create rte_mempool, flags can be parsed from command line. >> > Now, it is possible for testpmd to create a af_xdp friendly >> > mempool (which enable zero copy). >> > >> > Signed-off-by: Qi Zhang <qi.z.zh...@intel.com> >> > Signed-off-by: Xiaolong Ye <xiaolong...@intel.com> >> > --- >> > app/test-pmd/parameters.c | 12 ++++++++++++ >> > app/test-pmd/testpmd.c | 17 ++++++++++------- >> > app/test-pmd/testpmd.h | 1 + >> > doc/guides/testpmd_app_ug/run_app.rst | 4 ++++ >> >> If I understand it correctly, The user needs to change all the >> application in order to avail zero copy feature of XDP. >> >> If so, >> >> How about creating wrapper mempool driver for xdp at drivers/mempool/? >> and mempool's best mempool feature to select the required mempool >> driver for XDP at runtime without changing the apps. >> >> see rte_mbuf_best_mempool_ops() >> see struct eth_dev_ops::pool_ops_supported >> > >Glab to read this, I was under the same impression :-)
We plan to separate this in another patchset and may target for next release. Thanks, Xiaolong > > >-- >David Marchand