On 09/24, Wang, Xiao W wrote: >Hi Xiaolong, > >Thanks for the update, 2 small comments below. > [snip] >> + ./vdpa --log-level=9 -c 0x6 -n 4 --socket-mem 1024,1024 \ >> + -w 0000:06:00.3,vdpa=1 -w 0000:06:00.4,vdpa=1 \ >> + -- --interactive > >To demonstrate app doesn't need to launch dedicated worker threads for vhost >enqueue/dequeue operations, >We can use "-c 0x2" to indicate that no need to allocate dedicated worker >threads. >
Got it, will do. >> + >> +.. note:: [snip] >> "%d\t\t"PCI_PRI_FMT"\t%"PRIu32"\t\t0x%"PRIu64"\n", did, >> + addr.domain, addr.bus, addr.devid, >> + addr.function, queue_num, features); > >Use PRIx64 instead of PRIu64 for features. >You can add a blank space between "PRIx64" and the other section to make it >more readable. >Refer to: > lib/librte_vhost/vhost_user.c: "guest memory region > %u, size: 0x%" PRIx64 "\n" Got it, will do. Thanks, Xiaolong > >BRs, >Xiao
