Hi, Ferruh
On 01/29, Ferruh Yigit wrote:
[snip]
>
>Hi Xiaolong,
>
>Your analysis looks correct, thanks for history provided, it seems renaming
>"state" to "status" was not correct [1].
>
>The intention of the 'pci_check_and_mask_intx()' is mask the interrupt if it is
>from this device, so your suggestion looks correct to me.
>
>Only concern is how we can test the change, most probably existing code is also
>failing but able to find its way since it is not tested fully. To be sure we
>are
>also not missing anything, I think better to test the code before getting it.
>Are you aware of any way to test updated code?
>
Yes, I am also thinking about how to verify the change, will update once I find
a proper method.
>
>And related to the initial patch, removing the comment, I think the comment is
>informative within the context of 'igbuio_pci_irqhandler()', so I suggest
>moving
>if from begging of the function into it just above legacy interrupt change.
>
Sure, will do.
Thanks,
Xiaolong
>[1]
>5b2f8137 ("igb_uio: fix typos for kernel older than 3.3")
>
>
>Thanks,
>ferruh
