[PATCH v9 2/2] dts: Change hugepage 'amount' to a different term

2024-06-10 Thread Nicholas Pratte
The term 'amount' is used for uncountable nouns. Since total hugepages is a discrete value (i.e. countable), the declaration of the 'amount' key value pair should be changes to a different term in both the config and the rest of the code. Bugzilla ID: 1370 Signed-off

[PATCH v1] Testbed And Node Configuration Split

2024-06-10 Thread Nicholas Pratte
process. Bugzilla ID: 1344 Signed-off-by: Nicholas Pratte --- dts/execution_conf.yaml| 26 ++ dts/framework/config/__init__.py | 26 +- dts/framework/config/conf_yaml_schema.json | 340 ++--- dts/framework/runner.py| 4 +- dts

Re: [PATCH v1] Testbed And Node Configuration Split

2024-06-10 Thread Nicholas Pratte
On Mon, Jun 10, 2024 at 3:00 PM Nicholas Pratte wrote: > > > -def load_config(config_file_path: Path) -> Configuration: > +def load_config(node_config_file_path: Path, exec_config_file_path: Path) -> > Configuration: > """Load DTS test run confi

[PATCH v1] dts: Testbed And Node Configuration Split

2024-06-10 Thread Nicholas Pratte
process. Bugzilla ID: 1344 Signed-off-by: Nicholas Pratte --- dts/execution_conf.yaml| 26 ++ dts/framework/config/__init__.py | 26 +- dts/framework/config/conf_yaml_schema.json | 340 ++--- dts/framework/runner.py| 4 +- dts

Re: [PATCH v1] dts: Testbed And Node Configuration Split

2024-06-10 Thread Nicholas Pratte
> -def load_config(config_file_path: Path) -> Configuration: > +def load_config(node_config_file_path: Path, exec_config_file_path: Path) -> > Configuration: > """Load DTS test run configuration from a file. > > -Load the YAML test run configuration file > +Load both the YAML testbe

[PATCH 0/4] dts: Remove Excess Attributes From User Config

2024-06-13 Thread Nicholas Pratte
look into potentially getting rid of the OS attribute at some point. Nicholas Pratte (4): dts: Remove build target config and list of devices dts: Use First Core Logic Change dts: Self-Discovering Architecture Change dts: Rework DPDK Attributes In SUT Node Config doc/guides/tools/dt

[PATCH 2/4] dts: Use First Core Logic Change

2024-06-13 Thread Nicholas Pratte
ot; will omit core 0. Documentation reworks are included to reflect the changes made. Bugzilla ID: 1360 Signed-off-by: Nicholas Pratte --- doc/guides/tools/dts.rst | 9 +++-- dts/conf.yaml | 3 +-- dts/framework/config/__init__.py | 11 ++

[PATCH 1/4] dts: Remove build target config and list of devices

2024-06-13 Thread Nicholas Pratte
Remove the list of devices from the schema, as these are unuesed. Likewise, removed build-target information since these is not currently used, and it is unlikely to be used in the future. Adjustments to the dts.rst are made to reflect these changes. Bugzilla ID: 1360 Signed-off-by: Nicholas

[PATCH 3/4] dts: Self-Discovering Architecture Change

2024-06-13 Thread Nicholas Pratte
the 'uname' command is used to determine system architecture. I believe that this is posix-standard and utilizes a standardized output. Bugzilla ID: 1360 Signed-off-by: Nicholas Pratte --- doc/guides/tools/dts.rst | 2 -- dts/conf.yaml

[PATCH 4/4] dts: Rework DPDK Attributes In SUT Node Config

2024-06-13 Thread Nicholas Pratte
7; from 'system_under_test_node' and moves it into 'executions.' Bugzilla ID: 1360 Signed-off-by: Nicholas Pratte --- doc/guides/tools/dts.rst | 2 + dts/conf.yaml| 18 +++ dts/framework/config/__init__.py | 45

Re: [PATCH v5 5/5] dts: add `show port stats` command to TestPmdShell

2024-06-14 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte wrote: > > Add a new TestPmdPortStats data structure to represent the output > returned by `show port stats`, which is implemented as part of > TestPmdShell. > > Bugzilla ID: 1407 > > Signed-off-by: Luca Vizza

Re: [PATCH v5 4/5] dts: add `show port info` command to TestPmdShell

2024-06-14 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Thu, Jun 6, 2024 at 5:34 PM Luca Vizzarro wrote: > > Add a new TestPmdPort data structure to represent the output > returned by `show port info`, which is implemented as part of > TestPmdShell. > > The TestPmdPort

Re: [PATCH v5 3/5] dts: add parsing utility module

2024-06-14 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Thu, Jun 6, 2024 at 5:34 PM Luca Vizzarro wrote: > > Adds parsing text into a custom dataclass. It provides a new > `TextParser` dataclass to be inherited. This implements the `parse` > method, which combined with the pars

Re: [PATCH 2/5] dts: skip first line of send_command output

2024-06-14 Thread Nicholas Pratte
> > > >> @@ -132,6 +135,9 @@ def send_command(self, command: str, prompt: str | > > > >> None = None) -> str: > > > >> self._stdin.flush() > > > >> out: str = "" > > > >> for line in self._stdout: > > > >> +if skip_first_line: > > > >> +sk

Re: [PATCH v5 1/5] dts: fix InteractiveShell command prompt filtering

2024-06-14 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Thu, Jun 6, 2024 at 5:34 PM Luca Vizzarro wrote: > > When sending a command using an instance of InteractiveShell the output > should filter out the trailing shell prompt when returning it. After > every command two shell

Re: [PATCH v3 3/3] dts: Improve logging for interactive shells

2024-06-14 Thread Nicholas Pratte
Ran a couple test suites to observe the output. As expected, everything works fine. Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Wed, May 29, 2024 at 3:49 PM wrote: > > From: Jeremy Spewock > > The messages being logged by interactive shells currently are usin

Re: [PATCH v3 2/3] dts: Add missing docstring from XML-RPC server

2024-06-14 Thread Nicholas Pratte
Just a small nitpick. Otherwise: Reviewed-by: Nicholas Pratte > class QuittableXMLRPCServer(SimpleXMLRPCServer): > -"""Basic XML-RPC server. > +r"""Basic XML-RPC server. > > The server may be augmented by functions serializable by the

Re: [PATCH v3 1/3] dts: Improve output gathering in interactive shells

2024-06-14 Thread Nicholas Pratte
Reviewed-by: Nicholas Pratte On Wed, May 29, 2024 at 3:49 PM wrote: > > From: Jeremy Spewock > > The current implementation of consuming output from interactive shells > relies on being able to find an expected prompt somewhere within the > output buffer after sending th

Re: [PATCH v5 1/8] dts: add params manipulation module

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Mon, Jun 17, 2024 at 10:54 AM Luca Vizzarro wrote: > > This commit introduces a new "params" module, which adds a new way > to manage command line parameters. The provided Params dataclass > is able to read t

Re: [PATCH v5 2/8] dts: use Params for interactive shells

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Mon, Jun 17, 2024 at 10:54 AM Luca Vizzarro wrote: > > Make it so that interactive shells accept an implementation of `Params` > for app arguments. Convert EalParameters to use `Params` instead. > > String command line

Re: [PATCH v5 3/8] dts: refactor EalParams

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Mon, Jun 17, 2024 at 10:54 AM Luca Vizzarro wrote: > > Move EalParams to its own module to avoid circular dependencies. > Also the majority of the attributes are now optional. > > Signed-off-by: Luca Vizzarro >

Re: [PATCH v5 4/8] dts: remove module-wide imports

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Mon, Jun 17, 2024 at 10:54 AM Luca Vizzarro wrote: > > Remove the imports in the testbed_model and remote_session modules init > file, to avoid the initialisation of unneeded modules, thus removing or > limiting the risk

Re: [PATCH v5 5/8] dts: add testpmd shell params

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Mon, Jun 17, 2024 at 10:54 AM Luca Vizzarro wrote: > > Implement all the testpmd shell parameters into a data structure. > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek > Reviewed-by: Juraj Lin

Re: [PATCH v5 6/8] dts: use testpmd params for scatter test suite

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Mon, Jun 17, 2024 at 10:54 AM Luca Vizzarro wrote: > > Update the buffer scatter test suite to use TestPmdParameters > instead of the StrParams implementation. > > Signed-off-by: Luca Vizzarro > Reviewed-b

Re: [PATCH v5 7/8] dts: rework interactive shells

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Mon, Jun 17, 2024 at 10:54 AM Luca Vizzarro wrote: > > The way nodes and interactive shells interact makes it difficult to > develop for static type checking and hinting. The current system relies > on a top-down approach

Re: [PATCH v5 8/8] dts: use Unpack for type checking and hinting

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Mon, Jun 17, 2024 at 10:54 AM Luca Vizzarro wrote: > > Interactive shells that inherit DPDKShell initialise their params > classes from a kwargs dict. Therefore, static type checking is > disabled. This change uses the func

Re: [PATCH v3 1/2] dts: update mypy static checker

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Thu, May 30, 2024 at 11:20 AM Luca Vizzarro wrote: > > Update the mypy static checker to the latest version and fix all the > reported errors. > > Bump up supported Poetry shell version. > > Bugzilla ID: 1433 &g

Re: [PATCH v3 2/2] dts: clean up config types

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte

Re: [PATCH 2/4] dts: Use First Core Logic Change

2024-06-20 Thread Nicholas Pratte
On Fri, Jun 14, 2024 at 2:09 PM Jeremy Spewock wrote: > > On Thu, Jun 13, 2024 at 4:21 PM Nicholas Pratte wrote: > > > > Removed use_first_core from the conf.yaml in favor of determining this > > within the framework. use_first_core continue to serve a purpose in that >

[PATCH 0/3] Mac Filter Port to New DTS

2024-06-21 Thread Nicholas Pratte
ke old DTS, instead of validating packet behavior using TestPMD, this test suite validates behavior by sending, and analysing, a list of received packets. Nicholas Pratte (3): dts: add boolean to adjust addresses dts: add testpmd methods for test suite dts: mac filter test suite refactored for new

[PATCH 1/3] dts: add boolean to adjust addresses

2024-06-21 Thread Nicholas Pratte
boolean is true by default. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/test_suite.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py index 694b2eba65..5044d5f9bb 100644 --- a/dts/framework

[PATCH 2/3] dts: add testpmd methods for test suite

2024-06-21 Thread Nicholas Pratte
specific to this test suite include adding or removing mac addresses, and adding or removing multicast mac addresses. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/remote_session/testpmd_shell.py | 209 ++ 1 file changed, 209 insertions(+) diff --git a/dts

[PATCH 3/3] dts: mac filter test suite refactored for new dts

2024-06-21 Thread Nicholas Pratte
--rxfreet=64 --mbcache=250 --portmask=0x3 Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestSuite_mac_filter.py | 212 + 2 files changed, 214 insertions(+), 1 deletion(-) create mode 100644

[RFC PATCH v2 0/1] Initial Implementation For Jumbo Frames

2024-06-21 Thread Nicholas Pratte
v2: - Suite has been refactored to include latest DPDK merge. - Include a 6 second timer to ensure each test case passes (This is just temporary placement in lieu of the context manager) Nicholas Pratte (1): Initial Implementation For Jumbo Frames Test Suite dts/framework/config

[RFC PATCH v2] Initial Implementation For Jumbo Frames Test Suite

2024-06-21 Thread Nicholas Pratte
directly from the old DTS framework, and the general methodology is the same as well. The process, at this point, has been refactored to operate within the new DTS framework. Bugzilla ID: 1421 Signed-off-by: Nicholas Pratte --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests

Re: [RFC PATCH v2] Initial Implementation For Jumbo Frames Test Suite

2024-06-25 Thread Nicholas Pratte
gt; > > On Jun 21, 2024, at 5:18 PM, Stephen Hemminger > > wrote: > > > > On Fri, 21 Jun 2024 17:19:21 -0400 > > Nicholas Pratte wrote: > > > >> +The test suite ensures the consistency of jumbo frames transmission within > >> +Poll Mode Drivers usi

Re: [RFC PATCH v2] Initial Implementation For Jumbo Frames Test Suite

2024-07-01 Thread Nicholas Pratte
erruh, please can you explain what is the problem with MTU sizes? > > > 25/06/2024 21:57, Nicholas Pratte: > > The previous comments led me to go on an investigation about how MTUs > > are allocated in testpmd. --max-pkt-len, which the documentation > > states is defaulted

Re: [PATCH 3/3] dts: mac filter test suite refactored for new dts

2024-07-01 Thread Nicholas Pratte
> > > +def send_packet_and_verify( > > +self, > > +mac_address: str, > > +add_vlan: bool = False, > > +should_receive: bool = True, > > +) -> None: > > +"""Generate, send, and verify a packet based on specified > > parameters. > > + > > +Te

Re: [PATCH 2/3] dts: add testpmd methods for test suite

2024-07-02 Thread Nicholas Pratte
iefly says what the added testpmd commands actually do. > > On Fri, Jun 21, 2024 at 1:23 PM Nicholas Pratte wrote: > > > > Several methods are either imported from currently in-develoment test > > suites, or they have been created specifically for this test suite. > >

Re: [PATCH 1/3] dts: add boolean to adjust addresses

2024-07-02 Thread Nicholas Pratte
handle this. Now that we have a few use cases for why > this fix is needed, it will probably make the discussion easier since > there is less speculation. > > On Fri, Jun 21, 2024 at 1:22 PM Nicholas Pratte wrote: > > > > Various test cases in the mac filter test suite call

[PATCH v2 0/3] dts: mac filter port to new dts

2024-07-02 Thread Nicholas Pratte
v2: - refactored mac filter suite and cleared out hidden bugs. - add/remove mac and multicast addresses code semantics improvements. - minor documentation changes based on suggestions. Nicholas Pratte (3): dts: add boolean to adjust addresses dts: add methods for setting mac and

[PATCH v2 1/3] dts: add boolean to adjust addresses

2024-07-02 Thread Nicholas Pratte
boolean is true by default. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/test_suite.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py index 694b2eba65..551a587525 100644 --- a/dts/framework

[PATCH v2 2/3] dts: add methods for setting mac and multicast addresses

2024-07-02 Thread Nicholas Pratte
est suites, and their implementations have been copied, but are subject to change; they are not the focus of this patch. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/remote_session/testpmd_shell.py | 177 ++ dts/tests/TestSuite_mac_filter.py | 0

[PATCH v2 3/3] dts: mac filter test suite refactored for new dts

2024-07-02 Thread Nicholas Pratte
--rxfreet=64 --mbcache=250 --portmask=0x3 Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- v2: * Refactored the address pool capacity tests to use all available octets in the mac address. * Change the payload to 'X' characters instead of 'P' charact

[PATCH v2 0/3] dts: mac filter port to new dts

2024-07-02 Thread Nicholas Pratte
v2: - refactored mac filter suite and cleared out hidden bugs. - add/remove mac and multicast addresses code semantics improvements. - minor documentation changes based on suggestions. Nicholas Pratte (3): dts: add boolean to adjust addresses dts: add methods for setting mac and

[PATCH v2 1/3] dts: add boolean to adjust addresses

2024-07-02 Thread Nicholas Pratte
boolean is true by default. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/test_suite.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py index 694b2eba65..551a587525 100644 --- a/dts/framework

[PATCH v2 2/3] dts: add methods for setting mac and multicast addresses

2024-07-02 Thread Nicholas Pratte
est suites, and their implementations have been copied, but are subject to change; they are not the focus of this patch. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/remote_session/testpmd_shell.py | 177 ++ dts/tests/TestSuite_mac_filter.py | 0

[PATCH v2 0/3] Mac Filter Port to New DTS

2024-07-02 Thread Nicholas Pratte
v2: - refactored mac filter suite and cleared out hidden bugs. - add/remove mac and multicast addresses code semantics improvements. - minor documentation changes based on suggestions. Nicholas Pratte (3): dts: add boolean to adjust addresses dts: add methods for setting mac and

[PATCH v2 1/3] dts: add boolean to adjust addresses

2024-07-02 Thread Nicholas Pratte
boolean is true by default. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/test_suite.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py index 694b2eba65..551a587525 100644 --- a/dts/framework

[PATCH v2 2/3] dts: add methods for setting mac and multicast addresses

2024-07-02 Thread Nicholas Pratte
est suites, and their implementations have been copied, but are subject to change; they are not the focus of this patch. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/remote_session/testpmd_shell.py | 177 ++ dts/tests/TestSuite_mac_filter.py | 0

[PATCH v2 3/3] dts: mac filter test suite refactored for new dts

2024-07-02 Thread Nicholas Pratte
--rxfreet=64 --mbcache=250 --portmask=0x3 Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- v2: * Refactored the address pool capacity tests to use all available octets in the mac address. * Change the payload to 'X' characters instead of 'P' charact

[PATCH v2 0/3] Mac Filter Port to New DTS

2024-07-02 Thread Nicholas Pratte
v2: - refactored mac filter suite and cleared out hidden bugs. - add/remove mac and multicast addresses code semantics improvements. - minor documentation changes based on suggestions. Nicholas Pratte (3): dts: add boolean to adjust addresses dts: add methods for setting mac and

[PATCH v2 1/3] dts: add boolean to adjust addresses

2024-07-02 Thread Nicholas Pratte
boolean is true by default. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/test_suite.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py index 694b2eba65..551a587525 100644 --- a/dts/framework

[PATCH v2 2/3] dts: add testpmd methods for test suite

2024-07-02 Thread Nicholas Pratte
est suites, and their implementations have been copied, but are subject to change; they are not the focus of this patch. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/remote_session/testpmd_shell.py | 177 ++ dts/tests/TestSuite_mac_filter.py | 0

[PATCH v2 3/3] dts: mac filter test suite refactored for new dts

2024-07-02 Thread Nicholas Pratte
--rxfreet=64 --mbcache=250 --portmask=0x3 Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- v2: * Refactored the address pool capacity tests to use all available octets in the mac address. * Change the payload to 'X' characters instead of 'P' charact

[PATCH v2 1/3] dts: add boolean to adjust addresses

2024-07-02 Thread Nicholas Pratte
boolean is true by default. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/test_suite.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py index 694b2eba65..551a587525 100644 --- a/dts/framework

[PATCH v2 0/3] Mac Filter Port to New DTS

2024-07-02 Thread Nicholas Pratte
ke old DTS, instead of validating packet behavior using TestPMD, this test suite validates behavior by sending, and analysing,a list of received packets. Nicholas Pratte (3): dts: add boolean to adjust addresses dts: add methods for setting mac and multicast addresses dts: mac filter test suite refa

[PATCH v2 2/3] dts: add testpmd methods for test suite

2024-07-02 Thread Nicholas Pratte
est suites, and their implementations have been copied, but are subject to change; they are not the focus of this patch. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/remote_session/testpmd_shell.py | 177 ++ dts/tests/TestSuite_mac_filter.py | 0

[PATCH v2 3/3] dts: mac filter test suite refactored for new dts

2024-07-02 Thread Nicholas Pratte
--rxfreet=64 --mbcache=250 --portmask=0x3 Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- v2: * Refactored the address pool capacity tests to use all available octets in the mac address. * Change the payload to 'X' characters instead of 'P' charact

[PATCH v2] dts: Testbed And Node Configuration Split

2024-07-03 Thread Nicholas Pratte
process. Bugzilla ID: 1344 Signed-off-by: Nicholas Pratte --- dts/execution_conf.yaml| 26 ++ dts/framework/config/__init__.py | 26 +- dts/framework/config/conf_yaml_schema.json | 340 ++--- dts/framework/runner.py| 4 +- dts

[PATCH v2 0/6] dts: Remove Excess Attributes From User Config

2024-07-05 Thread Nicholas Pratte
v2: * Patch series has been rebased to release candidate one. * Added functionality to make 'test_suites' optional, based on certain conditions. * Aggregated all of the DPDK documentation into one holistic patch. Nicholas Pratte (6): dts: Remove build target config and list

[PATCH v2 1/6] dts: Remove build target config and list of devices

2024-07-05 Thread Nicholas Pratte
Remove the list of devices from the schema, as these are unuesed. Likewise, removed build-target information since these is not currently used, and it is unlikely to be used in the future. Adjustments to the dts.rst are made to reflect these changes. Bugzilla ID: 1360 Signed-off-by: Nicholas

[PATCH v2 2/6] dts: Use First Core Logic Change

2024-07-05 Thread Nicholas Pratte
ot; will omit core 0. Documentation reworks are included to reflect the changes made. Bugzilla ID: 1360 Signed-off-by: Nicholas Pratte --- dts/conf.yaml | 3 +-- dts/framework/config/__init__.py | 11 +++ dts/framework/config/conf_yaml_schema.json | 6 +

[PATCH v2 3/6] dts: Self-Discovering Architecture Change

2024-07-05 Thread Nicholas Pratte
the 'uname' command is used to determine system architecture. I believe that this is posix-standard and utilizes a standardized output. Bugzilla ID: 1360 Signed-off-by: Nicholas Pratte --- dts/conf.yaml| 2 -- dts/framework/config/__init__.py

[PATCH v2 4/6] dts: Rework DPDK Attributes In SUT Node Config

2024-07-05 Thread Nicholas Pratte
7; from 'system_under_test_node' and moves it into 'executions.' Bugzilla ID: 1360 Signed-off-by: Nicholas Pratte --- dts/conf.yaml| 20 - dts/framework/config/__init__.py | 45 +++ dts/framework/config/conf_yaml_

[PATCH v2 5/6] dts: add conditional behavior for test suite

2024-07-05 Thread Nicholas Pratte
test suites via the --test-suite parameter, a schema violation is thrown. This patch mitigates this, by removing the schema requirement if the user has indicated test suites within main.py parameters, allowing for the 'test_suites' attribute to be optional. Bugzilla ID: 1360 Signed-off

[PATCH v2 6/6] doc: dpdk documentation changes for new dts config

2024-07-05 Thread Nicholas Pratte
Adjusted DPDK documentation to reflect the changes made to the dts conf.yaml configuration file. Bugzilla ID: 1360 Signed-off-by: Nicholas Pratte --- doc/guides/tools/dts.rst | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/doc/guides/tools

[PATCH v2 1/6] dts: Remove build target config and list of devices

2024-07-05 Thread Nicholas Pratte
Remove the list of devices from the schema, as these are unuesed. Likewise, removed build-target information since these is not currently used, and it is unlikely to be used in the future. Adjustments to the dts.rst are made to reflect these changes. Bugzilla ID: 1360 Signed-off-by: Nicholas

[PATCH v2 1/6] dts: Remove build target config and list of devices

2024-07-05 Thread Nicholas Pratte
Remove the list of devices from the schema, as these are unuesed. Likewise, removed build-target information since these is not currently used, and it is unlikely to be used in the future. Adjustments to the dts.rst are made to reflect these changes. Bugzilla ID: 1360 Signed-off-by: Nicholas

[PATCH v2 2/6] dts: Use First Core Logic Change

2024-07-05 Thread Nicholas Pratte
ot; will omit core 0. Documentation reworks are included to reflect the changes made. Bugzilla ID: 1360 Signed-off-by: Nicholas Pratte --- dts/conf.yaml | 3 +-- dts/framework/config/__init__.py | 11 +++ dts/framework/config/conf_yaml_schema.json | 6 +

[PATCH v2 3/6] dts: Self-Discovering Architecture Change

2024-07-05 Thread Nicholas Pratte
the 'uname' command is used to determine system architecture. I believe that this is posix-standard and utilizes a standardized output. Bugzilla ID: 1360 Signed-off-by: Nicholas Pratte --- dts/conf.yaml| 2 -- dts/framework/config/__init__.py

[PATCH v2 4/6] dts: Rework DPDK Attributes In SUT Node Config

2024-07-05 Thread Nicholas Pratte
7; from 'system_under_test_node' and moves it into 'executions.' Bugzilla ID: 1360 Signed-off-by: Nicholas Pratte --- dts/conf.yaml| 20 - dts/framework/config/__init__.py | 45 +++ dts/framework/config/conf_yaml_

[PATCH v2 5/6] dts: add conditional behavior for test suite

2024-07-05 Thread Nicholas Pratte
test suites via the --test-suite parameter, a schema violation is thrown. This patch mitigates this, by removing the schema requirement if the user has indicated test suites within main.py parameters, allowing for the 'test_suites' attribute to be optional. Bugzilla ID: 1360 Signed-off

[PATCH v2 6/6] doc: dpdk documentation changes for new dts config

2024-07-05 Thread Nicholas Pratte
Adjusted DPDK documentation to reflect the changes made to the dts conf.yaml configuration file. Bugzilla ID: 1360 Signed-off-by: Nicholas Pratte --- doc/guides/tools/dts.rst | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/doc/guides/tools

[PATCH] dts: Change hugepage runtime config to 2MB Exclusively

2024-04-04 Thread Nicholas Pratte
difference. If the amount of hugepages requested is either less than or equal to the amount already configured on the system, then nothing is done. Bugzilla ID: 1370 Signed-off-by: Nicholas Pratte Reviewed-by: Jeremy Spewock --- dts/conf.yaml| 8 dts

Re: [PATCH] dts: Change hugepage runtime config to 2MB Exclusively

2024-04-09 Thread Nicholas Pratte
I will change the default hugepage total back to 256. Much of the justification for changing the default amount was based on guidelines in the DPDK documentation. In the system requirements section, an example is provided demonstrating how to allocate 2GB of 2MB hugepages. We used this reasoning wh

[PATCH v2] dts: Change hugepage runtime config to 2MB Exclusively

2024-04-09 Thread Nicholas Pratte
difference. If the amount of hugepages requested is either less than or equal to the amount already configured on the system, then nothing is done. Bugzilla ID: 1370 Signed-off-by: Nicholas Pratte Reviewed-by: Jeremy Spewock --- dts/conf.yaml| 4 ++-- dts/framework

[PATCH v3] dts: Change hugepage runtime config to 2MB Exclusively

2024-04-16 Thread Nicholas Pratte
difference. If the amount of hugepages requested is either less than or equal to the amount already configured on the system, then nothing is done. Bugzilla ID: 1370 Signed-off-by: Nicholas Pratte Reviewed-by: Jeremy Spewock --- doc/guides/tools/dts.rst | 7 +- dts/conf.yaml

Re: [PATCH v3] dts: Change hugepage runtime config to 2MB Exclusively

2024-04-16 Thread Nicholas Pratte
orward, so this has been removed. On Tue, Apr 16, 2024 at 2:18 PM Nicholas Pratte wrote: > > The previous implementation configures and allocates hugepage sizes > based on a system default. This can lead to two problems: overallocation of > hugepages (which may crash the remote host)

[PATCH v4] dts: Change hugepage runtime config to 2MB Exclusively

2024-04-18 Thread Nicholas Pratte
difference. If the amount of hugepages requested is either less than or equal to the amount already configured on the system, then nothing is done. Bugzilla ID: 1370 Signed-off-by: Nicholas Pratte Reviewed-by: Jeremy Spewock --- v4: * dts.rst punctuation/grammar corrections and 2mb exclusivity

Re: [PATCH v4 2/2] dts: mac filter test suite refactored for new dts

2024-09-05 Thread Nicholas Pratte
I wanted to point out a unique issue I've been experiencing on the Mellanox/NVIDIA NICs (Connect x5). The mac address pool feature, which is assessed in the test_invalid_address, inserts 128 (in the case of Connect_X5) addresses and fails this test case. On the other hand, Broadcom P225p devices ar

Re: [PATCH] dts: add l2fwd test suite

2024-09-09 Thread Nicholas Pratte
Just a few clarifying questions below. Otherwise, (Test cases was run on Connect_x5 and Broadcom P225p devices). Reviewed-by: Nicholas Pratte Tested-by: Nicholas Pratte > + > +with TestPmdShell( > +self.sut_node, > +lcore_filter_specifier=Logi

[PATCH v5 0/2] Mac Filter Port to New DTS

2024-09-12 Thread Nicholas Pratte
v5: * Addressed some concerns on docstrings based on previous reviews. Nicholas Pratte (2): dts: add methods for setting mac and multicast addresses dts: mac filter test suite refactored for new dts dts/framework/config/conf_yaml_schema.json| 3 +- dts/framework/remote_session

[PATCH v5 1/2] dts: add methods for setting mac and multicast addresses

2024-09-12 Thread Nicholas Pratte
based on a boolean 'add or remove' parameter. The success or failure of each call can be verified if a user deems it necessary. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/remote_session/testpmd_shell.py | 59 +++ 1 file changed, 59 insertions(+) d

[PATCH v5 2/2] dts: mac filter test suite refactored for new dts

2024-09-12 Thread Nicholas Pratte
--rxfreet=64 --mbcache=250 --portmask=0x3 depends-on: patch-143594 ("dts: add send_packets to test suites and rework packet addressing") depends-on: patch-143385 ("dts: add VLAN methods to testpmd shell") Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- v2: * Refact

Re: [PATCH v2 1/6] dts: Remove build target config and list of devices

2024-09-12 Thread Nicholas Pratte
On Tue, Sep 10, 2024 at 7:30 AM Juraj Linkeš wrote: > > The subject line should be all lowercase (except for abbreviations and > maybe some other exceptions). Ack. > > On 5. 7. 2024 19:13, Nicholas Pratte wrote: > > Remove the list of devices from the schema, as these

Re: [PATCH v2 1/6] dts: Remove build target config and list of devices

2024-09-12 Thread Nicholas Pratte
> > @classmethod > > def from_dict(cls, d: BuildTargetConfigDict) -> Self: > > r"""A convenience method that processes the inputs before creating > > an instance. > > > > -`arch`, `os`, `cpu` and `compiler` are converted to > > :class:`Enum`\s and > > -`name` i

[PATCH v6 0/2] Mac Filter Port to New DTS

2024-10-08 Thread Nicholas Pratte
v6: * Added a subtle change to the invalid address test to avoid failures. This component should be discussed and eventually fixed as this is a temporary fix for a discovered issue. * Added decorators to sync with the capabilities patch. Nicholas Pratte (2): dts: add methods for

[PATCH v6 2/2] dts: mac filter test suite refactored for new dts

2024-10-08 Thread Nicholas Pratte
--rxfreet=64 --mbcache=250 --portmask=0x3 depends-on: patch-143594 ("dts: add send_packets to test suites and rework packet addressing") depends-on: patch-143385 ("dts: add VLAN methods to testpmd shell") Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- v2: * Refact

[PATCH v6 1/2] dts: add methods for setting mac and multicast addresses

2024-10-08 Thread Nicholas Pratte
based on a boolean 'add or remove' parameter. The success or failure of each call can be verified if a user deems it necessary. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/remote_session/testpmd_shell.py | 59 +++ 1 file changed, 59 insertions(+) d

[PATCH v9 3/3] dts: mac filter test suite refactored for new dts

2024-10-16 Thread Nicholas Pratte
igned to be vendor agnostic. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestSuite_mac_filter.py | 204 + 2 files changed, 206 insertions(+), 1 deletion(-) create mode 100644 dts/

[PATCH v9 1/3] dts: add methods for setting mac and multicast addresses

2024-10-16 Thread Nicholas Pratte
based on a boolean 'add or remove' parameter. The success or failure of each call can be verified if a user deems it necessary. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/remote_session/testpmd_shell.py | 59 +++ 1 file changed, 59 insertions(+) d

[PATCH v9 2/3] dts: add capability check for multicast filtering

2024-10-16 Thread Nicholas Pratte
The multicast address filter component of the mac filter test suite is definitively supported across all vendors. Thus, a simple capability check is added to ensure that this functionality is supported. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/remote_session

[PATCH v9 0/3] dts: mac filter port to new dts

2024-10-16 Thread Nicholas Pratte
v9: * Removed the vlan component of the multicast filter test as there is an ongoing bug with this functionality across many NICs. * Added a multicast address capability check since some NICs do not support this feature. Nicholas Pratte (3): dts: add methods for setting mac and

[PATCH v7 0/2] dts: mac filter port to new dts

2024-10-10 Thread Nicholas Pratte
v7: * adjusted commit messages to be more associative with the main branch Nicholas Pratte (2): dts: add methods for setting mac and multicast addresses dts: mac filter test suite refactored for new dts dts/framework/config/conf_yaml_schema.json| 3 +- dts/framework

[PATCH v7 1/2] dts: add methods for setting mac and multicast addresses

2024-10-10 Thread Nicholas Pratte
based on a boolean 'add or remove' parameter. The success or failure of each call can be verified if a user deems it necessary. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/remote_session/testpmd_shell.py | 59 +++ 1 file changed, 59 insertions(+) d

[PATCH v7 2/2] dts: mac filter test suite refactored for new dts

2024-10-10 Thread Nicholas Pratte
igned to be vendor agnostic. depends-on: patch-143594 ("dts: add send_packets to test suites and rework packet addressing") depends-on: patch-143385 ("dts: add VLAN methods to testpmd shell") Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/config/conf_yaml_

[PATCH v8 2/2] dts: mac filter test suite refactored for new dts

2024-10-10 Thread Nicholas Pratte
igned to be vendor agnostic. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- v1: * In porting over this test suite into the new framework, some adjustments were made, namely in the EAL and TestPMD parameter provided before executing the application. While the original test pla

[PATCH v8 1/2] dts: add methods for setting mac and multicast addresses

2024-10-10 Thread Nicholas Pratte
based on a boolean 'add or remove' parameter. The success or failure of each call can be verified if a user deems it necessary. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/remote_session/testpmd_shell.py | 59 +++ 1 file changed, 59 insertions(+) d

[PATCH v8 0/2] dts: mac filter port to new dts

2024-10-10 Thread Nicholas Pratte
v8: * final adjustments made for the merged version of vlan testpmd methods. Nicholas Pratte (2): dts: add methods for setting mac and multicast addresses dts: mac filter test suite refactored for new dts dts/framework/config/conf_yaml_schema.json| 3 +- dts/framework

<    1   2   3   >