[dpdk-dev] [PATCH] net/octeontx2: support non-ethernet L2 hdr

2021-07-01 Thread Anoob Joseph
In the inline inound path, a custom header would be present at L3 which has sequence number & SPI. L2 need to be adjusted such that the eventual packet would have L3 after L2. Remove assumption of L2 type in this handling. Signed-off-by: Anoob Joseph --- drivers/crypto/octeo

[dpdk-dev] [PATCH 1/2] crypto/octeontx2: reset feature flags during config

2021-07-02 Thread Anoob Joseph
Feature flags in dev would be updated during config. On reconfigure, the field need to be set again to original value. Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx2/otx2_cryptodev.c | 30 --- drivers/crypto/octeontx2/otx2_cryptodev.h | 1 + drivers

[dpdk-dev] [PATCH 2/2] crypto/octeontx2: clear session priv mem upon destroy

2021-07-02 Thread Anoob Joseph
During session destroy, clear session private memory. Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_sec.c b/drivers/crypto/octeontx2/otx2_cryptodev_sec.c index 3c5686a

RE: [PATCH v1] test/crypto: remove unused stats in test setup

2024-07-15 Thread Anoob Joseph
> Subject: [PATCH v1] test/crypto: remove unused stats in test setup > > Remove unused stats in test setup. > > Coverity issue: 373869 > Fixes: 2c6dab9cd93 ("test/crypto: add RSA and Mod tests") > Cc: sta...@dpdk.org > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph

RE: [PATCH v1] test/crypto: fix asymmetric capability test

2024-07-15 Thread Anoob Joseph
issue: 373365 > Fixes: 2c6dab9cd93 ("test/crypto: add RSA and Mod tests") > Cc: sta...@dpdk.org > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph

RE: [PATCH v1] test/crypto: fix comparison function for modex values

2024-07-15 Thread Anoob Joseph
ro") > Cc: sta...@dpdk.org > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph

RE: [PATCH] doc: announce cryptodev change to support EDDSA

2024-07-23 Thread Anoob Joseph
> Subject: [PATCH] doc: announce cryptodev change to support EDDSA > > Announce the additions in cryptodev ABI to support EDDSA algorithm. > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph

RE: [PATCH] doc: announce cryptodev changes to offload RSA in VirtIO

2024-07-23 Thread Anoob Joseph
> Subject: [PATCH] doc: announce cryptodev changes to offload RSA in VirtIO > > Announce cryptodev changes to offload RSA asymmetric operation in VirtIO > PMD. > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph

RE: [PATCH] doc: announce change in crypto queue setup

2024-07-31 Thread Anoob Joseph
> > Certain hardware crypto PMDs may support setting up of priority to a queue > pair. > Hence a new parameter for priority will be added in struct > rte_cryptodev_qp_conf. > > Signed-off-by: Akhil Goyal Acked-by: Anoob Joseph

RE: [PATCH v1] examples/ipsec-secgw: free the actual mbuf pointer

2024-08-21 Thread Anoob Joseph
gt; Signed-off-by: Vidya Sagar Velumuri Acked-by: Anoob Joseph

[PATCH 0/6] Fixes and improvements in crypto unit tests

2024-08-22 Thread Anoob Joseph
Enable larger packet sizes in TLS tests and add minor improvements in crypto unit tests. Anoob Joseph (6): test/crypto: add asserts to validate test lengths test/crypto: enable larger packet sizes with TLS test/crypto: remove redefinition test/crypto: remove unused macros test/crypto

[PATCH 6/6] test/crypto: free pools in teardown

2024-08-22 Thread Anoob Joseph
Free the pools allocated in testsuite_setup. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 1491ff03ba..6079d10078 100644 --- a/app/test

[PATCH 5/6] test/crypto: start opening brace in new line

2024-08-22 Thread Anoob Joseph
Start opening brace of the function body in new line as suggested in coding guideline. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/app/test/test_cryptodev.h b/app/test/test_cryptodev.h index c56ef2fe3f

[PATCH 4/6] test/crypto: remove unused macros

2024-08-22 Thread Anoob Joseph
The macros are not used. Remove the same. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c | 2 -- app/test/test_cryptodev.h | 5 - 2 files changed, 7 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 169e2f3b48..1491ff03ba 100644 --- a/app/test

[PATCH 2/6] test/crypto: enable larger packet sizes with TLS

2024-08-22 Thread Anoob Joseph
Enable larger packet sizes with TLS. Add wrapper for existing create_segmented_mbuf() function to get allocations from both pools. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c | 13 +-- app/test/test_cryptodev.h | 38

[PATCH 3/6] test/crypto: remove redefinition

2024-08-22 Thread Anoob Joseph
Remove redefinition of TRUE & FALSE. These are defined by stdbool. Can use the same. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c | 5 +++-- app/test/test_cryptodev.h | 3 --- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/

[PATCH 1/6] test/crypto: add asserts to validate test lengths

2024-08-22 Thread Anoob Joseph
Add asserts to validate the max lengths set. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c | 2 +- app/test/test_cryptodev.h | 2 ++ app/test/test_cryptodev_aead_test_vectors.h | 14 +- 3 files changed, 16 insertions(+), 2 deletions

[PATCH 1/2] test/crypto: allow retries with stats test

2024-08-26 Thread Anoob Joseph
Stats need not be reflected instantly after the operation. Relax the test case to have retries to allow slower updates. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.h| 1 + app/test/test_cryptodev_security_ipsec.c | 11 ++- 2 files changed, 11 insertions

[PATCH 2/2] crypto/cnxk: remove delay in stats

2024-08-26 Thread Anoob Joseph
Having 1 ms delay for retrieving stats per session would mean significant delay for a system with large number of sessions. If accurate stats are required, application can call stats again after a delay and get most updated stats. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk

RE: [PATCH] crypto/cnxk: fix condition check

2022-06-09 Thread Anoob Joseph
rity issue: 378865 > > Signed-off-by: Volodymyr Fialko Acked-by: Anoob Joseph

RE: [PATCH 1/1] examples/ipsec-secgw: add option for descriptors per QP

2022-06-09 Thread Anoob Joseph
re packets to stay in flight simultaneously and reduce enqueue > failures. > > Signed-off-by: Volodymyr Fialko Acked-by: Anoob Joseph

[PATCH 1/2] crypto/octeontx: pass sub event type in event

2022-06-10 Thread Anoob Joseph
Response info may have valid sub_event_type. Pass this to the event generated by CPT. Signed-off-by: Anoob Joseph Reviewed-by: Shijith Thotton Reviewed-by: Jerin Jacob Kollanukkaran --- drivers/crypto/octeontx/otx_cryptodev_ops.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

[PATCH 2/2] crypto/cnxk: pass sub event type in event

2022-06-10 Thread Anoob Joseph
Response info may have valid sub_event_type. Pass this to the event generated by CPT. Signed-off-by: Anoob Joseph Reviewed-by: Shijith Thotton Reviewed-by: Jerin Jacob Kollanukkaran --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 7 --- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 7

RE: [EXT] [PATCH] test/crypto: fix warnings for optimization=1 build

2022-06-12 Thread Anoob Joseph
Hi Rahul, Please see inline. Thanks, Anoob > -Original Message- > From: Rahul Lakkireddy > Sent: Saturday, June 11, 2022 3:40 AM > To: dev@dpdk.org > Cc: Akhil Goyal ; roy.fan.zh...@intel.com; > sta...@dpdk.org > Subject: [EXT] [PATCH] test/crypto: fix warnings for optimization=1 build

RE: [EXT] [PATCH v2] test/crypto: fix warnings for optimization=1 build

2022-06-13 Thread Anoob Joseph
:32: note: ‘td_outb’ declared here > struct ipsec_test_data td_outb[IPSEC_TEST_PACKETS_MAX]; > ^~~ > > Bugzilla ID: 1032 > Fixes: d02c6bfcb99a ("test/crypto: add ESN and antireplay cases") > Cc: sta...@dpdk.org > > Reported-by: Daxue Gao > Signed-off-by: Rahul Lakkireddy Acked-by: Anoob Joseph

[PATCH] crypto/cnxk: add CPT hardware flow control checks

2022-06-20 Thread Anoob Joseph
gured. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/hw/cpt.h | 9 drivers/common/cnxk/roc_cpt.c | 10 - drivers/common/cnxk/roc_cpt.h | 12 +- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 20 - drivers/crypto

RE: [PATCH v3] app/test: add event inline security tests

2022-06-22 Thread Anoob Joseph
; > Signed-off-by: Volodymyr Fialko Acked-by: Anoob Joseph

[PATCH] crypto/cnxk: predecrement esn value to be used in session

2022-06-27 Thread Anoob Joseph
ESN provided in the session would be the next sequence number to be used. Hence predecrement the value, so that in datapath, incremented value will be as expected. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn9k_ipsec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [dpdk-dev] [PATCH v4 2/3] event/octeontx2: support crypto adapter forward mode

2021-04-06 Thread Anoob Joseph
Hi Abhinandan, Please see inline. Thanks, Anoob > > > > Advertise crypto adapter forward mode capability and set crypto > > adapter enqueue function in driver. > > > > Signed-off-by: Shijith Thotton [snip] > > + > > + if (!ev->sched_type) > > + otx2_ssogws_head_wait(tag_op); > > +

RE: [EXT] [PATCH v2 4/4] crypto: modify return value for asym session create

2022-01-31 Thread Anoob Joseph
Hi Ciara, Minor nits. Please see inline. With the fixes, Acked-by: Anoob Joseph Thanks, Anoob > -Original Message- > From: Ciara Power > Sent: Monday, January 24, 2022 8:34 PM > To: dev@dpdk.org > Cc: roy.fan.zh...@intel.com; Akhil Goyal ; Anoob Joseph > ; m...@ashr

RE: [EXT] [PATCH v2 3/4] crypto: add asym session user data API

2022-01-31 Thread Anoob Joseph
Hi Ciara, Minor nits inline. Acked-by: Anoob Joseph Thanks, Anoob > -Original Message- > From: Ciara Power > Sent: Monday, January 24, 2022 8:34 PM > To: dev@dpdk.org > Cc: roy.fan.zh...@intel.com; Akhil Goyal ; Anoob Joseph > ; m...@ashroe.eu; Ciara Power

RE: [EXT] [PATCH v5 2/5] crypto: use single buffer for asymmetric session

2022-02-10 Thread Anoob Joseph
Hi Ciara, Minor nit inline. With that Series Acked-by: Anoob Joseph Thanks, Anoob > -Original Message- > From: Ciara Power > Sent: Thursday, February 10, 2022 7:32 PM > To: dev@dpdk.org > Cc: roy.fan.zh...@intel.com; Akhil Goyal ; Anoob Joseph > ; m...@ashr

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-12 Thread Anoob Joseph
Hi Ray, Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Tuesday, October 12, 2021 3:49 PM > To: Kinsella, Ray ; dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > hemant.agra...@nxp.com; Anoob Joseph ; &

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-12 Thread Anoob Joseph
Hi Ray, Please see inline. Thanks, Anoob > -Original Message- > From: Kinsella, Ray > Sent: Tuesday, October 12, 2021 4:58 PM > To: Anoob Joseph ; Akhil Goyal ; > dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > hemant.agra...@nxp.com; pablo.de.

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-12 Thread Anoob Joseph
Hi Thomas, Please see inline. Thanks, Anoob > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, October 12, 2021 5:22 PM > To: Kinsella, Ray ; Akhil Goyal ; > dev@dpdk.org; Anoob Joseph > Cc: david.march...@redhat.com; hemant.agra...@nxp.com; > pablo.de.

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-12 Thread Anoob Joseph
Hi Thomas, Please see inline. Thanks, Anoob > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, October 12, 2021 7:25 PM > To: Kinsella, Ray ; Akhil Goyal ; > dev@dpdk.org; Anoob Joseph > Cc: david.march...@redhat.com; hemant.agra...@nxp.com; > pablo.de.

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-12 Thread Anoob Joseph
Hi Thomas, Ray, Please see inline. Thanks, Anoob > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, October 12, 2021 8:37 PM > To: Anoob Joseph ; Akhil Goyal > ; dev@dpdk.org; Kinsella, Ray > Cc: david.march...@redhat.com; hemant.agra...@nxp.com; &

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-13 Thread Anoob Joseph
Hi Akhil, Ray, Thomas, Please see inline. Thanks, Anoob > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, October 13, 2021 12:32 PM > To: Akhil Goyal ; dev@dpdk.org; Kinsella, Ray > ; Anoob Joseph > Cc: david.march...@redhat.com; hema

[dpdk-dev] [PATCH 1/2] common/cnxk: align CPT queue depth to power of 2

2021-10-18 Thread Anoob Joseph
Use CPT LF queue depth as power of 2 to aid in masked checks for pending queue. Signed-off-by: Anoob Joseph Acked-by: Jerin Jacob Kollanukkaran --- drivers/common/cnxk/roc_cpt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/common/cnxk/roc_cpt.c b/drivers/common/cnxk/roc_cpt.c

[dpdk-dev] [PATCH 2/2] crypto/cnxk: rework pending queue

2021-10-18 Thread Anoob Joseph
Rework pending queue to allow producer and consumer cores to be different. Signed-off-by: Anoob Joseph --- doc/guides/cryptodevs/cnxk.rst| 6 --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 36 +++--- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 63

RE: [PATCH 1/1] crypto/cnxk: enable 3des-cbc secure capability

2022-05-02 Thread Anoob Joseph
Hi Vamsi, Please see inline. Thanks, Anoob > -Original Message- > From: Vamsi Attunuru > Sent: Saturday, April 30, 2022 11:07 AM > To: dev@dpdk.org > Cc: Anoob Joseph ; Akhil Goyal > ; Vamsi Krishna Attunuru > Subject: [PATCH 1/1] crypto/cnxk: enable 3des-

RE: [PATCH v2 1/1] crypto/cnxk: enable 3des-cbc secure capability

2022-05-02 Thread Anoob Joseph
_cryptodev_capabilities.c | 24 +++ > drivers/crypto/cnxk/cnxk_ipsec.h | 4 > 3 files changed, 29 insertions(+), 1 deletion(-) Acked-by: Anoob Joseph

RE: [PATCH v4 1/7] cryptodev: add APIs to get/set event metadata

2022-05-02 Thread Anoob Joseph
Hi Akhil, Minor nit inline. With that addressed, Series Acked-by: Anoob Joseph Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Monday, May 2, 2022 12:55 AM > To: dev@dpdk.org > Cc: Anoob Joseph ; Jerin Jacob Kollanukkaran > ; abhinanda

RE: [EXT] [PATCH 1/8] app/test-crypto-perf: improve dequeue logic

2022-05-16 Thread Anoob Joseph
Hi Gagandeep, Please see inline. Thanks, Anoob > -Original Message- > From: Gagandeep Singh > Sent: Monday, May 16, 2022 12:44 PM > To: Akhil Goyal ; dev@dpdk.org; Hemant Agrawal > > Cc: Anoob Joseph > Subject: RE: [EXT] [PATCH 1/8] app/test-crypto-perf: improve

RE: [PATCH v7 0/7] app/test: add inline IPsec and reassembly cases

2022-05-24 Thread Anoob Joseph
+ > app/test/test_security_inline_proto.c | 2382 + > app/test/test_security_inline_proto_vectors.h | 704 + > doc/guides/rel_notes/release_22_07.rst|5 + > 7 files changed, 3137 insertions(+), 2 deletions(-) create mode 100644 > app/test/test_security_inline_proto.c > create mode 100644 app/test/test_security_inline_proto_vectors.h > > -- > 2.25.1 Series Acked-by: Anoob Joseph

[PATCH] app/test: update skipped count when setup returns skipped

2022-05-24 Thread Anoob Joseph
If the setup function returns TEST_SKIPPED, the logs would say the test case is skipped while the summary count would consider it under failed cases. Address this by counting such test cases under 'skipped'. Signed-off-by: Anoob Joseph --- app/test/test.c | 2 ++ 1 file changed, 2

RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform

2022-05-25 Thread Anoob Joseph
Hi Arek, Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, May 25, 2022 12:06 PM > To: Akhil Goyal ; dev@dpdk.org; Kiran Kumar > Kokkilagadda ; Anoob Joseph > > Cc: Zhang, Roy Fan > Subject: RE: [EXT]

RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform

2022-05-27 Thread Anoob Joseph
Hi Arek, Please see inline. Thanks, Anoob > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, May 27, 2022 12:26 PM > To: Anoob Joseph ; Akhil Goyal ; > dev@dpdk.org; Kiran Kumar Kokkilagadda > Cc: Zhang, Roy Fan ; Umesh Kartha > ; Ramkumar Balu

Re: [dpdk-dev] [PATCH] crypto/cnxk: fix bus error on RSA verify

2021-10-24 Thread Anoob Joseph
uot;) > > Signed-off-by: Kiran Kumar K > --- > drivers/crypto/cnxk/cnxk_ae.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Acked-by: Anoob Joseph

Re: [dpdk-dev] [PATCH] common/cnxk: fix build failure

2021-10-28 Thread Anoob Joseph
> Subject: [PATCH] common/cnxk: fix build failure > > Fixing build failure with EXTRA_CFLAGS='-O1'. > > Fixes: d85f9749f915 ("common/cnxk: add hash generation API") > > Reported-by: Longfeng Liang > Signed-off-by: Tejasree Kondoj Acked-by: Anoob Joseph

Re: [dpdk-dev] [PATCH] crypto/octeontx2: fix ESN seqhi

2021-10-28 Thread Anoob Joseph
: Archana Muniganti > --- > drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > Acked-by: Anoob Joseph

Re: [dpdk-dev] [PATCH 0/6] add cnxk lookaside IPsec additional features

2021-10-28 Thread Anoob Joseph
feature addition, key length and supported features list update > is added. > > Anoob Joseph (2): > common/cnxk: add null auth with IPsec > crypto/cnxk: add null auth > > Archana Muniganti (4): > crypto/cnxk: add cn9k ESN and anti-replay support > doc/guides: up

Re: [dpdk-dev] [PATCH] crypto/octeontx2: fix lookaside IPsec IPv6 support

2021-10-29 Thread Anoob Joseph
Tejasree Kondoj Acked-by: Anoob Joseph

Re: [dpdk-dev] [EXT] [dpdk-dev v1] test/cryptodev: fix incomplete data length

2021-11-07 Thread Anoob Joseph
Hi Kai, Patch looks good. Wondering if we need same fix in functions such as " test_zuc_auth_cipher()". We were also hitting this issue when we enabled few additional features in Marvell PMDs. Upon investigation, we realized that this issue would come up for certain packet size combinations if

Re: [dpdk-dev] [EXT] [dpdk-dev v1] test/cryptodev: fix incomplete data length

2021-11-07 Thread Anoob Joseph
Hi Kai, Also, couple of nits. Please check inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Anoob Joseph > Sent: Monday, November 8, 2021 9:36 AM > To: Kai Ji ; dev@dpdk.org; Akhil Goyal > > Cc: pablo.de.lara.gua...@intel.com; adamx.dybkow...@intel

[dpdk-dev] [PATCH] test/crypto: fix missing return checks

2021-11-08 Thread Anoob Joseph
The API could return errors. Add error checking for the same. Fixes: b3bbd9e5f265 ("cryptodev: support device independent sessions") Cc: slawomirx.mrozow...@intel.com Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c | 116 -- 1 fi

[dpdk-dev] [PATCH] test/crypto: skip plain text compare for null cipher OOP

2021-11-08 Thread Anoob Joseph
NULL cipher is used for validating auth only cases. With out of place processing, validating plain text should not be done as the PMD is only expected to update auth data. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c | 17 + 1 file changed, 17 insertions(+) diff

Re: [dpdk-dev] [EXT] [dpdk-dev v2] test/cryptodev: fix incomplete data length

2021-11-09 Thread Anoob Joseph
Hi Kai, Minor nit inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Kai Ji > Sent: Tuesday, November 9, 2021 3:57 PM > To: dev@dpdk.org > Cc: Kai Ji ; pablo.de.lara.gua...@intel.com; > adamx.dybkow...@intel.com; damianx.no...@intel.com > Subject: [EXT] [dpdk-dev] [dpdk

Re: [dpdk-dev] [EXT] [dpdk-dev v3] test/cryptodev: fix incomplete data length

2021-11-09 Thread Anoob Joseph
Hi Kai, Thanks for addressing the comments. Acked-by: Anoob Joseph > > -- > This patch fixes incorrect data lengths computation in cryptodev unit test. > Previously some data lengths were incorrectly se

[dpdk-dev] [PATCH] common/cnxk: fix memory leak

2021-11-09 Thread Anoob Joseph
The memory allocated for temporarily keeping DPTR need to be freed after operation. Also, dptr need to be aligned to 8B. Fixes: e0bf49f7622b ("common/cnxk: add code to write CPT CTX through microcode op") Cc: scha...@marvell.com Signed-off-by: Anoob Joseph Reviewed-by: Nithin Kumar

[dpdk-dev] [PATCH v2] common/cnxk: fix memory leak

2021-11-09 Thread Anoob Joseph
The memory allocated for temporarily keeping DPTR need to be freed after operation. Also, dptr need to be aligned to 8B. Fixes: 71213a8b773c ("common/cnxk: support CPT CTX write through microcode op") Cc: scha...@marvell.com Signed-off-by: Anoob Joseph Reviewed-by: Nithin Kumar

Re: [dpdk-dev] [PATCH v3] eventdev: update crypto adapter metadata structures

2021-09-13 Thread Anoob Joseph
Hi Abhinandan, Shijith, Please see inline. Thanks, Anoob > -Original Message- > From: Shijith Thotton > Sent: Tuesday, September 14, 2021 10:07 AM > To: Gujjar, Abhinandan S ; dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > ; Pavan Nikhilesh Bhagavatu

Re: [dpdk-dev] [EXT] Re: [PATCH] RFC: ethdev: add reassembly offload

2021-09-13 Thread Anoob Joseph
Hi Andrew, Rosen, Please see inline. Thanks, Anoob > -Original Message- > From: Andrew Rybchenko > Sent: Monday, September 13, 2021 12:52 PM > To: Xu, Rosen ; Anoob Joseph > ; Yigit, Ferruh ; Andrew > Rybchenko > Cc: Nicolau, Radu ; Doherty, Declan > ; hema

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix parsing of flow queue

2021-09-15 Thread Anoob Joseph
Documentation specifies that flow port & queue is provided as, <...> port 0 queue 0 But code is expecting the same as, <...> port 0 0 Fix the above to match documentation. Fixes: 8e693616fcb2 ("examples/ipsec-secgw: enable flow based distribution") Signed-off-by: A

Re: [dpdk-dev] [EXT] [PATCH v2 4/9] examples/ipsec-secgw: add stats interval argument

2021-09-16 Thread Anoob Joseph
Hi Radu, Making stats dynamic would have a perf cost. That was the reason it was introduced as a compile time option. Why do we need it changed? Also, it looks like this patch is only disabling stats printing when timeout is 0. I don't see stats collection being conditional. Stats collection wo

Re: [dpdk-dev] [PATCH v2 1/6] security: add SA lifetime configuration

2021-09-16 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, September 16, 2021 4:36 PM > To: Anoob Joseph ; Akhil Goyal > ; Doherty, Declan ; > Zhang, Roy Fan > Cc: Jerin Jacob Kollanukkaran ; Archana Munigant

Re: [dpdk-dev] [EXT] [PATCH v2 4/9] examples/ipsec-secgw: add stats interval argument

2021-09-17 Thread Anoob Joseph
Hi Radu, Please see inline. Thanks, Anoob > Subject: Re: [EXT] [dpdk-dev] [PATCH v2 4/9] examples/ipsec-secgw: add > stats interval argument > > Hi Anoob, > > On 9/16/2021 10:30 AM, Anoob Joseph wrote: > > Hi Radu, > > > > Making stats dynamic would have

[dpdk-dev] [PATCH v4 0/5] Add lookaside IPsec tests

2021-09-17 Thread Anoob Joseph
ser to specify IV. - Added IV generation tests - Minor fixes in combined mode tests to handle multiple packets Anoob Joseph (2): test/crypto: add lookaside IPsec tests test/crypto: add combined mode tests Tejasree Kondoj (3): test/crypto: add lookaside IPsec ICV corrupt test case test/crypto

[dpdk-dev] [PATCH v4 1/5] test/crypto: add lookaside IPsec tests

2021-09-17 Thread Anoob Joseph
Added test case for lookaside IPsec. Inbound known vector tests are added. Cipher list: AES-GCM 128, 192 & 256 Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/meson.build | 1 + app/test/test.h|

[dpdk-dev] [PATCH v4 2/5] test/crypto: add combined mode tests

2021-09-17 Thread Anoob Joseph
Add framework to test IPsec features with all supported combinations of ciphers. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 73 +++-- app/test/test_cryptodev_security_ipsec.c | 107

[dpdk-dev] [PATCH v4 3/5] test/crypto: add lookaside IPsec ICV corrupt test case

2021-09-17 Thread Anoob Joseph
From: Tejasree Kondoj Adding lookaside IPsec ICV corrupt test case. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 16 app/test/test_cryptodev_security_ipsec.c | 30 -- app/test

[dpdk-dev] [PATCH v4 4/5] test/crypto: add IV gen tests

2021-09-17 Thread Anoob Joseph
From: Tejasree Kondoj Add test cases to verify IV generated by PMD. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 19 app/test/test_cryptodev_security_ipsec.c | 52 app/test

[dpdk-dev] [PATCH v4 5/5] test/crypto: add UDP encapsulation test cases

2021-09-17 Thread Anoob Joseph
From: Tejasree Kondoj Adding UDP encapsulation test cases. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 19 +++ app/test/test_cryptodev_security_ipsec.c | 28 app/test/test_cryptodev_security_ipsec.h | 1 + doc/guid

Re: [dpdk-dev] [PATCH v4 1/5] test/crypto: add lookaside IPsec tests

2021-09-22 Thread Anoob Joseph
Hi Akhil, Thanks for the review. Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Tuesday, September 21, 2021 9:38 PM > To: Anoob Joseph ; Declan Doherty > ; Fan Zhang ; > Konstantin Ananyev ; Ciara Power > > Cc: An

Re: [dpdk-dev] [PATCH v4 1/5] test/crypto: add lookaside IPsec tests

2021-09-23 Thread Anoob Joseph
Hi Ciara, Please see inline. Thanks, Anoob > -Original Message- > From: Power, Ciara > Sent: Thursday, September 23, 2021 4:09 PM > To: Anoob Joseph ; Akhil Goyal ; > Doherty, Declan ; Zhang, Roy Fan > ; Ananyev, Konstantin > > Cc: Jerin Jacob Kollanukk

Re: [dpdk-dev] [PATCH v4 1/5] test/crypto: add lookaside IPsec tests

2021-09-23 Thread Anoob Joseph
Hi Ciara, I'm planning to send next version addressing Akhil's comments. Can you review and ack patches if you don't have further comments? Thanks, Anoob > -Original Message- > From: Power, Ciara > Sent: Thursday, September 23, 2021 4:57 PM > To: Anoob Josep

Re: [dpdk-dev] [EXT] Re: [PATCH v4 2/5] test/crypto: add combined mode tests

2021-09-24 Thread Anoob Joseph
Hi Hemant, Please see inline. Thanks, Anoob > -Original Message- > From: Hemant Agrawal > Sent: Friday, September 24, 2021 12:54 PM > To: Anoob Joseph ; Akhil Goyal ; > Declan Doherty ; Fan Zhang > ; Konstantin Ananyev > > Cc: Jerin Jacob Kollanukkaran ; Archan

Re: [dpdk-dev] [EXT] app/test: fix pdcp short mac test

2021-09-24 Thread Anoob Joseph
e changed, 1 insertion(+), 5 deletions(-) Acked-by: Anoob Joseph

[dpdk-dev] [PATCH] common/cpt: rework pending queue

2021-09-24 Thread Anoob Joseph
From: David George Replace pending queue with one that allows concurrent single producer and single consumer. This relaxes the restriction of only allowing a single lcore to operate on a given queue pair. Signed-off-by: David George Signed-off-by: Anoob Joseph --- doc/guides/cryptodevs

[dpdk-dev] [PATCH v5 0/5] Add lookaside IPsec tests

2021-09-25 Thread Anoob Joseph
Dropped outbound known vector tests as lookaside protocol would require IV generated by PMD. The tests would be introduced with spec change to allow user to specify IV. - Added IV generation tests - Minor fixes in combined mode tests to handle multiple packets Anoob Joseph (2): test/cry

[dpdk-dev] [PATCH v5 1/5] test/crypto: add lookaside IPsec cases

2021-09-25 Thread Anoob Joseph
Added test case for lookaside IPsec. Inbound known vector tests are added. Cipher list: AES-GCM 128, 192 & 256 Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj Acked-by: Akhil Goyal Acked-by: Ciara Power Acked-by: Hemant Agrawal --- app/test/meson.b

[dpdk-dev] [PATCH v5 2/5] test/crypto: add combined mode IPsec cases

2021-09-25 Thread Anoob Joseph
the test, known vectors are not required. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj Acked-by: Akhil Goyal Acked-by: Ciara Power --- app/test/test_cryptodev.c| 73 +++-- app/test/test_cryptodev_security_ipsec.c | 107

[dpdk-dev] [PATCH v5 3/5] test/crypto: add lookaside IPsec ICV corrupt test case

2021-09-25 Thread Anoob Joseph
validate that PMD returns an error in such cases. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj Acked-by: Akhil Goyal Acked-by: Ciara Power Acked-by: Hemant Agrawal --- app/test/test_cryptodev.c| 16 app/test/test_cryptodev_security_ipsec.c | 30

[dpdk-dev] [PATCH v5 4/5] test/crypto: add IV gen cases for IPsec

2021-09-25 Thread Anoob Joseph
From: Tejasree Kondoj Added cases to verify IV generated by PMD for lookaside IPsec. The tests compare IV generated for a batch of packets and ensures that IV is not getting repeated in the batch. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj Acked-by: Akhil Goyal Acked-by

[dpdk-dev] [PATCH v5 5/5] test/crypto: add UDP encapsulated IPsec test cases

2021-09-25 Thread Anoob Joseph
-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj Acked-by: Akhil Goyal Acked-by: Ciara Power --- app/test/test_cryptodev.c| 19 +++ app/test/test_cryptodev_security_ipsec.c | 28 app/test/test_cryptodev_security_ipsec.h | 1

Re: [dpdk-dev] [PATCH] net/octeontx2: use fast udata and mdata flags

2021-09-26 Thread Anoob Joseph
> > Using fast metadata and userdata flags instead of driver callbacks for > set_pkt_metadata and get_userdata in inline IPsec. > > Signed-off-by: Tejasree Kondoj Acked-by: Anoob Joseph

[dpdk-dev] [PATCH v3 0/6] Add SA lifetime in security

2021-09-28 Thread Anoob Joseph
Unit tests are added for soft and hard expiry with number of packets. Changes in v3: - Removed explicit 0 setting of soft expiry configuration in ipsec-secgw (comment from Konstantin) Changes in v2: - Clear soft expiry configuration in ipsec-secgw - Rebased on v3 of dependent series Anoob Josep

[dpdk-dev] [PATCH v3 1/6] security: add SA lifetime configuration

2021-09-28 Thread Anoob Joseph
`rte_crypto_op.aux_flags` field. In case of hard expiry, the packets will not be IPsec processed and would result in error. Signed-off-by: Anoob Joseph Acked-by: Konstantin Ananyev --- .../test_cryptodev_security_ipsec_test_vectors.h | 3 --- doc/guides/rel_notes/deprecation.rst | 5 doc

[dpdk-dev] [PATCH v3 2/6] common/cnxk: support lifetime configuration

2021-09-28 Thread Anoob Joseph
Add support for SA lifetime configuration. Expiry can be either in units of octets or packets. Also, updated cryptodev dequeue path to update crypto op result to indicate soft expiry. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/cnxk_security.c | 70

[dpdk-dev] [PATCH v3 3/6] crypto/octeontx2: add checks for life configuration

2021-09-28 Thread Anoob Joseph
Lifetime tracking is not supported by hardware and is not implemented in software either. Return failure when lifetime is configured. Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx2/otx2_ipsec_po.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/octeontx2

[dpdk-dev] [PATCH v3 4/6] test/crypto: add packets soft expiry tests

2021-09-28 Thread Anoob Joseph
Add tests to validate packets soft expiry handling. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 21 +++-- app/test/test_cryptodev_security_ipsec.c | 18 -- app/test/test_cryptodev_security_ipsec.h | 4 +++- 3 files changed, 38

[dpdk-dev] [PATCH v3 5/6] test/crypto: add packets hard expiry tests

2021-09-28 Thread Anoob Joseph
Add tests to validate packets hard expiry handling. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 19 ++- app/test/test_cryptodev_security_ipsec.c | 22 +++--- app/test/test_cryptodev_security_ipsec.h | 1 + 3 files changed, 38

[dpdk-dev] [PATCH v3 6/6] examples/ipsec-secgw: clear soft expiry configuration

2021-09-28 Thread Anoob Joseph
the functionality, remove the same by clearing life configuration. Signed-off-by: Anoob Joseph --- examples/ipsec-secgw/ipsec.c | 1 - examples/ipsec-secgw/ipsec.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c index 4868294

[dpdk-dev] [PATCH v4 0/6] Add SA lifetime in security

2021-09-28 Thread Anoob Joseph
n v2: - Clear soft expiry configuration in ipsec-secgw - Rebased on v3 of dependent series Anoob Joseph (6): security: add SA lifetime configuration common/cnxk: support lifetime configuration crypto/octeontx2: add checks for life configuration test/crypto: add packets soft expiry cases test/cr

[dpdk-dev] [PATCH v4 1/6] security: add SA lifetime configuration

2021-09-28 Thread Anoob Joseph
`rte_crypto_op.aux_flags` field. In case of hard expiry, the packets will not be IPsec processed and would result in error. Signed-off-by: Anoob Joseph Acked-by: Konstantin Ananyev --- .../test_cryptodev_security_ipsec_test_vectors.h | 3 --- doc/guides/rel_notes/deprecation.rst | 5 doc

[dpdk-dev] [PATCH v4 2/6] common/cnxk: support lifetime configuration

2021-09-28 Thread Anoob Joseph
Add support for SA lifetime configuration. Expiry can be either in units of octets or packets. Also, updated cryptodev dequeue path to update crypto op result to indicate soft expiry. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/cnxk_security.c | 70

[dpdk-dev] [PATCH v4 3/6] crypto/octeontx2: add checks for life configuration

2021-09-28 Thread Anoob Joseph
Lifetime tracking is not supported by hardware and is not implemented in software either. Return failure when lifetime is configured. Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx2/otx2_ipsec_po.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/octeontx2

[dpdk-dev] [PATCH v4 4/6] test/crypto: add packets soft expiry cases

2021-09-28 Thread Anoob Joseph
Add tests to validate packets soft expiry handling. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 21 +++-- app/test/test_cryptodev_security_ipsec.c | 18 -- app/test/test_cryptodev_security_ipsec.h | 4 +++- 3 files changed, 38

[dpdk-dev] [PATCH v4 5/6] test/crypto: add packets hard expiry cases

2021-09-28 Thread Anoob Joseph
Add tests to validate packets hard expiry handling. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 19 ++- app/test/test_cryptodev_security_ipsec.c | 22 +++--- app/test/test_cryptodev_security_ipsec.h | 1 + 3 files changed, 38

[dpdk-dev] [PATCH v4 6/6] examples/ipsec-secgw: clear soft expiry configuration

2021-09-28 Thread Anoob Joseph
the functionality, remove the same by clearing life configuration. Signed-off-by: Anoob Joseph --- examples/ipsec-secgw/ipsec.c | 1 - examples/ipsec-secgw/ipsec.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c index 4868294

<    1   2   3   4   5   6   7   8   9   10   >