Hi Radu, Please see inline.
Thanks, Anoob > Subject: Re: [EXT] [dpdk-dev] [PATCH v2 4/9] examples/ipsec-secgw: add > stats interval argument > > Hi Anoob, > > On 9/16/2021 10:30 AM, Anoob Joseph wrote: > > Hi Radu, > > > > Making stats dynamic would have a perf cost. That was the reason it was > introduced as a compile time option. Why do we need it changed? > We changed it for two reasons, for a better UX and for the telemetry feature > that is introduced with patch 3. > > > > Also, it looks like this patch is only disabling stats printing when > > timeout is 0. > I don't see stats collection being conditional. Stats collection would also > have > perf impact, right? > I don't think there is a measurable performance impact because these are > per burst calls. [Anoob] Agreed. If it was done intentionally, then I don’t see any problem. Acked-by: Anoob Joseph <ano...@marvell.com> [snip]
