Hi Ciara,
Minor nits inline.
Acked-by: Anoob Joseph <ano...@marvell.com>
Thanks,
Anoob
> -----Original Message-----
> From: Ciara Power <ciara.po...@intel.com>
> Sent: Monday, January 24, 2022 8:34 PM
> To: dev@dpdk.org
> Cc: roy.fan.zh...@intel.com; Akhil Goyal <gak...@marvell.com>; Anoob Joseph
> <ano...@marvell.com>; m...@ashroe.eu; Ciara Power
> <ciara.po...@intel.com>; Declan Doherty <declan.dohe...@intel.com>
> Subject: [EXT] [PATCH v2 3/4] crypto: add asym session user data API
>
> External Email
>
> ----------------------------------------------------------------------
> A user data field is added to the asymmetric session structure.
> Relevant API added to get/set the field.
>
> Signed-off-by: Ciara Power <ciara.po...@intel.com>
>
> ---
> v2: Corrected order of version map entries.
> ---
> app/test/test_cryptodev_asym.c | 2 +-
> lib/cryptodev/cryptodev_pmd.h | 4 ++-
> lib/cryptodev/rte_cryptodev.c | 39 ++++++++++++++++++++++++++---
> lib/cryptodev/rte_cryptodev.h | 34 ++++++++++++++++++++++++-
> lib/cryptodev/rte_cryptodev_trace.h | 3 ++-
> lib/cryptodev/version.map | 2 ++
> 6 files changed, 76 insertions(+), 8 deletions(-)
>
> diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
> index f93f39af42..a81d6292f6 100644
> --- a/app/test/test_cryptodev_asym.c
> +++ b/app/test/test_cryptodev_asym.c
> @@ -897,7 +897,7 @@ testsuite_setup(void)
> }
>
> ts_params->session_mpool =
> rte_cryptodev_asym_session_pool_create(
> - "test_asym_sess_mp", TEST_NUM_SESSIONS * 2, 0,
> + "test_asym_sess_mp", TEST_NUM_SESSIONS * 2, 0, 0,
> SOCKET_ID_ANY);
>
> TEST_ASSERT_NOT_NULL(ts_params->session_mpool,
> diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h
> index 2d12505d3c..a0f7bb0c05 100644
> --- a/lib/cryptodev/cryptodev_pmd.h
> +++ b/lib/cryptodev/cryptodev_pmd.h
> @@ -636,7 +636,9 @@ __extension__ struct rte_cryptodev_asym_session {
> /**< Session driver ID. */
> uint8_t max_priv_session_sz;
> /**< size of private session data used when creating mempool */
> - uint8_t padding[6];
> + uint16_t user_data_sz;
> + /**< session user data will be placed after sess_data */
[Anoob] The formatting of comments is slightly inconsistent here. Like "Session
driver ID." v/s "session user data.." For the line you are adding do you mind
making S capital? Same comment below as well.
> + uint8_t padding[4];
> uint8_t sess_private_data[0];
> };
>
> diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c
> index
> c10b9bf05f..2a591930de 100644
> --- a/lib/cryptodev/rte_cryptodev.c
> +++ b/lib/cryptodev/rte_cryptodev.c
> @@ -210,6 +210,8 @@ struct rte_cryptodev_sym_session_pool_private_data {
> struct rte_cryptodev_asym_session_pool_private_data {
> uint8_t max_priv_session_sz;
> /**< size of private session data used when creating mempool */
> + uint16_t user_data_sz;
> + /**< session user data will be placed after sess_private_data */
> };
>
> int
> @@ -1803,7 +1805,7 @@ rte_cryptodev_sym_session_pool_create(const char
> *name, uint32_t nb_elts,
>
