Hi Rahul,
Please see inline.
Thanks,
Anoob
> -----Original Message-----
> From: Rahul Lakkireddy <rahul.lakkire...@chelsio.com>
> Sent: Saturday, June 11, 2022 3:40 AM
> To: dev@dpdk.org
> Cc: Akhil Goyal <gak...@marvell.com>; roy.fan.zh...@intel.com;
> sta...@dpdk.org
> Subject: [EXT] [PATCH] test/crypto: fix warnings for optimization=1 build
>
> External Email
>
> ----------------------------------------------------------------------
> Skip IPSec ESN and antireplay cases, if there are no packets. Fixes following
> warning when using optimization=1 build flag with GCC 11.
>
> ../app/test/test_cryptodev.c: In function ‘test_ipsec_pkt_replay’:
> ../app/test/test_cryptodev.c:10074:15: warning: ‘td_outb’ may be used
> uninitialized [-Wmaybe-uninitialized]
> ret = test_ipsec_proto_process(td_outb, td_inb, nb_pkts, true,
>
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> &flags);
> ~~~~~~~
> ../app/test/test_cryptodev.c:9150:1: note: by argument 1 of type ‘const
> struct ipsec_test_data[]’ to ‘test_ipsec_proto_process’ declared here
> test_ipsec_proto_process(const struct ipsec_test_data td[],
> ^~~~~~~~~~~~~~~~~~~~~~~~
> ../app/test/test_cryptodev.c:10056:32: note: ‘td_outb’ declared here
> struct ipsec_test_data td_outb[IPSEC_TEST_PACKETS_MAX];
> ^~~~~~~
>
> Fixes: d02c6bfcb99a ("test/crypto: add ESN and antireplay cases")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com>
> ---
> app/test/test_cryptodev.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index
> 524019ce0e..47ce3d8420 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -10058,6 +10058,9 @@ test_ipsec_pkt_replay(const void *test_data,
> const uint64_t esn[],
> struct ipsec_test_flags flags;
> uint32_t i = 0, ret = 0;
>
> + if (nb_pkts == 0)
> + return TEST_SKIPPED;
> +
[Anoob] nb_pkts == 0 would indicate a badly written test case. Might be better
to return TEST_FAILED in that case.
> memset(&flags, 0, sizeof(flags));
> flags.antireplay = true;
>
> --
> 2.27.0
