On 09/08/2023 01:10, Stephen Hemminger wrote:
The power management API's were last changed in 22.11 release.
Therefore remove experimental for 23.11 release.
Signed-off-by: Stephen Hemminger
---
Acked-by: David Hunt
On 19/10/2023 20:10, Stephen Hemminger wrote:
The power management API's were last changed in 22.11 release.
Therefore remove experimental for 23.11 release.
Signed-off-by: Stephen Hemminger
---
Acked-by: David Hunt
On 23/10/2023 05:27, Sivaprasad Tummala wrote:
Add co-maintainer for power library.
Signed-off-by: Sivaprasad Tummala
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
Thanks for the help, Sivaprasad.
Acked-by: David Hunt
On 20/07/2024 17:50, Sivaprasad Tummala wrote:
After refactoring the power library, power management operations are now
consistently supported regardless of the operating environment, making
function pointer checks unnecessary and thus removed from applications.
Signed-off-by: Sivaprasad Tummal
Hi Sivaprasad,
A couple of comments below:
On 20/07/2024 17:50, Sivaprasad Tummala wrote:
This patch introduces a comprehensive refactor to the core power
management library. The primary focus is on improving modularity
and organization by relocating specific driver implementations
from the 'li
On 20/07/2024 17:50, Sivaprasad Tummala wrote:
This patch refactors the power management library, addressing uncore
power management. The primary changes involve the creation of dedicated
directories for each driver within 'drivers/power/uncore/*'. The
adjustment of meson.build files enables the
On 20/07/2024 17:50, Sivaprasad Tummala wrote:
This patch introduces driver support for power management of uncore
components in AMD EPYC processors.
Signed-off-by: Sivaprasad Tummala
---
drivers/power/amd_uncore/amd_uncore.c | 321 ++
drivers/power/amd_uncore/amd_u
On 22/07/2024 21:15, Stephen Hemminger wrote:
The number of uncore frequencies was defined in three places,
and two of them were too small leading to test failures.
All places should be using RTE_MAX_UNCORE_FREQS.
Bugzilla ID: 1499
Fixes: 60b8a661a957 ("power: add Intel uncore frequency control
Hi Ferruh,
On 20/06/2022 18:10, Ferruh Yigit wrote:
On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote:
This patch fixes the syntax error when using the single-core
for both rx and distributor functions.
Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
Cc: sta...@dpdk.org
Signed-
Hi Ömer,
I've a few comments:
On 21/06/2022 21:15, Abdullah Ömer Yamaç wrote:
In this patch,
* It is possible to switch the running mode of the distributor
using the command line argument.
* With "-c" parameter, you can run RX and Distributor
on the same core.
* Without
submit patch?
Yes, You can wait, or you can submit to the mailing list now and mark
the patch as "Deferred" in patchwork. Once 22.07 is released it will get
marked as "New", and under consideration for 22.11.
The other question is below,
On 27.06.2022 18:51, Hunt, D
On 28/06/2022 12:06, Omer Yamac wrote:
Hi David,
I have one more question. When I was working on new patch, I just want
to make sure what we are doing.
On 27.06.2022 18:51, Hunt, David wrote:
Hi Ömer,
I've a few comments:
On 21/06/2022 21:15, Abdullah Ömer Yamaç wrote:
--cl
On 28/06/2022 13:06, Omer Yamac wrote:
Hi,
Here is the final version. If it is ok, I will test the code and publish.
if (enable_lcore_rx_distributor){
// rx and distributor combined, 3 fixed function cores (stat, TX, at
least 1 worker)
min_cores = 4;
num_workers = rte_lcore_count() -
On 01/06/2022 11:54, Hamza Khan wrote:
Currently, when vm_power_manager exits, we are using a LIST_FOREACH
macro to iterate over VM info structures while freeing them. This
leads to use-after-free error. To address this, use the newly added
LIST_FOREACH_SAFE macro.
Fixes: e8ae9b662506 ("exampl
On 08/07/2022 09:51, Hamza Khan wrote:
Currently, when vm_power_manager exits, we are using a LIST_FOREACH
macro to iterate over VM info structures while freeing them. This
leads to use-after-free error. To address this, replace all usages of
LIST_* with TAILQ_* macros, and use the RTE_TAILQ_FO
On 22/02/2023 02:13, Jie Hai wrote:
Hi, David Hunt,
Kindly ping. Could you please take a look at this patch?
Thanks,
Jie Hai
On 2023/1/31 10:58, Jie Hai wrote:
Currently the l3fwd-power only supports ACPI cpufreq and Pstate
cpufreq, This patch adds CPPC cpufreq.
Signed-off-by: Jie Hai
On 22/02/2023 16:25, Stephen Hemminger wrote:
Found by doing duplicate word scan.
Signed-off-by: Stephen Hemminger
---
lib/distributor/rte_distributor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/distributor/rte_distributor.c
b/lib/distributor/rte_distributor.
On 22/02/2023 16:25, Stephen Hemminger wrote:
Found by doing duplicate word scan.
Signed-off-by: Stephen Hemminger
---
drivers/net/bonding/rte_eth_bond_8023ad.h | 2 +-
examples/vm_power_manager/channel_monitor.h | 2 +-
examples/vm_power_manager/oob_monitor.h | 2 +-
3 files chang
On 22/02/2023 16:25, Stephen Hemminger wrote:
Found by doing duplicate word scan.
Signed-off-by: Stephen Hemminger
---
app/test/test_resource.c | 2 +-
lib/pipeline/rte_swx_ctl.c | 2 +-
lib/power/guest_channel.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/a
On 21/02/2023 19:01, Stephen Hemminger wrote:
Use dynamic log type for power library.
Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/power/guest_channel.c
On 21/02/2023 19:01, Stephen Hemminger wrote:
Convert to using a dynamic logtype for the application.
Signed-off-by: Stephen Hemminger
---
examples/l3fwd-power/main.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/examples/l3fwd-power/main.c b/examples/
On 21/02/2023 19:01, Stephen Hemminger wrote:
Don't use static logtype in sample application.
Signed-off-by: Stephen Hemminger
---
examples/distributor/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/distributor/main.c b/examples/distributor/main.c
index
On 15/02/2023 17:23, Stephen Hemminger wrote:
Use dynamic log type for power library.
Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h| 2 +-
lib/power/guest_channel.c
On 22/02/2023 16:07, Stephen Hemminger wrote:
Use dynamic log type for power library.
Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/power/guest_channel.c
On 22/02/2023 16:07, Stephen Hemminger wrote:
Convert to using a dynamic logtype for the application.
Signed-off-by: Stephen Hemminger
---
examples/l3fwd-power/main.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/examples/l3fwd-power/main.c b/examples/
On 22/02/2023 16:07, Stephen Hemminger wrote:
Don't use static logtype in sample application.
Signed-off-by: Stephen Hemminger
---
examples/distributor/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/distributor/main.c b/examples/distributor/main.c
index
On 01/03/2024 02:56, lihuisong (C) wrote:
在 2024/2/20 23:33, Sivaprasad Tummala 写道:
This patch introduces a comprehensive refactor to the core power
management library. The primary focus is on improving modularity
and organization by relocating specific driver implementations
from the 'lib/po
Hi Euan,
On 07/12/2023 16:18, Euan Bourke wrote:
Update to the l3fwd-power example application to call the arg parser
library for its 'combined core string parser' instead of implementing its
own corelist parser. The default_type passed into the function call is
a corelist.
Signed-off-by: Euan
On 11/12/2023 17:23, Stephen Hemminger wrote:
Be consistent for all the error printouts and use fprintf().
The EAL logtype is reserved for internal use by EAL.
Signed-off-by: Stephen Hemminger
---
examples/vm_power_manager/main.c | 11 ---
1 file changed, 4 insertions(+), 7 deletio
Hi Sivaprasad, Karen,
On 27/10/2023 13:36, Kelly, Karen wrote:
On 26/10/2023 16:19, Sivaprasad Tummala wrote:
Updated the l3fwd-power app to configure the uncore env before invoking
any uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is
too late because other APIs already cal
On 15/06/2023 10:16, Anatoly Burakov wrote:
Add co-maintainer for power library.
Signed-off-by: Anatoly Burakov
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 906b31f97c..21c971a273 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1671,6 +
On 02/09/2022 06:20, Omer Yamac wrote:
Hi David,
I applied the changes as new version (v3), Thank you
--snip--
With the above suggested changes to the commit message:
Reviewed-by: David Hunt
Hi Omer,
2 things:
Usually you submit subsequent versions of patches "in-reply-to" the
pre
On 01/09/2022 15:09, omer.yamac at ceng.metu.edu.tr (Abdullah Ömer
Yamaç) wrote:
In this patch,
* It is possible to switch the running mode of the distributor
using the command line argument.
* With "-c" parameter, you can run RX and Distributor
on the same core.
* Without "-c"
Hi Tadhg,
On 13/07/2022 15:07, Tadhg Kearney wrote:
Add option for setting uncore frequency min/max/index, through uncore api.
This will be set for each package and die on the SKU. On exit, uncore
frequency will be reverted back to previous frequency.
Signed-off-by: Tadhg Kearney
---
.../sam
On 20/09/2022 10:48, Tadhg Kearney wrote:
Add option for setting uncore frequency min/max/index, through uncore API.
This will be set for each package and die on the SKU. On exit, uncore min
and max frequency will be reverted back to previous frequencies.
Signed-off-by: Tadhg Kearney
---
..
On 20/09/2022 10:48, Tadhg Kearney wrote:
Add API to allow uncore frequency adjustment. This is done through
manipulating related uncore frequency control sysfs entries to
adjust the minimum and maximum uncore frequency values.
Nine API's are being added that are all public and experimental.
S
Hi Tadhg,
On 20/09/2022 10:48, Tadhg Kearney wrote:
Add basic unit tests covering all nine uncore API's.
Signed-off-by: Tadhg Kearney
---
app/test/meson.build | 2 +
app/test/test_power_uncore.c | 299 +++
2 files changed, 301 insertions(+)
create
Hi Tadhg,
On 28/09/2022 10:06, Tadhg Kearney wrote:
Add option for setting uncore frequency min/max/index, through uncore API.
This will be set for each package and die on the SKU. On exit, uncore min
and max frequency will be reverted back to previous frequencies.
Signed-off-by: Tadhg Kearney
Hi Tadhg,
On 28/09/2022 14:30, Tadhg Kearney wrote:
This is targeting 22.11 and aims to add an API to DPDK power library to allow
uncore frequency adjustment. This will be called through the l3fwd-power app
and gives the ability to set the minimum and maximum uncore frequency to both
min,
max o
On 06/10/2022 18:32, Stephen Hemminger wrote:
On Thu, 6 Oct 2022 09:38:01 +
Tadhg Kearney wrote:
Add API to allow uncore frequency adjustment. Uncore is a
term used by Intel to describe function of a microprocessor
that are closely connected to the core to achieve high
performance. This
On 20/12/2022 12:56, David Hunt wrote:
Remove calls to the experimental empty poll API. l3fwd-power
is the only app that uses this.
This API is no longer needed as it is superceded by the
monitor/pause/scale callback mechanism.
I did check the spelling against my spellchecker with checkpatc
On 22/08/2022 11:58, Reshma Pattan wrote:
From: Hamza Khan
Currently, when vm_power_manager exits, we are using a LIST_FOREACH
macro to iterate over VM info structures while freeing them. This
leads to use-after-free error. To address this, replace all usages of
LIST_* with TAILQ_* macros, an
Hi Markus,
On 24/08/2022 20:28, Markus Theil wrote:
If DPDK applications should be used with a minimal set of privileges,
using the msr kernel module on linux should not be necessary.
Since at least kernel 4.4 the rdmsr call to obtain the last non-turbo
boost frequency can be left out, if the s
On 25/08/2022 07:42, Feifei Wang wrote:
For Arm aarch, power monitor uses WFE instruction to enable, which can
not exit automatically within the time limit. This means
'rte_power_monitor_wakeup' API needs to be called to wake up sleep cores
if there is no store operation to monitored address.
On 02/08/2022 16:22, Reshma Pattan wrote:
Add removal note for experimental empty poll API.
CC: David Hunt
Signed-off-by: Reshma Pattan
---
doc/guides/prog_guide/power_man.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/prog_guide/power_man.rst
b/doc/guides/prog
Hi Ömer,
On 28/06/2022 20:54, omer.yamac at ceng.metu.edu.tr (Abdullah Ömer
Yamaç) wrote:
In this patch,
* It is possible to switch the running mode of the distributor
using the command line argument.
* With "-c" parameter, you can run RX and Distributor
on the same core.
* Witho
Thanks for the comments Bruce. Addressed below.
On 16/1/2017 4:36 PM, Bruce Richardson wrote:
On Mon, Jan 09, 2017 at 07:50:43AM +, David Hunt wrote:
Now sends bursts of up to 8 mbufs to each worker, and tracks
the in-flight flow-ids (atomic scheduling)
New file with a new api, similar to
On 16/1/2017 4:40 PM, Bruce Richardson wrote:
On Mon, Jan 09, 2017 at 07:50:44AM +, David Hunt wrote:
--- a/lib/librte_distributor/rte_distributor_burst.c
+++ b/lib/librte_distributor/rte_distributor_burst.c
@@ -352,6 +352,9 @@ rte_distributor_process_burst(struct rte_distributor_burst
*d,
On 13/1/2017 3:19 PM, Bruce Richardson wrote:
On Mon, Jan 09, 2017 at 07:50:43AM +, David Hunt wrote:
Now sends bursts of up to 8 mbufs to each worker, and tracks
the in-flight flow-ids (atomic scheduling)
New file with a new api, similar to the old API except with _burst
at the end of th
On 13/1/2017 3:26 PM, Bruce Richardson wrote:
On Mon, Jan 09, 2017 at 07:50:44AM +, David Hunt wrote:
Signed-off-by: David Hunt
---
lib/librte_distributor/Makefile| 4 +
lib/librte_distributor/rte_distributor_burst.c | 11 +-
lib/librte_distributor/rte_distr
On 9/2/2017 2:20 PM, Ferruh Yigit wrote:
On 2/6/2017 8:08 AM, David Hunt wrote:
Given that the packet distributor library improvements (1) will
not be in 17.02, I plan on doing some consolidation of the
API for burst operation for 17.05, merging the two api's into
one, with options for single o
Thanks for the review, Jerin, I very much appreciate it. I'll address
all the minor comments, and I've a comment or two on the remaining
changes below.
On 22/12/2016 12:47 PM, Jerin Jacob wrote:
On Thu, Dec 22, 2016 at 04:37:04AM +, David Hunt wrote:
--snip--
+
+ /* set the
On 22/12/2016 12:19 PM, Jerin Jacob wrote:
On Thu, Dec 22, 2016 at 04:37:06AM +, David Hunt wrote:
+ struct rte_distributor_burst *d = arg;
+ unsigned int count = 0;
+ unsigned int num = 0;
+ unsigned int id = __sync_fetch_and_add(&worker_idx, 1);
Use rte_atomic eq
Hi Jerin,
On 3/7/2017 6:37 AM, Jerin Jacob wrote:
-Original Message-
From: Harry van Haaren
Adi a new entry in the sample app user-guides,
which details the working of the eventdev_pipeline_sw.
Signed-off-by: Harry van Haaren
Signed-off-by: David Hunt
---
doc/guides/sample_app_
Hi Jerin,
On 3/7/2017 4:57 AM, Jerin Jacob wrote:
-Original Message-
From: Harry van Haaren
This commit adds a sample app for the eventdev library.
The app has been tested with DPDK 17.05-rc2, hence this
release (or later) is recommended.
The sample app showcases a pipeline processin
On 3/7/2017 10:32 AM, Jerin Jacob wrote:
-Original Message-
--snip--
@@ -69,6 +69,7 @@ Sample Applications User Guides
netmap_compatibility
ip_pipeline
test_pipeline
+eventdev_pipeline_sw
eventdev_pipeline_sw_pmd
There's no need to change this, it would
Hi Jerin,
On 5/7/2017 6:30 AM, Jerin Jacob wrote:
-Original Message-
Date: Tue, 4 Jul 2017 08:55:25 +0100
From: "Hunt, David"
To: Jerin Jacob
CC: dev@dpdk.org, harry.van.haa...@intel.com, Gage Eads
, Bruce Richardson
Subject: Re: [PATCH v5 1/3] examples/eventdev_pipel
On 6/7/2017 4:31 AM, Jerin Jacob wrote:
-Original Message-
Date: Wed, 5 Jul 2017 12:15:51 +0100
From: "Hunt, David"
To: Jerin Jacob
CC: dev@dpdk.org, harry.van.haa...@intel.com, Gage Eads
, Bruce Richardson
Subject: Re: [PATCH v5 1/3] examples/eventdev_pipeline: added
On 6/7/2017 11:04 AM, Hunt, David wrote:
On 6/7/2017 4:31 AM, Jerin Jacob wrote:
Note:
Change application to new name.
checkpatch.sh
-
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to
using 'consumer', this function&
Hi Jerin,
On 6/7/2017 11:04 AM, Hunt, David wrote:
On 6/7/2017 4:31 AM, Jerin Jacob wrote:
-Original Message-
--snip--
I checked v7 it looks to OK to merge. Can you fix following minor
issue with
check patch and check-git-log.sh
check-git-log.sh
-
Wrong headline
-Original Message-
From: Thomas Monjalon [mailto:tho...@monjalon.net]
Sent: Thursday, 3 August, 2017 11:40 PM
To: Hunt, David
Cc: dev@dpdk.org; shreyansh.j...@nxp.com
Subject: Re: [dpdk-dev] [PATCH v3 1/3] mk: add sensible default target with
defconfig
07/06/2017 16:37, David Hunt
On 4/8/2017 10:36 AM, Thomas Monjalon wrote:
04/08/2017 10:22, Hunt, David:
From: Thomas Monjalon [mailto:tho...@monjalon.net]
07/06/2017 16:37, David Hunt:
Users can now use 'make defconfig' to generate a configuration using
the most appropriate defaults for the current machine.
On 4/8/2017 11:05 AM, Thomas Monjalon wrote:
04/08/2017 11:53, Hunt, David:
On 4/8/2017 10:36 AM, Thomas Monjalon wrote:
04/08/2017 10:22, Hunt, David:
From: Thomas Monjalon [mailto:tho...@monjalon.net]
07/06/2017 16:37, David Hunt:
Users can now use 'make defconfig' to
On 15/3/2017 5:18 PM, Thomas Monjalon wrote:
2017-03-15 06:19, David Hunt:
+/**
+ * Number of packets to deal with in bursts. Needs to be 8 so as to
+ * fit in one cache line.
+ */
+#define RTE_DIST_BURST_SIZE (sizeof(rte_xmm_t) / sizeof(uint16_t))
error: 'rte_xmm_t' undeclared here (arm compil
On 20/3/2017 10:03 AM, Shreyansh Jain wrote:
CONFIG_RTE_DRIVER_MEMPOOL_STACK option added to common_base.
Stack mempool handler moved from lib/librte_mempool into drivers/mempool.
With this patch, the Stack mempool handler registration is optional and
toggled via the configuration file. In case
Hi Thomas,
On 27/3/2017 2:02 PM, Thomas Monjalon wrote:
2017-03-20 10:08, David Hunt:
Also bumped up the ABI version number in the Makefile
It would be good to explain the intent of versioning here.
Signed-off-by: David Hunt
Acked-by: Bruce Richardson
---
lib/librte_distributor/Makefile
On 27/3/2017 2:04 PM, Thomas Monjalon wrote:
2017-03-20 10:08, David Hunt:
Approximately 10% performance increase due to these changes.
It would have been better to explain what are the changes.
Signed-off-by: David Hunt
Acked-by: Bruce Richardson
---
examples/distributor/main.c | 36 +++
On 27/3/2017 2:10 PM, Thomas Monjalon wrote:
2017-03-20 10:08, David Hunt:
Signed-off-by: David Hunt
Acked-by: Bruce Richardson
[...]
SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include := rte_distributor.h
-SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include += rte_distributor_v20.h
There is
On 30/3/2017 12:25 AM, Harry van Haaren wrote:
From: Bruce Richardson
Add in the scheduling function which takes the events from the
producer queues and buffers them before scheduling them to consumer
queues. The scheduling logic includes support for atomic, reordered,
and parallel scheduling o
On 30/3/2017 12:25 AM, Harry van Haaren wrote:
From: Bruce Richardson
Segfault issue resolved when only partially configured and
rte_event_dev_dump() is called before start(),
Reported-by: Vipin Varghese
Signed-off-by: Bruce Richardson
Signed-off-by: Harry van Haaren
---
drivers/event/sw
On 30/3/2017 12:25 AM, Harry van Haaren wrote:
From: Bruce Richardson
Add support for xstats to report out on the state of the eventdev.
Useful for debugging and for unit tests, as well as observability
at runtime and performance tuning of apps to work well with the
scheduler.
--snip--
+s
On 30/3/2017 8:30 PM, Harry van Haaren wrote:
Signed-off-by: Harry van Haaren
---
doc/guides/rel_notes/release_17_05.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/doc/guides/rel_notes/release_17_05.rst
b/doc/guides/rel_notes/release_17_05.rst
index 918f483..a5b8351 100644
--
On 9/2/2017 4:53 PM, Thomas Monjalon wrote:
2016-11-06 22:09, Thomas Monjalon:
2016-09-29 18:34, Thomas Monjalon:
2016-09-30 02:54, Nikhil Rao:
The original code used movl instead of xchgl, this caused
rte_atomic64_cmpset to use ebx as the lower dword of the source
to cmpxchg8b instead of the
On 10/2/2017 10:53 AM, Thomas Monjalon wrote:
2017-02-10 10:39, Hunt, David:
On 9/2/2017 4:53 PM, Thomas Monjalon wrote:
2016-11-06 22:09, Thomas Monjalon:
2016-09-29 18:34, Thomas Monjalon:
2016-09-30 02:54, Nikhil Rao:
The original code used movl instead of xchgl, this caused
On 21/2/2017 3:17 AM, David Hunt wrote:
Move files out of the way so that we can replace with new
versions of the distributor libtrary. Files are named in
such a way as to match the symbol versioning that we will
apply for backward ABI compatibility.
Signed-off-by: David Hunt
---
---snip--
On 21/2/2017 3:17 AM, David Hunt wrote:
Note: LIBABIVER is also bumped up in the Makefile
Signed-off-by: David Hunt
---
lib/librte_distributor/rte_distributor.c | 10 +-
lib/librte_distributor/rte_distributor_v20.c | 10 ++
lib/librte_distributor/rte_distrib
On 24/2/2017 2:03 PM, Bruce Richardson wrote:
On Tue, Feb 21, 2017 at 03:17:37AM +, David Hunt wrote:
Move files out of the way so that we can replace with new
versions of the distributor libtrary. Files are named in
such a way as to match the symbol versioning that we will
apply for backw
On 24/2/2017 2:08 PM, Bruce Richardson wrote:
On Tue, Feb 21, 2017 at 03:17:40AM +, David Hunt wrote:
Signed-off-by: David Hunt
---
lib/librte_distributor/rte_distributor_private.h | 61
1 file changed, 61 insertions(+)
diff --git a/lib/librte_distributor/rte_
On 24/2/2017 2:09 PM, Bruce Richardson wrote:
On Tue, Feb 21, 2017 at 03:17:40AM +, David Hunt wrote:
Signed-off-by: David Hunt
---
lib/librte_distributor/rte_distributor_private.h | 61
1 file changed, 61 insertions(+)
diff --git a/lib/librte_distributor/rte_
On 24/2/2017 2:14 PM, Bruce Richardson wrote:
On Tue, Feb 21, 2017 at 03:17:44AM +, David Hunt wrote:
In the next few patches, we'll want to test old and new API,
so here we're allowing different parameters to be passed to
the tests, instead of just a distributor struct.
Signed-off-by: Dav
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#84: FILE: lib/librte_distributor/rte_distributor.c:172:
+BIND_DEFAULT_SYMBOL(rte_distributor_get_pkt, , 17.05);
^
FYI, checkpatch does not like this regardless of whether there's
a space there
-Original Message-
From: Richardson, Bruce
Sent: Friday, 10 March, 2017 4:22 PM
To: Hunt, David
Cc: dev@dpdk.org
Subject: Re: [PATCH v9 09/18] lib: add symbol versioning to distributor
On Mon, Mar 06, 2017 at 09:10:24AM +, David Hunt wrote:
> Also bumped up the ABI version num
On 10/3/2017 4:22 PM, Bruce Richardson wrote:
On Mon, Mar 06, 2017 at 09:10:24AM +, David Hunt wrote:
Also bumped up the ABI version number in the Makefile
Signed-off-by: David Hunt
---
lib/librte_distributor/Makefile| 2 +-
lib/librte_distributor/rte_distributor.c
On 13/3/2017 11:01 AM, Van Haaren, Harry wrote:
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hunt, David
Subject: Re: [dpdk-dev] [PATCH v9 09/18] lib: add symbol versioning to
distributor
On 10/3/2017 4:22 PM, Bruce Richardson wrote:
On Mon, Mar 06, 2017 at 09:10:24AM +, David
On 10/3/2017 4:51 PM, Bruce Richardson wrote:
On Mon, Mar 06, 2017 at 09:10:31AM +, David Hunt wrote:
This so that with the increased amount of stats we are counting,
we don't interfere with the rx core.
Where are the stats being counted in the current code and how would they
interfere?
On 10/3/2017 4:03 PM, Bruce Richardson wrote:
On Mon, Mar 06, 2017 at 09:10:19AM +, David Hunt wrote:
This patch includes public header file which will be used once
we add in the symbol versioning for v20 and v1705 APIs.
Also includes v1702 header file, and code for new
Now 1705.
burst
On 10/3/2017 4:46 PM, Bruce Richardson wrote:
On Mon, Mar 06, 2017 at 09:10:27AM +, David Hunt wrote:
+ freq = rte_get_timer_hz();
+ t = rte_rdtsc() + freq;
+ while (!quit_signal_dist) {
+ if (t < rte_rdtsc()) {
+ print_stats();
+
On 10/3/2017 4:49 PM, Bruce Richardson wrote:
On Mon, Mar 06, 2017 at 09:10:29AM +, David Hunt wrote:
Signed-off-by: David Hunt
---
Title could do with some rewording - e.g. "make distributor API calls on
dedicated core"
This also requires an explanation as to why the change is being ma
On 10/3/2017 4:50 PM, Bruce Richardson wrote:
On Mon, Mar 06, 2017 at 09:10:30AM +, David Hunt wrote:
Signed-off-by: David Hunt
---
Please explain reason for change.
/Bruce
I've re-worked this change, as it's mostly do to with performance,
resulting in about 10% gain.
The number of Tx
Shreyansh, Jan, Hemant,
On 9/9/2016 9:43 AM, Shreyansh Jain wrote:
> Introduction:
> =
>
> This patch set is direct derivative of Jan's original series [1],[2].
>
> - As this deviates substantially from original series, if need be I can
> post it as a separate patch rather than v
Some small comments below:
On 9/9/2016 9:43 AM, Shreyansh Jain wrote:
> Define initial structures and functions for the SoC infrastructure.
> This patch supports only a very minimal functions for now.
> More features will be added in the following commits.
>
> Includes rte_device/rte_driver inheri
On 9/9/2016 9:43 AM, Shreyansh Jain wrote:
> Registeration of a SoC driver through a helper DRIVER_REGISTER_SOC
> (on the lines of DRIVER_REGISTER_PCI). soc_driver_list stores all the
> registered drivers.
>
> Test case has been introduced to verify the registration and
> deregistration.
>
> Sign
On 9/9/2016 9:43 AM, Shreyansh Jain wrote:
> We abstract access to the intr_handle here as we want to get
> it either from the pci_dev or soc_dev.
>
> Signed-off-by: Jan Viktorin
> Signed-off-by: Shreyansh Jain
> Signed-off-by: Hemant Agrawal
> ---
> lib/librte_ether/rte_ethdev.c | 15 +++
On 9/9/2016 9:43 AM, Shreyansh Jain wrote:
> Signed-off-by: Jan Viktorin
> Signed-off-by: Shreyansh Jain
> Signed-off-by: Hemant Agrawal
> ---
> lib/librte_ether/rte_ethdev.c | 15 ++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_ether/rte_ethdev
Hi Hemant,
On 15/9/2016 6:13 PM, Hemant Agrawal wrote:
> In the rte_pktmbuf_pool_create, if the default external mempool is
> not available, the implementation can default to "ring_mp_mc", which
> is an software implementation.
>
> Signed-off-by: Hemant Agrawal
> ---
> lib/librte_mbuf/rte_mbuf.
Hi Hemant,
On 15/9/2016 6:13 PM, Hemant Agrawal wrote:
> External offloaded mempool may not be available always. This check enables
> run time verification of the presence of external mempool before the
> mempool ops are installed.
>
> An application built with a specific external mempool may work
Shreyansh,
I found an issue (or two) with this part of the patch, and have a
proposed solution.
1. RTE_TARGET originally had a different meaning. It was used for making
examples, specifying the target directory of where the SDK was built.
It's not good to re-purpose this for something el
Hi Shreyansh,
On 7/6/2017 10:36 AM, Shreyansh Jain wrote:
Hello David,
On Wednesday 07 June 2017 02:09 PM, Hunt, David wrote:
Shreyansh,
I found an issue (or two) with this part of the patch, and have
a proposed solution.
1. RTE_TARGET originally had a different meaning. It was used
Hi Jerin,
I'm assisting Harry on the sample app, and have just pushed up a V2
patch based on your feedback. I've addressed most of your suggestions,
comments below. There may still a couple of outstanding questions that
need further discussion.
Regards,
Dave
On 10/5/2017 3:12 PM, Jerin Jaco
Hi Jerin:
On 27/6/2017 10:35 AM, Jerin Jacob wrote:
-Original Message-
Date: Mon, 26 Jun 2017 15:46:47 +0100
From: "Hunt, David"
To: Jerin Jacob , Harry van Haaren
CC: dev@dpdk.org, Gage Eads , Bruce Richardson
Subject: Re: [dpdk-dev] [PATCH 1/3] examples/eventde
1 - 100 of 393 matches
Mail list logo
