Re: [PATCH v3 8/8] examples/l3fwd-power: update to call arg parser API

[Hunt, David]

Hi Euan,

On 07/12/2023 16:18, Euan Bourke wrote:
Update to the l3fwd-power example application to call the arg parser
library for its 'combined core string parser' instead of implementing its
own corelist parser. The default_type passed into the function call is
a corelist.
Signed-off-by: Euan Bourke <euan.bou...@intel.com>
---
  examples/l3fwd-power/perf_core.c | 51 +++++---------------------------
  1 file changed, 8 insertions(+), 43 deletions(-)

diff --git a/examples/l3fwd-power/perf_core.c b/examples/l3fwd-power/perf_core.c
index 41ef6d0c9a..f8511e30b3 100644
--- a/examples/l3fwd-power/perf_core.c
+++ b/examples/l3fwd-power/perf_core.c
@@ -12,6 +12,7 @@
  #include <rte_lcore.h>
  #include <rte_power.h>
  #include <rte_string_fns.h>
+#include <rte_arg_parser.h>
  
  #include "perf_core.h"
  #include "main.h"
@@ -177,56 +178,20 @@ parse_perf_config(const char *q_arg)
  int
  parse_perf_core_list(const char *corelist)
  {
-       int i, idx = 0;
-       unsigned int count = 0;
-       char *end = NULL;
-       int min, max;
+       int count;
+       uint16_t cores[RTE_MAX_LCORE];
  
  	if (corelist == NULL) {
                printf("invalid core list\n");
                return -1;
        }
  
+	count = rte_arg_parse_core_string(corelist, cores, RTE_DIM(cores), 1);
  
-	/* Remove all blank characters ahead and after */
-       while (isblank(*corelist))
-               corelist++;
-       i = strlen(corelist);
-       while ((i > 0) && isblank(corelist[i - 1]))
-               i--;
+       for (int i = 0; i < count; i++)


nit: you've used int here, but below you use uint16_t for a for loop. If 
you're re-spinning, it might be worth making consistent. But no biggie.

--snip--

@@ -234,7 +199,7 @@ parse_perf_core_list(const char *corelist)
        nb_hp_lcores = count;
  
  	printf("Configured %d high performance cores\n", nb_hp_lcores);
-       for (i = 0; i < nb_hp_lcores; i++)
+       for (uint16_t i = 0; i < nb_hp_lcores; i++)
                printf("\tHigh performance core %d %d\n",
                                i, hp_lcores[i]);
  


I've also tested this with a 16-core incantation of l3fwd-power with 
various combinations of cores, seems to work well.

Acked-by: David Hunt <david.h...@intel.com>