+ Honnappa
Hi Yipeng,
Thank you for the review comments!
> On Mar 7, 2019, at 11:49 AM, Wang, Yipeng1 wrote:
>
> Thanks for this patch! Some initial comments inlined:
>
>> -Original Message-
>> From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com]
>>
This patch series:
- Enables lock-free read-write concurrency support for extendable
bucket feature.
- Adds lock-free read-write concurrency tests for ext bkt
Dharmik Thakkar (2):
hash: add lock free support for extendable bucket
test/hash: lock-free rw concurrency test ext bkt
app/test
This patch enables lock-free read-write concurrency support for
extendable bucket feature.
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Reviewed-by: Gavin Hu
Reviewed-by: Honnappa Nagarahalli
---
doc/guides/prog_guide/hash_lib.rst | 3 +-
lib
Add unit test to check for hash lookup and bulk-lookup perf.
Test with lock-free enabled and with lock-free disabled.
Test include:
- hash lookup on keys in ext bkt,
hash delete causing key-shifts of keys from ext bkt to secondary bkt
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik
Hi Honnappa,
Thank you for the review comments!
> On Mar 14, 2019, at 7:31 PM, Honnappa Nagarahalli
> wrote:
>
>
>
@@ -1072,10 +1071,23 @@ __rte_hash_add_key_with_hash(const struct
>> rte_hash *h, const void *key,
bkt_id = (uint32_t)((uintptr_t)ext_bkt_id) - 1;
/* Use th
+Honnappa
Hi Yipeng,
Thank you for reviewing!
> On Mar 22, 2019, at 6:48 PM, Wang, Yipeng1 wrote:
>
> Thanks for the patch!
>
> Comments inlined:
>
>> -Original Message-
>> From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com]
>> Sent: Wednesday
This patch enables lock-free read-write concurrency support for
extendable bucket feature.
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Reviewed-by: Gavin Hu
Reviewed-by: Honnappa Nagarahalli
---
v2:
- Update doc (Yipeng)
- Update lib
Add unit test to check for hash lookup and bulk-lookup perf.
Test with lock-free enabled and with lock-free disabled.
Test include:
- hash lookup on keys in ext bkt,
hash delete causing key-shifts of keys from ext bkt to secondary bkt
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik
This patch series:
- Enables lock-free read-write concurrency support for extendable
bucket feature.
- Adds lock-free read-write concurrency tests for ext bkt
Dharmik Thakkar (2):
hash: add lock free support for extendable bucket
test/hash: lock-free rw concurrency test ext bkt
app/test
+Honnappa
Hi Yipeng,
Thank you for the review comments!
> On Apr 1, 2019, at 1:55 PM, Wang, Yipeng1 wrote:
>
> A little bit improvement on commit-message maybe needed.
>
>> -Original Message-
>> From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com]
>>
+Honnappa
Hi Yipeng,
Thank you for the review!
> On Apr 1, 2019, at 1:20 PM, Wang, Yipeng1 wrote:
>
>> -Original Message-----
>> From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com]
>> Sent: Monday, March 25, 2019 2:09 PM
>> To: Wang, Yipeng1 ; Gobriel,
This patch enables lock-free read-write concurrency support for
extendable bucket feature.
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Reviewed-by: Gavin Hu
Reviewed-by: Honnappa Nagarahalli
Acked-by: Yipeng Wang
---
doc/guides/prog_guide
: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
---
app/test/test_hash_readwrite_lf.c | 350 --
1 file changed, 284 insertions(+), 66 deletions(-)
diff --git a/app/test/test_hash_readwrite_lf.c
b/app/test/test_hash_readwrite_lf.c
index cbfd9322696b..ddd8d7aa6a7d
This patch series:
- Enables lock-free read-write concurrency support for extendable
bucket feature.
- Adds lock-free read-write concurrency tests for ext bkt
Dharmik Thakkar (2):
hash: add lock free support for extendable bucket
test/hash: lock-free rw concurrency test ext bkt
app/test
This patch series:
- Enables lock-free read-write concurrency support for extendable
bucket feature.
- Adds lock-free read-write concurrency tests for ext bkt
Dharmik Thakkar (2):
hash: add lock free support for extendable bucket
test/hash: lock-free rw concurrency test ext bkt
app/test
This patch enables lock-free read-write concurrency support for
extendable bucket feature.
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Reviewed-by: Gavin Hu
Reviewed-by: Honnappa Nagarahalli
Acked-by: Yipeng Wang
---
v3:
- Update lib
: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Acked-by: Yipeng Wang
---
v4:
- Add Acked-by tag.
---
v3:
- Update commit message (Yipeng)
---
app/test/test_hash_readwrite_lf.c | 350 --
1 file changed, 284 insertions(+), 66 deletions(-)
diff --git a/app/test
Hi Thomas,
Thank you for the review!
> On Apr 1, 2019, at 7:57 PM, Thomas Monjalon wrote:
>
> 02/04/2019 01:08, Dharmik Thakkar:
>> Add unit test to check for hash lookup and bulk-lookup perf for
>> extendable bucket feature.
>> It is tested with both lock-free ena
This patch enables lock-free read-write concurrency support for
extendable bucket feature.
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Reviewed-by: Ruifeng Wang
Reviewed-by: Gavin Hu
Reviewed-by: Honnappa Nagarahalli
Acked-by: Yipeng Wang
---
doc/guides/prog_guide
(Yipeng).
* Add Acked-by tag.
v2:
* Update doc (Yipeng).
* Update lib/librte_hash/rte_cuckoo_hash.c (Yipeng).
Dharmik Thakkar (2):
hash: add lock free support for extendable bucket
test/hash: lock-free rw concurrency test ext bkt
app/test/test_hash_readwrite_lf.c | 352
: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
Acked-by: Yipeng Wang
---
app/test/test_hash_readwrite_lf.c | 352 --
1 file changed, 285 insertions(+), 67 deletions(-)
diff --git a/app/test/test_hash_readwrite_lf.c
b/app/test/test_hash_readwrite_lf.c
index
Replace 'typedef int bool' with 'stdbool.h'
Thus, avoid future compilation problems when 'stdbool.h'
gets included in these files.
---
v2:
- Remove 'typedef int bool' from other drivers
---
Dharmik Thakkar (7):
net/ixgbe: avoid multpile definitions of
Replace 'typedef int bool' with 'stdbool.h' to avoid possible
multiple definitions of 'bool'.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Phil Yang
Reviewed-by: Ruifeng Wang
---
drivers/net/cxgbe/cxgbe_compat.h | 4 +---
drivers/net/cxgbe/cxgbe_main.c | 13 +++
63:5: note: expected
‘bool * {aka int *}’ but argument is of type ‘_Bool *’'
Signed-off-by: Dharmik Thakkar
Reviewed-by: Phil Yang
Reviewed-by: Gavin Hu
---
drivers/net/ixgbe/base/ixgbe_osdep.h | 4 +---
drivers/net/ixgbe/ixgbe_ethdev.c | 7 ---
2 files changed, 5 insertions(+), 6
Replace 'typedef int bool' with 'stdbool.h' to avoid possible
multiple definitions of 'bool'.
Remove 'typedef char Bool' and use 'bool' instead.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Phil Yang
Reviewed-by: Ruifeng Wang
---
drivers/net/vm
Replace 'typedef int bool' with 'stdbool.h' to avoid possible
multiple definitions of 'bool'.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Phil Yang
Reviewed-by: Ruifeng Wang
---
drivers/net/fm10k/base/fm10k_osdep.h | 8 +---
drivers/net/fm10k/fm10k_ethdev.c
Replace 'typedef int bool' with 'stdbool.h' to avoid possible
multiple definitions of 'bool'.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Phil Yang
Reviewed-by: Ruifeng Wang
---
drivers/net/bnx2x/bnx2x_ethdev.h | 4 +--
drivers
Replace 'typedef int bool' with 'stdbool.h' to avoid possible
multiple definitions of 'bool'.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Phil Yang
---
drivers/net/e1000/base/e1000_osdep.h | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff
Replace 'typedef int bool' with 'stdbool.h' to avoid possible
multiple definitions of 'bool'.
(Not sure if the previous code is checking for true/false condition.
Recommend careful review on this patch.)
Signed-off-by: Dharmik Thakkar
Reviewed-by: Phil Y
Replace 'typedef int bool' with 'stdbool.h'
Thus, avoid future compilation problems when 'stdbool.h'
gets included in these files.
---
v3:
- Rebase on dpdk-next-net
- Fix build issue in net/ixgbe
---
v2:
- Remove 'typedef int bool' from other drivers
---
Replace 'typedef int bool' with 'stdbool.h' to avoid possible
multiple definitions of 'bool'.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Phil Yang
Reviewed-by: Ruifeng Wang
---
drivers/net/cxgbe/cxgbe_compat.h | 4 +---
drivers/net/cxgbe/cxgbe_main.c | 13 +++
Replace 'typedef int bool' with 'stdbool.h' to avoid possible
multiple definitions of 'bool'.
Remove 'typedef char Bool' and use 'bool' instead.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Phil Yang
Reviewed-by: Ruifeng Wang
Acked-by: Yong
Replace 'typedef int bool' with 'stdbool.h' to avoid possible
multiple definitions of 'bool'.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Phil Yang
Reviewed-by: Ruifeng Wang
---
drivers/net/bnx2x/bnx2x_ethdev.h | 4 +--
drivers
Replace 'typedef int bool' with 'stdbool.h' to avoid possible
multiple definitions of 'bool'.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Phil Yang
---
drivers/net/e1000/base/e1000_osdep.h | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff
63:5: note: expected
‘bool * {aka int *}’ but argument is of type ‘_Bool *’'
Signed-off-by: Dharmik Thakkar
Reviewed-by: Phil Yang
Reviewed-by: Gavin Hu
---
drivers/net/ixgbe/base/ixgbe_osdep.h | 4 +---
drivers/net/ixgbe/ixgbe_ethdev.c | 10 ++
2 files changed, 7 inser
Replace 'typedef int bool' with 'stdbool.h' to avoid possible
multiple definitions of 'bool'.
(Not sure if the previous code is checking for true/false condition.
Recommend careful review on this patch.)
Signed-off-by: Dharmik Thakkar
Reviewed-by: Phil Y
Replace 'typedef int bool' with 'stdbool.h' to avoid possible
multiple definitions of 'bool'.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Phil Yang
Reviewed-by: Ruifeng Wang
Acked-by: Xiao Wang
---
drivers/net/fm10k/base/fm10k_osdep.h | 8 +---
drivers/ne
Hi Ferruh,
Thank you for the comments!
I have rebased the patches on dpdk-next-net and fixed the issue.
I have put out the patch.
> On Jan 10, 2020, at 3:22 AM, Ferruh Yigit wrote:
>
> On 1/2/2020 5:48 PM, Dharmik Thakkar wrote:
>> Compilation issue arises due to multiple defin
Hi Thomas,
Can this patch be merged?
> On Nov 25, 2019, at 5:14 PM, Thomas Monjalon wrote:
>
> 25/11/2019 23:55, Dharmik Thakkar:
>>
>>> On Nov 25, 2019, at 4:44 PM, Thomas Monjalon wrote:
>>>
>>> 25/11/2019 23:02, Wang, Yipeng1:
>>>> From:
E_EVENT_TIMER_CANCELED;
> - evtims[i]->impl_opaque[0] = 0;
> - evtims[i]->impl_opaque[1] = 0;
>
> rte_smp_wmb();
> }
> —
> 2.7.4
>
Reviewed-by: Dharmik Thakkar
On aarch64 platforms, the cycles are counted using either a
low-resolution generic counter or a high-resolution PMU cycle counter.
Print the clock frequency along with CPU cycles/packet to identify which
cycle counter is being used.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa
Add a separate section for low-resolution generic counter
for ARM64 profiling methods.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Phil Yang
---
doc/guides/prog_guide/profile_app.rst | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff
Update testpmd documentation to include RECORD configuration options,
CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES and
CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Phil Yang
---
doc/guides/testpmd_app_ug/build_app.rst | 12
Update documentation for 'show fwd' testpmd runtime function to show
CPU cycles/packet example.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Phil Yang
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 51 +
1 file changed, 31
: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Phil Yang
---
app/test-pmd/testpmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 9a8cbbd6fc7c..9444a730a153 100644
--- a/app/test-pmd/testpmd.c
+++ b/app
Hi Konstantin,
> On May 7, 2020, at 4:50 AM, Ananyev, Konstantin
> wrote:
>
>
>
>> -Original Message-
>> From: dev On Behalf Of Dharmik Thakkar
>> Sent: Wednesday, May 6, 2020 10:59 PM
>> To: Lu, Wenzhuo ; Wu, Jingjing
>> ; Iremonge
Hi Jerin,
> On May 7, 2020, at 12:24 AM, Jerin Jacob wrote:
>
> On Thu, May 7, 2020 at 3:30 AM Dharmik Thakkar
> wrote:
>>
>> Update documentation for 'show fwd' testpmd runtime function to show
>> CPU cycles/packet example.
>>
>> Sign
> On May 8, 2020, at 12:17 PM, Ananyev, Konstantin
> wrote:
>
>> Hi Konstantin,
>>
>>> On May 7, 2020, at 4:50 AM, Ananyev, Konstantin
>>> wrote:
>>>
>>>
>>>
>>>> -Original Message-
>>>>
Update testpmd documentation to include RECORD configuration options,
CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES and
CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Phil Yang
---
v2:
- Remove extra '#'.
---
Update documentation for 'show fwd' testpmd runtime function to show
CPU cycles/packet example.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Phil Yang
---
v2:
- Use shorter lines, up to 100.
---
doc/guides/testpmd_app_ug/testpmd_func
Add a separate section for low-resolution generic counter
for ARM64 profiling methods.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Phil Yang
Acked-by: Jerin Jacob
---
v2:
- Add Acked-by tag
---
doc/guides/prog_guide/profile_app.rst | 11 ---
1 file
On aarch64 platforms, the cycles are counted using either a
low-resolution generic counter or a high-resolution PMU cycle counter.
Print the clock frequency along with CPU cycles/packet to identify which
cycle counter is being used.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa
: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Phil Yang
---
v2:
- Change typecast to (double) fwd_cycles / total_recv
---
app/test-pmd/testpmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 806abb805879
Hi Ferruh,
> On May 15, 2020, at 7:15 AM, Ferruh Yigit wrote:
>
> On 5/8/2020 11:38 PM, Dharmik Thakkar wrote:
>> Update documentation for 'show fwd' testpmd runtime function to show
>> CPU cycles/packet example.
>>
>> Signed-off-by: Dharmik Th
> On May 18, 2020, at 4:47 AM, Ferruh Yigit wrote:
>
> On 5/15/2020 9:33 PM, Dharmik Thakkar wrote:
>> Hi Ferruh,
>>
>>> On May 15, 2020, at 7:15 AM, Ferruh Yigit wrote:
>>>
>>> On 5/8/2020 11:38 PM, Dharmik Thakkar wrote:
>>>> Upd
> On May 19, 2020, at 2:42 AM, Thomas Monjalon wrote:
>
>>> Update testpmd documentation to include RECORD configuration options,
>>> CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES and
>>> CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS.
>>>
>>> Signed
Update testpmd documentation to include RECORD configuration options,
CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES and
CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Phil Yang
---
v3:
- Replace config/common_base with build
Update documentation for 'show fwd' testpmd runtime function to show
CPU cycles/packet example.
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Phil Yang
---
v3:
- Keep existing stats and add a note providing CPU cycles/packet
example (Ferruh)
> On May 20, 2020, at 2:53 AM, Thomas Monjalon wrote:
>
> 20/05/2020 00:58, Dharmik Thakkar:
>>> On May 19, 2020, at 2:42 AM, Thomas Monjalon wrote:
>>>>> Update testpmd documentation to include RECORD configuration options,
>>>>
+ Bruce
> On Jun 17, 2020, at 2:48 PM, Thomas Monjalon wrote:
>
> 17/06/2020 20:21, Ferruh Yigit:
>> On 5/20/2020 4:20 AM, Dharmik Thakkar wrote:
>>> Update testpmd documentation to include RECORD configuration options,
>>> CONFIG_RT
> On Jun 19, 2020, at 10:43 AM, Thomas Monjalon wrote:
>
> 19/06/2020 17:38, Dharmik Thakkar:
>> + Bruce
>>
>>> On Jun 17, 2020, at 2:48 PM, Thomas Monjalon wrote:
>>>
>>> 17/06/2020 20:21, Ferruh Yigit:
>>>> On 5/20/2020 4:20 AM,
> On Jun 22, 2020, at 10:26 AM, Thomas Monjalon wrote:
>
> 19/06/2020 18:13, Dharmik Thakkar:
>>> On Jun 19, 2020, at 10:43 AM, Thomas Monjalon wrote:
>>> 19/06/2020 17:38, Dharmik Thakkar:
>>>>> On Jun 17, 2020, at 2:48 PM, Thomas Monjalon w
Remove __hash_rw_reader_unlock() calls from lock free hash lookup
Signed-off-by: Dharmik Thakkar
Reviewed-by: Gavin Hu
Reviewed-by: Honnappa Nagarahalli
---
lib/librte_hash/rte_cuckoo_hash.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/lib/librte_hash
> On Nov 25, 2019, at 4:44 PM, Thomas Monjalon wrote:
>
> 25/11/2019 23:02, Wang, Yipeng1:
>> From: Thomas Monjalon [mailto:tho...@monjalon.net]
>>> 25/11/2019 19:49, Wang, Yipeng1:
>>>> From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com]
>>>&g
Some of the internal header files have 'rte_' prefix
and some don't.
Remove 'rte_' prefix from all internal header files.
Suggested-by: Thomas Monjalon
Signed-off-by: Dharmik Thakkar
Reviewed-by: Phil Yang
Reviewed-by: Ruifeng Wang
---
drivers/compres
63:5: note: expected
‘bool * {aka int *}’ but argument is of type ‘_Bool *’'
Signed-off-by: Dharmik Thakkar
Reviewed-by: Honnappa Nagarahalli
---
drivers/net/ixgbe/base/ixgbe_osdep.h | 4 +---
drivers/net/ixgbe/ixgbe_ethdev.c | 7 ---
2 files changed, 5 insertions(+), 6 deletions(-
Add new meson.build file for crypto/armv8
Signed-off-by: Dharmik Thakkar
---
drivers/crypto/armv8/meson.build | 25 +
drivers/crypto/meson.build | 6 +++---
meson_options.txt| 2 ++
3 files changed, 30 insertions(+), 3 deletions(-)
create mode
Hi Ye,
Thank you for the comments!
> On Oct 16, 2019, at 1:23 AM, Ye Xiaolong wrote:
>
> Hi,
>
> On 10/03, Dharmik Thakkar wrote:
>> Compilation issue arises due to multiple definitions of 'bool'
>> in 'ixgbe_ethdev.h'.
>
> Which compi
Hi,
Please find the inline comment.
> On Apr 9, 2019, at 2:06 PM, Vivian Kong wrote:
>
> Add big endian support for s390x architecture.
>
> Signed-off-by: Vivian Kong
> ---
> lib/librte_hash/rte_fbk_hash.h | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/lib/librte_hash/rte_fbk_
/librte_hash/rte_hash.h
> index c93d1a1..abba8d7 100644
> --- a/lib/librte_hash/rte_hash.h
> +++ b/lib/librte_hash/rte_hash.h
> @@ -463,7 +463,7 @@ rte_hash_lookup_with_hash(const struct rte_hash *h,
>
> /**
> * Calc a hash value by key.
> - * This operation is not multi-thread safe.
> + * This operation is not multi-process safe.
> *
> * @param h
> * Hash table to look in.
> --
> 2.7.4
>
Acked-by: Dharmik Thakkar
I am taking a look at this bug. Will update ASAP. Did you run any test case to
detect the bug?
Thank you!
> On Apr 30, 2019, at 4:03 AM, bugzi...@dpdk.org wrote:
>
> https://bugs.dpdk.org/show_bug.cgi?id=261
>
>Bug ID: 261
> Summary: DPDK 18.11 bug on rte_hash_free_key_wi
Hi Yongseok,
Thank you for the patch! I have tested it on Bluefield reference platform. It
works fine.
One observation:
Even though I used 'make config T=arm64-bluefield-linuxapp-gcc’,
at the end of the build process it said 'Build complete
[arm64-armv8a-linuxapp-gcc]’
Tested-b
Signed-off-by: Dharmik Thakkar
---
lib/librte_hash/rte_cuckoo_hash.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/lib/librte_hash/rte_cuckoo_hash.c
b/lib/librte_hash/rte_cuckoo_hash.c
index 261267b7fd3d..590895d72062 100644
--- a/lib/librte_hash/rte_cuckoo_ha
This patch series solves 2 bugs reported on Bugzilla (bug-261) within
the function rte_hash_free_key_with_postion(). It also adds a test case
to catch similar bugs in the future.
https://bugs.dpdk.org/show_bug.cgi?id=261
Dharmik Thakkar (2):
hash: fix bugs in 'free key with position&#x
This patch adds a unit test for rte_hash_free_key_with_position().
Suggested-by: Linfan
Signed-off-by: Dharmik Thakkar
---
app/test/test_hash.c | 83
1 file changed, 83 insertions(+)
diff --git a/app/test/test_hash.c b/app/test/test_hash.c
index
> On May 8, 2019, at 3:11 PM, Wang, Yipeng1 wrote:
>
> Hi, thanks for the patch!
> Reply inlined:
Hi Yipeng,
Thank you for the review!
>
>> -Original Message-----
>> From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com]
>> Sent: Wednesday, May 8,
This patch adds a unit test for rte_hash_free_key_with_position().
Suggested-by: Linfan
Signed-off-by: Dharmik Thakkar
---
app/test/test_hash.c | 94
1 file changed, 94 insertions(+)
diff --git a/app/test/test_hash.c b/app/test/test_hash.c
index
Signed-off-by: Dharmik Thakkar
---
lib/librte_hash/rte_cuckoo_hash.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/lib/librte_hash/rte_cuckoo_hash.c
b/lib/librte_hash/rte_cuckoo_hash.c
index 261267b7fd3d..ed2e96b6f178 100644
--- a/lib/librte_hash/rte_cuc
warning
Dharmik Thakkar (2):
hash: fix bugs in 'free key with position'
test/hash: add test for 'free key with position'
app/test/test_hash.c | 94 +++
lib/librte_hash/rte_cuckoo_hash.c | 15 +++--
2 files changed, 104 insert
en we'll need approval from the maintainers.
>
> PS1: Please provide your full name in english alphabet
> PS2: Please do not top-post
>
>
>> At 2019-05-09 16:29:56, "Thomas Monjalon" wrote:
>>> 09/05/2019 00:59, Dharmik Thakkar:
>>>> This pa
comments in test_hash.c (Yipeng)
* Resolve checkpatch warning
Dharmik Thakkar (3):
hash: fix position bug in 'free key with position'
hash: fix total entries in free key with position
test/hash: add test for 'free key with position'
app/test/test_hash
ee on delete")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Reported-by: Linfan
Suggested-by: Linfan
Signed-off-by: Dharmik Thakkar
---
lib/librte_hash/rte_cuckoo_hash.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/lib/librte_hash/rte_cuckoo_has
total entries.
This patch fixes this incorrect computation of total_entries.
Bugzilla ID: 261
Fixes: 9d033dac7d7c ("hash: support no free on delete")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Reported-by: Linfan
Suggested-by: Linfan
Signed-off-by: Dharmik Thakkar
---
lib/l
This patch adds a unit test for rte_hash_free_key_with_position().
Suggested-by: Linfan
Signed-off-by: Dharmik Thakkar
---
app/test/test_hash.c | 94
1 file changed, 94 insertions(+)
diff --git a/app/test/test_hash.c b/app/test/test_hash.c
index
total entries.
This patch fixes this incorrect computation of total_entries.
Bugzilla ID: 261
Fixes: 9d033dac7d7c ("hash: support no free on delete")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Reported-by: Linfan
Suggested-by: Linfan
Signed-off-by: Dharmik Thakkar
---
lib/l
This patch adds a unit test for rte_hash_free_key_with_position().
Suggested-by: Linfan
Signed-off-by: Dharmik Thakkar
---
app/test/test_hash.c | 94
1 file changed, 94 insertions(+)
diff --git a/app/test/test_hash.c b/app/test/test_hash.c
index
update commit logs (Thomas)
v2:
* Add comments in test_hash.c (Yipeng)
* Resolve checkpatch warning
Dharmik Thakkar (3):
hash: fix position bug in 'free key with position'
hash: fix total entries in free key with position
test/hash: add test for 'free key with position'
ee on delete")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Reported-by: Linfan
Suggested-by: Linfan
Signed-off-by: Dharmik Thakkar
---
lib/librte_hash/rte_cuckoo_hash.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/lib/librte_hash/rte_cuckoo_has
> On May 9, 2019, at 10:48 AM, Wang, Yipeng1 wrote:
>
>> -Original Message-----
>> From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com]
>> Sent: Thursday, May 9, 2019 6:39 AM
>> To: Wang, Yipeng1 ; Gobriel, Sameh
>> ; Richardson, Bruce ;
>>
> On May 9, 2019, at 2:27 PM, Wang, Yipeng1 wrote:
>
>
>
>> -Original Message-
>> From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com]
>> Sent: Thursday, May 9, 2019 10:19 AM
>> To: Wang, Yipeng1 ; Gobriel, Sameh
>> ; Richardson, Bruce
> On May 9, 2019, at 3:23 PM, Thomas Monjalon wrote:
>
> 09/05/2019 22:14, Dharmik Thakkar:
>>> On May 9, 2019, at 2:27 PM, Wang, Yipeng1 wrote:
>>>> - RETURN_IF_TRUE(((h == NULL) || (position == EMPTY_SLOT)), -EINVAL);
>>>> + /* Key index where k
ore();
> rte_hash_free(tbl_rwc_test_param.h);
> return -1;
> }
> @@ -1222,10 +1219,9 @@ struct {
> }
> }
> writer_done = 1;
> - rte_eal_mp_wait_lcore();
>
> for (i = 1; i <= rwc_core_cnt[n]; i++)
> - if (lcore_config[i].ret < 0)
> + if (rte_eal_wait_lcore(i) < 0)
if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0)
> goto err;
>
> unsigned long long cycles_per_lookup =
> @@ -1242,6 +1238,7 @@ struct {
> return 0;
>
> err:
> + rte_eal_mp_wait_lcore();
> rte_hash_free(tbl_rwc_test_param.h);
> return -1;
> }
> --
> 1.8.3.1
>
Thank you,
Dharmik Thakkar
> On May 22, 2019, at 12:17 PM, David Marchand
> wrote:
>
> Hello Dharmik,
>
> On Wed, May 22, 2019 at 6:27 PM Dharmik Thakkar
> wrote:
> > On May 22, 2019, at 10:06 AM, David Marchand
> > wrote:
> >
> > Prefer the existing apis rather than
> On May 27, 2019, at 5:15 AM, David Marchand wrote:
>
> Hello Dharmik,
Hi David,
>
> On Wed, May 22, 2019 at 9:38 PM Dharmik Thakkar
> wrote:
> > On May 22, 2019, at 12:17 PM, David Marchand
> > wrote:
> > On Wed, May 22, 2019 at 6:27 PM Dharmik T
This patch rectifies slave_id passed to rte_eal_wait_lcore()
to point to valid cores in read-write lock-free concurrency test.
It also replaces a 'for' loop with RTE_LCORE_FOREACH API.
Fixes: dfd9d5537e876 ("test/hash: use existing lcore API")
Cc: sta...@dpdk.org
Signed-off
Hi David,
Thank you for your comments!
> On Jun 1, 2019, at 10:59 AM, David Marchand wrote:
>
> On Sat, Jun 1, 2019 at 1:28 AM Dharmik Thakkar
> wrote:
> This patch rectifies slave_id passed to rte_eal_wait_lcore()
> to point to valid cores in read-write lock-free concurr
> On Jun 3, 2019, at 2:31 PM, David Marchand wrote:
>
>
> On Mon, Jun 3, 2019 at 6:57 PM Dharmik Thakkar
> wrote:
> > On Jun 1, 2019, at 10:59 AM, David Marchand
> > wrote:
> > I would change the Fixes: tag, fix the checkpatch warning, and send it next
rte_hash_rcu_qsbr_add for application to
register a RCU variable that hash library will use.
Add functional and performance test cases.
Fix 'ixgbe_ethdev.h' to avoid multiple definitions of 'bool'.
(Please note that this fix is temporary. Recommend suggesting better
solution)
Dharmi
emporary fix. Recommend suggesting better solution.)
Signed-off-by: Dharmik Thakkar
---
drivers/net/ixgbe/ixgbe_ethdev.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h
index 6e9ed2e10f3c..dd4d6c022545 100644
--- a/drivers/net
Add functional and performance tests for the integrated RCU QSBR.
Suggested-by: Honnappa Nagarahalli
Signed-off-by: Dharmik Thakkar
---
app/test/test_hash_readwrite_lf.c | 694 +-
1 file changed, 693 insertions(+), 1 deletion(-)
diff --git a/app/test
101 - 200 of 263 matches
Mail list logo
