[dpdk-dev] [PATCH] lib/hash: remove unnecessary locks in lock-free

[Dharmik Thakkar]

Remove __hash_rw_reader_unlock() calls from lock free hash lookup

Signed-off-by: Dharmik Thakkar <dharmik.thak...@arm.com>
Reviewed-by: Gavin Hu <gavin...@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>
---
 lib/librte_hash/rte_cuckoo_hash.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/lib/librte_hash/rte_cuckoo_hash.c 
b/lib/librte_hash/rte_cuckoo_hash.c
index 87a4c01f2f9e..1a4795c82321 100644
--- a/lib/librte_hash/rte_cuckoo_hash.c
+++ b/lib/librte_hash/rte_cuckoo_hash.c
@@ -1285,10 +1285,8 @@ __rte_hash_lookup_with_hash_lf(const struct rte_hash *h, 
const void *key,
                /* Check if key is in primary location */
                bkt = &h->buckets[prim_bucket_idx];
                ret = search_one_bucket_lf(h, key, short_sig, data, bkt);
-               if (ret != -1) {
-                       __hash_rw_reader_unlock(h);
+               if (ret != -1)
                        return ret;
-               }
                /* Calculate secondary hash */
                bkt = &h->buckets[sec_bucket_idx];
 
@@ -1296,10 +1294,8 @@ __rte_hash_lookup_with_hash_lf(const struct rte_hash *h, 
const void *key,
                FOR_EACH_BUCKET(cur_bkt, bkt) {
                        ret = search_one_bucket_lf(h, key, short_sig,
                                                data, cur_bkt);
-                       if (ret != -1) {
-                               __hash_rw_reader_unlock(h);
+                       if (ret != -1)
                                return ret;
-                       }
                }
 
                /* The loads of sig_current in search_one_bucket
-- 
2.17.1