Hi Thomas, Thank you for the review!
> On Apr 1, 2019, at 7:57 PM, Thomas Monjalon <tho...@monjalon.net> wrote: > > 02/04/2019 01:08, Dharmik Thakkar: >> Add unit test to check for hash lookup and bulk-lookup perf for >> extendable bucket feature. >> It is tested with both lock-free enabled and lock-free disabled case. >> >> Test includes: >> >> - hash lookup on keys in ext bkt >> - hash delete causing key-shifts of keys from ext bkt to secondary bkt >> >> Suggested-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> >> Signed-off-by: Dharmik Thakkar <dharmik.thak...@arm.com> >> Acked-by: Yipeng Wang <yipeng1.w...@intel.com> >> --- >> v4: >> - Add Acked-by tag. > > FYI, no need to send a new version just for this. Sure, thanks! > > Please run devtools/test-meson-builds.sh. > When building build-clang-static, I see this error: > > app/test/test_hash_readwrite_lf.c:670:13: error: > variable 'key_cnt' is used uninitialized whenever 'if' condition is false Will resolve and update.
