RE: [EXT] Re: [PATCH v2 1/2] common/cnxk: add support to get aged flows

2023-09-28 Thread Ankur Dwivedi
> > >Ankur, following changes in upstream changed the thread APIs. I have >adapted to this change in [1]. Please review ASAP - It is blocking rc1 PR. I have reviewed the changes. The changes are fine. Thanks. > >commit 1c1abf1786a6de044bd396da4cc316961e3fd812 >Author: Thomas Monjalon >Date:

[PATCH v1] common/cnxk: fix flow add in age flow list

2023-10-17 Thread Ankur Dwivedi
flow is added or deleted to/from age flow list if the flow has age action. Fixes: 357f5ebc8a24 ("common/cnxk: support flow aging") Cc: sta...@dpdk.org Signed-off-by: Ankur Dwivedi --- drivers/common/cnxk/roc_npc.c | 9 ++--- drivers/common/cnxk/roc_npc.h | 1 + driv

[PATCH v3 0/2] devtools: add tracepoint check in checkpatch

2022-10-15 Thread Ankur Dwivedi
-map.sh. - Removed check-tracepoint.py file. - Code improvements in check-tracepoint.sh. v2: - Add check for parent directory. Ankur Dwivedi (2): devtools: move build symbol map function devtools: add tracepoint check in checkpatch devtools/build-symbol-map.sh| 77

[PATCH v3 1/2] devtools: move build symbol map function

2022-10-15 Thread Ankur Dwivedi
This patch moves the build_map_changes function from check-symbol-change.sh to a new build-symbol-map.sh file. This function can be used in other scripts by including build-symbol-map.sh file. Signed-off-by: Ankur Dwivedi --- devtools/build-symbol-map.sh| 77

[PATCH v3 2/2] devtools: add tracepoint check in checkpatch

2022-10-15 Thread Ankur Dwivedi
for the presence of tracepoint. The checkpatch return error if the tracepoint is not present. For functions for which trace is not needed, they can be added to devtools/trace-skiplist.txt file. The above tracepoint check will be skipped for them. Signed-off-by: Ankur Dwivedi --- devtools/check

RE: [PATCH v3 0/2] devtools: add tracepoint check in checkpatch

2022-11-01 Thread Ankur Dwivedi
Hi Thomas, Please let me know if this series can be included in 22.11 rc3. Regards, Ankur >-Original Message- >From: Ankur Dwivedi >Sent: Saturday, October 15, 2022 6:28 PM >To: dev@dpdk.org >Cc: tho...@monjalon.net; david.march...@redhat.com; Akhil Goyal >; royz

[PATCH v5 0/6] add trace points in ethdev library

2023-01-12 Thread Ankur Dwivedi
the input value of features in rte_eth_trace_rx_metadata_negotiate(). - Added code to capture return value in flow trace. Ankur Dwivedi (6): eal: trace: add trace point emit for blob ethdev: add trace points for ethdev ethdev: add trace points for remaining functions ethdev: add trace

[PATCH v5 1/6] eal: trace: add trace point emit for blob

2023-01-12 Thread Ankur Dwivedi
Adds a trace point emit function for emitting a blob. The maximum blob bytes which can be captured is maximum value contained in uint16_t, which is 65535. Also adds test case for emit array tracepoint function. Signed-off-by: Ankur Dwivedi --- app/test/test_trace.c | 5

[PATCH v5 2/6] ethdev: add trace points for ethdev

2023-01-12 Thread Ankur Dwivedi
Adds trace points for ethdev functions. Moved the rte_ethdev_trace_rx_burst and rte_ethdev_trace_tx_burst to a new file rte_ethdev_trace_fp_burst.h. This is needed to resolve cyclic dependency between rte_ethdev.h and rte_ethdev_trace_fp.h. Signed-off-by: Ankur Dwivedi --- lib/ethdev

[PATCH v5 3/6] ethdev: add trace points for remaining functions

2023-01-12 Thread Ankur Dwivedi
Adds trace points for remaining ethdev functions. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace_points.c | 252 +++ lib/ethdev/rte_ethdev.c | 476 ++- lib/ethdev/rte_ethdev_cman.c | 30 +- lib/ethdev/rte_ethdev_trace.h| 529

[PATCH v5 4/6] ethdev: add trace points for flow

2023-01-12 Thread Ankur Dwivedi
Adds trace points for rte_flow specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace_points.c | 117 ++ lib/ethdev/rte_ethdev_trace.h| 383 +++ lib/ethdev/rte_ethdev_trace_fp.h | 113 + lib/ethdev/rte_flow.c

[PATCH v5 5/6] ethdev: add trace points for mtr

2023-01-12 Thread Ankur Dwivedi
Adds trace points for rte_mtr specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace_points.c | 63 + lib/ethdev/rte_ethdev_trace.h| 112 ++ lib/ethdev/rte_ethdev_trace_fp.h | 100 lib/ethdev/rte_mtr.c

[PATCH v5 6/6] ethdev: add trace points for tm

2023-01-12 Thread Ankur Dwivedi
Adds trace points for rte_tm specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace_points.c | 90 +++ lib/ethdev/rte_ethdev_trace.h| 141 ++ lib/ethdev/rte_ethdev_trace_fp.h | 171 + lib/ethdev/rte_tm.c

RE: [PATCH v5 1/6] eal: trace: add trace point emit for blob

2023-01-12 Thread Ankur Dwivedi
Hi Morten, My comments are inline. >-Original Message- >From: Morten Brørup >Sent: Thursday, January 12, 2023 6:09 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: tho...@monjalon.net; david.march...@redhat.com; m...@ashroe.eu; >or...@nvidia.com; ferruh.yi...@amd.com; ch

RE: [PATCH v5 3/6] ethdev: add trace points for remaining functions

2023-01-12 Thread Ankur Dwivedi
Hi Sunil, My comments are inline. >-Original Message- >From: Sunil Kumar Kori >Sent: Thursday, January 12, 2023 10:09 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: tho...@monjalon.net; david.march...@redhat.com; m...@ashroe.eu; >or...@nvidia.com; ferruh.yi...@amd.com; ch

RE: [EXT] Re: [PATCH v5 0/6] add trace points in ethdev library

2023-01-12 Thread Ankur Dwivedi
Hi Ferruh, My comments are inline. >-Original Message- >From: Ferruh Yigit >Sent: Thursday, January 12, 2023 10:33 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: tho...@monjalon.net; david.march...@redhat.com; m...@ashroe.eu; >or...@nvidia.com; ch...@att.com; humi...@

[PATCH v6 0/6] add trace points in ethdev library

2023-01-20 Thread Ankur Dwivedi
ed code to capture return value in flow trace. Ankur Dwivedi (6): eal: trace: add trace point emit for blob ethdev: add trace points for ethdev (part one) ethdev: add trace points for ethdev (part two) ethdev: add trace points for flow ethdev: add trace points for mtr ethdev: add trace

[PATCH v6 1/6] eal: trace: add trace point emit for blob

2023-01-20 Thread Ankur Dwivedi
64 the remaining trailing bytes are set to zero. This patch also adds test case for emit blob tracepoint function. Signed-off-by: Ankur Dwivedi --- app/test/test_trace.c | 11 doc/guides/prog_guide/trace_lib.rst| 12 lib/eal/common

[PATCH v6 2/6] ethdev: add trace points for ethdev (part one)

2023-01-20 Thread Ankur Dwivedi
Adds trace points for ethdev functions. Moved the rte_ethdev_trace_rx_burst and rte_ethdev_trace_tx_burst to a new file rte_ethdev_trace_fp_burst.h. This is needed to resolve cyclic dependency between rte_ethdev.h and rte_ethdev_trace_fp.h. Signed-off-by: Ankur Dwivedi --- lib/ethdev

[PATCH v6 3/6] ethdev: add trace points for ethdev (part two)

2023-01-20 Thread Ankur Dwivedi
Adds trace points for remaining ethdev functions. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace_points.c | 252 +++ lib/ethdev/rte_ethdev.c | 476 ++- lib/ethdev/rte_ethdev_cman.c | 30 +- lib/ethdev/rte_ethdev_trace.h| 529

[PATCH v6 4/6] ethdev: add trace points for flow

2023-01-20 Thread Ankur Dwivedi
Adds trace points for rte_flow specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace_points.c | 117 ++ lib/ethdev/rte_ethdev_trace.h| 383 +++ lib/ethdev/rte_ethdev_trace_fp.h | 113 + lib/ethdev/rte_flow.c

[PATCH v6 5/6] ethdev: add trace points for mtr

2023-01-20 Thread Ankur Dwivedi
Adds trace points for rte_mtr specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace_points.c | 63 + lib/ethdev/rte_ethdev_trace.h| 112 ++ lib/ethdev/rte_ethdev_trace_fp.h | 100 lib/ethdev/rte_mtr.c

[PATCH v6 6/6] ethdev: add trace points for tm

2023-01-20 Thread Ankur Dwivedi
Adds trace points for rte_tm specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace_points.c | 90 +++ lib/ethdev/rte_ethdev_trace.h| 141 ++ lib/ethdev/rte_ethdev_trace_fp.h | 171 + lib/ethdev/rte_tm.c

[PATCH v7 0/6] add trace points in ethdev library

2023-01-23 Thread Ankur Dwivedi
to the end, in ethdev and flow trace. - Added code to print the input value of features in rte_eth_trace_rx_metadata_negotiate(). - Added code to capture return value in flow trace. Ankur Dwivedi (6): eal: trace: add trace point emit for blob ethdev: add trace points for ethdev (part one

[PATCH v7 3/6] ethdev: add trace points for ethdev (part two)

2023-01-23 Thread Ankur Dwivedi
Adds trace points for remaining ethdev functions. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace_points.c | 252 +++ lib/ethdev/rte_ethdev.c | 476 ++- lib/ethdev/rte_ethdev_cman.c | 30 +- lib/ethdev/rte_ethdev_trace.h| 529

[PATCH v7 5/6] ethdev: add trace points for mtr

2023-01-23 Thread Ankur Dwivedi
Adds trace points for rte_mtr specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace_points.c | 63 + lib/ethdev/rte_ethdev_trace.h| 112 ++ lib/ethdev/rte_ethdev_trace_fp.h | 100 lib/ethdev/rte_mtr.c

[PATCH v7 6/6] ethdev: add trace points for tm

2023-01-23 Thread Ankur Dwivedi
Adds trace points for rte_tm specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace_points.c | 90 +++ lib/ethdev/rte_ethdev_trace.h| 141 ++ lib/ethdev/rte_ethdev_trace_fp.h | 171 + lib/ethdev/rte_tm.c

[PATCH v7 2/6] ethdev: add trace points for ethdev (part one)

2023-01-23 Thread Ankur Dwivedi
Adds trace points for ethdev functions. Moved the rte_ethdev_trace_rx_burst and rte_ethdev_trace_tx_burst to a new file rte_ethdev_trace_fp_burst.h. This is needed to resolve cyclic dependency between rte_ethdev.h and rte_ethdev_trace_fp.h. Signed-off-by: Ankur Dwivedi --- lib/ethdev

[PATCH v7 4/6] ethdev: add trace points for flow

2023-01-23 Thread Ankur Dwivedi
Adds trace points for rte_flow specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace_points.c | 117 ++ lib/ethdev/rte_ethdev_trace.h| 383 +++ lib/ethdev/rte_ethdev_trace_fp.h | 113 + lib/ethdev/rte_flow.c

[PATCH v7 1/6] eal: trace: add trace point emit for blob

2023-01-23 Thread Ankur Dwivedi
64 the remaining trailing bytes are set to zero. This patch also adds test case for emit blob tracepoint function. Signed-off-by: Ankur Dwivedi --- app/test/test_trace.c | 11 doc/guides/prog_guide/trace_lib.rst| 12 + lib/eal/common

RE: [PATCH v7 1/6] eal: trace: add trace point emit for blob

2023-01-23 Thread Ankur Dwivedi
>-Original Message- >From: Morten Brørup >Sent: Monday, January 23, 2023 6:39 PM >To: Jerin Jacob ; Ankur Dwivedi > >Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com; >m...@ashroe.eu; or...@nvidia.com; ferruh.yi...@amd.com; ch...@att.com; >h

RE: [EXT] Re: [PATCH v6 1/6] eal: trace: add trace point emit for blob

2023-01-25 Thread Ankur Dwivedi
>-Original Message- >From: Ferruh Yigit >Sent: Monday, January 23, 2023 10:58 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: tho...@monjalon.net; david.march...@redhat.com; m...@ashroe.eu; >or...@nvidia.com; ch...@att.com; humi...@huawei.com; >linvi...@tuxdriver.com; c

RE: [EXT] Re: [PATCH v6 1/6] eal: trace: add trace point emit for blob

2023-01-30 Thread Ankur Dwivedi
>-Original Message- >From: Ferruh Yigit >Sent: Wednesday, January 25, 2023 9:40 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: tho...@monjalon.net; david.march...@redhat.com; m...@ashroe.eu; >or...@nvidia.com; ch...@att.com; humi...@huawei.com; >linvi...@tuxdriver.com; c

RE: [EXT] Re: [PATCH v6 2/6] ethdev: add trace points for ethdev (part one)

2023-01-30 Thread Ankur Dwivedi
>-Original Message- >From: Ferruh Yigit >Sent: Monday, January 23, 2023 10:59 PM >To: Ankur Dwivedi ; dev@dpdk.org; David >Marchand >Cc: tho...@monjalon.net; david.march...@redhat.com; m...@ashroe.eu; >or...@nvidia.com; ch...@att.com; humi...@huawei.com; &g

RE: [EXT] Re: [PATCH v6 2/6] ethdev: add trace points for ethdev (part one)

2023-02-01 Thread Ankur Dwivedi
>-Original Message- >From: Ferruh Yigit >Sent: Wednesday, February 1, 2023 12:08 AM >To: Ankur Dwivedi ; dev@dpdk.org; David >Marchand ; Jerin Jacob Kollanukkaran >; Andrew Rybchenko > >Cc: tho...@monjalon.net; m...@ashroe.eu; or...@nvidia.com; >ch...@att.com

RE: [EXT] Re: [PATCH v6 2/6] ethdev: add trace points for ethdev (part one)

2023-02-02 Thread Ankur Dwivedi
>-Original Message- >From: Ferruh Yigit >Sent: Thursday, February 2, 2023 2:27 PM >To: Ankur Dwivedi ; dev@dpdk.org; David >Marchand ; Jerin Jacob Kollanukkaran >; Andrew Rybchenko > >Cc: tho...@monjalon.net; m...@ashroe.eu; or...@nvidia.com; >ch...@att.com

RE: [EXT] Re: [PATCH v6 2/6] ethdev: add trace points for ethdev (part one)

2023-02-02 Thread Ankur Dwivedi
> >On 2/2/2023 10:20 AM, Ankur Dwivedi wrote: > >>>>>>>> +RTE_TRACE_POINT_FP( >>>>>>>> + rte_eth_trace_find_next, >>>>>>>> + RTE_TRACE_POINT_ARGS(uint16_t port_id), >>>>>>>> +

RE: [EXT] Re: [PATCH v6 2/6] ethdev: add trace points for ethdev (part one)

2023-02-02 Thread Ankur Dwivedi
> >On 2/2/2023 1:40 PM, Ankur Dwivedi wrote: >>> >>> On 2/2/2023 10:20 AM, Ankur Dwivedi wrote: >>> >>>>>>>>>> +RTE_TRACE_POINT_FP( >>>>>>>>>> +rte_eth_trace_find_next, >>>

RE: [PATCH v7 4/6] ethdev: add trace points for flow

2023-02-02 Thread Ankur Dwivedi
From: Ori Kam >> Sent: Thursday, 2 February 2023 15:52 >> >> Hi Ankur, >> >> > -Original Message- >> > From: Ankur Dwivedi >> > Sent: Monday, 23 January 2023 11:02 >> > >> > Adds trace points for rte_flow specific functions in

[PATCH v8 0/6] add trace points in ethdev library

2023-02-06 Thread Ankur Dwivedi
tions call to the end, in ethdev and flow trace. - Added code to print the input value of features in rte_eth_trace_rx_metadata_negotiate(). - Added code to capture return value in flow trace. Ankur Dwivedi (6): eal: trace: add trace point emit for blob ethdev: add trace points for ethdev

[PATCH v8 1/6] eal: trace: add trace point emit for blob

2023-02-06 Thread Ankur Dwivedi
64 the remaining trailing bytes are set to zero. This patch also adds test case for emit blob tracepoint function. Signed-off-by: Ankur Dwivedi Acked-by: Morten Brørup Acked-by: Sunil Kumar Kori Acked-by: Jerin Jacob --- app/test/test_trace.c | 11 doc/guides

[PATCH v8 2/6] ethdev: add trace points for ethdev (part one)

2023-02-06 Thread Ankur Dwivedi
: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_private.c | 7 + lib/ethdev/ethdev_trace.h| 642 +++ lib/ethdev/ethdev_trace_points.c | 195 +- lib/ethdev/meson.build | 2 +- lib/ethdev/rte_ethdev.c | 386

[PATCH v8 3/6] ethdev: add trace points for ethdev (part two)

2023-02-06 Thread Ankur Dwivedi
Adds trace points for remaining ethdev functions. Signed-off-by: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_trace.h| 893 +++ lib/ethdev/ethdev_trace_points.c | 252 + lib/ethdev/rte_ethdev.c | 486 ++--- lib

[PATCH v8 4/6] ethdev: add trace points for flow

2023-02-06 Thread Ankur Dwivedi
Adds trace points for rte_flow specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h| 502 +++ lib/ethdev/ethdev_trace_points.c | 117 +++ lib/ethdev/rte_flow.c| 356 +- 3 files

[PATCH v8 6/6] ethdev: add trace points for tm

2023-02-06 Thread Ankur Dwivedi
Adds trace points for rte_tm specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h| 332 +++ lib/ethdev/ethdev_trace_points.c | 90 + lib/ethdev/rte_tm.c | 225 ++--- 3 files changed

[PATCH v8 5/6] ethdev: add trace points for mtr

2023-02-06 Thread Ankur Dwivedi
Adds trace points for rte_mtr specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_trace.h| 223 +++ lib/ethdev/ethdev_trace_points.c | 63 + lib/ethdev/rte_mtr.c | 156

RE: [EXT] Re: [PATCH v8 1/6] eal: trace: add trace point emit for blob

2023-02-06 Thread Ankur Dwivedi
>On Mon, Feb 6, 2023 at 12:59 PM Ankur Dwivedi >wrote: >> >> Adds a trace point emit function for capturing a blob. The blob >> captures the length passed by the application followed by the array. >> >> The maximum blob bytes which can be captured is bounde

[PATCH v9 0/6] add trace points in ethdev library

2023-02-06 Thread Ankur Dwivedi
functions from EXPERIMENTAL to INTERNAL in version.map. - Moved trace functions call to the end, in ethdev and flow trace. - Added code to print the input value of features in rte_eth_trace_rx_metadata_negotiate(). - Added code to capture return value in flow trace. Ankur Dwivedi (6): eal:

[PATCH v9 1/6] eal: trace: add trace point emit for blob

2023-02-06 Thread Ankur Dwivedi
64 the remaining trailing bytes are set to zero. This patch also adds test case for emit blob tracepoint function. Signed-off-by: Ankur Dwivedi Acked-by: Morten Brørup Acked-by: Sunil Kumar Kori Acked-by: Jerin Jacob --- app/test/test_trace.c | 11 doc/guides

[PATCH v9 2/6] ethdev: add trace points for ethdev (part one)

2023-02-06 Thread Ankur Dwivedi
: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_private.c | 7 + lib/ethdev/ethdev_trace.h| 642 +++ lib/ethdev/ethdev_trace_points.c | 195 +- lib/ethdev/meson.build | 2 +- lib/ethdev/rte_ethdev.c | 386

[PATCH v9 3/6] ethdev: add trace points for ethdev (part two)

2023-02-06 Thread Ankur Dwivedi
Adds trace points for remaining ethdev functions. Signed-off-by: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_trace.h| 893 +++ lib/ethdev/ethdev_trace_points.c | 252 + lib/ethdev/rte_ethdev.c | 486 ++--- lib

[PATCH v9 4/6] ethdev: add trace points for flow

2023-02-06 Thread Ankur Dwivedi
Adds trace points for rte_flow specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h| 502 +++ lib/ethdev/ethdev_trace_points.c | 117 +++ lib/ethdev/rte_flow.c| 356 +- 3 files

[PATCH v9 5/6] ethdev: add trace points for mtr

2023-02-06 Thread Ankur Dwivedi
Adds trace points for rte_mtr specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_trace.h| 223 +++ lib/ethdev/ethdev_trace_points.c | 63 + lib/ethdev/rte_mtr.c | 156

[PATCH v9 6/6] ethdev: add trace points for tm

2023-02-06 Thread Ankur Dwivedi
Adds trace points for rte_tm specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h| 332 +++ lib/ethdev/ethdev_trace_points.c | 90 + lib/ethdev/rte_tm.c | 225 ++--- 3 files changed

[PATCH v1] common/cnxk: fix initialization of MCAM ID

2023-09-21 Thread Ankur Dwivedi
The start and end mcam id is initialized when aged_flows_cnt is 0. The boolean variable aging_enabled is not needed. Fixes: d110c44d29e7 ("common/cnxk: support flow aging") Signed-off-by: Ankur Dwivedi --- drivers/common/cnxk/roc_npc_aging.c | 4 +--- 1 file changed, 1 inser

Re: [dpdk-dev] [PATCH v2 1/2] event/octeontx2: fix crypto adapter queue pair ops

2021-04-26 Thread Ankur Dwivedi
>-Original Message- >From: Shijith Thotton >Sent: Monday, April 26, 2021 5:51 PM >To: dev@dpdk.org >Cc: Shijith Thotton ; Jerin Jacob Kollanukkaran >; Anoob Joseph ; Ankur Dwivedi >; Pavan Nikhilesh Bhagavatula > >Subject: [PATCH v2 1/2] event/octeontx2: fi

RE: [PATCH v6 0/2] devtools: add tracepoint check in checkpatch

2024-07-17 Thread Ankur Dwivedi
>-Original Message- >From: Ankur Dwivedi >Sent: Friday, December 15, 2023 12:14 PM >To: dev@dpdk.org >Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; >Ankur Dwivedi >Subject: [PATCH v6 0/2] devtools: add tracepoint check in checkpatch > >This patch

[PATCH v1] common/cnxk: fix integer overflow

2024-07-17 Thread Ankur Dwivedi
94318e ("common/cnxk: fix flow aging on application exit") Cc: sta...@dpdk.org Signed-off-by: Ankur Dwivedi --- drivers/common/cnxk/roc_npc_aging.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_npc_aging.c b/drivers/common/cnxk/roc_n

RE: [EXT] Re: [PATCH 01/12] common/cpt: fix build with GCC 12

2022-06-13 Thread Ankur Dwivedi
Hi David, >-Original Message- >From: David Marchand >Sent: Friday, June 10, 2022 6:42 PM >To: Anoob Joseph ; Ankur Dwivedi > >Cc: Thomas Monjalon ; Ferruh Yigit >; dpdk stable ; dev >; Akhil Goyal ; Jerin Jacob >Kollanukkaran >Subject: [EXT] Re: [PATCH 01/

RE: [EXT] Re: [PATCH 01/12] common/cpt: fix build with GCC 12

2022-06-16 Thread Ankur Dwivedi
Hi David, >-Original Message- >From: David Marchand >Sent: Thursday, June 16, 2022 3:00 PM >To: Ankur Dwivedi ; Jerin Jacob Kollanukkaran > >Cc: Anoob Joseph ; Thomas Monjalon >; Ferruh Yigit ; dpdk stable >; dev ; Akhil Goyal >Subject: Re: [EXT] Re: [PATCH 0

[PATCH 0/2] fix compilation with GCC 12

2022-06-16 Thread Ankur Dwivedi
This patch series resolves compilation warning observed with GCC 12, in common/cpt and crypto/cnxk. Ankur Dwivedi (2): common/cpt: fix compilation with GCC 12 crypto/cnxk: fix compilation with GCC 12 drivers/common/cpt/cpt_mcode_defines.h | 2 +- drivers/common/cpt/cpt_ucode.h | 21

[PATCH 1/2] common/cpt: fix compilation with GCC 12

2022-06-16 Thread Ankur Dwivedi
the warning. Fixes: 9be415daf469 ("common/cpt: add common defines for microcode") Fixes: b74652f3a91f ("common/cpt: add microcode interface for encryption") Cc: sta...@dpdk.org Signed-off-by: Ankur Dwivedi Reviewed-by: Anoob Joseph Reviewed-by: Jerin Jacob Kollanukkaran

[PATCH 2/2] crypto/cnxk: fix compilation with GCC 12

2022-06-16 Thread Ankur Dwivedi
xes: 3de331795f73 ("crypto/cnxk: add flexi cipher encryption") Cc: sta...@dpdk.org Signed-off-by: Ankur Dwivedi Reviewed-by: Anoob Joseph Reviewed-by: Jerin Jacob Kollanukkaran --- drivers/crypto/cnxk/cnxk_se.h | 20 ++-- 1 file changed, 10 insertions(+), 10 delet

RE: [EXT] Re: [PATCH 1/2] common/cpt: fix compilation with GCC 12

2022-06-17 Thread Ankur Dwivedi
Hi David, >-Original Message- >From: David Marchand >Sent: Friday, June 17, 2022 5:38 PM >To: Ankur Dwivedi >Cc: dev ; Anoob Joseph ; Akhil Goyal >; Tejasree Kondoj ; Jerin >Jacob Kollanukkaran ; dpdk stable >Subject: [EXT] Re: [PATCH 1/2] common/cpt: fix

[PATCH v2 0/2] fix compilation with GCC 12

2022-06-17 Thread Ankur Dwivedi
This patch series resolves compilation warning observed with GCC 12, in common/cpt and crypto/cnxk. --- v2: - Add Bugzilla ID in patch 1. - Remove empty line between Fixes: and Cc:. Ankur Dwivedi (2): common/cpt: fix compilation with GCC 12 crypto/cnxk: fix compilation with GCC 12 drivers

[PATCH v2 1/2] common/cpt: fix compilation with GCC 12

2022-06-17 Thread Ankur Dwivedi
the warning. Bugzilla ID: 861 Fixes: 9be415daf469 ("common/cpt: add common defines for microcode") Fixes: b74652f3a91f ("common/cpt: add microcode interface for encryption") Cc: sta...@dpdk.org Signed-off-by: Ankur Dwivedi Reviewed-by: Anoob Joseph Reviewed-by: Jerin Jacob Koll

[PATCH v2 2/2] crypto/cnxk: fix compilation with GCC 12

2022-06-17 Thread Ankur Dwivedi
xes: 3de331795f73 ("crypto/cnxk: add flexi cipher encryption") Cc: sta...@dpdk.org Signed-off-by: Ankur Dwivedi Reviewed-by: Anoob Joseph Reviewed-by: Jerin Jacob Kollanukkaran --- drivers/crypto/cnxk/cnxk_se.h | 20 ++-- 1 file changed, 10 insertions(+), 10 delet

[PATCH] common/cnxk: validate length argument

2022-02-06 Thread Ankur Dwivedi
4 into destination object ‘int_info’ of size 64 uint8_t int_info[NPC_MAX_EXTRACT_DATA_LEN]; Bugzilla ID: 854 Fixes: 665b6a7400bf ("common/cnxk: add NPC helper API") Cc: sta...@dpdk.org Signed-off-by: Ankur Dwivedi Reviewed-by: Kiran Kumar Kokkilagadda --- drivers/common/cnxk/roc

[PATCH 0/2] add telemetry for inline IPsec

2022-02-09 Thread Ankur Dwivedi
Adds telemetry function for inline ipsec in net CNXK driver. This series depends on the following patch series: Series: Adding new features and improvements in cnxk crypto PMD http://patches.dpdk.org/project/dpdk/list/?series=21433 Ankur Dwivedi (2): net/cnxk: add telemetry for inline IPsec

[PATCH 1/2] net/cnxk: add telemetry for inline IPsec for cn9k

2022-02-09 Thread Ankur Dwivedi
Adds telemetry function to get information about inline outbound and inline inbound sa's. The function takes port id as input. Some fields in the structures roc_onf_ipsec_outb_sa and roc_onf_ipsec_inb_sa are returned as output. Signed-off-by: Ankur Dwivedi Reviewed-by: Jerin Jacob Kollanuk

[PATCH 2/2] net/cnxk: add telemetry for inline IPsec for cn10k

2022-02-09 Thread Ankur Dwivedi
Adds telemetry function to get information about inline outbound and inline inbound sa's. The function takes port id as input. Some fields in the structures roc_ot_ipsec_outb_sa and roc_ot_ipsec_inb_sa are returned as output. Signed-off-by: Ankur Dwivedi Reviewed-by: Jerin Jacob Kollanuk

RE: [EXT] Re: [PATCH 0/2] add telemetry for inline IPsec

2022-02-10 Thread Ankur Dwivedi
Hi Bruce, Please see my comment inline. Regards, Ankur >-Original Message- >From: Bruce Richardson >Sent: Thursday, February 10, 2022 2:42 PM >To: Ankur Dwivedi >Cc: dev@dpdk.org; Nithin Kumar Dabilpuram ; >Kiran Kumar Kokkilagadda ; Sunil Kumar Kori >; Satha

RE: [EXT] Re: [PATCH 0/2] add telemetry for inline IPsec

2022-02-10 Thread Ankur Dwivedi
>-Original Message- >From: Bruce Richardson >Sent: Thursday, February 10, 2022 5:02 PM >To: Ankur Dwivedi >Cc: dev@dpdk.org; Nithin Kumar Dabilpuram ; >Kiran Kumar Kokkilagadda ; Sunil Kumar Kori >; Satha Koteswara Rao Kottidi >; Jerin Jacob Kollanukkaran &g

[PATCH 0/2] add zuc-256 support

2022-06-03 Thread Ankur Dwivedi
Adds support for zuc-256 cipher in cnxk crypto PMD. Ankur Dwivedi (2): common/cnxk: swap zuc-256 key crypto/cnxk: swap zuc-256 iv drivers/common/cnxk/roc_se.c | 7 +-- drivers/common/cnxk/roc_se.h | 22 ++ drivers/crypto/cnxk/cnxk_se.h | 24

[PATCH 1/2] common/cnxk: swap zuc-256 key

2022-06-03 Thread Ankur Dwivedi
The microcode expects zuc-256 key to be in reverse of what is provided by dpdk test app. This patch swaps the zuc-256 key. Signed-off-by: Ankur Dwivedi Reviewed-by: Jerin Jacob Kollanukkaran --- drivers/common/cnxk/roc_se.c | 7 +-- drivers/common/cnxk/roc_se.h | 22

[PATCH 2/2] crypto/cnxk: swap zuc-256 iv

2022-06-03 Thread Ankur Dwivedi
The microcode expects the iv to be in reverse of what is provided by dpdk test app. Also the first 8 bytes of reversed iv is compressed to 6 bytes. Signed-off-by: Ankur Dwivedi Reviewed-by: Jerin Jacob Kollanukkaran --- drivers/crypto/cnxk/cnxk_se.h | 24 +--- 1 file

[dpdk-dev] [PATCH] common/cnxk: fix pointer argument with gcc 12

2021-11-08 Thread Ankur Dwivedi
nix_cn10k_sq_ctx_s[0]’ is partly outside array bounds of ‘volatile void[8]’ [-Warray-bounds] Bugzilla ID: 853 Fixes: af75aac78978 ("common/cnxk: support telemetry for NIX") Signed-off-by: Ankur Dwivedi Reviewed-by: Gowrishankar Muthukrishnan Reviewed-by: Jerin Jacob Kollanukkaran

[dpdk-dev] [PATCH 0/2] add dev start and dev stop ops in cnxk crypto PMD

2021-07-08 Thread Ankur Dwivedi
The dev start and dev stop ops are added in cnxk crypto PMD. The instruction queues are enabled in dev start and disabled in dev stop. Ankur Dwivedi (2): common/cnxk: move instruction queue enable to roc API crypto/cnxk: add dev start and dev stop drivers/common/cnxk/roc_cpt.c

[dpdk-dev] [PATCH 1/2] common/cnxk: move instruction queue enable to roc API

2021-07-08 Thread Ankur Dwivedi
The code for enabling instruction queue is moved to roc API. Signed-off-by: Ankur Dwivedi --- drivers/common/cnxk/roc_cpt.c | 41 - drivers/common/cnxk/roc_cpt.h | 1 + drivers/common/cnxk/version.map | 1 + 3 files changed, 27 insertions(+), 16 deletions

[dpdk-dev] [PATCH 2/2] crypto/cnxk: add dev start and dev stop

2021-07-08 Thread Ankur Dwivedi
The instruction queue is enabled in dev start and is disabled in dev stop. Signed-off-by: Ankur Dwivedi --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_cryptodev_ops.c b/drivers/crypto

[dpdk-dev] [PATCH] crypto/octeontx2: fix null pointer dereferences

2021-01-22 Thread Ankur Dwivedi
Coverity reports that pointers ip and ip6 may be dereferenced with null value. This patch fixes this. Coverity issue: 365549 Coverity issue: 365551 Fixes: 1c119d38876d ("crypto/octeontx2: support lookaside AES-CBC SHA1-HMAC") Signed-off-by: Ankur Dwivedi --- drivers/crypto

[dpdk-dev] [PATCH v2] crypto/octeontx2: fix null pointer dereferences

2021-01-27 Thread Ankur Dwivedi
Coverity reports that pointers ip and ip6 may be dereferenced with null value. This patch fixes this. Coverity issue: 365549 Coverity issue: 365551 Fixes: 8f685ec2d545 ("crypto/octeontx2: support AES-CBC SHA1-HMAC") Signed-off-by: Ankur Dwivedi --- v2: * Fixed wrong fixes reference

[dpdk-dev] [PATCH] crypto/octeontx: fix session-less mode

2021-02-28 Thread Ankur Dwivedi
;) Signed-off-by: Ankur Dwivedi --- drivers/crypto/octeontx/otx_cryptodev_ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c b/drivers/crypto/octeontx/otx_cryptodev_ops.c index 0cf760b296..b74eb2694b 100644 --- a/drivers/crypt

RE: [EXT] Re: [PATCH v9 2/6] ethdev: add trace points for ethdev (part one)

2023-02-08 Thread Ankur Dwivedi
>Subject: [EXT] Re: [PATCH v9 2/6] ethdev: add trace points for ethdev (part >one) > >External Email > >-- >On 2/7/2023 6:32 AM, Ankur Dwivedi wrote: >> Adds trace points for ethdev functions. >

RE: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ankur Dwivedi
>Subject: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part >two) > >External Email > >-- >On 2/7/2023 6:32 AM, Ankur Dwivedi wrote: >> Subject: >> [PATCH v9 3/6] ethdev: add

[PATCH v10 0/6] add trace points in ethdev library

2023-02-08 Thread Ankur Dwivedi
x_metadata_negotiate(). - Added code to capture return value in flow trace. Ankur Dwivedi (6): eal: trace: add trace point emit for blob ethdev: add trace points for ethdev (part one) ethdev: add trace points for ethdev (part two) ethdev: add trace points for flow ethdev: add trace points for mtr

[PATCH v10 1/6] eal: trace: add trace point emit for blob

2023-02-08 Thread Ankur Dwivedi
64 the remaining trailing bytes are set to zero. This patch also adds test case for emit blob tracepoint function. Signed-off-by: Ankur Dwivedi Acked-by: Morten Brørup Acked-by: Sunil Kumar Kori Acked-by: Jerin Jacob Acked-by: Ferruh Yigit --- app/test/test_trace.c | 11

[PATCH v10 2/6] ethdev: add trace points for ethdev (part one)

2023-02-08 Thread Ankur Dwivedi
: Ankur Dwivedi Acked-by: Sunil Kumar Kori Reviewed-by: Ferruh Yigit --- lib/ethdev/ethdev_private.c | 7 + lib/ethdev/ethdev_trace.h| 635 +++ lib/ethdev/ethdev_trace_points.c | 195 +- lib/ethdev/meson.build | 2 +- lib/ethdev

[PATCH v10 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ankur Dwivedi
Adds trace points for remaining ethdev functions. Signed-off-by: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_trace.h| 875 +++ lib/ethdev/ethdev_trace_points.c | 252 + lib/ethdev/rte_ethdev.c | 485 ++--- lib

[PATCH v10 4/6] ethdev: add trace points for flow

2023-02-08 Thread Ankur Dwivedi
Adds trace points for rte_flow specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h| 503 +++ lib/ethdev/ethdev_trace_points.c | 117 +++ lib/ethdev/rte_flow.c| 356 +- 3 files

[PATCH v10 5/6] ethdev: add trace points for mtr

2023-02-08 Thread Ankur Dwivedi
Adds trace points for rte_mtr specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_trace.h| 206 +++ lib/ethdev/ethdev_trace_points.c | 63 ++ lib/ethdev/rte_mtr.c | 150

[PATCH v10 6/6] ethdev: add trace points for tm

2023-02-08 Thread Ankur Dwivedi
Adds trace points for rte_tm specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h| 304 +++ lib/ethdev/ethdev_trace_points.c | 90 + lib/ethdev/rte_tm.c | 225 --- 3 files

RE: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ankur Dwivedi
>Subject: Re: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part >two) > >On 2/8/2023 11:00 AM, Ferruh Yigit wrote: >> On 2/8/2023 10:42 AM, Ankur Dwivedi wrote: >>>>> +RTE_TRACE_POINT( >>>>> + rte_ethdev_trace_set_mc_addr_lis

RE: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ankur Dwivedi
>Subject: Re: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part >two) > >On 2/8/2023 2:15 PM, Ankur Dwivedi wrote: >>> Subject: Re: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for >>> ethdev (part >>> two) >>> >>> On 2

[PATCH v11 0/6] add trace points in ethdev library

2023-02-08 Thread Ankur Dwivedi
from EXPERIMENTAL to INTERNAL in version.map. - Moved trace functions call to the end, in ethdev and flow trace. - Added code to print the input value of features in rte_eth_trace_rx_metadata_negotiate(). - Added code to capture return value in flow trace. Ankur Dwivedi (6): eal: trace: add

[PATCH v11 1/6] eal: trace: add trace point emit for blob

2023-02-08 Thread Ankur Dwivedi
64 the remaining trailing bytes are set to zero. This patch also adds test case for emit blob tracepoint function. Signed-off-by: Ankur Dwivedi Acked-by: Morten Brørup Acked-by: Sunil Kumar Kori Acked-by: Jerin Jacob Acked-by: Ferruh Yigit --- app/test/test_trace.c | 11

[PATCH v11 2/6] ethdev: add trace points for ethdev (part one)

2023-02-08 Thread Ankur Dwivedi
: Ankur Dwivedi Acked-by: Sunil Kumar Kori Reviewed-by: Ferruh Yigit --- lib/ethdev/ethdev_private.c | 7 + lib/ethdev/ethdev_trace.h| 635 +++ lib/ethdev/ethdev_trace_points.c | 195 +- lib/ethdev/meson.build | 2 +- lib/ethdev

[PATCH v11 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ankur Dwivedi
Adds trace points for remaining ethdev functions. Signed-off-by: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_trace.h| 877 +++ lib/ethdev/ethdev_trace_points.c | 252 + lib/ethdev/rte_ethdev.c | 485 ++--- lib

[PATCH v11 4/6] ethdev: add trace points for flow

2023-02-08 Thread Ankur Dwivedi
Adds trace points for rte_flow specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi Acked-by: Ori Kam --- lib/ethdev/ethdev_trace.h| 503 +++ lib/ethdev/ethdev_trace_points.c | 117 +++ lib/ethdev/rte_flow.c| 356

[PATCH v11 5/6] ethdev: add trace points for mtr

2023-02-08 Thread Ankur Dwivedi
Adds trace points for rte_mtr specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_trace.h| 206 +++ lib/ethdev/ethdev_trace_points.c | 63 ++ lib/ethdev/rte_mtr.c | 150

  1   2   3   4   >