Hi Ferruh,
My comments are inline.
>-----Original Message-----
>From: Ferruh Yigit <ferruh.yi...@amd.com>
>Sent: Thursday, January 12, 2023 10:33 PM
>To: Ankur Dwivedi <adwiv...@marvell.com>; dev@dpdk.org
>Cc: tho...@monjalon.net; david.march...@redhat.com; m...@ashroe.eu;
>or...@nvidia.com; ch...@att.com; humi...@huawei.com;
>linvi...@tuxdriver.com; ciara.lof...@intel.com; qi.z.zh...@intel.com;
>m...@semihalf.com; m...@semihalf.com; shaib...@amazon.com;
>evge...@amazon.com; igo...@amazon.com; cha...@amd.com; Igor Russkikh
><irussk...@marvell.com>; shepard.sie...@atomicrules.com;
>ed.cz...@atomicrules.com; john.mil...@atomicrules.com;
>ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; Jerin Jacob
>Kollanukkaran <jer...@marvell.com>; Maciej Czekaj [C]
><mcze...@marvell.com>; Shijith Thotton <sthot...@marvell.com>;
>Srisivasubramanian Srinivasan <sriniva...@marvell.com>; Harman Kalra
><hka...@marvell.com>; rahul.lakkire...@chelsio.com; johnd...@cisco.com;
>hyon...@cisco.com; liudongdo...@huawei.com; yisen.zhu...@huawei.com;
>xuanziya...@huawei.com; cloud.wangxiao...@huawei.com;
>zhouguoy...@huawei.com; simei...@intel.com; wenjun1...@intel.com;
>qiming.y...@intel.com; yuying.zh...@intel.com; beilei.x...@intel.com;
>xiao.w.w...@intel.com; jingjing...@intel.com; junfeng....@intel.com;
>rosen...@intel.com; Nithin Kumar Dabilpuram <ndabilpu...@marvell.com>;
>Kiran Kumar Kokkilagadda <kirankum...@marvell.com>; Sunil Kumar Kori
><sk...@marvell.com>; Satha Koteswara Rao Kottidi
><skotesh...@marvell.com>; Liron Himi <lir...@marvell.com>;
>z...@semihalf.com; Radha Chintakuntla <rad...@marvell.com>;
>Veerasenareddy Burru <vbu...@marvell.com>; Sathesh B Edara
><sed...@marvell.com>; ma...@nvidia.com; viachesl...@nvidia.com;
>lon...@microsoft.com; spin...@cesnet.cz; chaoyong...@corigine.com;
>niklas.soderl...@corigine.com; hemant.agra...@nxp.com;
>sachin.sax...@oss.nxp.com; g.si...@nxp.com; apeksha.gu...@nxp.com;
>sachin.sax...@nxp.com; abo...@pensando.io; Rasesh Mody
><rm...@marvell.com>; Shahed Shaikh <shsha...@marvell.com>; Devendra
>Singh Rawat <dsinghra...@marvell.com>; andrew.rybche...@oktetlabs.ru;
>jiawe...@trustnetic.com; jianw...@trustnetic.com; jbehr...@vmware.com;
>maxime.coque...@redhat.com; chenbo....@intel.com;
>steven.webs...@windriver.com; matt.pet...@windriver.com;
>bruce.richard...@intel.com; mtetsu...@gmail.com; gr...@u256.net;
>jasvinder.si...@intel.com; cristian.dumitre...@intel.com; jgraj...@cisco.com;
>m...@smartsharesystems.com
>Subject: [EXT] Re: [PATCH v5 0/6] add trace points in ethdev library
>
>External Email
>
>----------------------------------------------------------------------
>On 1/12/2023 11:21 AM, Ankur Dwivedi wrote:
>> This series adds trace points for functions in the ethdev library.
>> The trace points are added in ethdev, flow, mtr and tm files.
>>
>> v5:
>> - The rte_trace_point_emit_char_array function is renamed to
>> rte_trace_point_emit_blob. With this function an array of
>> any length upto 65535 bytes can be captured.
>> For example, the following is the ctf metadata created to display
>> a mac addr array in rte_eth_trace_macaddr_get():
>> struct {
>> ...
>> uint16_t len;
>> uint8_t mac_addr_addr_bytes[len];
>> };
>> - Added additional test cases for rte_eal_trace_generic_blob
>> test case.
>> - Capturing of return value of a function is added to tracepoint
>> for flow, mtr and tm patches.
>> - In ehdev patch (1/6), removed extra line. Also added rx_pkts and
>> tx_pkts pointer in trace point.
>>
>> v4:
>> - Adds tracepoint function to emit char array. Also adds the
>> test case.
>> - Resolved review comments on "ethdev: add trace point" patch.
>> This patch is divided into 2 patches to minimize per patch
>> size.
>> - From the earlier version (v3), few tracepoints in ethdev,
>> flow, mtr, tm are made as fast path tracepoints. For the
>> tracepoint which i was unsure, i have made it as fastpath.
>> All the fast path tracepoints can be found in
>> rte_ethdev_trace_fp.h and rte_ethdev_trace_fp_burst.h.
>> All the slow path tracepoints can be found in rte_ethdev_trace.h.
>> - Capturing of return value is added to tracepoint in ethdev.
>> For flow, mtr and tm these changes are still yet to bde done.
>> Will do it in the next versions.
>> - Moved the trace functions from INTERNAL to EXPERIMENTAL in
>> version.map.
>>
>> v3:
>> - Moved the trace functions from EXPERIMENTAL to INTERNAL in
>> version.map.
>> - Moved trace functions call to the end, in ethdev and flow trace.
>> - Added code to print the input value of features in
>> rte_eth_trace_rx_metadata_negotiate().
>> - Added code to capture return value in flow trace.
>>
>> Ankur Dwivedi (6):
>> eal: trace: add trace point emit for blob
>> ethdev: add trace points for ethdev
>> ethdev: add trace points for remaining functions
>> ethdev: add trace points for flow
>> ethdev: add trace points for mtr
>> ethdev: add trace points for tm
>
>Hi Ankur,
>
>Build seems failing with set, can you please check:
>https://urldefense.proofpoint.com/v2/url?u=https-
>3A__mails.dpdk.org_archives_test-2Dreport_2023-
>2DJanuary_339696.html&d=DwICaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=ILjiNF3
>GF25y6QdHZUxMl6JrStU0MIuCtO5dMzn3Ybk&m=FhQtWKgLxBWQ7rF_fkPm7V
>K5-efg3NcVDA6cTbGsoNZmX7WvvZKas2o4xnsIxj5D&s=HDHVPZX4YsLz-
>DsRwK3mRisxOk9U8FK7fStn7gCgsXk&e=
>
>I can reproduce build failures via 32bit and debugoptimized builds.
Sure, I will check.
